[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Status: Patch Available (was: Open)
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Attachment: HDFS-7743.000.patch
The first patch mainly does the rename and removes the unnecessary overrided
methods from BlockInfo.
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Status: Open (was: Patch Available)
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Attachment: HDFS-7743.000.patch
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch, HDFS-7743.000.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Status: Patch Available (was: Open)
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Attachment: (was: HDFS-7743.000.patch)
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Attachment: HDFS-7743.001.patch
[~zhz]
[suggested|https://issues.apache.org/jira/browse/HDFS-7716?focusedCommentId=14309739&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14309739]
we name the new class as {{BlockInfoContiguous}}. I think this is a better
name. Update the patch. The patch also removes the tabs to address Nicholas's
comments.
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch, HDFS-7743.001.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Attachment: HDFS-7743.002.patch
We still need the equals and hashCode methods to avoid findbug warning. Update
the patch.
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch, HDFS-7743.001.patch,
> HDFS-7743.002.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk.
> In the meanwhile, we can also use this chance to do some minor code cleanup.
> E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods
> since they are just the same with the super class {{Block}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[
https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HDFS-7743:
Description: In the work of erasure coding (HDFS-7285), we plan to extend
the class BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
(HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans to
rename the current BlockInfo to BlockReplicationInfo in trunk. In the
meanwhile, we can also use this chance to do some minor code cleanup. (was: In
the work of erasure coding (HDFS-7285), we plan to extend the class BlockInfo
to two subclasses: BlockReplicationInfo and BlockGroupInfo (HDFS-7716). To ease
the HDFS-EC branch syncing with trunk, this jira plans to rename the current
BlockInfo to BlockReplicationInfo in trunk.
In the meanwhile, we can also use this chance to do some minor code cleanup.
E.g., removing unnecessary overrided {{hashCode}} and {{equals}} methods since
they are just the same with the super class {{Block}}.)
> Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
> --
>
> Key: HDFS-7743
> URL: https://issues.apache.org/jira/browse/HDFS-7743
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-7743.000.patch, HDFS-7743.001.patch,
> HDFS-7743.002.patch
>
>
> In the work of erasure coding (HDFS-7285), we plan to extend the class
> BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo
> (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans
> to rename the current BlockInfo to BlockReplicationInfo in trunk. In the
> meanwhile, we can also use this chance to do some minor code cleanup.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7743) Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo
[ https://issues.apache.org/jira/browse/HDFS-7743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz Wo Nicholas Sze updated HDFS-7743: -- Hadoop Flags: Reviewed BlockInfoContiguous sounds good. +1 on the new patch. > Code cleanup of BlockInfo and rename BlockInfo to BlockReplicationInfo > -- > > Key: HDFS-7743 > URL: https://issues.apache.org/jira/browse/HDFS-7743 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Reporter: Jing Zhao >Assignee: Jing Zhao >Priority: Minor > Attachments: HDFS-7743.000.patch, HDFS-7743.001.patch, > HDFS-7743.002.patch > > > In the work of erasure coding (HDFS-7285), we plan to extend the class > BlockInfo to two subclasses: BlockReplicationInfo and BlockGroupInfo > (HDFS-7716). To ease the HDFS-EC branch syncing with trunk, this jira plans > to rename the current BlockInfo to BlockReplicationInfo in trunk. In the > meanwhile, we can also use this chance to do some minor code cleanup. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
