[jira] [Updated] (HDFS-8101) DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junping Du updated HDFS-8101: - Fix Version/s: 2.8.0 > DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at > runtime > --- > > Key: HDFS-8101 > URL: https://issues.apache.org/jira/browse/HDFS-8101 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.7.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Fix For: 2.8.0, 2.7.3, 3.0.0-alpha1 > > Attachments: HDFS-8101.1.patch.txt > > > Previously, all references to DFSConfigKeys in DFSClient were compile time > constants which meant that normal users of DFSClient wouldn't resolve > DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a > member of DFSConfigKeys that isn't compile time constant > (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT). > Since the class must be resolved now, this particular member > {code} > public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = > AuthFilter.class.getName(); > {code} > means that javax.servlet.Filter needs to be on the classpath. > javax-servlet-api is one of the properly listed dependencies for HDFS, > however if we replace {{AuthFilter.class.getName()}} with the equivalent > String literal then downstream folks can avoid including it while maintaining > compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Updated] (HDFS-8101) DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai updated HDFS-8101: - Fix Version/s: (was: 2.8.0) 2.7.3 > DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at > runtime > --- > > Key: HDFS-8101 > URL: https://issues.apache.org/jira/browse/HDFS-8101 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.7.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Fix For: 2.7.3 > > Attachments: HDFS-8101.1.patch.txt > > > Previously, all references to DFSConfigKeys in DFSClient were compile time > constants which meant that normal users of DFSClient wouldn't resolve > DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a > member of DFSConfigKeys that isn't compile time constant > (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT). > Since the class must be resolved now, this particular member > {code} > public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = > AuthFilter.class.getName(); > {code} > means that javax.servlet.Filter needs to be on the classpath. > javax-servlet-api is one of the properly listed dependencies for HDFS, > however if we replace {{AuthFilter.class.getName()}} with the equivalent > String literal then downstream folks can avoid including it while maintaining > compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-8101) DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aaron T. Myers updated HDFS-8101: - Resolution: Fixed Fix Version/s: 2.8.0 Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) I've just committed this to trunk and branch-2. Thanks very much for the contribution, Sean. > DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at > runtime > --- > > Key: HDFS-8101 > URL: https://issues.apache.org/jira/browse/HDFS-8101 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.7.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Fix For: 2.8.0 > > Attachments: HDFS-8101.1.patch.txt > > > Previously, all references to DFSConfigKeys in DFSClient were compile time > constants which meant that normal users of DFSClient wouldn't resolve > DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a > member of DFSConfigKeys that isn't compile time constant > (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT). > Since the class must be resolved now, this particular member > {code} > public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = > AuthFilter.class.getName(); > {code} > means that javax.servlet.Filter needs to be on the classpath. > javax-servlet-api is one of the properly listed dependencies for HDFS, > however if we replace {{AuthFilter.class.getName()}} with the equivalent > String literal then downstream folks can avoid including it while maintaining > compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-8101) DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HDFS-8101: -- Status: Patch Available (was: In Progress) > DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at > runtime > --- > > Key: HDFS-8101 > URL: https://issues.apache.org/jira/browse/HDFS-8101 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.7.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Attachments: HDFS-8101.1.patch.txt > > > Previously, all references to DFSConfigKeys in DFSClient were compile time > constants which meant that normal users of DFSClient wouldn't resolve > DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a > member of DFSConfigKeys that isn't compile time constant > (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT). > Since the class must be resolved now, this particular member > {code} > public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = > AuthFilter.class.getName(); > {code} > means that javax.servlet.Filter needs to be on the classpath. > javax-servlet-api is one of the properly listed dependencies for HDFS, > however if we replace {{AuthFilter.class.getName()}} with the equivalent > String literal then downstream folks can avoid including it while maintaining > compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-8101) DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HDFS-8101: -- Attachment: HDFS-8101.1.patch.txt Manually inspected javap output for DFSConfigKeys and NameNodeHttpServer (it's what uses AuthFilter) to verify that NameNodeHttpServer didn't change. Checked DFSConfigKeys for other webhdfs class references. > DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at > runtime > --- > > Key: HDFS-8101 > URL: https://issues.apache.org/jira/browse/HDFS-8101 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.7.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > Attachments: HDFS-8101.1.patch.txt > > > Previously, all references to DFSConfigKeys in DFSClient were compile time > constants which meant that normal users of DFSClient wouldn't resolve > DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a > member of DFSConfigKeys that isn't compile time constant > (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT). > Since the class must be resolved now, this particular member > {code} > public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = > AuthFilter.class.getName(); > {code} > means that javax.servlet.Filter needs to be on the classpath. > javax-servlet-api is one of the properly listed dependencies for HDFS, > however if we replace {{AuthFilter.class.getName()}} with the equivalent > String literal then downstream folks can avoid including it while maintaining > compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-8101) DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime
[ https://issues.apache.org/jira/browse/HDFS-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Busbey updated HDFS-8101: -- Summary: DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at runtime (was: DFSConfigKeys pulls in WebHDFS classes at runtime) > DFSClient use of non-constant DFSConfigKeys pulls in WebHDFS classes at > runtime > --- > > Key: HDFS-8101 > URL: https://issues.apache.org/jira/browse/HDFS-8101 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs-client >Affects Versions: 2.7.0 >Reporter: Sean Busbey >Assignee: Sean Busbey >Priority: Minor > > Previously, all references to DFSConfigKeys in DFSClient were compile time > constants which meant that normal users of DFSClient wouldn't resolve > DFSConfigKeys at run time. As of HDFS-7718, DFSClient has a reference to a > member of DFSConfigKeys that isn't compile time constant > (DFS_CLIENT_KEY_PROVIDER_CACHE_EXPIRY_DEFAULT). > Since the class must be resolved now, this particular member > {code} > public static final String DFS_WEBHDFS_AUTHENTICATION_FILTER_DEFAULT = > AuthFilter.class.getName(); > {code} > means that javax.servlet.Filter needs to be on the classpath. > javax-servlet-api is one of the properly listed dependencies for HDFS, > however if we replace {{AuthFilter.class.getName()}} with the equivalent > String literal then downstream folks can avoid including it while maintaining > compatibility. -- This message was sent by Atlassian JIRA (v6.3.4#6332)