[jira] [Updated] (HDFS-8255) Rename getBlockReplication to getPreferredBlockStorageNum
[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated HDFS-8255:
---
Labels: BB2015-05-TBR (was: )
> Rename getBlockReplication to getPreferredBlockStorageNum
> -
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.8.0
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
> Labels: BB2015-05-TBR
> Attachments: HDFS-8255.000.patch, HDFS-8255.001.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8255) Rename getBlockReplication to getPreferredBlockStorageNum
[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-8255:
Affects Version/s: 2.8.0
> Rename getBlockReplication to getPreferredBlockStorageNum
> -
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
>Affects Versions: 2.8.0
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
> Attachments: HDFS-8255.000.patch, HDFS-8255.001.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8255) Rename getBlockReplication to getPreferredBlockStorageNum
[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-8255:
Attachment: HDFS-8255.001.patch
Thanks Andrew for the comment. Yes we do want to support striping + replication
in the future. In that case, {{getPreferredBlockReplication}} can still
represent the repl factor of each internal block, while a new value can
represent the preferred _level of redundancy_.
Let's just use this JIRA to rename {{getBlockReplication}} to
{{getPreferredBlockReplication}} then. I will add {{getPreferredRedundancy}}
under HDFS-8010 (it doesn't make much sense to add it without EC).
> Rename getBlockReplication to getPreferredBlockStorageNum
> -
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
> Attachments: HDFS-8255.000.patch, HDFS-8255.001.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8255) Rename getBlockReplication to getPreferredBlockStorageNum
[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-8255:
Attachment: HDFS-8255.000.patch
> Rename getBlockReplication to getPreferredBlockStorageNum
> -
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
> Attachments: HDFS-8255.000.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8255) Rename getBlockReplication to getPreferredBlockStorageNum
[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-8255:
Status: Patch Available (was: Open)
The patch is just a simple refactor plus reformatting several lines to make
them shorter than 80 chars.
> Rename getBlockReplication to getPreferredBlockStorageNum
> -
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
> Attachments: HDFS-8255.000.patch
>
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8255) Rename getBlockReplication to getPreferredBlockStorageNum
[
https://issues.apache.org/jira/browse/HDFS-8255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhe Zhang updated HDFS-8255:
Description:
We should rename {{BlockCollection#getBlockReplication}} to
{{getPreferredBlockStorageNum}} for 2 reasons:
# Currently, this method actually returns the _preferred_ block replication
factor instead of the _actual_ number of replicas. The current name is a little
ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
{{getPreferredBlockSize}}
# With the erasure coding feature, the name doesn't apply to striped blocks.
was:
We should rename {{BlockCollection#getBlockReplication}} to
{{getPreferredBlockStorageNum}} for 2 reasons:
# Currently, this method actually returns the _preferred_ block replication
factor instead of the _actual_ number of replicas. The current name is a little
ambiguous.
# With the erasure coding feature, the name doesn't apply to striped blocks.
> Rename getBlockReplication to getPreferredBlockStorageNum
> -
>
> Key: HDFS-8255
> URL: https://issues.apache.org/jira/browse/HDFS-8255
> Project: Hadoop HDFS
> Issue Type: Improvement
>Reporter: Zhe Zhang
>Assignee: Zhe Zhang
>
> We should rename {{BlockCollection#getBlockReplication}} to
> {{getPreferredBlockStorageNum}} for 2 reasons:
> # Currently, this method actually returns the _preferred_ block replication
> factor instead of the _actual_ number of replicas. The current name is a
> little ambiguous. {{getPreferredBlockStorageNum}} is also consistent with
> {{getPreferredBlockSize}}
> # With the erasure coding feature, the name doesn't apply to striped blocks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
