[jira] [Updated] (HDFS-8280) Code Cleanup in DFSInputStream

2015-04-28 Thread Haohui Mai (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-8280:
-
   Resolution: Fixed
Fix Version/s: 2.8.0
   Status: Resolved  (was: Patch Available)

I've committed the patch to trunk and branch-2. Thanks [~jingzhao] for the 
contribution.

> Code Cleanup in DFSInputStream
> --
>
> Key: HDFS-8280
> URL: https://issues.apache.org/jira/browse/HDFS-8280
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Fix For: 2.8.0
>
> Attachments: HDFS-8280.000.patch
>
>
> This is some code cleanup separate from HDFS-8272:
> # Avoid duplicated block reader creation code
> # If no new source DN can be found, {{getBestNodeDNAddrPair}} returns null 
> instead of throwing Exception. Whether to throw Exception or not should be 
> determined by {{getBestNodeDNAddrPair}}'s caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8280) Code Cleanup in DFSInputStream

2015-04-28 Thread Tsz Wo Nicholas Sze (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsz Wo Nicholas Sze updated HDFS-8280:
--
Hadoop Flags: Reviewed

+1 patch looks good.

> Code Cleanup in DFSInputStream
> --
>
> Key: HDFS-8280
> URL: https://issues.apache.org/jira/browse/HDFS-8280
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-8280.000.patch
>
>
> This is some code cleanup separate from HDFS-8272:
> # Avoid duplicated block reader creation code
> # If no new source DN can be found, {{getBestNodeDNAddrPair}} returns null 
> instead of throwing Exception. Whether to throw Exception or not should be 
> determined by {{getBestNodeDNAddrPair}}'s caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8280) Code Cleanup in DFSInputStream

2015-04-28 Thread Jing Zhao (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-8280:

Status: Patch Available  (was: Open)

> Code Cleanup in DFSInputStream
> --
>
> Key: HDFS-8280
> URL: https://issues.apache.org/jira/browse/HDFS-8280
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-8280.000.patch
>
>
> This is some code cleanup separate from HDFS-8272:
> # Avoid duplicated block reader creation code
> # If no new source DN can be found, {{getBestNodeDNAddrPair}} returns null 
> instead of throwing Exception. Whether to throw Exception or not should be 
> determined by {{getBestNodeDNAddrPair}}'s caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8280) Code Cleanup in DFSInputStream

2015-04-28 Thread Jing Zhao (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jing Zhao updated HDFS-8280:

Attachment: HDFS-8280.000.patch

> Code Cleanup in DFSInputStream
> --
>
> Key: HDFS-8280
> URL: https://issues.apache.org/jira/browse/HDFS-8280
> Project: Hadoop HDFS
>  Issue Type: Improvement
>Reporter: Jing Zhao
>Assignee: Jing Zhao
>Priority: Minor
> Attachments: HDFS-8280.000.patch
>
>
> This is some code cleanup separate from HDFS-8272:
> # Avoid duplicated block reader creation code
> # If no new source DN can be found, {{getBestNodeDNAddrPair}} returns null 
> instead of throwing Exception. Whether to throw Exception or not should be 
> determined by {{getBestNodeDNAddrPair}}'s caller.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)