[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.008.patch
Updated the patch to use utf-8 {{InputSource}}.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch,
HDFS-8306.005.patch, HDFS-8306.006.patch, HDFS-8306.007.patch,
HDFS-8306.008.patch, HDFS-8306.debug0.patch, HDFS-8306.debug1.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.007.patch
Remove the code of {{dumpAclEntries}}, because there is a such function already
in {{trunk}}.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch,
HDFS-8306.005.patch, HDFS-8306.006.patch, HDFS-8306.007.patch,
HDFS-8306.debug0.patch, HDFS-8306.debug1.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.006.patch
Rebase to trunk
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch,
HDFS-8306.005.patch, HDFS-8306.006.patch, HDFS-8306.debug0.patch,
HDFS-8306.debug1.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.debug1.patch
Change {{PrintStream}} to utf8 as well.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch,
HDFS-8306.005.patch, HDFS-8306.debug0.patch, HDFS-8306.debug1.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.debug0.patch
Still can not reproduce the error on both OSX and Linux machines. Uploaded a
debug patch to print more debug information.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch,
HDFS-8306.005.patch, HDFS-8306.debug0.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.005.patch
Updated the patch to address the check style errors.
However, I could not reproduce the test failure ({{TestOfflineImageViewer}}) on
both OSX and Linux box.
So based on my guess, I try to encoding the XML outputs in utf8 to see whether
it passes the test.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch,
HDFS-8306.005.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.003.patch
Hi, [~andrew.wang]
I added a layout version in the XML outputs and test against use the OIV tool
to load newer version of fsimage, as you suggested.
Would you give another look?
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.004.patch
Thanks a lot for this quick review, [~andrew.wang]. Fixed typos as you
suggested.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch, HDFS-8306.003.patch, HDFS-8306.004.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Allen Wittenauer updated HDFS-8306:
---
Labels: BB2015-05-TBR (was: )
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Labels: BB2015-05-TBR
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.002.patch
Updated the patch to fix checkstyle warnings.
bq. We can do something similar for this tool to make sure nothing is missing,
though we might want to more vigorously exercise some of the operations.
We might use reflection to fill all fields in fsimage, and generate XML files
and then compares them with the fsimage generated from the outputs? Would be a
interesting JIRA to do.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch,
HDFS-8306.002.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.001.patch
Thanks a lot for reviewing, [~andrew.wang]
bq. I think xattr keys can be binary too, so would need to base64 them too.
In {{o.a.h.fs.XAttr}}:
{code}
public class XAttr {
...
private final String name;
private final byte[] value;
}
{code}
It should indicate that {{name}} has no intention to be binary data. The
current code can handle UTF-8 and escape chars well, I added tests in the
updated patch.
bq. In this case, I'd really like to see a compile time error saying that
support for this new data hasn't been added to OIV.
Yeah, it is a nice function to have. Lets do it in a follow on JIRA?
Could you give another review? Thanks!
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Attachments: HDFS-8306.000.patch, HDFS-8306.001.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Attachment: HDFS-8306.000.patch
This patch generates ACLs and Xattrs in OIV XML outputs, and verifies the XML
outputs in the test. The value of Xattr is base64 encoded.
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Attachments: HDFS-8306.000.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-8306) Generate ACL and Xattr outputs in OIV XML outputs
[
https://issues.apache.org/jira/browse/HDFS-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lei (Eddy) Xu updated HDFS-8306:
Status: Patch Available (was: Open)
Generate ACL and Xattr outputs in OIV XML outputs
-
Key: HDFS-8306
URL: https://issues.apache.org/jira/browse/HDFS-8306
Project: Hadoop HDFS
Issue Type: Sub-task
Components: namenode
Affects Versions: 2.7.0
Reporter: Lei (Eddy) Xu
Assignee: Lei (Eddy) Xu
Priority: Minor
Attachments: HDFS-8306.000.patch
Currently, in the {{hdfs oiv}} XML outputs, not all fields of fsimage are
outputs. It makes inspecting {{fsimage}} from XML outputs less practical.
Also it prevents recovering a fsimage from XML file.
This JIRA is adding ACL and XAttrs in the XML outputs as the first step to
achieve the goal described in HDFS-8061.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
