[jira] [Updated] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode

2015-05-07 Thread Haohui Mai (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-8321:
-
   Resolution: Fixed
Fix Version/s: 2.8.0
 Hadoop Flags: Reviewed
   Status: Resolved  (was: Patch Available)

I've committed the patch to trunk and branch-2. Thanks Jing for the reviews.

 CacheDirectives and CachePool operations should throw RetriableException in 
 safemode
 

 Key: HDFS-8321
 URL: https://issues.apache.org/jira/browse/HDFS-8321
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Haohui Mai
Assignee: Haohui Mai
  Labels: BB2015-05-TBR
 Fix For: 2.8.0

 Attachments: HDFS-8321.000.patch, HDFS-8321.001.patch, 
 HDFS-8321.002.patch


 Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when 
 the NN is in safemode:
 {code}
   if (isInSafeMode()) {
 throw new SafeModeException(
 Cannot add cache directive, safeMode);
   }
 {code}
 While other NN operations throws {{RetriableException}} when HA is enabled:
 {code}
   void checkNameNodeSafeMode(String errorMsg)
   throws RetriableException, SafeModeException {
 if (isInSafeMode()) {
   SafeModeException se = new SafeModeException(errorMsg, safeMode);
   if (haEnabled  haContext != null
haContext.getState().getServiceState() == HAServiceState.ACTIVE
shouldRetrySafeMode(this.safeMode)) {
 throw new RetriableException(se);
   } else {
 throw se;
   }
 }
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode

2015-05-05 Thread Allen Wittenauer (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Allen Wittenauer updated HDFS-8321:
---
Labels: BB2015-05-TBR  (was: )

 CacheDirectives and CachePool operations should throw RetriableException in 
 safemode
 

 Key: HDFS-8321
 URL: https://issues.apache.org/jira/browse/HDFS-8321
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Haohui Mai
Assignee: Haohui Mai
  Labels: BB2015-05-TBR
 Attachments: HDFS-8321.000.patch, HDFS-8321.001.patch


 Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when 
 the NN is in safemode:
 {code}
   if (isInSafeMode()) {
 throw new SafeModeException(
 Cannot add cache directive, safeMode);
   }
 {code}
 While other NN operations throws {{RetriableException}} when HA is enabled:
 {code}
   void checkNameNodeSafeMode(String errorMsg)
   throws RetriableException, SafeModeException {
 if (isInSafeMode()) {
   SafeModeException se = new SafeModeException(errorMsg, safeMode);
   if (haEnabled  haContext != null
haContext.getState().getServiceState() == HAServiceState.ACTIVE
shouldRetrySafeMode(this.safeMode)) {
 throw new RetriableException(se);
   } else {
 throw se;
   }
 }
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode

2015-05-05 Thread Haohui Mai (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-8321:
-
Attachment: HDFS-8321.001.patch

 CacheDirectives and CachePool operations should throw RetriableException in 
 safemode
 

 Key: HDFS-8321
 URL: https://issues.apache.org/jira/browse/HDFS-8321
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-8321.000.patch, HDFS-8321.001.patch


 Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when 
 the NN is in safemode:
 {code}
   if (isInSafeMode()) {
 throw new SafeModeException(
 Cannot add cache directive, safeMode);
   }
 {code}
 While other NN operations throws {{RetriableException}} when HA is enabled:
 {code}
   void checkNameNodeSafeMode(String errorMsg)
   throws RetriableException, SafeModeException {
 if (isInSafeMode()) {
   SafeModeException se = new SafeModeException(errorMsg, safeMode);
   if (haEnabled  haContext != null
haContext.getState().getServiceState() == HAServiceState.ACTIVE
shouldRetrySafeMode(this.safeMode)) {
 throw new RetriableException(se);
   } else {
 throw se;
   }
 }
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode

2015-05-05 Thread Haohui Mai (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-8321:
-
Attachment: HDFS-8321.002.patch

 CacheDirectives and CachePool operations should throw RetriableException in 
 safemode
 

 Key: HDFS-8321
 URL: https://issues.apache.org/jira/browse/HDFS-8321
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Haohui Mai
Assignee: Haohui Mai
  Labels: BB2015-05-TBR
 Attachments: HDFS-8321.000.patch, HDFS-8321.001.patch, 
 HDFS-8321.002.patch


 Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when 
 the NN is in safemode:
 {code}
   if (isInSafeMode()) {
 throw new SafeModeException(
 Cannot add cache directive, safeMode);
   }
 {code}
 While other NN operations throws {{RetriableException}} when HA is enabled:
 {code}
   void checkNameNodeSafeMode(String errorMsg)
   throws RetriableException, SafeModeException {
 if (isInSafeMode()) {
   SafeModeException se = new SafeModeException(errorMsg, safeMode);
   if (haEnabled  haContext != null
haContext.getState().getServiceState() == HAServiceState.ACTIVE
shouldRetrySafeMode(this.safeMode)) {
 throw new RetriableException(se);
   } else {
 throw se;
   }
 }
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode

2015-05-04 Thread Haohui Mai (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-8321:
-
Attachment: HDFS-8321.000.patch

 CacheDirectives and CachePool operations should throw RetriableException in 
 safemode
 

 Key: HDFS-8321
 URL: https://issues.apache.org/jira/browse/HDFS-8321
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-8321.000.patch


 Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when 
 the NN is in safemode:
 {code}
   if (isInSafeMode()) {
 throw new SafeModeException(
 Cannot add cache directive, safeMode);
   }
 {code}
 While other NN operations throws {{RetriableException}} when HA is enabled:
 {code}
   void checkNameNodeSafeMode(String errorMsg)
   throws RetriableException, SafeModeException {
 if (isInSafeMode()) {
   SafeModeException se = new SafeModeException(errorMsg, safeMode);
   if (haEnabled  haContext != null
haContext.getState().getServiceState() == HAServiceState.ACTIVE
shouldRetrySafeMode(this.safeMode)) {
 throw new RetriableException(se);
   } else {
 throw se;
   }
 }
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-8321) CacheDirectives and CachePool operations should throw RetriableException in safemode

2015-05-04 Thread Haohui Mai (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-8321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Haohui Mai updated HDFS-8321:
-
Status: Patch Available  (was: Open)

 CacheDirectives and CachePool operations should throw RetriableException in 
 safemode
 

 Key: HDFS-8321
 URL: https://issues.apache.org/jira/browse/HDFS-8321
 Project: Hadoop HDFS
  Issue Type: Bug
Reporter: Haohui Mai
Assignee: Haohui Mai
 Attachments: HDFS-8321.000.patch


 Operations such as {{addCacheDirectives()}} throws {{SafeModeException}} when 
 the NN is in safemode:
 {code}
   if (isInSafeMode()) {
 throw new SafeModeException(
 Cannot add cache directive, safeMode);
   }
 {code}
 While other NN operations throws {{RetriableException}} when HA is enabled:
 {code}
   void checkNameNodeSafeMode(String errorMsg)
   throws RetriableException, SafeModeException {
 if (isInSafeMode()) {
   SafeModeException se = new SafeModeException(errorMsg, safeMode);
   if (haEnabled  haContext != null
haContext.getState().getServiceState() == HAServiceState.ACTIVE
shouldRetrySafeMode(this.safeMode)) {
 throw new RetriableException(se);
   } else {
 throw se;
   }
 }
   }
 {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)