[jira] [Updated] (HDFS-9141) Thread leak in Datanode#refreshVolumes

2015-09-29 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-9141:
--
Status: Patch Available  (was: Open)

> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: datanode
>Affects Versions: 2.7.1, 3.0.0
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume 
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are 
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-9141) Thread leak in Datanode#refreshVolumes

2015-09-29 Thread Uma Maheswara Rao G (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uma Maheswara Rao G updated HDFS-9141:
--
Attachment: HDFS-9141.00.patch

Updated the patch to handle this.

> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume 
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are 
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (HDFS-9141) Thread leak in Datanode#refreshVolumes

2015-09-29 Thread Yi Liu (JIRA) 

 [ 
https://issues.apache.org/jira/browse/HDFS-9141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yi Liu updated HDFS-9141:
-
   Resolution: Fixed
 Hadoop Flags: Reviewed
Fix Version/s: 2.8.0
   Status: Resolved  (was: Patch Available)

Committed to trunk and branch-2, thanks Uma.

> Thread leak in Datanode#refreshVolumes
> --
>
> Key: HDFS-9141
> URL: https://issues.apache.org/jira/browse/HDFS-9141
> Project: Hadoop HDFS
>  Issue Type: Bug
>  Components: datanode
>Affects Versions: 3.0.0, 2.7.1
>Reporter: Uma Maheswara Rao G
>Assignee: Uma Maheswara Rao G
> Fix For: 2.8.0
>
> Attachments: HDFS-9141.00.patch
>
>
> In refreshVolumes, we are creating executor service and submitting volume 
> addition tasks to it.
> But we are not shutting down the service after the use. Even though we are 
> not holding instance level service, the initialized thread could be left out.
> {code}
> ExecutorService service = Executors.newFixedThreadPool(
> changedVolumes.newLocations.size());
> {code}
> So, simple fix for this would be to shutdown the service after its use.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)