[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HDFS-9400:
Resolution: Fixed
Hadoop Flags: Reviewed
Fix Version/s: 2.8.0
Status: Resolved (was: Patch Available)
I have committed this to branch-2. Brahma and Mingliang, thank you for the
help!
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
> Fix For: 2.8.0
>
> Attachments: HDFS-9400-branch-2.001.patch,
> HDFS-9400-branch-2.002.patch, HDFS-9400-branch-2.patch
>
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-9400:
---
Attachment: HDFS-9400-branch-2.002.patch
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
> Attachments: HDFS-9400-branch-2.001.patch,
> HDFS-9400-branch-2.002.patch, HDFS-9400-branch-2.patch
>
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mingliang Liu updated HDFS-9400:
Attachment: HDFS-9400-branch-2.001.patch
Thank you [~cnauroth] for narrowing down the cause of this failing test. The
[HDFS-8979] was not supposed to contain logic change. Unfortunately it brought
some changes which was actually added by [HDFS-8332] in trunk.
Thank you [~brahmareddy] for working on this and investigating the root cause.
I totally agree with you that the root cause is calling {{checkOpen()}} in
{{DFSClient}} class, brought by [HDFS-8979] which obviously was not aware of
the revert of [HDFS-8332] from {{branch-2}} when committing.
The fix may be to simply revert the unnecessary {{checkOpen()}} method call
brought by [HDFS-8979]. I tested the v1 patch locally on my Gentoo Linux and
Mac, and it seems to work.
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
> Attachments: HDFS-9400-branch-2.001.patch, HDFS-9400-branch-2.patch
>
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-9400:
---
Status: Patch Available (was: Open)
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
> Attachments: HDFS-9400.patch
>
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-9400:
---
Attachment: HDFS-9400.patch
Even this testcase fails without HDFS-8332 in Trunk. After dfs.close(); dfs is
object getting used {{TestRollingUpgrade.queryForPreparation(dfs);}} so just
before this call add {{dfs = dfsCluster.getFileSystem(0);}} even which is same
with trunk.
{noformat}
java.io.IOException: Filesystem closed
at org.apache.hadoop.hdfs.DFSClient.checkOpen(DFSClient.java:455)
at org.apache.hadoop.hdfs.DFSClient.rollingUpgrade(DFSClient.java:2421)
at
org.apache.hadoop.hdfs.DistributedFileSystem.rollingUpgrade(DistributedFileSystem.java:1313)
at
org.apache.hadoop.hdfs.TestRollingUpgrade.queryForPreparation(TestRollingUpgrade.java:583)
at
org.apache.hadoop.hdfs.TestRollingUpgradeRollback.testRollbackWithHAQJM(TestRollingUpgradeRollback.java:231)
{noformat}
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
> Attachments: HDFS-9400.patch
>
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-9400:
---
Attachment: (was: HDFS-9400.patch)
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-9400) TestRollingUpgradeRollback fails on branch-2.
[
https://issues.apache.org/jira/browse/HDFS-9400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brahma Reddy Battula updated HDFS-9400:
---
Attachment: HDFS-9400-branch-2.patch
> TestRollingUpgradeRollback fails on branch-2.
> -
>
> Key: HDFS-9400
> URL: https://issues.apache.org/jira/browse/HDFS-9400
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Chris Nauroth
>Assignee: Brahma Reddy Battula
>Priority: Blocker
> Attachments: HDFS-9400-branch-2.patch
>
>
> During a Jenkins pre-commit run on branch-2 for the HDFS-9394 patch, we
> noticed a pre-existing failure in {{TestRollingUpgradeRollback}}. I have
> confirmed that this test is failing in branch-2 only. It passes in trunk,
> and it passes in branch-2.7.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
