[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Status: Open (was: Patch Available) Pondering more related cleanups in DiffInfo and DistCpSync. There is always a struggle between being thorough and over-engineering. > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch, HDFS-9522-002.patch, > HDFS-9522-003.patch, HDFS-9522-004.patch, HDFS-9522-005.patch, > HDFS-9522-006.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Attachment: HDFS-9522-006.patch Patch 006: * Use subclass hierarchy instead of C-style tagged union for different types of diff report entries. * Fix DiffReportEntry.hashcode to include field 'type' when generating the hash code. (HDFS-9573) * Rename field 'fullpath' to 'sourcePath' in SnapshotDiffReportEntryProto. > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch, HDFS-9522-002.patch, > HDFS-9522-003.patch, HDFS-9522-004.patch, HDFS-9522-005.patch, > HDFS-9522-006.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Attachment: HDFS-9522-005.patch Patch 005: * Use subclass hierarchy instead of C-style tagged union for different types of diff report entries. * Fix DiffReportEntry.hashcode to include field 'type' when generating the hash code. (HDFS-9573) * Add unit test testDiffReportWithDeleteCreateSameName and testDiffReportWithCircularRenames to TestSnapshotDiffReport. * Rename field 'fullpath' to 'sourcePath' in SnapshotDiffReportEntryProto. > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch, HDFS-9522-002.patch, > HDFS-9522-003.patch, HDFS-9522-004.patch, HDFS-9522-005.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Attachment: HDFS-9522-003.patch Patch 003: * Fix checkstyle and findbugs errors and warnings. * Abandon over-engineered DiffPath and Bytes class. > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch, HDFS-9522-002.patch, > HDFS-9522-003.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Attachment: HDFS-9522-004.patch Revert changes that fix existing checkstyle warnings. Revert formatting changes. > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch, HDFS-9522-002.patch, > HDFS-9522-003.patch, HDFS-9522-004.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Attachment: HDFS-9522-002.patch A slight enhancement to patch 001. Add unit test testDiffReportWithDeleteCreateSameName and testDiffReportWithCircularRenames to TestSnapshotDiffReport. > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch, HDFS-9522-002.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Status: Patch Available (was: In Progress) > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Attachment: HDFS-9522-001.patch > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Attachments: HDFS-9522-001.patch > > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Zhuge updated HDFS-9522: - Summary: Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport (was: Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport$DiffReportEntry) > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HDFS-9522) Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport$DiffReportEntry
[ https://issues.apache.org/jira/browse/HDFS-9522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mingliang Liu updated HDFS-9522: Summary: Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport$DiffReportEntry (was: Cleanup DiffReportEntry) > Cleanup o.a.h.hdfs.protocol.SnapshotDiffReport$DiffReportEntry > -- > > Key: HDFS-9522 > URL: https://issues.apache.org/jira/browse/HDFS-9522 > Project: Hadoop HDFS > Issue Type: Improvement >Reporter: John Zhuge >Assignee: John Zhuge >Priority: Minor > Original Estimate: 24h > Remaining Estimate: 24h > > The current DiffReportEntry is a C-style tagged union-like data structure. > Recommend subclass hierarchy as in Java idiom. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
