[jira] Updated: (HDFS-957) FSImage layout version should be only once file is complete
[ https://issues.apache.org/jira/browse/HDFS-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HDFS-957: - Attachment: hdfs-957.txt This probably could do with some new unit tests, but wanted to attach here for early comment to see if people are on board with the idea. > FSImage layout version should be only once file is complete > --- > > Key: HDFS-957 > URL: https://issues.apache.org/jira/browse/HDFS-957 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node >Affects Versions: 0.22.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Attachments: hdfs-957.txt > > > Right now, the FSImage save code writes the LAYOUT_VERSION at the head of the > file, along with some other headers, and then dumps the directory into the > file. Instead, it should write a special IMAGE_IN_PROGRESS entry for the > layout version, dump all of the data, then seek back to the head of the file > to write the proper LAYOUT_VERSION. This would make it very easy to detect > the case where the FSImage save got interrupted. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-957) FSImage layout version should be only once file is complete
[ https://issues.apache.org/jira/browse/HDFS-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Todd Lipcon updated HDFS-957: - Status: Patch Available (was: Open) > FSImage layout version should be only once file is complete > --- > > Key: HDFS-957 > URL: https://issues.apache.org/jira/browse/HDFS-957 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node >Affects Versions: 0.22.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Attachments: hdfs-957.txt > > > Right now, the FSImage save code writes the LAYOUT_VERSION at the head of the > file, along with some other headers, and then dumps the directory into the > file. Instead, it should write a special IMAGE_IN_PROGRESS entry for the > layout version, dump all of the data, then seek back to the head of the file > to write the proper LAYOUT_VERSION. This would make it very easy to detect > the case where the FSImage save got interrupted. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] [Updated] (HDFS-957) FSImage layout version should be only once file is complete
[ https://issues.apache.org/jira/browse/HDFS-957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Allen Wittenauer updated HDFS-957: -- Status: Open (was: Patch Available) Patch no longer applies. > FSImage layout version should be only once file is complete > --- > > Key: HDFS-957 > URL: https://issues.apache.org/jira/browse/HDFS-957 > Project: Hadoop HDFS > Issue Type: Improvement > Components: namenode >Affects Versions: 0.22.0 >Reporter: Todd Lipcon >Assignee: Todd Lipcon > Attachments: hdfs-957.txt > > > Right now, the FSImage save code writes the LAYOUT_VERSION at the head of the > file, along with some other headers, and then dumps the directory into the > file. Instead, it should write a special IMAGE_IN_PROGRESS entry for the > layout version, dump all of the data, then seek back to the head of the file > to write the proper LAYOUT_VERSION. This would make it very easy to detect > the case where the FSImage save got interrupted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
