[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[ https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=214100=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214100 ] ASF GitHub Bot logged work on HDDS-1246: Author: ASF GitHub Bot Created on: 15/Mar/19 23:08 Start Date: 15/Mar/19 23:08 Worklog Time Spent: 10m Work Description: ajayydv commented on pull request #594: HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. URL: https://github.com/apache/hadoop/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 214100) Time Spent: 3h 40m (was: 3.5h) > Add ozone delegation token utility subcmd for Ozone CLI > --- > > Key: HDDS-1246 > URL: https://issues.apache.org/jira/browse/HDDS-1246 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Xiaoyu Yao >Assignee: Xiaoyu Yao >Priority: Major > Labels: pull-request-available > Time Spent: 3h 40m > Remaining Estimate: 0h > > This allow running dtutil with integration test and dev test for demo of > Ozone security. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=214098=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214098
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 15/Mar/19 23:06
Start Date: 15/Mar/19 23:06
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r266171177
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java
##
@@ -84,16 +86,23 @@ public OMFailoverProxyProvider(OzoneConfiguration
configuration,
public final class OMProxyInfo
extends FailoverProxyProvider.ProxyInfo {
private InetSocketAddress address;
+private Text dtService;
Review comment:
oh, you mean in follow up jira it will be uri. Make sense.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 214098)
Time Spent: 3.5h (was: 3h 20m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[ https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213564 ] ASF GitHub Bot logged work on HDDS-1246: Author: ASF GitHub Bot Created on: 15/Mar/19 04:35 Start Date: 15/Mar/19 04:35 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #594: HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. URL: https://github.com/apache/hadoop/pull/594#issuecomment-473155720 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 21 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 30 | Maven dependency ordering for branch | | +1 | mvninstall | 1280 | trunk passed | | +1 | compile | 108 | trunk passed | | +1 | checkstyle | 30 | trunk passed | | +1 | mvnsite | 110 | trunk passed | | +1 | shadedclient | 731 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 150 | trunk passed | | +1 | javadoc | 85 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 92 | the patch passed | | +1 | compile | 93 | the patch passed | | +1 | javac | 93 | the patch passed | | +1 | checkstyle | 25 | the patch passed | | +1 | mvnsite | 82 | the patch passed | | +1 | shellcheck | 27 | There were no new shellcheck issues. | | +1 | shelldocs | 14 | There were no new shelldocs issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 816 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 155 | the patch passed | | +1 | javadoc | 77 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 37 | common in the patch passed. | | +1 | unit | 28 | client in the patch passed. | | +1 | unit | 94 | ozonefs in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 4284 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-594/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/594 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle shellcheck shelldocs | | uname | Linux 9e0430b6eea6 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 2627dad | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | shellcheck | v0.4.6 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-594/2/testReport/ | | Max. process+thread count | 2913 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozonefs U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-594/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 213564) Time Spent: 3h 20m (was: 3h 10m) > Add ozone delegation token utility subcmd for Ozone CLI > --- > > Key: HDDS-1246 > URL: https://issues.apache.org/jira/browse/HDDS-1246 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Xiaoyu Yao >Assignee: Xiaoyu Yao >Priority: Major > Labels: pull-request-available > Time Spent: 3h 20m > Remaining Estimate: 0h > > This allow running dtutil with integration test and dev test for demo of > Ozone security. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213410=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213410
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 20:54
Start Date: 14/Mar/19 20:54
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265761945
##
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/O3fsDtFetcher.java
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.ozone;
+
+import java.io.IOException;
+import java.net.URI;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.security.Credentials;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.security.token.DtFetcher;
+import org.apache.hadoop.security.token.Token;
+
+
+/**
+ * A DT fetcher for OzoneFileSystem.
+ * It is only needed for the `hadoop dtutil` command.
+ */
+public class O3fsDtFetcher implements DtFetcher {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(O3fsDtFetcher.class);
+
+ private static final String SERVICE_NAME = OzoneConsts.OZONE_URI_SCHEME;
+
+ private static final String FETCH_FAILED =
+ "Fetch ozone delegation token failed";
+
+ /**
+ * Returns the service name for O3fs, which is also a valid URL prefix.
+ */
+ public Text getServiceName() {
+return new Text(SERVICE_NAME);
+ }
+
+ public boolean isTokenRequired() {
Review comment:
No, we can't. It is an implementation of DtFetcher interface method.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213410)
Time Spent: 3h 10m (was: 3h)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213403=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213403
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 20:38
Start Date: 14/Mar/19 20:38
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265756537
##
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/O3fsDtFetcher.java
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.ozone;
+
+import java.io.IOException;
+import java.net.URI;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.security.Credentials;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.security.token.DtFetcher;
+import org.apache.hadoop.security.token.Token;
+
+
+/**
+ * A DT fetcher for OzoneFileSystem.
+ * It is only needed for the `hadoop dtutil` command.
+ */
+public class O3fsDtFetcher implements DtFetcher {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(O3fsDtFetcher.class);
+
+ private static final String SERVICE_NAME = OzoneConsts.OZONE_URI_SCHEME;
+
+ private static final String FETCH_FAILED =
+ "Fetch ozone delegation token failed";
+
+ /**
+ * Returns the service name for O3fs, which is also a valid URL prefix.
+ */
+ public Text getServiceName() {
+return new Text(SERVICE_NAME);
+ }
+
+ public boolean isTokenRequired() {
Review comment:
yes
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213403)
Time Spent: 3h (was: 2h 50m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213396=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213396
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 20:28
Start Date: 14/Mar/19 20:28
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265752989
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
Review comment:
Agree, if those changes are not there in ozone-0.4, the cherry-pick and
merge will be messy.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213396)
Time Spent: 2h 50m (was: 2h 40m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[ https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213331=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213331 ] ASF GitHub Bot logged work on HDDS-1246: Author: ASF GitHub Bot Created on: 14/Mar/19 18:37 Start Date: 14/Mar/19 18:37 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #594: HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. URL: https://github.com/apache/hadoop/pull/594#issuecomment-473005533 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 24 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | 0 | mvndep | 69 | Maven dependency ordering for branch | | +1 | mvninstall | 1099 | trunk passed | | +1 | compile | 102 | trunk passed | | +1 | checkstyle | 32 | trunk passed | | +1 | mvnsite | 106 | trunk passed | | +1 | shadedclient | 738 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 137 | trunk passed | | +1 | javadoc | 85 | trunk passed | ||| _ Patch Compile Tests _ | | 0 | mvndep | 14 | Maven dependency ordering for patch | | +1 | mvninstall | 93 | the patch passed | | +1 | compile | 90 | the patch passed | | +1 | javac | 90 | the patch passed | | +1 | checkstyle | 24 | the patch passed | | +1 | mvnsite | 83 | the patch passed | | +1 | shellcheck | 25 | There were no new shellcheck issues. | | +1 | shelldocs | 17 | There were no new shelldocs issues. | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 810 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 154 | the patch passed | | +1 | javadoc | 77 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 38 | common in the patch passed. | | +1 | unit | 28 | client in the patch passed. | | +1 | unit | 91 | ozonefs in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 4122 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-594/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/594 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle shellcheck shelldocs | | uname | Linux 3e369e125c30 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / d60673c | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | shellcheck | v0.4.6 | | findbugs | v3.1.0-RC1 | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-594/1/testReport/ | | Max. process+thread count | 2982 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/common hadoop-ozone/client hadoop-ozone/ozonefs U: hadoop-ozone | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-594/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 213331) Time Spent: 2h 40m (was: 2.5h) > Add ozone delegation token utility subcmd for Ozone CLI > --- > > Key: HDDS-1246 > URL: https://issues.apache.org/jira/browse/HDDS-1246 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Xiaoyu Yao >Assignee: Xiaoyu Yao >Priority: Major > Labels: pull-request-available > Time Spent: 2h 40m > Remaining Estimate: 0h > > This allow running dtutil with integration test and dev test for demo of > Ozone security. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213250=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213250
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:48
Start Date: 14/Mar/19 16:48
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265665773
##
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/O3fsDtFetcher.java
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.ozone;
+
+import java.io.IOException;
+import java.net.URI;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.security.Credentials;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.security.token.DtFetcher;
+import org.apache.hadoop.security.token.Token;
+
+
+/**
+ * A DT fetcher for OzoneFileSystem.
+ * It is only needed for the `hadoop dtutil` command.
+ */
+public class O3fsDtFetcher implements DtFetcher {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(O3fsDtFetcher.class);
+
+ private static final String SERVICE_NAME = OzoneConsts.OZONE_URI_SCHEME;
+
+ private static final String FETCH_FAILED =
+ "Fetch ozone delegation token failed";
+
+ /**
+ * Returns the service name for O3fs, which is also a valid URL prefix.
+ */
+ public Text getServiceName() {
+return new Text(SERVICE_NAME);
+ }
+
+ public boolean isTokenRequired() {
Review comment:
You mean isTokenRequired?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213250)
Time Spent: 2.5h (was: 2h 20m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213243=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213243
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:46
Start Date: 14/Mar/19 16:46
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265665005
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java
##
@@ -84,16 +86,23 @@ public OMFailoverProxyProvider(OzoneConfiguration
configuration,
public final class OMProxyInfo
extends FailoverProxyProvider.ProxyInfo {
private InetSocketAddress address;
+private Text dtService;
Review comment:
The dtService will be a combined URI format that contains both instances'
ip:port. The token selector will be updated to accept.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213243)
Time Spent: 2h (was: 1h 50m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213249=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213249
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:48
Start Date: 14/Mar/19 16:48
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265665546
##
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##
@@ -576,7 +576,7 @@ message OMTokenProto {
optional uint32 sequenceNumber = 7;
optional uint32 masterKeyId= 8;
optional uint64 expiryDate = 9;
-required string omCertSerialId = 10;
+optional string omCertSerialId = 10;
Review comment:
Agree, this PR was created before that change. This will be fixed in next
push after rebase.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213249)
Time Spent: 2h 20m (was: 2h 10m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213245=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213245
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:47
Start Date: 14/Mar/19 16:47
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265665217
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSelector.java
##
@@ -44,7 +44,9 @@ public OzoneDelegationTokenSelector() {
public Token selectToken(Text service,
Collection> tokens) {
LOG.trace("Getting token for service {}", service);
-return super.selectToken(service, tokens);
+Token token = super.selectToken(service, tokens);
+LOG.info("Got tokens: {} for service {}", token, service);
Review comment:
Yes, I will definitely change this to DEBUG.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213245)
Time Spent: 2h 10m (was: 2h)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213239=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213239
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:45
Start Date: 14/Mar/19 16:45
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265664265
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
Review comment:
We will revisit this when full OM HA is implemented. For 0.4 we can assume
this will always return the first proxy. We will have to do this because the HA
code has been partially implemented in trunk. We don't want to work two
different versions that are difficult to merge later.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213239)
Time Spent: 1h 50m (was: 1h 40m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=213238=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213238
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 16:42
Start Date: 14/Mar/19 16:42
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #594: HDDS-1246.
Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu
Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265663195
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
+ LOG.info("Created " + token.toString());
+} else {
+ LOG.info("Cannot get ozone delegation token from " + renewer);
Review comment:
will fix in the next push.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 213238)
Time Spent: 1h 40m (was: 1.5h)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212859=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212859
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:24
Start Date: 14/Mar/19 03:24
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265408144
##
File path:
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/O3fsDtFetcher.java
##
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.ozone;
+
+import java.io.IOException;
+import java.net.URI;
+
+import org.apache.hadoop.ozone.OzoneConsts;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.security.Credentials;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.security.token.DtFetcher;
+import org.apache.hadoop.security.token.Token;
+
+
+/**
+ * A DT fetcher for OzoneFileSystem.
+ * It is only needed for the `hadoop dtutil` command.
+ */
+public class O3fsDtFetcher implements DtFetcher {
+ private static final Logger LOG =
+ LoggerFactory.getLogger(O3fsDtFetcher.class);
+
+ private static final String SERVICE_NAME = OzoneConsts.OZONE_URI_SCHEME;
+
+ private static final String FETCH_FAILED =
+ "Fetch ozone delegation token failed";
+
+ /**
+ * Returns the service name for O3fs, which is also a valid URL prefix.
+ */
+ public Text getServiceName() {
+return new Text(SERVICE_NAME);
+ }
+
+ public boolean isTokenRequired() {
Review comment:
Shall we move it to OzoneSecurityUtil?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212859)
Time Spent: 1.5h (was: 1h 20m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212858=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212858
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:21
Start Date: 14/Mar/19 03:21
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265407768
##
File path: hadoop-ozone/common/src/main/proto/OzoneManagerProtocol.proto
##
@@ -576,7 +576,7 @@ message OMTokenProto {
optional uint32 sequenceNumber = 7;
optional uint32 masterKeyId= 8;
optional uint64 expiryDate = 9;
-required string omCertSerialId = 10;
+optional string omCertSerialId = 10;
Review comment:
it is already optional.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212858)
Time Spent: 1h 20m (was: 1h 10m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212857=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212857
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:19
Start Date: 14/Mar/19 03:19
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265407576
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSelector.java
##
@@ -44,7 +44,9 @@ public OzoneDelegationTokenSelector() {
public Token selectToken(Text service,
Collection> tokens) {
LOG.trace("Getting token for service {}", service);
-return super.selectToken(service, tokens);
+Token token = super.selectToken(service, tokens);
+LOG.info("Got tokens: {} for service {}", token, service);
Review comment:
shall we dial it down to debug level?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212857)
Time Spent: 1h 10m (was: 1h)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212850=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212850
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:08
Start Date: 14/Mar/19 03:08
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265406128
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
Review comment:
I think this if for OM HA. Are we taking Om HA in badlands?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212850)
Time Spent: 0.5h (was: 20m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212856=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212856
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:17
Start Date: 14/Mar/19 03:17
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265407334
##
File path:
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/OMFailoverProxyProvider.java
##
@@ -84,16 +86,23 @@ public OMFailoverProxyProvider(OzoneConfiguration
configuration,
public final class OMProxyInfo
extends FailoverProxyProvider.ProxyInfo {
private InetSocketAddress address;
+private Text dtService;
Review comment:
During failover Om proxy may change and point to another OM instance, in
that case our previously set service field will become unusable.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212856)
Time Spent: 1h (was: 50m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212854=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212854
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:15
Start Date: 14/Mar/19 03:15
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265407031
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
Review comment:
On a related note it seems leader in OM HA may change which will mean
previously obtained token will not be selected by TokenSelector.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212854)
Time Spent: 50m (was: 40m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212851=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212851
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 14/Mar/19 03:09
Start Date: 14/Mar/19 03:09
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265406128
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
Review comment:
I think this is if for OM HA. Are we taking Om HA in badlands?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212851)
Time Spent: 40m (was: 0.5h)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[
https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=212757=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-212757
]
ASF GitHub Bot logged work on HDDS-1246:
Author: ASF GitHub Bot
Created on: 13/Mar/19 23:04
Start Date: 13/Mar/19 23:04
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #594: HDDS-1246. Add
ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao.
URL: https://github.com/apache/hadoop/pull/594#discussion_r265365974
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java
##
@@ -445,7 +444,18 @@ public void removeBucketAcls(
@Override
public Token getDelegationToken(Text renewer)
throws IOException {
-return ozoneManagerClient.getDelegationToken(renewer);
+
+Token token =
+ozoneManagerClient.getDelegationToken(renewer);
+if (token != null) {
+ Text dtService =
+ getOMProxyProvider().getProxy().getDelegationTokenService();
+ token.setService(dtService);
+ LOG.info("Created " + token.toString());
+} else {
+ LOG.info("Cannot get ozone delegation token from " + renewer);
Review comment:
Shall we replace "Cannot get ozone delegation token from" with "Cannot get
ozone delegation token for {}, renewer"?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 212757)
Time Spent: 20m (was: 10m)
> Add ozone delegation token utility subcmd for Ozone CLI
> ---
>
> Key: HDDS-1246
> URL: https://issues.apache.org/jira/browse/HDDS-1246
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
>Reporter: Xiaoyu Yao
>Assignee: Xiaoyu Yao
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This allow running dtutil with integration test and dev test for demo of
> Ozone security.
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1246) Add ozone delegation token utility subcmd for Ozone CLI
[ https://issues.apache.org/jira/browse/HDDS-1246?focusedWorklogId=211728=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-211728 ] ASF GitHub Bot logged work on HDDS-1246: Author: ASF GitHub Bot Created on: 12/Mar/19 14:00 Start Date: 12/Mar/19 14:00 Worklog Time Spent: 10m Work Description: xiaoyuyao commented on pull request #594: HDDS-1246. Add ozone delegation token utility subcmd for Ozone CLI. Contributed by Xiaoyu Yao. URL: https://github.com/apache/hadoop/pull/594 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 211728) Time Spent: 10m Remaining Estimate: 0h > Add ozone delegation token utility subcmd for Ozone CLI > --- > > Key: HDDS-1246 > URL: https://issues.apache.org/jira/browse/HDDS-1246 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task >Reporter: Xiaoyu Yao >Assignee: Xiaoyu Yao >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > This allow running dtutil with integration test and dev test for demo of > Ozone security. > > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
