[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=237492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237492 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 05/May/19 16:21 Start Date: 05/May/19 16:21 Worklog Time Spent: 10m Work Description: hanishakoneru commented on pull request #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 237492) Time Spent: 1h 50m (was: 1h 40m) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 1h 50m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=237491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237491 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 05/May/19 16:20 Start Date: 05/May/19 16:20 Worklog Time Spent: 10m Work Description: hanishakoneru commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-489440978 The test is flaky. I will merge this PR. Thanks @swagle for working on this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 237491) Time Spent: 1h 40m (was: 1.5h) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 1h 40m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=237132&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237132 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 04/May/19 00:54 Start Date: 04/May/19 00:54 Worklog Time Spent: 10m Work Description: swagle commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-489279581 Thanks for review @hanishakoneru. On my local machine, I get a 80% pass rate on this test. I can see that it is failing elsewhere without these changes as well: https://github.com/apache/hadoop/pull/781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 237132) Time Spent: 1.5h (was: 1h 20m) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=237023&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-237023 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 03/May/19 19:31 Start Date: 03/May/19 19:31 Worklog Time Spent: 10m Work Description: hanishakoneru commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-489213679 The patch LGTM overall. The CI unit test failure TestOzoneClientRetriesOnException#testMaxRetriesByOzoneClient looks related though. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 237023) Time Spent: 1h 20m (was: 1h 10m) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=236460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236460 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 02/May/19 18:07 Start Date: 02/May/19 18:07 Worklog Time Spent: 10m Work Description: swagle commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-488773774 /label ozone This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 236460) Time Spent: 1h 10m (was: 1h) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=236440&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-236440 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 02/May/19 17:45 Start Date: 02/May/19 17:45 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-488766177 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 46 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 434 | trunk passed | | +1 | compile | 214 | trunk passed | | +1 | checkstyle | 52 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 868 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 126 | trunk passed | | 0 | spotbugs | 298 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 501 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 444 | the patch passed | | +1 | compile | 203 | the patch passed | | +1 | javac | 203 | the patch passed | | +1 | checkstyle | 56 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 727 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 124 | the patch passed | | +1 | findbugs | 448 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 163 | hadoop-hdds in the patch failed. | | -1 | unit | 967 | hadoop-ozone in the patch failed. | | +1 | asflicense | 32 | The patch does not generate ASF License warnings. | | | | 5530 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules | | | hadoop.ozone.scm.TestXceiverClientMetrics | | | hadoop.ozone.web.TestOzoneVolumes | | | hadoop.ozone.om.TestOmInit | | | hadoop.ozone.client.rpc.TestContainerStateMachineFailures | | | hadoop.ozone.web.client.TestKeys | | | hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics | | | hadoop.ozone.web.client.TestOzoneClient | | | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.hdds.scm.container.TestContainerStateManagerIntegration | | | hadoop.ozone.ozShell.TestOzoneDatanodeShell | | | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.scm.pipeline.TestPipelineManagerMXBean | | | hadoop.ozone.om.TestOzoneManagerRestInterface | | | hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline | | | hadoop.ozone.om.TestOzoneManagerHA | | | hadoop.hdds.scm.pipeline.TestPipelineClose | | | hadoop.ozone.ozShell.TestS3Shell | | | hadoop.hdds.scm.pipeline.TestNode2PipelineMap | | | hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey | | | hadoop.ozone.scm.TestSCMNodeManagerMXBean | | | hadoop.ozone.scm.TestSCMMXBean | | | hadoop.ozone.ozShell.TestOzoneShell | | | hadoop.ozone.om.TestOzoneManagerConfiguration | | | hadoop.ozone.web.TestOzoneWebAccess | | | hadoop.ozone.client.rpc.TestCommitWatcher | | | hadoop.ozone.om.TestOmMetrics | | | hadoop.ozone.om.TestContainerReportWithKeys | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.scm.TestContainerSmallFile | | | hadoop.hdds.scm.pipeline.TestSCMRestart | | | hadoop.ozone.scm.node.TestQueryNode | | | hadoop.ozone.scm.node.TestSCMNodeMetrics | | | hadoop.ozone.client.rpc.TestBCSID | | | hadoop.hdds.scm.pipeline.TestNodeFailure | | | hadoop.ozone.scm.TestXceiverClientManager | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-785/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/785 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyl
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=235022&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-235022 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 30/Apr/19 01:17 Start Date: 30/Apr/19 01:17 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-487795655 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 23 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1011 | trunk passed | | +1 | compile | 32 | trunk passed | | +1 | checkstyle | 18 | trunk passed | | +1 | mvnsite | 28 | trunk passed | | +1 | shadedclient | 645 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 33 | trunk passed | | +1 | javadoc | 22 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 27 | the patch passed | | +1 | compile | 19 | the patch passed | | +1 | javac | 19 | the patch passed | | -0 | checkstyle | 12 | hadoop-ozone/client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 21 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 696 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 42 | the patch passed | | +1 | javadoc | 17 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 23 | client in the patch passed. | | +1 | asflicense | 27 | The patch does not generate ASF License warnings. | | | | 2782 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-785/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/785 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 061695c41da7 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 4b4200f | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/3/artifact/out/diff-checkstyle-hadoop-ozone_client.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/3/testReport/ | | Max. process+thread count | 444 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/client U: hadoop-ozone/client | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/3/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 235022) Time Spent: 50m (was: 40m) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=234971&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234971 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 29/Apr/19 23:07 Start Date: 29/Apr/19 23:07 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-487774326 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 816 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1241 | trunk passed | | +1 | compile | 49 | trunk passed | | +1 | checkstyle | 21 | trunk passed | | +1 | mvnsite | 29 | trunk passed | | +1 | shadedclient | 689 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 38 | trunk passed | | +1 | javadoc | 24 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 31 | the patch passed | | +1 | compile | 22 | the patch passed | | +1 | javac | 22 | the patch passed | | -0 | checkstyle | 14 | hadoop-ozone/client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 23 | the patch passed | | -1 | whitespace | 0 | The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <>. Refer https://git-scm.com/docs/git-apply | | +1 | shadedclient | 758 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 44 | the patch passed | | +1 | javadoc | 20 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 27 | client in the patch passed. | | +1 | asflicense | 33 | The patch does not generate ASF License warnings. | | | | 4000 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-785/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/785 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 13ab06d49bcf 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 4b4200f | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/2/artifact/out/diff-checkstyle-hadoop-ozone_client.txt | | whitespace | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/2/artifact/out/whitespace-eol.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/2/testReport/ | | Max. process+thread count | 411 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/client U: hadoop-ozone/client | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/2/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 234971) Time Spent: 40m (was: 0.5h) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval befor
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[
https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=234970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234970
]
ASF GitHub Bot logged work on HDDS-1464:
Author: ASF GitHub Bot
Created on: 29/Apr/19 23:07
Start Date: 29/Apr/19 23:07
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #785: HDDS-1464.
Client should have different retry policies for different exceptions.
URL: https://github.com/apache/hadoop/pull/785#discussion_r279571146
##
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java
##
@@ -500,12 +505,16 @@ private void markStreamClosed() {
cleanup();
closed = true;
}
-
+
Review comment:
whitespace:end of line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 234970)
Time Spent: 0.5h (was: 20m)
> Client should have different retry policies for different exceptions
>
>
> Key: HDDS-1464
> URL: https://issues.apache.org/jira/browse/HDDS-1464
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
>Reporter: Hanisha Koneru
>Assignee: Siddharth Wagle
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Client should have different retry policies for different type of failures.
> For example, If a key write fails because of ContainerNotOpen exception, the
> client should wait for a specified interval before retrying. But if the key
> write fails because of lets say ratis leader election or request timeout, we
> want the client to retry immediately.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=234950&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234950 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 29/Apr/19 22:15 Start Date: 29/Apr/19 22:15 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785#issuecomment-487763236 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 24 | Docker mode activated. | ||| _ Prechecks _ | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 1054 | trunk passed | | +1 | compile | 48 | trunk passed | | +1 | checkstyle | 20 | trunk passed | | +1 | mvnsite | 28 | trunk passed | | +1 | shadedclient | 716 | branch has no errors when building and testing our client artifacts. | | +1 | findbugs | 34 | trunk passed | | +1 | javadoc | 19 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 30 | the patch passed | | +1 | compile | 21 | the patch passed | | +1 | javac | 21 | the patch passed | | -0 | checkstyle | 14 | hadoop-ozone/client: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 24 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 747 | patch has no errors when building and testing our client artifacts. | | +1 | findbugs | 42 | the patch passed | | +1 | javadoc | 20 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 27 | client in the patch passed. | | +1 | asflicense | 29 | The patch does not generate ASF License warnings. | | | | 2985 | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/hadoop-multibranch/job/PR-785/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/785 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux e829b67ce4ef 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 95790bb | | maven | version: Apache Maven 3.3.9 | | Default Java | 1.8.0_191 | | findbugs | v3.1.0-RC1 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/1/artifact/out/diff-checkstyle-hadoop-ozone_client.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/1/testReport/ | | Max. process+thread count | 410 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/client U: hadoop-ozone/client | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-785/1/console | | Powered by | Apache Yetus 0.9.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 234950) Time Spent: 20m (was: 10m) > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005
[jira] [Work logged] (HDDS-1464) Client should have different retry policies for different exceptions
[ https://issues.apache.org/jira/browse/HDDS-1464?focusedWorklogId=234916&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234916 ] ASF GitHub Bot logged work on HDDS-1464: Author: ASF GitHub Bot Created on: 29/Apr/19 21:24 Start Date: 29/Apr/19 21:24 Worklog Time Spent: 10m Work Description: swagle commented on pull request #785: HDDS-1464. Client should have different retry policies for different exceptions. URL: https://github.com/apache/hadoop/pull/785 + @hanishakoneru KeyOutputStream correctly does the handleWrite() from inside the retry so only the correct setting for fixed initial delay needs to be set appropriately. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 234916) Time Spent: 10m Remaining Estimate: 0h > Client should have different retry policies for different exceptions > > > Key: HDDS-1464 > URL: https://issues.apache.org/jira/browse/HDDS-1464 > Project: Hadoop Distributed Data Store > Issue Type: Improvement >Reporter: Hanisha Koneru >Assignee: Siddharth Wagle >Priority: Major > Labels: pull-request-available > Time Spent: 10m > Remaining Estimate: 0h > > Client should have different retry policies for different type of failures. > For example, If a key write fails because of ContainerNotOpen exception, the > client should wait for a specified interval before retrying. But if the key > write fails because of lets say ratis leader election or request timeout, we > want the client to retry immediately. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
