[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=291621=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291621
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 08/Aug/19 22:40
Start Date: 08/Aug/19 22:40
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 291621)
Time Spent: 4h (was: 3h 50m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 4h
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=291620=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291620
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 08/Aug/19 22:40
Start Date: 08/Aug/19 22:40
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on issue #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#issuecomment-519712984
Thank You @xiaoyuyao and @arp7 for the review.
Test failures are not related to this patch. I will commit this to the trunk.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 291620)
Time Spent: 3h 50m (was: 3h 40m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 3h 50m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=291593=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291593
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 08/Aug/19 21:51
Start Date: 08/Aug/19 21:51
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r312258419
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -263,9 +262,7 @@ public Void call() throws Exception {
// Compute the common initial digest for all keys without their UUID
if (validateWrites) {
commonInitialMD = DigestUtils.getDigest(DIGEST_ALGORITHM);
- int uuidLength = UUID.randomUUID().toString().length();
- keySize = Math.max(uuidLength, keySize);
- for (long nrRemaining = keySize - uuidLength; nrRemaining > 0;
+ for (long nrRemaining = keySize; nrRemaining > 0;
Review comment:
LGTM, +1.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 291593)
Time Spent: 3h 40m (was: 3.5h)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=291205=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-291205 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 08/Aug/19 11:53 Start Date: 08/Aug/19 11:53 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-519486672 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 45 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 645 | trunk passed | | +1 | compile | 369 | trunk passed | | +1 | checkstyle | 64 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 188 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 142 | trunk passed | | 0 | spotbugs | 414 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 602 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 540 | the patch passed | | +1 | compile | 348 | the patch passed | | +1 | javac | 348 | the patch passed | | +1 | checkstyle | 65 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 710 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 155 | the patch passed | | +1 | findbugs | 646 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 277 | hadoop-hdds in the patch passed. | | -1 | unit | 2236 | hadoop-ozone in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 7221 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestWatchForCommit | | | hadoop.ozone.om.TestKeyManagerImpl | | | hadoop.ozone.om.TestOzoneManagerHA | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.client.rpc.TestCommitWatcher | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 26885d0b72d3 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 397a563 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/testReport/ | | Max. process+thread count | 4765 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/8/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 291205) Time Spent: 3.5h (was: 3h 20m) > Freon RandomKeyGenerator even if keySize is set to 0, it returns some random > data to key > > > Key: HDDS-1863 > URL: https://issues.apache.org/jira/browse/HDDS-1863 > Project: Hadoop Distributed Data Store > Issue
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=290990=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-290990 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 08/Aug/19 04:30 Start Date: 08/Aug/19 04:30 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-519358446 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 131 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 748 | trunk passed | | +1 | compile | 461 | trunk passed | | +1 | checkstyle | 103 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 1168 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 227 | trunk passed | | 0 | spotbugs | 555 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 812 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 706 | the patch passed | | +1 | compile | 439 | the patch passed | | +1 | javac | 439 | the patch passed | | +1 | checkstyle | 93 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 859 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 217 | the patch passed | | +1 | findbugs | 771 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 411 | hadoop-hdds in the patch passed. | | -1 | unit | 3099 | hadoop-ozone in the patch failed. | | +1 | asflicense | 47 | The patch does not generate ASF License warnings. | | | | 10479 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.om.TestSecureOzoneManager | | | hadoop.ozone.client.rpc.Test2WayCommitInRatis | | | hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | | | hadoop.ozone.client.rpc.TestBlockOutputStream | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestCommitWatcher | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.om.TestKeyManagerImpl | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux a4622866266d 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 70b4617 | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/testReport/ | | Max. process+thread count | 5370 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/7/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 290990) Time Spent: 3h 20m (was: 3h 10m) > Freon RandomKeyGenerator even if keySize is set to 0, it returns some random > data to key >
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=287415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-287415 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 02/Aug/19 01:07 Start Date: 02/Aug/19 01:07 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-517509664 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 84 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 604 | trunk passed | | +1 | compile | 404 | trunk passed | | +1 | checkstyle | 74 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 945 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 169 | trunk passed | | 0 | spotbugs | 474 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 681 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 585 | the patch passed | | +1 | compile | 394 | the patch passed | | +1 | javac | 394 | the patch passed | | +1 | checkstyle | 75 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 753 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 186 | the patch passed | | +1 | findbugs | 738 | the patch passed | ||| _ Other Tests _ | | +1 | unit | 359 | hadoop-hdds in the patch passed. | | -1 | unit | 2121 | hadoop-ozone in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 8371 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestCommitWatcher | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.0 Server=19.03.0 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux c1f6d5f0c2ef 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 32607db | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/testReport/ | | Max. process+thread count | 4797 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/6/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 287415) Time Spent: 3h 10m (was: 3h) > Freon RandomKeyGenerator even if keySize is set to 0, it returns some random > data to key > > > Key: HDDS-1863 > URL: https://issues.apache.org/jira/browse/HDDS-1863 > Project: Hadoop Distributed Data Store > Issue Type: Bug >Reporter: Bharat Viswanadham >
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=286064=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286064
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 31/Jul/19 17:01
Start Date: 31/Jul/19 17:01
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r309330700
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -263,9 +262,7 @@ public Void call() throws Exception {
// Compute the common initial digest for all keys without their UUID
if (validateWrites) {
commonInitialMD = DigestUtils.getDigest(DIGEST_ALGORITHM);
- int uuidLength = UUID.randomUUID().toString().length();
- keySize = Math.max(uuidLength, keySize);
- for (long nrRemaining = keySize - uuidLength; nrRemaining > 0;
+ for (long nrRemaining = keySize; nrRemaining > 0;
Review comment:
Opened https://issues.apache.org/jira/browse/HDDS-1883 for this.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 286064)
Time Spent: 3h (was: 2h 50m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=286062=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286062
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 31/Jul/19 16:59
Start Date: 31/Jul/19 16:59
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r309329802
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -263,9 +262,7 @@ public Void call() throws Exception {
// Compute the common initial digest for all keys without their UUID
if (validateWrites) {
commonInitialMD = DigestUtils.getDigest(DIGEST_ALGORITHM);
- int uuidLength = UUID.randomUUID().toString().length();
- keySize = Math.max(uuidLength, keySize);
- for (long nrRemaining = keySize - uuidLength; nrRemaining > 0;
+ for (long nrRemaining = keySize; nrRemaining > 0;
Review comment:
Yes, we don't enter inside for loop if keySize passed is negative.
If we want to add keySize checks, i think it might be applicable for all the
parameters like numVolumes, numBuckets. I will open a new jira to handle this.
So, if any parameter is incorrect, show the error message to the user or any
other idea how to handle this?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 286062)
Time Spent: 2h 50m (was: 2h 40m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=285337=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285337
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 30/Jul/19 23:23
Start Date: 30/Jul/19 23:23
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308983465
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -263,9 +262,7 @@ public Void call() throws Exception {
// Compute the common initial digest for all keys without their UUID
if (validateWrites) {
commonInitialMD = DigestUtils.getDigest(DIGEST_ALGORITHM);
- int uuidLength = UUID.randomUUID().toString().length();
- keySize = Math.max(uuidLength, keySize);
- for (long nrRemaining = keySize - uuidLength; nrRemaining > 0;
+ for (long nrRemaining = keySize; nrRemaining > 0;
Review comment:
should we add some parameter check before processing nrRemaining?
E.g., keySize > 0, keySize < bufferSize, otherwise, if someone specify
keySize < 0 or keySize< bufferSize, the nrRemaining and curSize can still be
possible be negative.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 285337)
Time Spent: 2.5h (was: 2h 20m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=285338=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285338
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 30/Jul/19 23:23
Start Date: 30/Jul/19 23:23
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308983465
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -263,9 +262,7 @@ public Void call() throws Exception {
// Compute the common initial digest for all keys without their UUID
if (validateWrites) {
commonInitialMD = DigestUtils.getDigest(DIGEST_ALGORITHM);
- int uuidLength = UUID.randomUUID().toString().length();
- keySize = Math.max(uuidLength, keySize);
- for (long nrRemaining = keySize - uuidLength; nrRemaining > 0;
+ for (long nrRemaining = keySize; nrRemaining > 0;
Review comment:
should we add some parameter check before processing nrRemaining?
E.g., keySize > 0, keySize > bufferSize, otherwise, if someone specify
keySize < 0 or keySize< bufferSize, the nrRemaining and curSize can still be
possible be negative.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 285338)
Time Spent: 2h 40m (was: 2.5h)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=285335=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-285335
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 30/Jul/19 23:20
Start Date: 30/Jul/19 23:20
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308983465
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -263,9 +262,7 @@ public Void call() throws Exception {
// Compute the common initial digest for all keys without their UUID
if (validateWrites) {
commonInitialMD = DigestUtils.getDigest(DIGEST_ALGORITHM);
- int uuidLength = UUID.randomUUID().toString().length();
- keySize = Math.max(uuidLength, keySize);
- for (long nrRemaining = keySize - uuidLength; nrRemaining > 0;
+ for (long nrRemaining = keySize; nrRemaining > 0;
Review comment:
should we add some parameter check before processing nrRemaining?
E.g., keySize > 0, keySize > bufferSize, otherwise, if someone specify
keySize < 0 or keySize< bufferSize, the nrRemaining and curSize can still be
possible be negative.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 285335)
Time Spent: 2h 20m (was: 2h 10m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284725
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 30/Jul/19 05:53
Start Date: 30/Jul/19 05:53
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308542706
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -697,12 +697,11 @@ private boolean createKey(long globalKeyNumber) {
try (Scope writeScope = GlobalTracer.get().buildSpan("writeKeyData")
.startActive(true)) {
long keyWriteStart = System.nanoTime();
- for (long nrRemaining = keySize - randomValue.length;
+ for (long nrRemaining = keySize;
nrRemaining > 0; nrRemaining -= bufferSize) {
int curSize = (int) Math.min(bufferSize, nrRemaining);
os.write(keyValueBuffer, 0, curSize);
}
- os.write(randomValue);
Review comment:
Thank you.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 284725)
Time Spent: 2h 10m (was: 2h)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284596=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284596 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 29/Jul/19 22:47 Start Date: 29/Jul/19 22:47 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-516190906 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 82 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 672 | trunk passed | | +1 | compile | 419 | trunk passed | | +1 | checkstyle | 69 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 1037 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 183 | trunk passed | | 0 | spotbugs | 450 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 684 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 560 | the patch passed | | +1 | compile | 372 | the patch passed | | +1 | javac | 372 | the patch passed | | +1 | checkstyle | 76 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 722 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 167 | the patch passed | | +1 | findbugs | 648 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 357 | hadoop-hdds in the patch failed. | | -1 | unit | 2072 | hadoop-ozone in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 8341 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.om.TestSecureOzoneManager | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux c6debda2dd09 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 611718f | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/testReport/ | | Max. process+thread count | 5274 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/5/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 284596) Time Spent: 2h (was: 1h 50m) > Freon RandomKeyGenerator even if keySize is set to 0, it returns some random > data to key > > > Key: HDDS-1863 > URL: https://issues.apache.org/jira/browse/HDDS-1863 > Project: Hadoop
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284583=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284583
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 29/Jul/19 22:22
Start Date: 29/Jul/19 22:22
Worklog Time Spent: 10m
Work Description: arp7 commented on issue #1167: HDDS-1863. Freon
RandomKeyGenerator even if keySize is set to 0, it returns some random data to
key.
URL: https://github.com/apache/hadoop/pull/1167#issuecomment-516184911
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 284583)
Time Spent: 1h 50m (was: 1h 40m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284552 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 29/Jul/19 21:20 Start Date: 29/Jul/19 21:20 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-516167022 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 131 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 834 | trunk passed | | +1 | compile | 459 | trunk passed | | +1 | checkstyle | 93 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 1141 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 218 | trunk passed | | 0 | spotbugs | 517 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 766 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 722 | the patch passed | | +1 | compile | 394 | the patch passed | | +1 | javac | 394 | the patch passed | | -0 | checkstyle | 39 | hadoop-ozone: The patch generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 728 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 163 | the patch passed | | +1 | findbugs | 707 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 348 | hadoop-hdds in the patch failed. | | -1 | unit | 2085 | hadoop-ozone in the patch failed. | | +1 | asflicense | 44 | The patch does not generate ASF License warnings. | | | | 9091 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdds.scm.block.TestBlockManager | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.om.TestSecureOzoneManager | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.TestMiniOzoneCluster | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=18.09.7 Server=18.09.7 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 8972131a09a7 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4 22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 611718f | | Default Java | 1.8.0_212 | | checkstyle | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/diff-checkstyle-hadoop-ozone.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/testReport/ | | Max. process+thread count | 5261 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/4/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284484 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 29/Jul/19 19:08 Start Date: 29/Jul/19 19:08 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-516122734 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 100 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 1 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | +1 | test4tests | 0 | The patch appears to include 1 new or modified test files. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 675 | trunk passed | | +1 | compile | 364 | trunk passed | | +1 | checkstyle | 64 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 847 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 168 | trunk passed | | 0 | spotbugs | 423 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 612 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 548 | the patch passed | | +1 | compile | 379 | the patch passed | | +1 | javac | 379 | the patch passed | | +1 | checkstyle | 82 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 691 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 165 | the patch passed | | -1 | findbugs | 429 | hadoop-ozone generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) | ||| _ Other Tests _ | | -1 | unit | 349 | hadoop-hdds in the patch failed. | | -1 | unit | 2045 | hadoop-ozone in the patch failed. | | +1 | asflicense | 40 | The patch does not generate ASF License warnings. | | | | 7959 | | | Reason | Tests | |---:|:--| | FindBugs | module:hadoop-ozone | | | Dead store to randomValue in org.apache.hadoop.ozone.freon.RandomKeyGenerator.createKey(long) At RandomKeyGenerator.java:org.apache.hadoop.ozone.freon.RandomKeyGenerator.createKey(long) At RandomKeyGenerator.java:[line 683] | | Failed junit tests | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestory | | | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider | | | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux ead716919039 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 60325c9 | | Default Java | 1.8.0_212 | | findbugs | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/new-findbugs-hadoop-ozone.html | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/testReport/ | | Max. process+thread count | 4276 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/3/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284469=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284469
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 29/Jul/19 18:48
Start Date: 29/Jul/19 18:48
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308382286
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -697,12 +697,11 @@ private boolean createKey(long globalKeyNumber) {
try (Scope writeScope = GlobalTracer.get().buildSpan("writeKeyData")
.startActive(true)) {
long keyWriteStart = System.nanoTime();
- for (long nrRemaining = keySize - randomValue.length;
+ for (long nrRemaining = keySize;
nrRemaining > 0; nrRemaining -= bufferSize) {
int curSize = (int) Math.min(bufferSize, nrRemaining);
os.write(keyValueBuffer, 0, curSize);
}
- os.write(randomValue);
Review comment:
Fixed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 284469)
Time Spent: 1h 20m (was: 1h 10m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284460=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284460
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 29/Jul/19 18:32
Start Date: 29/Jul/19 18:32
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308375410
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -697,12 +697,11 @@ private boolean createKey(long globalKeyNumber) {
try (Scope writeScope = GlobalTracer.get().buildSpan("writeKeyData")
.startActive(true)) {
long keyWriteStart = System.nanoTime();
- for (long nrRemaining = keySize - randomValue.length;
+ for (long nrRemaining = keySize;
nrRemaining > 0; nrRemaining -= bufferSize) {
int curSize = (int) Math.min(bufferSize, nrRemaining);
os.write(keyValueBuffer, 0, curSize);
}
- os.write(randomValue);
Review comment:
Thanks for fixing it. Now `randomValue` is unused, could be removed
completely. (I think findbugs complains about that, too.)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 284460)
Time Spent: 1h 10m (was: 1h)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284417=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284417
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 29/Jul/19 16:54
Start Date: 29/Jul/19 16:54
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308332750
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -697,12 +697,11 @@ private boolean createKey(long globalKeyNumber) {
try (Scope writeScope = GlobalTracer.get().buildSpan("writeKeyData")
.startActive(true)) {
long keyWriteStart = System.nanoTime();
- for (long nrRemaining = keySize - randomValue.length;
+ for (long nrRemaining = keySize;
nrRemaining > 0; nrRemaining -= bufferSize) {
int curSize = (int) Math.min(bufferSize, nrRemaining);
os.write(keyValueBuffer, 0, curSize);
}
- os.write(randomValue);
Review comment:
Thanks for catching it. And there is also test failing for it. Now that will
be fixed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 284417)
Time Spent: 1h (was: 50m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=284415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-284415
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 29/Jul/19 16:53
Start Date: 29/Jul/19 16:53
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r308332750
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -697,12 +697,11 @@ private boolean createKey(long globalKeyNumber) {
try (Scope writeScope = GlobalTracer.get().buildSpan("writeKeyData")
.startActive(true)) {
long keyWriteStart = System.nanoTime();
- for (long nrRemaining = keySize - randomValue.length;
+ for (long nrRemaining = keySize;
nrRemaining > 0; nrRemaining -= bufferSize) {
int curSize = (int) Math.min(bufferSize, nrRemaining);
os.write(keyValueBuffer, 0, curSize);
}
- os.write(randomValue);
Review comment:
Fixed it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 284415)
Time Spent: 50m (was: 40m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=283329=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283329 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 26/Jul/19 13:03 Start Date: 26/Jul/19 13:03 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-515442529 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 67 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 606 | trunk passed | | +1 | compile | 369 | trunk passed | | +1 | checkstyle | 78 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 874 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 151 | trunk passed | | 0 | spotbugs | 417 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 610 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 544 | the patch passed | | +1 | compile | 358 | the patch passed | | +1 | javac | 358 | the patch passed | | +1 | checkstyle | 67 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 646 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 151 | the patch passed | | +1 | findbugs | 629 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 346 | hadoop-hdds in the patch failed. | | -1 | unit | 2351 | hadoop-ozone in the patch failed. | | +1 | asflicense | 36 | The patch does not generate ASF License warnings. | | | | 8028 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.client.rpc.TestHybridPipelineOnDatanode | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | | hadoop.hdds.scm.pipeline.TestRatisPipelineProvider | | | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux 71d21296cc80 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / aebac6d | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/testReport/ | | Max. process+thread count | 3957 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/2/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 283329) Time Spent: 40m (was: 0.5h) > Freon RandomKeyGenerator even if keySize is set to 0, it returns some random > data to key >
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=283292=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283292
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 26/Jul/19 11:31
Start Date: 26/Jul/19 11:31
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1167: HDDS-1863.
Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
data to key.
URL: https://github.com/apache/hadoop/pull/1167#discussion_r307702723
##
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/RandomKeyGenerator.java
##
@@ -697,12 +697,11 @@ private boolean createKey(long globalKeyNumber) {
try (Scope writeScope = GlobalTracer.get().buildSpan("writeKeyData")
.startActive(true)) {
long keyWriteStart = System.nanoTime();
- for (long nrRemaining = keySize - randomValue.length;
+ for (long nrRemaining = keySize;
nrRemaining > 0; nrRemaining -= bufferSize) {
int curSize = (int) Math.min(bufferSize, nrRemaining);
os.write(keyValueBuffer, 0, curSize);
}
- os.write(randomValue);
Review comment:
I think key write validation should be adjusted, too.
`keyValueBuffer` is common for all keys, while `randomValue` is unique per
key. The latter is used below in key write validatation (if requested). So
validation fails as is, since it still uses `randomValue`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 283292)
Time Spent: 0.5h (was: 20m)
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[ https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=283065=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283065 ] ASF GitHub Bot logged work on HDDS-1863: Author: ASF GitHub Bot Created on: 26/Jul/19 03:19 Start Date: 26/Jul/19 03:19 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on issue #1167: HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key. URL: https://github.com/apache/hadoop/pull/1167#issuecomment-515293051 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | 0 | reexec | 50 | Docker mode activated. | ||| _ Prechecks _ | | +1 | dupname | 0 | No case conflicting files found. | | +1 | @author | 0 | The patch does not contain any @author tags. | | -1 | test4tests | 0 | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ trunk Compile Tests _ | | +1 | mvninstall | 615 | trunk passed | | +1 | compile | 349 | trunk passed | | +1 | checkstyle | 62 | trunk passed | | +1 | mvnsite | 0 | trunk passed | | +1 | shadedclient | 790 | branch has no errors when building and testing our client artifacts. | | +1 | javadoc | 144 | trunk passed | | 0 | spotbugs | 412 | Used deprecated FindBugs config; considering switching to SpotBugs. | | +1 | findbugs | 598 | trunk passed | ||| _ Patch Compile Tests _ | | +1 | mvninstall | 525 | the patch passed | | +1 | compile | 342 | the patch passed | | +1 | javac | 342 | the patch passed | | +1 | checkstyle | 63 | the patch passed | | +1 | mvnsite | 0 | the patch passed | | +1 | whitespace | 0 | The patch has no whitespace issues. | | +1 | shadedclient | 619 | patch has no errors when building and testing our client artifacts. | | +1 | javadoc | 141 | the patch passed | | +1 | findbugs | 619 | the patch passed | ||| _ Other Tests _ | | -1 | unit | 293 | hadoop-hdds in the patch failed. | | -1 | unit | 1822 | hadoop-ozone in the patch failed. | | +1 | asflicense | 36 | The patch does not generate ASF License warnings. | | | | 7233 | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.ozone.TestStorageContainerManager | | | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures | | | hadoop.ozone.om.TestScmSafeMode | | | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClient | | | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis | | | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/1167 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle | | uname | Linux a3d800fa42c7 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | personality/hadoop.sh | | git revision | trunk / 6b8107a | | Default Java | 1.8.0_212 | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/artifact/out/patch-unit-hadoop-hdds.txt | | unit | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/artifact/out/patch-unit-hadoop-ozone.txt | | Test Results | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/testReport/ | | Max. process+thread count | 4662 (vs. ulimit of 5500) | | modules | C: hadoop-ozone/tools U: hadoop-ozone/tools | | Console output | https://builds.apache.org/job/hadoop-multibranch/job/PR-1167/1/console | | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 | | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 283065) Time Spent: 20m (was: 10m) > Freon RandomKeyGenerator even if keySize is set to 0, it returns some random > data to key > > > Key: HDDS-1863 >
[jira] [Work logged] (HDDS-1863) Freon RandomKeyGenerator even if keySize is set to 0, it returns some random data to key
[
https://issues.apache.org/jira/browse/HDDS-1863?focusedWorklogId=283038=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283038
]
ASF GitHub Bot logged work on HDDS-1863:
Author: ASF GitHub Bot
Created on: 26/Jul/19 01:13
Start Date: 26/Jul/19 01:13
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1167:
HDDS-1863. Freon RandomKeyGenerator even if keySize is set to 0, it returns
some random data to key.
URL: https://github.com/apache/hadoop/pull/1167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 283038)
Time Spent: 10m
Remaining Estimate: 0h
> Freon RandomKeyGenerator even if keySize is set to 0, it returns some random
> data to key
>
>
> Key: HDDS-1863
> URL: https://issues.apache.org/jira/browse/HDDS-1863
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
>Reporter: Bharat Viswanadham
>Assignee: Bharat Viswanadham
>Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
>
> {code:java}
> ***
> Status: Success
> Git Base Revision: e97acb3bd8f3befd27418996fa5d4b50bf2e17bf
> Number of Volumes created: 1
> Number of Buckets created: 1
> Number of Keys added: 1
> Ratis replication factor: THREE
> Ratis replication type: STAND_ALONE
> Average Time spent in volume creation: 00:00:00,002
> Average Time spent in bucket creation: 00:00:00,000
> Average Time spent in key creation: 00:00:00,002
> Average Time spent in key write: 00:00:00,101
> Total bytes written: 0
> Total Execution time: 00:00:05,699
>
> {code}
> ***
> [root@ozoneha-2 ozone-0.5.0-SNAPSHOT]# bin/ozone sh key list
> /vol-0-28271/bucket-0-95211
> [
> { "version" : 0, "md5hash" : null, "createdOn" : "Fri, 26 Jul 2019
> 01:02:08 GMT", "modifiedOn" : "Fri, 26 Jul 2019 01:02:09 GMT", "size" :
> 36, "keyName" : "key-0-98235", "type" : null }
> ]
>
> This is because of the below code in RandomKeyGenerator:
> {code:java}
> for (long nrRemaining = keySize - randomValue.length;
> nrRemaining > 0; nrRemaining -= bufferSize) {
> int curSize = (int) Math.min(bufferSize, nrRemaining);
> os.write(keyValueBuffer, 0, curSize);
> }
> os.write(randomValue);
> os.close();{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
