[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611185&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611185
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 08:20
Start Date: 15/Jun/21 08:20
Worklog Time Spent: 10m
Work Description: tasanuma commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861292413
Thanks for your reviews and commits, @hemanthboyina and @tomscut. I will
cherry-pick to lower branches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611185)
Time Spent: 1h 20m (was: 1h 10m)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611179&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611179
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 07:53
Start Date: 15/Jun/21 07:53
Worklog Time Spent: 10m
Work Description: hemanthboyina commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861272730
Committed to trunk , thanks for contribution @tasanuma , thanks for the
review @tomscut
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611179)
Time Spent: 1h 10m (was: 1h)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611177&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611177
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 07:50
Start Date: 15/Jun/21 07:50
Worklog Time Spent: 10m
Work Description: hemanthboyina merged pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611177)
Time Spent: 1h (was: 50m)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611146&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611146
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 05:50
Start Date: 15/Jun/21 05:50
Worklog Time Spent: 10m
Work Description: hemanthboyina commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861191955
+1 will commit shortly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611146)
Time Spent: 50m (was: 40m)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=64&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-64
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 02:51
Start Date: 15/Jun/21 02:51
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861129182
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 13s | | trunk passed |
| +1 :green_heart: | compile | 1m 1s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 0m 55s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 0m 31s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 59s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 43s | | trunk passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 40s | | trunk passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 27s | | trunk passed |
| +1 :green_heart: | shadedclient | 15m 41s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 46s | | the patch passed |
| +1 :green_heart: | compile | 0m 52s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 0m 52s | | the patch passed |
| +1 :green_heart: | compile | 0m 47s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 0m 47s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 18s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 49s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 33s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 0m 29s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 2m 30s | | the patch passed |
| +1 :green_heart: | shadedclient | 15m 10s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 16s | | hadoop-hdfs-client in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 32s | | The patch does not
generate ASF License warnings. |
| | | 79m 0s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3104/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/3104 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 5e1a36ddd1ed 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 9765967b2691b64fc25736bf46371a4c3769694e |
| Default Java | Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Multi-JDK versions |
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04
/usr/lib/jvm/java-8-openjdk-amd64:Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3104/1/testReport/ |
| Max. process+thread count | 743 (vs. ulimit of 5500) |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client U:
hadoop-hdfs-project/hadoop-hdfs-client |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3104/1/console |
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611096
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 01:50
Start Date: 15/Jun/21 01:50
Worklog Time Spent: 10m
Work Description: tomscut commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861108603
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611096)
Time Spent: 0.5h (was: 20m)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611092
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 01:31
Start Date: 15/Jun/21 01:31
Worklog Time Spent: 10m
Work Description: tasanuma opened a new pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104
JIRA: HDFS-16068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611092)
Remaining Estimate: 0h
Time Spent: 10m
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16068) WebHdfsFileSystem has a possible connection leak in connection with HttpFS
[
https://issues.apache.org/jira/browse/HDFS-16068?focusedWorklogId=611093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611093
]
ASF GitHub Bot logged work on HDFS-16068:
-
Author: ASF GitHub Bot
Created on: 15/Jun/21 01:31
Start Date: 15/Jun/21 01:31
Worklog Time Spent: 10m
Work Description: tasanuma commented on pull request #3104:
URL: https://github.com/apache/hadoop/pull/3104#issuecomment-861103245
Writing the unit test is not easy because `cachedConnection` is private. But
the fix is clear and safe. So I don't think the unit test is required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 611093)
Time Spent: 20m (was: 10m)
> WebHdfsFileSystem has a possible connection leak in connection with HttpFS
> --
>
> Key: HDFS-16068
> URL: https://issues.apache.org/jira/browse/HDFS-16068
> Project: Hadoop HDFS
> Issue Type: Bug
>Reporter: Takanobu Asanuma
>Assignee: Takanobu Asanuma
>Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When we use WebHdfsFileSystem for HttpFS, some connections remain for a while
> after the filesystems are closed until GC runs. After investigating it for a
> while, I found that there is a potential connection leak in WebHdfsFileSystem.
> {code:java}
> // Close both the InputStream and the connection.
> @VisibleForTesting
> void closeInputStream(RunnerState rs) throws IOException {
> if (in != null) {
> IOUtils.close(cachedConnection);
> in = null;
> }
> cachedConnection = null;
> runnerState = rs;
> }
> {code}
> In the above code, if the variable of {{in}} is null and {{cachedConnection}}
> is not null, {{cachedConnection}} doesn't close and the connection remains. I
> think this is the cause of our problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
