[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[
https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=796227=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-796227
]
ASF GitHub Bot logged work on HDFS-16208:
-
Author: ASF GitHub Bot
Created on: 29/Jul/22 03:20
Start Date: 29/Jul/22 03:20
Worklog Time Spent: 10m
Work Description: jianghuazhu commented on PR #3376:
URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1198838825
Thanks @prasad-acit .
I have read your update carefully, here are some of my personal insights:
1. We should hold child locks in FSDirDeleteOp, here are some of my
suggestions.
`FSDirDeleteOp#deleteInternal() {
''
fsd.getINodeMap().latchWriteLock(iip.getExistingINodes(), new INode[]{});
fsn.removeLeasesAndINodes(removedUCFiles, removedINodes, true);
''
}
`
At this stage, the deleteInternal() operation may be safer, and when FGL
becomes more mature, it can be processed more fine-grained.
2. Adding hasWriteLock() to PartitionedGSet may still fail to accurately
capture each Partition and lock. Because the elements saved in PartitionedGSet
will be repeated and distributed in different Partitions.
3. It seems unnecessary to add hasWriteLock() and latchWriteLock() to
INodeMap because latchWriteLock(INodesInPath iip, INode[] missing) already
exists.
Also, regarding the child lock issue you mentioned, I think it's a matter of
concern. I'll submit some PRs later.
Welcome to the discussion, @prasad-acit .
Issue Time Tracking
---
Worklog Id: (was: 796227)
Time Spent: 1.5h (was: 1h 20m)
> [FGL] Implement Delete API with FGL
> ---
>
> Key: HDFS-16208
> URL: https://issues.apache.org/jira/browse/HDFS-16208
> Project: Hadoop HDFS
> Issue Type: Sub-task
>Reporter: Renukaprasad C
>Assignee: Renukaprasad C
>Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Replace all global locks for file / directory deletion with FGL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[
https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=789328=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789328
]
ASF GitHub Bot logged work on HDFS-16208:
-
Author: ASF GitHub Bot
Created on: 10/Jul/22 17:56
Start Date: 10/Jul/22 17:56
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #3376:
URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1179771907
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 12m 59s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ fgl Compile Tests _ |
| +0 :ok: | mvndep | 14m 32s | | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 21m 13s |
[/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/branch-mvninstall-root.txt)
| root in fgl failed. |
| -1 :x: | compile | 13m 36s |
[/branch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/branch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root in fgl failed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. |
| -1 :x: | compile | 11m 55s |
[/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root in fgl failed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07. |
| +1 :green_heart: | checkstyle | 3m 53s | | fgl passed |
| +1 :green_heart: | mvnsite | 3m 22s | | fgl passed |
| +1 :green_heart: | javadoc | 2m 32s | | fgl passed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 3m 30s | | fgl passed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 2m 47s |
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
| hadoop-common-project/hadoop-common in fgl has 2 extant spotbugs warnings.
|
| +1 :green_heart: | shadedclient | 17m 0s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 30s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 25s | | the patch passed |
| -1 :x: | compile | 13m 17s |
[/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root in the patch failed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. |
| -1 :x: | javac | 13m 17s |
[/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root in the patch failed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. |
| -1 :x: | compile | 11m 45s |
[/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root in the patch failed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07. |
| -1 :x: | javac | 11m 45s |
[/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/3/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root in the patch failed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 43s | | the patch
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[ https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=789315=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-789315 ] ASF GitHub Bot logged work on HDFS-16208: - Author: ASF GitHub Bot Created on: 10/Jul/22 09:58 Start Date: 10/Jul/22 09:58 Worklog Time Spent: 10m Work Description: prasad-acit commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1179696038 Thanks @jianghuazhu to bringup the issue. Same has been addressed and pushed the changes. @shvachko @jianghuazhu Plz help to review the patch? @shvachko There are some changes cause the compatibility issues, can we rebase the code? Otherwise, need to cherry-pick the related changes to compile the code. Issue Time Tracking --- Worklog Id: (was: 789315) Time Spent: 1h 10m (was: 1h) > [FGL] Implement Delete API with FGL > --- > > Key: HDFS-16208 > URL: https://issues.apache.org/jira/browse/HDFS-16208 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Renukaprasad C >Assignee: Renukaprasad C >Priority: Major > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > Replace all global locks for file / directory deletion with FGL. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[
https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=788800=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-788800
]
ASF GitHub Bot logged work on HDFS-16208:
-
Author: ASF GitHub Bot
Created on: 08/Jul/22 00:08
Start Date: 08/Jul/22 00:08
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on PR #3376:
URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1178389941
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 19m 40s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ fgl Compile Tests _ |
| +0 :ok: | mvndep | 14m 21s | | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 23m 57s |
[/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/branch-mvninstall-root.txt)
| root in fgl failed. |
| -1 :x: | compile | 14m 43s |
[/branch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/branch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root in fgl failed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. |
| -1 :x: | compile | 12m 24s |
[/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/branch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root in fgl failed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07. |
| +1 :green_heart: | checkstyle | 4m 14s | | fgl passed |
| +1 :green_heart: | mvnsite | 3m 9s | | fgl passed |
| +1 :green_heart: | javadoc | 2m 18s | | fgl passed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 |
| +1 :green_heart: | javadoc | 3m 12s | | fgl passed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| -1 :x: | spotbugs | 2m 50s |
[/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/branch-spotbugs-hadoop-common-project_hadoop-common-warnings.html)
| hadoop-common-project/hadoop-common in fgl has 2 extant spotbugs warnings.
|
| +1 :green_heart: | shadedclient | 19m 17s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 23s | | the patch passed |
| -1 :x: | compile | 14m 43s |
[/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root in the patch failed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. |
| -1 :x: | javac | 14m 43s |
[/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/patch-compile-root-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt)
| root in the patch failed with JDK Private
Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. |
| -1 :x: | compile | 12m 25s |
[/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root in the patch failed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07. |
| -1 :x: | javac | 12m 25s |
[/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/2/artifact/out/patch-compile-root-jdkPrivateBuild-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07.txt)
| root in the patch failed with JDK Private
Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07. |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 3m 57s |
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[ https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=784683=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784683 ] ASF GitHub Bot logged work on HDFS-16208: - Author: ASF GitHub Bot Created on: 24/Jun/22 18:31 Start Date: 24/Jun/22 18:31 Worklog Time Spent: 10m Work Description: prasad-acit commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1165831454 > For delete using FGL, it may be safer to add child locks before fsn.removeLeasesAndINodes(). Thanks @jianghuazhu to bring up this issue. This is very imp task we had missed it. Recently, similar issue got reported in our version & we have fixed it in better way along with children lock. I will update the patch soon. Thanks once again for review & feedback. Issue Time Tracking --- Worklog Id: (was: 784683) Time Spent: 50m (was: 40m) > [FGL] Implement Delete API with FGL > --- > > Key: HDFS-16208 > URL: https://issues.apache.org/jira/browse/HDFS-16208 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Renukaprasad C >Assignee: Renukaprasad C >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > Replace all global locks for file / directory deletion with FGL. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[ https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=777369=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-777369 ] ASF GitHub Bot logged work on HDFS-16208: - Author: ASF GitHub Bot Created on: 02/Jun/22 09:35 Start Date: 02/Jun/22 09:35 Worklog Time Spent: 10m Work Description: jianghuazhu commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1144654653 Hi @prasad-acit , nice to talk to you. For delete using FGL, it may be safer to add child locks before fsn.removeLeasesAndINodes().  The reason here is that after finishing running unprotectedDelete(), there are still updated content, such as block-related updates, and snapshotManager deletes Snapshottable. Before this, this was done while holding the FSNamesystemLock. Based on the premise of safety, I make my proposal. If my suggestion is wrong, please ignore it. Issue Time Tracking --- Worklog Id: (was: 777369) Time Spent: 40m (was: 0.5h) > [FGL] Implement Delete API with FGL > --- > > Key: HDFS-16208 > URL: https://issues.apache.org/jira/browse/HDFS-16208 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Renukaprasad C >Assignee: Renukaprasad C >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > Replace all global locks for file / directory deletion with FGL. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[ https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=765534=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-765534 ] ASF GitHub Bot logged work on HDFS-16208: - Author: ASF GitHub Bot Created on: 03/May/22 16:50 Start Date: 03/May/22 16:50 Worklog Time Spent: 10m Work Description: prasad-acit commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1116324730 @shvachko @xinglin Can you please review the PR? We had similar implementation in our version and verified it. Issue Time Tracking --- Worklog Id: (was: 765534) Time Spent: 0.5h (was: 20m) > [FGL] Implement Delete API with FGL > --- > > Key: HDFS-16208 > URL: https://issues.apache.org/jira/browse/HDFS-16208 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Renukaprasad C >Assignee: Renukaprasad C >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > Replace all global locks for file / directory deletion with FGL. -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[
https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=646179=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646179
]
ASF GitHub Bot logged work on HDFS-16208:
-
Author: ASF GitHub Bot
Created on: 03/Sep/21 05:18
Start Date: 03/Sep/21 05:18
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #3376:
URL: https://github.com/apache/hadoop/pull/3376#issuecomment-912262581
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
_ fgl Compile Tests _ |
| +1 :green_heart: | mvninstall | 37m 48s | | fgl passed |
| +1 :green_heart: | compile | 1m 48s | | fgl passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | compile | 1m 34s | | fgl passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | checkstyle | 1m 15s | | fgl passed |
| +1 :green_heart: | mvnsite | 1m 48s | | fgl passed |
| +1 :green_heart: | javadoc | 1m 7s | | fgl passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 57s | | fgl passed with JDK Private
Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 4m 25s | | fgl passed |
| +1 :green_heart: | shadedclient | 22m 51s | | branch has no errors
when building and testing our client artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 36s | | the patch passed |
| +1 :green_heart: | compile | 1m 42s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javac | 1m 42s | | the patch passed |
| +1 :green_heart: | compile | 1m 38s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | javac | 1m 38s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 1m 8s |
[/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 123 unchanged
- 0 fixed = 125 total (was 123) |
| +1 :green_heart: | mvnsite | 1m 46s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | | the patch passed with JDK
Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 |
| +1 :green_heart: | javadoc | 1m 40s | | the patch passed with JDK
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 |
| +1 :green_heart: | spotbugs | 4m 28s | | the patch passed |
| +1 :green_heart: | shadedclient | 22m 6s | | patch has no errors
when building and testing our client artifacts. |
_ Other Tests _ |
| -1 :x: | unit | 307m 51s |
[/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3376/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt)
| hadoop-hdfs in the patch passed. |
| +1 :green_heart: | asflicense | 0m 52s | | The patch does not
generate ASF License warnings. |
| | | 417m 34s | | |
| Reason | Tests |
|---:|:--|
| Failed junit tests |
hadoop.hdfs.server.namenode.snapshot.TestCheckpointsWithSnapshots |
| |
hadoop.hdfs.server.namenode.snapshot.TestFSImageWithOrderedSnapshotDeletion |
| | hadoop.hdfs.server.namenode.ha.TestPipelinesFailover |
| | hadoop.hdfs.TestStateAlignmentContextWithHA |
| | hadoop.hdfs.server.namenode.snapshot.TestRandomOpsWithSnapshots |
| | hadoop.hdfs.TestFileChecksum |
| | hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints |
| | hadoop.hdfs.server.namenode.TestEditLogRace |
| | hadoop.hdfs.server.namenode.TestFSNamesystemLock |
| | hadoop.hdfs.TestRollingUpgrade |
| | hadoop.hdfs.server.namenode.TestNameNodeRecovery |
| | hadoop.hdfs.server.namenode.TestStartup |
| | hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer |
| |
[jira] [Work logged] (HDFS-16208) [FGL] Implement Delete API with FGL
[ https://issues.apache.org/jira/browse/HDFS-16208?focusedWorklogId=646078=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646078 ] ASF GitHub Bot logged work on HDFS-16208: - Author: ASF GitHub Bot Created on: 02/Sep/21 22:19 Start Date: 02/Sep/21 22:19 Worklog Time Spent: 10m Work Description: prasad-acit opened a new pull request #3376: URL: https://github.com/apache/hadoop/pull/3376 Delete File / Directory should use FGL instead of global write lock. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 646078) Remaining Estimate: 0h Time Spent: 10m > [FGL] Implement Delete API with FGL > --- > > Key: HDFS-16208 > URL: https://issues.apache.org/jira/browse/HDFS-16208 > Project: Hadoop HDFS > Issue Type: Sub-task >Reporter: Renukaprasad C >Assignee: Renukaprasad C >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Replace all global locks for file / directory deletion with FGL. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
