[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=780514=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780514 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 11/Jun/22 14:35 Start Date: 11/Jun/22 14:35 Worklog Time Spent: 10m Work Description: ZanderXu commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1152939271 @cnauroth @jojochuang Thanks for helping to review this code! Issue Time Tracking --- Worklog Id: (was: 780514) Time Spent: 1h 20m (was: 1h 10m) > IllegalArgumentException in LifelineSender > -- > > Key: HDFS-16623 > URL: https://issues.apache.org/jira/browse/HDFS-16623 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ZanderXu >Assignee: ZanderXu >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0, 3.2.4, 3.3.4 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > In our production environment, an IllegalArgumentException occurred in the > LifelineSender at one DataNode which was undergoing GC at that time. > And the bug code is at line 1060 in BPServiceActor.java, because the sleep > time is negative. > {code:java} > while (shouldRun()) { > try { > if (lifelineNamenode == null) { > lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr); > } > sendLifelineIfDue(); > Thread.sleep(scheduler.getLifelineWaitTime()); > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } catch (IOException e) { > LOG.warn("IOException in LifelineSender for " + BPServiceActor.this, > e); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=780412=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780412 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 10/Jun/22 19:01 Start Date: 10/Jun/22 19:01 Worklog Time Spent: 10m Work Description: cnauroth merged PR #4409: URL: https://github.com/apache/hadoop/pull/4409 Issue Time Tracking --- Worklog Id: (was: 780412) Time Spent: 1h 10m (was: 1h) > IllegalArgumentException in LifelineSender > -- > > Key: HDFS-16623 > URL: https://issues.apache.org/jira/browse/HDFS-16623 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ZanderXu >Assignee: ZanderXu >Priority: Major > Labels: pull-request-available > Fix For: 3.4.0, 3.2.4, 3.3.4 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In our production environment, an IllegalArgumentException occurred in the > LifelineSender at one DataNode which was undergoing GC at that time. > And the bug code is at line 1060 in BPServiceActor.java, because the sleep > time is negative. > {code:java} > while (shouldRun()) { > try { > if (lifelineNamenode == null) { > lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr); > } > sendLifelineIfDue(); > Thread.sleep(scheduler.getLifelineWaitTime()); > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } catch (IOException e) { > LOG.warn("IOException in LifelineSender for " + BPServiceActor.this, > e); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=779798=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779798 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 09/Jun/22 07:48 Start Date: 09/Jun/22 07:48 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1150788913 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec | 0m 38s | | Docker mode activated. | _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 0s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 37m 35s | | trunk passed | | +1 :green_heart: | compile | 1m 43s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 1m 34s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 1m 24s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 47s | | trunk passed | | +1 :green_heart: | javadoc | 1m 24s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 1m 45s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 40s | | trunk passed | | +1 :green_heart: | shadedclient | 22m 57s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 22s | | the patch passed | | +1 :green_heart: | compile | 1m 26s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javac | 1m 26s | | the patch passed | | +1 :green_heart: | compile | 1m 20s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 1m 20s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 1m 1s | | the patch passed | | +1 :green_heart: | mvnsite | 1m 25s | | the patch passed | | +1 :green_heart: | javadoc | 0m 58s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 1m 30s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 19s | | the patch passed | | +1 :green_heart: | shadedclient | 22m 30s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | +1 :green_heart: | unit | 254m 46s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 23s | | The patch does not generate ASF License warnings. | | | | 363m 58s | | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4409/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4409 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux 36b5aa7a5a87 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / eb2f7cfc0f4092e782aaacf13b0cd2fc5de5bccd | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4409/2/testReport/ | | Max. process+thread count | 3100 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4409/2/console | | versions |
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=779743=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779743 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 09/Jun/22 01:44 Start Date: 09/Jun/22 01:44 Worklog Time Spent: 10m Work Description: ZanderXu commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1150581728 Thanks @cnauroth , please help me review the patch again. Issue Time Tracking --- Worklog Id: (was: 779743) Time Spent: 50m (was: 40m) > IllegalArgumentException in LifelineSender > -- > > Key: HDFS-16623 > URL: https://issues.apache.org/jira/browse/HDFS-16623 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ZanderXu >Assignee: ZanderXu >Priority: Major > Labels: pull-request-available > Time Spent: 50m > Remaining Estimate: 0h > > In our production environment, an IllegalArgumentException occurred in the > LifelineSender at one DataNode which was undergoing GC at that time. > And the bug code is at line 1060 in BPServiceActor.java, because the sleep > time is negative. > {code:java} > while (shouldRun()) { > try { > if (lifelineNamenode == null) { > lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr); > } > sendLifelineIfDue(); > Thread.sleep(scheduler.getLifelineWaitTime()); > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } catch (IOException e) { > LOG.warn("IOException in LifelineSender for " + BPServiceActor.this, > e); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=779260=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779260 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 07/Jun/22 20:58 Start Date: 07/Jun/22 20:58 Worklog Time Spent: 10m Work Description: cnauroth commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1149161121 @ZanderXu , yes, I was thinking of just testing that `getLifelineWaitTime()` only returns non-negative numbers. There is a similar kind of test in `TestBpServiceActorScheduler#testScheduleLifeline`, but it doesn't yet cover the case that would lead to a negative value. I think testing for LifelineSender thread exit would be more complete, but also a lot more complex. Testing directly against the `getLifelineWaitTime()` return values is a good compromise. Thanks! Issue Time Tracking --- Worklog Id: (was: 779260) Time Spent: 40m (was: 0.5h) > IllegalArgumentException in LifelineSender > -- > > Key: HDFS-16623 > URL: https://issues.apache.org/jira/browse/HDFS-16623 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ZanderXu >Assignee: ZanderXu >Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > In our production environment, an IllegalArgumentException occurred in the > LifelineSender at one DataNode which was undergoing GC at that time. > And the bug code is at line 1060 in BPServiceActor.java, because the sleep > time is negative. > {code:java} > while (shouldRun()) { > try { > if (lifelineNamenode == null) { > lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr); > } > sendLifelineIfDue(); > Thread.sleep(scheduler.getLifelineWaitTime()); > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } catch (IOException e) { > LOG.warn("IOException in LifelineSender for " + BPServiceActor.this, > e); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=779075=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779075 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 07/Jun/22 12:55 Start Date: 07/Jun/22 12:55 Worklog Time Spent: 10m Work Description: ZanderXu commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1148630372 Thanks @cnauroth for your comment. Do you mean to add a UT to test that `getLifelineWaitTime()` can only return non-negative numbers? I think if we need a UT, we should test the LifelineSender thread exit, but it is difficult to judge whether the thread exits or not. Do you have some good ideas? Thanks Issue Time Tracking --- Worklog Id: (was: 779075) Time Spent: 0.5h (was: 20m) > IllegalArgumentException in LifelineSender > -- > > Key: HDFS-16623 > URL: https://issues.apache.org/jira/browse/HDFS-16623 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ZanderXu >Assignee: ZanderXu >Priority: Major > Labels: pull-request-available > Time Spent: 0.5h > Remaining Estimate: 0h > > In our production environment, an IllegalArgumentException occurred in the > LifelineSender at one DataNode which was undergoing GC at that time. > And the bug code is at line 1060 in BPServiceActor.java, because the sleep > time is negative. > {code:java} > while (shouldRun()) { > try { > if (lifelineNamenode == null) { > lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr); > } > sendLifelineIfDue(); > Thread.sleep(scheduler.getLifelineWaitTime()); > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } catch (IOException e) { > LOG.warn("IOException in LifelineSender for " + BPServiceActor.this, > e); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=778725=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778725 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 06/Jun/22 18:42 Start Date: 06/Jun/22 18:42 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4409: URL: https://github.com/apache/hadoop/pull/4409#issuecomment-1147767240 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec | 0m 40s | | Docker mode activated. | _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 36m 52s | | trunk passed | | +1 :green_heart: | compile | 1m 43s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 1m 38s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 1m 26s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 44s | | trunk passed | | +1 :green_heart: | javadoc | 1m 24s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 1m 47s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 41s | | trunk passed | | +1 :green_heart: | shadedclient | 23m 4s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 21s | | the patch passed | | +1 :green_heart: | compile | 1m 27s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javac | 1m 27s | | the patch passed | | +1 :green_heart: | compile | 1m 19s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 1m 19s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 1m 4s | | the patch passed | | +1 :green_heart: | mvnsite | 1m 24s | | the patch passed | | +1 :green_heart: | javadoc | 0m 59s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 1m 29s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 24s | | the patch passed | | +1 :green_heart: | shadedclient | 23m 57s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | +1 :green_heart: | unit | 246m 1s | | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 13s | | The patch does not generate ASF License warnings. | | | | 356m 0s | | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4409/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4409 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux 81481f6ff660 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / b21f7354ea3697413259bfae677b81f41e68b1c3 | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4409/1/testReport/ | | Max. process+thread count | 3917 (vs. ulimit of 5500) | | modules | C: hadoop-hdfs-project/hadoop-hdfs U:
[jira] [Work logged] (HDFS-16623) IllegalArgumentException in LifelineSender
[ https://issues.apache.org/jira/browse/HDFS-16623?focusedWorklogId=778600=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778600 ] ASF GitHub Bot logged work on HDFS-16623: - Author: ASF GitHub Bot Created on: 06/Jun/22 12:45 Start Date: 06/Jun/22 12:45 Worklog Time Spent: 10m Work Description: ZanderXu opened a new pull request, #4409: URL: https://github.com/apache/hadoop/pull/4409 Jira: [HDFS-16623](https://issues.apache.org/jira/browse/HDFS-16623), fix bug to avoid IllegalArgumentException in LifelineSender. In our production environment, an IllegalArgumentException occurred in the LifelineSender at one DataNode which was undergoing GC at that time. Issue Time Tracking --- Worklog Id: (was: 778600) Remaining Estimate: 0h Time Spent: 10m > IllegalArgumentException in LifelineSender > -- > > Key: HDFS-16623 > URL: https://issues.apache.org/jira/browse/HDFS-16623 > Project: Hadoop HDFS > Issue Type: Bug >Reporter: ZanderXu >Assignee: ZanderXu >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > In our production environment, an IllegalArgumentException occurred in the > LifelineSender at one DataNode which was undergoing GC at that time. > And the bug code is at line 1060 in BPServiceActor.java, because the sleep > time is negative. > {code:java} > while (shouldRun()) { > try { > if (lifelineNamenode == null) { > lifelineNamenode = dn.connectToLifelineNN(lifelineNnAddr); > } > sendLifelineIfDue(); > Thread.sleep(scheduler.getLifelineWaitTime()); > } catch (InterruptedException e) { > Thread.currentThread().interrupt(); > } catch (IOException e) { > LOG.warn("IOException in LifelineSender for " + BPServiceActor.this, > e); > } > } > {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org