[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=779145&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779145 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 07/Jun/22 15:11 Start Date: 07/Jun/22 15:11 Worklog Time Spent: 10m Work Description: snmvaughan opened a new pull request, #4414: URL: https://github.com/apache/hadoop/pull/4414 ### Description of PR There are unit tests that require native PMDK libraries which aren't checking if the library is available, resulting in unsuccessful test. This patch checks the assumption about PMDK availability. The same changes have been applied and tested against trunk (3.4.0-SNAPSHOT), branch-3.3 (3.3.4-SNAPSHOT), and branch-3.3.3. ### How was this patch tested? This patch has been applied to a local build that runs in the Hadoop development environment, which doesn't include the PMDK shared libraries. ### For code changes: - [X] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? Issue Time Tracking --- Worklog Id: (was: 779145) Remaining Estimate: 0h Time Spent: 10m > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Time Spent: 10m > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=779284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779284 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 08/Jun/22 00:15 Start Date: 08/Jun/22 00:15 Worklog Time Spent: 10m Work Description: ashutoshcipher commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1149301940 LGTM Issue Time Tracking --- Worklog Id: (was: 779284) Time Spent: 20m (was: 10m) > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Labels: pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=779693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779693 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 08/Jun/22 22:51 Start Date: 08/Jun/22 22:51 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1150490913 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec | 0m 45s | | Docker mode activated. | _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 38m 46s | | trunk passed | | +1 :green_heart: | compile | 1m 27s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 1m 21s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 1m 6s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 31s | | trunk passed | | +1 :green_heart: | javadoc | 1m 6s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 1m 28s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 53s | | trunk passed | | +1 :green_heart: | shadedclient | 23m 25s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 18s | | the patch passed | | +1 :green_heart: | compile | 1m 21s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javac | 1m 21s | | the patch passed | | +1 :green_heart: | compile | 1m 9s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 1m 9s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | -0 :warning: | checkstyle | 0m 53s | [/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/1/artifact/out/results-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) | | +1 :green_heart: | mvnsite | 1m 22s | | the patch passed | | +1 :green_heart: | javadoc | 0m 53s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javadoc | 1m 32s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 28s | | the patch passed | | +1 :green_heart: | shadedclient | 23m 2s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | -1 :x: | unit | 255m 42s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 0m 52s | | The patch does not generate ASF License warnings. | | | | 363m 10s | | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.TestRollingUpgrade | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4414 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets | | uname | Linux 9ecd4ea00f04 4.15.0-169-generic #177-Ubuntu SMP Thu Feb 3 10:50:38 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/bin/hadoop.sh | | git revision | trunk / 63c6681369fec3c1ad4541d01f04e0753ba1db45 | | Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | Multi-JD
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=779698&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-779698 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 08/Jun/22 23:08 Start Date: 08/Jun/22 23:08 Worklog Time Spent: 10m Work Description: saintstack commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1150502169 The test failure looks unrelated. I see that this test failed in a nightly from a few days ago too https://ci-hadoop.apache.org/job/hadoop-qbt-trunk-java8-linux-x86_64/878/#showFailuresLink. This PR is a change to tests only and the changed tests are not the test that failed. Let me merge. Issue Time Tracking --- Worklog Id: (was: 779698) Time Spent: 40m (was: 0.5h) > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=780453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780453 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 10/Jun/22 23:27 Start Date: 10/Jun/22 23:27 Worklog Time Spent: 10m Work Description: hadoop-yetus commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1152799203 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexec | 0m 40s | | Docker mode activated. | _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. | | +0 :ok: | codespell | 0m 1s | | codespell was not available. | | +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available. | | +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 2 new or modified test files. | _ trunk Compile Tests _ | | +1 :green_heart: | mvninstall | 66m 49s | | trunk passed | | +1 :green_heart: | compile | 1m 44s | | trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | compile | 1m 35s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | checkstyle | 1m 25s | | trunk passed | | +1 :green_heart: | mvnsite | 1m 48s | | trunk passed | | -1 :x: | javadoc | 1m 25s | [/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt) | hadoop-hdfs in trunk failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. | | +1 :green_heart: | javadoc | 1m 50s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 43s | | trunk passed | | +1 :green_heart: | shadedclient | 23m 5s | | branch has no errors when building and testing our client artifacts. | _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 1m 21s | | the patch passed | | +1 :green_heart: | compile | 1m 27s | | the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 | | +1 :green_heart: | javac | 1m 27s | | the patch passed | | +1 :green_heart: | compile | 1m 18s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | javac | 1m 18s | | the patch passed | | +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. | | +1 :green_heart: | checkstyle | 1m 2s | | the patch passed | | +1 :green_heart: | mvnsite | 1m 24s | | the patch passed | | -1 :x: | javadoc | 0m 58s | [/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-11.0.15+10-Ubuntu-0ubuntu0.20.04.1.txt) | hadoop-hdfs in the patch failed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1. | | +1 :green_heart: | javadoc | 1m 32s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 | | +1 :green_heart: | spotbugs | 3m 24s | | the patch passed | | +1 :green_heart: | shadedclient | 22m 42s | | patch has no errors when building and testing our client artifacts. | _ Other Tests _ | | -1 :x: | unit | 242m 19s | [/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt) | hadoop-hdfs in the patch passed. | | +1 :green_heart: | asflicense | 1m 15s | | The patch does not generate ASF License warnings. | | | | 380m 48s | | | | Reason | Tests | |---:|:--| | Failed junit tests | hadoop.hdfs.TestClientProtocolForPipelineRecovery | | | hadoop.hdfs.TestRollingUpgrade | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4414/2/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hadoop/pull/4414 | | Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell de
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=781000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781000 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 14/Jun/22 06:40 Start Date: 14/Jun/22 06:40 Worklog Time Spent: 10m Work Description: saintstack commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1154777686 Javadoc build fails are unrelated to this PR's add of a check to two unit tests. The TestRollingUpgrade failure we've flagged already as pre-existing condition and the TestClientProtocolForPipelineRecovery failure is not a test changed here. Let me merge. Issue Time Tracking --- Worklog Id: (was: 781000) Time Spent: 1h (was: 50m) > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Labels: pull-request-available > Time Spent: 1h > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=781001&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781001 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 14/Jun/22 06:42 Start Date: 14/Jun/22 06:42 Worklog Time Spent: 10m Work Description: saintstack merged PR #4414: URL: https://github.com/apache/hadoop/pull/4414 Issue Time Tracking --- Worklog Id: (was: 781001) Time Spent: 1h 10m (was: 1h) > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Labels: pull-request-available > Time Spent: 1h 10m > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=781002&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781002 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 14/Jun/22 06:43 Start Date: 14/Jun/22 06:43 Worklog Time Spent: 10m Work Description: saintstack commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1154780518 Thanks for the contrib. Do you want to put up a backport for branch-3.3 when you get a chance @snmvaughan ? Thanks. Issue Time Tracking --- Worklog Id: (was: 781002) Time Spent: 1h 20m (was: 1h 10m) > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Labels: pull-request-available > Time Spent: 1h 20m > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Work logged] (HDFS-16625) Unit tests aren't checking for PMDK availability
[ https://issues.apache.org/jira/browse/HDFS-16625?focusedWorklogId=781230&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781230 ] ASF GitHub Bot logged work on HDFS-16625: - Author: ASF GitHub Bot Created on: 14/Jun/22 14:14 Start Date: 14/Jun/22 14:14 Worklog Time Spent: 10m Work Description: snmvaughan commented on PR #4414: URL: https://github.com/apache/hadoop/pull/4414#issuecomment-1155245597 Will do. Issue Time Tracking --- Worklog Id: (was: 781230) Time Spent: 1.5h (was: 1h 20m) > Unit tests aren't checking for PMDK availability > > > Key: HDFS-16625 > URL: https://issues.apache.org/jira/browse/HDFS-16625 > Project: Hadoop HDFS > Issue Type: Test > Components: test >Affects Versions: 3.4.0, 3.3.4 >Reporter: Steve Vaughan >Priority: Blocker > Labels: pull-request-available > Time Spent: 1.5h > Remaining Estimate: 0h > > There are unit tests that require native PMDK libraries which aren't checking > if the library is available, resulting in unsuccessful test. Adding the > following in the test setup addresses the problem. > {code:java} > assumeTrue ("Requires PMDK", NativeIO.POSIX.isPmdkAvailable()); {code} -- This message was sent by Atlassian Jira (v8.20.7#820007) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org