[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-09 Thread Tanping Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12907859#action_12907859
 ] 

Tanping Wang commented on HDFS-1310:


 I run ant test on my Linux box under hadoop-hdfs.  Besides this test case, 
there should be 8 test cases already failing, i.e.

[junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery FAILED
[junit] Test org.apache.hadoop.hdfs.TestFileStatus FAILED
[junit] Test org.apache.hadoop.hdfs.TestHDFSServerPorts FAILED
[junit] Test org.apache.hadoop.hdfs.TestHDFSTrash FAILED
[junit] Test org.apache.hadoop.hdfs.server.namenode.TestReplicationPolicy 
FAILED
[junit] Test org.apache.hadoop.fs.TestHDFSFileContextMainOperations FAILED
[junit] Test org.apache.hadoop.hdfs.server.datanode.TestBlockRecovery FAILED
[junit] Test org.apache.hadoop.hdfs.TestFiHFlush FAILED

After applying the patch, these tests are stilling failing, but no other unit 
test cases failed.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12907889#action_12907889
 ] 

Hudson commented on HDFS-1310:
--

Integrated in Hadoop-Hdfs-trunk-Commit #383 (See 
[https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/383/])
HDFS-1310. The ClientDatanodeProtocol proxy should be stopped in 
DFSInputStream.readBlockLength(..).  Contributed by sam rash


 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
  Components: hdfs client
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Fix For: 0.22.0

 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-07 Thread sam rash (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906912#action_12906912
 ] 

sam rash commented on HDFS-1310:


my apologies for the delay--i came down with a cold right before the long 
weekend

results of test-patch:

 [exec] -1 overall.  
 [exec] 
 [exec] +1 @author.  The patch does not contain any @author tags.
 [exec] 
 [exec] -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
 [exec] Please justify why no new tests are needed 
for this patch.
 [exec] Also please list what manual steps were 
performed to verify this patch.
 [exec] 
 [exec] +1 javadoc.  The javadoc tool did not generate any warning 
messages.
 [exec] 
 [exec] +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
 [exec] 
 [exec] +1 findbugs.  The patch does not introduce any new Findbugs 
warnings.
 [exec] 
 [exec] +1 release audit.  The applied patch does not increase the 
total number of release audit warnings.
 [exec] 
 [exec] +1 system tests framework.  The patch passed system tests 
framework compile.


 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-07 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906927#action_12906927
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1310:
--

No problem and thanks for running test-patch.  Have you also run the unit tests?

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-07 Thread sam rash (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906964#action_12906964
 ] 

sam rash commented on HDFS-1310:


I have not run it all the way through yet.  Is it 'test' or 'test-core' these 
days?

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-07 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906980#action_12906980
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1310:
--

It is ant test.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-03 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905994#action_12905994
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1310:
--

 I think Hudson is back as of a couple of days ago.

I saw some Hudson report recently but it seems that it only works 
probabilistically.

Sam, could you run test-patch and all the unit tests over your patch?

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-03 Thread sam rash (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906105#action_12906105
 ] 

sam rash commented on HDFS-1310:


is that just 

ant test

?

not familiar with test-patch ?


 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-03 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906111#action_12906111
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1310:
--

ant test is for running the unit tests
ant test-patch is checking other stuffs like findbugs, javadoc, forrest, etc.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-03 Thread Eli Collins (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12906115#action_12906115
 ] 

Eli Collins commented on HDFS-1310:
---

There's a test-patch target.  You need to run it from an svn tree rather than 
a git tree. Here's a bash function that's useful for running it:

{code}
function ant-test-patch() {
 ant -Dpatch.file=$1 \
   -Dforrest.home=$FORREST_HOME \
   -Dfindbugs.home=$FINDBUGS_HOME \
   -Djava5.home=$JAVA5_HOME \
   test-patch
}
{code}


 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt, hdfs-1310-2.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-01 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905348#action_12905348
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1310:
--

Thanks Tanping for checking TestFileConcurrentReader.

Sam, could you run test-patch and all the unit tests over your patch?  Hudson 
seems not working recently.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-01 Thread Tsz Wo (Nicholas), SZE (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905354#action_12905354
 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-1310:
--

{code}
 for(DatanodeInfo datanode : locatedblock.getLocations()) {
+  final ClientDatanodeProtocol cdp = 
DFSClient.createClientDatanodeProtocolProxy(
+datanode, dfsClient.conf, dfsClient.socketTimeout, locatedblock);
+  
   try {
-final ClientDatanodeProtocol cdp = 
DFSClient.createClientDatanodeProtocolProxy(
-datanode, dfsClient.conf, dfsClient.socketTimeout, locatedblock);
{code}
Found a problem: If createClientDatanodeProtocolProxy(..) throws an exception, 
it won't try the remaining datanodes.  Sorry that I have not seen it earlier.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-01 Thread Konstantin Boudnik (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905368#action_12905368
 ] 

Konstantin Boudnik commented on HDFS-1310:
--

I think Hudson is back as of a couple of days ago.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-09-01 Thread sam rash (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12905380#action_12905380
 ] 

sam rash commented on HDFS-1310:


good point, i'll move the init into the try block



 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash
 Attachments: hdfs-1310-1.txt


 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-30 Thread sam rash (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904472#action_12904472
 ] 

sam rash commented on HDFS-1310:


sorry for the delay, I skimmed this jira and the last comment contradicted the 
title, so I assumed it was in ok shape.
I will have a minute to look at this in more detail tomorrow night


 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-30 Thread Tanping Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904483#action_12904483
 ] 

Tanping Wang commented on HDFS-1310:


Hi, Sam, sorry about the confusion.  In my last comment, I mentioned that I ran 
each one test case( out of the total seven tests in TestFileConcurrentReader), 
one by one, *individually*.  .i.e. commenting other six tests out, but only 
leaving one test running each time.  Each single one test got passed.  However, 
if I run seven tests  from TestFileConcurrentReader together, the last three ( 
sometimes, two) tests fail.  
The last three tests are testUnfinishedBlockCRCErrorTransferToVerySmallWrite, 
testUnfinishedBlockCRCErrorNormalTransfer and 
testUnfinishedBlockCRCErrorNormalTransferVerySmallWrite.

Please look at the Hudson result for reference,

https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk/413/testReport/org.apache.hadoop.hdfs/TestFileConcurrentReader/testUnfinishedBlockCRCErrorTransferToVerySmallWrite/
https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk/413/testReport/org.apache.hadoop.hdfs/TestFileConcurrentReader/testUnfinishedBlockCRCErrorNormalTransfer/
https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk/413/testReport/org.apache.hadoop.hdfs/TestFileConcurrentReader/testUnfinishedBlockCRCErrorNormalTransferVerySmallWrite/

The first test case failed because of java.io.IOException: Too many open 
files.
The next two ( sometimes one ) tests fail due to Cannot lock storage ... The 
directory is already locked. 
It seems to me that the test runs into race condition and does not release 
resources properly.



 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-30 Thread sam rash (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12904506#action_12904506
 ] 

sam rash commented on HDFS-1310:


actually the 2nd two are likely fallout from the first--if it died and didn't 
cleanup the locks, this could happen.

as i noted, i'm a bit short on time tonight, so I'll get to this tomorrow 
evening.  fwiw, this looks familiar--the 'too many open files' with this unit 
test.  i thought i already saw this and fixed it, though, where I simply didn't 
close a file in a thread...maybe only patched it in our local branch.

thanks for the directly links to the results

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas
Assignee: sam rash

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-23 Thread Tanping Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901621#action_12901621
 ] 

Tanping Wang commented on HDFS-1310:


I ran this test case, TestFileConcurrentReader with Java 1.6.0_07 and this test 
stuck for ever on Yahoo hudson build box.  I switched to Java 1.6.0_15 on the 
same build box,  the test case passed with no problem.  (Suspecting running 
into some race conditions in the test cases.)  On the other hand,  on my own 
Linux box, with the latest Java version, .1.6.0_21, initially, 3 out of 7 test 
cases failed, after putting in some sleep time between each test case,  shown 
as below,

  protected void tearDown() throws Exception {
cluster.shutdown();
cluster = null;

super.tearDown();
// NEW: go to sleep
try{Thread.sleep(3000);}catch(Exception e) {}; 
  }

tests passed.

Which java sub-version do we use for Hudson?

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-23 Thread Tanping Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901660#action_12901660
 ] 

Tanping Wang commented on HDFS-1310:


In stead of putting in a sleep interval, removing super.tearDown() inside of 
tearDown() function itself makes the test case pass with Java1.6._12, 
Java1.6_15 and Java1.6_21.  

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-23 Thread Konstantin Boudnik (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901666#action_12901666
 ] 

Konstantin Boudnik commented on HDFS-1310:
--

Using sleep intervals in tests is suboptimal at best; using them to fix 
race-conditioned tests is pretty bad, I'd say.
Besides, the test is JUnit v3 - an unsupported old version of the framework. We 
are using 4.5 at the moment. Last but not least, calling {{super.tearDown()}} 
doesn't make _any_ sense at all because this is an empty method of the 
{{TestCase}} class.

Loops like this
{noformat}
while (!done) {
  try {
Thread.sleep(1000);
  } catch (InterruptedException e) {
  }
  done = true;
  BlockLocation[] locations = fileSys.getFileBlockLocations(
fileSys.getFileStatus(name), 0, blockSize);
  if (locations.length  1) {
done = false;
continue;
  }
}
{noformat}
are begging for troubles and potential timeouts. There's no guarantee that its 
condition will ever be satisfied.

I'd say the test needs to be refactored to JUnit v4.5 and then re-evaluated to 
see if the timeouts still occur.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-08-23 Thread Tanping Wang (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12901676#action_12901676
 ] 

Tanping Wang commented on HDFS-1310:


I also ran each test from TestFileConcurrentReader test suite individually, i.e.

testUnfinishedBlockRead
testUnfinishedBlockPacketBufferOverrun
testImmediateReadOfNewFile
testUnfinishedBlockCRCErrorTransferTo
testUnfinishedBlockCRCErrorTransferToVerySmallWrite
testUnfinishedBlockCRCErrorNormalTransfer
testUnfinishedBlockCRCErrorNormalTransferVerySmallWrite

every one of them passed with no problem.

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HDFS-1310) TestFileConcurrentReader fails

2010-07-20 Thread Suresh Srinivas (JIRA)

[ 
https://issues.apache.org/jira/browse/HDFS-1310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12890389#action_12890389
 ] 

Suresh Srinivas commented on HDFS-1310:
---

Todd or Hairong, can you please take a look at this failure

 TestFileConcurrentReader fails
 --

 Key: HDFS-1310
 URL: https://issues.apache.org/jira/browse/HDFS-1310
 Project: Hadoop HDFS
  Issue Type: Test
Affects Versions: 0.22.0
Reporter: Suresh Srinivas

 For details of test failure see 
 http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/218/testReport/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.