[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12926378#action_12926378 ] Hudson commented on HDFS-1462: -- Integrated in Hadoop-Hdfs-trunk-Commit #420 (See [https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/420/]) Add missing file in last commit (HDFS-1462). Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Fix For: 0.22.0 Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12925912#action_12925912 ] Eli Collins commented on HDFS-1462: --- +1 Nit: In FSNamesytem#adjustReplication typo replicatoin And please add spacing around operators. Otherwise looks great. Agree with removing the last log. This was added in HADOOP-4045, I checked that change and didn't find any other logs that fire with every edit. Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12925208#action_12925208 ] Sanjay Radia commented on HDFS-1462: Had not realized that there is already a log category for FSImage. Given that, don't pass the FSNamesystem.LOG as a parameter, create one for the FSEditLog and use it. Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12924448#action_12924448 ] Sanjay Radia commented on HDFS-1462: +1 Looks good. Not worth changing the Log category - just pass as parameter, This leaves it as a straight refactor and at the same time removes all references to FSNamesystem from FSEditlog. Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12924805#action_12924805 ] Todd Lipcon commented on HDFS-1462: --- Looks like FSEditLog refers to FSImage.LOG in a couple of places. Should I leave those, or have them use the passed log? Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12924094#action_12924094 ] Jitendra Nath Pandey commented on HDFS-1462: This patch removes the references to namesystem object from FSEditlog, which is a good thing. FSEditlog still refers to FSNamesystem.LOG, if LOG object could be passed as a parameter, we could remove all references to FSNamesystem from FSEditlog. Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1462) Refactor edit log loading to a separate class from edit log writing
[ https://issues.apache.org/jira/browse/HDFS-1462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12924109#action_12924109 ] Todd Lipcon commented on HDFS-1462: --- Sure, we could pass in LOG, or just create our own logger for FSEditLog. I left it as is to make it a straight refactor, but so long as people don't mind the slightly breaking change of changing the log category, I'm fine changing it. Thoughts? Refactor edit log loading to a separate class from edit log writing --- Key: HDFS-1462 URL: https://issues.apache.org/jira/browse/HDFS-1462 Project: Hadoop HDFS Issue Type: Sub-task Components: name-node Affects Versions: 0.22.0 Reporter: Todd Lipcon Assignee: Todd Lipcon Attachments: hdfs-1462.txt, hdfs-1462.txt, hdfs-1462.txt Before the major work in HDFS-1073, I'd like to do this refactor to clean up the monster FSEditLog class. We can separate all the functions that take of loading edits into an FSN from the functions that take care of writing edits, rolling, etc. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
