[jira] [Commented] (HDFS-1506) Refactor fsimage loading code
[ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022444#comment-13022444 ] Hudson commented on HDFS-1506: -- Integrated in Hadoop-Hdfs-trunk #643 (See [https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/643/]) Refactor fsimage loading code - Key: HDFS-1506 URL: https://issues.apache.org/jira/browse/HDFS-1506 Project: Hadoop HDFS Issue Type: Improvement Components: name-node Affects Versions: 0.23.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.23.0 Attachments: refactorImageLoader.patch, refactorImageLoader1.patch I plan to do some code refactoring to make HDFS-1070 simpler. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12972936#action_12972936 ] Todd Lipcon commented on HDFS-1506: --- I'd like to propose this go into branch-0.22 as well, since we intend to put HDFS-1073 into 22, and all of those patches build on top of this. Would you mind committing if you don't object, Hairong? Refactor fsimage loading code - Key: HDFS-1506 URL: https://issues.apache.org/jira/browse/HDFS-1506 Project: Hadoop HDFS Issue Type: Improvement Components: name-node Affects Versions: 0.23.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.23.0 Attachments: refactorImageLoader.patch, refactorImageLoader1.patch I plan to do some code refactoring to make HDFS-1070 simpler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966608#action_12966608 ] Todd Lipcon commented on HDFS-1506: --- +1 looks good to me assuming tests pass Refactor fsimage loading code - Key: HDFS-1506 URL: https://issues.apache.org/jira/browse/HDFS-1506 Project: Hadoop HDFS Issue Type: Improvement Components: name-node Affects Versions: 0.23.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Attachments: refactorImageLoader.patch, refactorImageLoader1.patch I plan to do some code refactoring to make HDFS-1070 simpler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966636#action_12966636 ] Hairong Kuang commented on HDFS-1506: - [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. No unit test is added since the patch mostly moves the code around. Refactor fsimage loading code - Key: HDFS-1506 URL: https://issues.apache.org/jira/browse/HDFS-1506 Project: Hadoop HDFS Issue Type: Improvement Components: name-node Affects Versions: 0.23.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Attachments: refactorImageLoader.patch, refactorImageLoader1.patch I plan to do some code refactoring to make HDFS-1070 simpler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966677#action_12966677 ] Hairong Kuang commented on HDFS-1506: - Failed tests are all known: TestBlockRecovery TestHDFSTrash TestBackupNode TestStorageRestore TestBalancer TestBlockTokenWithDFS Refactor fsimage loading code - Key: HDFS-1506 URL: https://issues.apache.org/jira/browse/HDFS-1506 Project: Hadoop HDFS Issue Type: Improvement Components: name-node Affects Versions: 0.23.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Attachments: refactorImageLoader.patch, refactorImageLoader1.patch I plan to do some code refactoring to make HDFS-1070 simpler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[
https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12966374#action_12966374
]
Todd Lipcon commented on HDFS-1506:
---
Looks pretty good. Just some small nits and then +1 from my viewpoint.
- FSNamesystem member in FSImageFormat.Loader should probably be marked final
and maybe declared up with {{conf}} rather than down with the output members
- The indentation is off on the loadFullNameINodes function
- The indentation of the addToParent() function arguments is pretty strange
looking
- A few whitespace lines removed needlessly (before spaceConsumedInTree and
following two functions)
Refactor fsimage loading code
-
Key: HDFS-1506
URL: https://issues.apache.org/jira/browse/HDFS-1506
Project: Hadoop HDFS
Issue Type: Improvement
Components: name-node
Affects Versions: 0.23.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Attachments: refactorImageLoader.patch
I plan to do some code refactoring to make HDFS-1070 simpler.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[
https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12965863#action_12965863
]
Konstantin Boudnik commented on HDFS-1506:
--
Hairong, just a quick look over the patch: JavaDoc for {{newINode}} doesn't
have descriptions for the parameters. Perhaps, their names are
self-explanatory?
Refactor fsimage loading code
-
Key: HDFS-1506
URL: https://issues.apache.org/jira/browse/HDFS-1506
Project: Hadoop HDFS
Issue Type: Improvement
Components: name-node
Affects Versions: 0.23.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Attachments: refactorImageLoader.patch
I plan to do some code refactoring to make HDFS-1070 simpler.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-1506) Refactor fsimage loading code
[ https://issues.apache.org/jira/browse/HDFS-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1293#action_1293 ] Hairong Kuang commented on HDFS-1506: - Todd, as I discussed with you previously, please go ahead with HDFS-1473. I do not think this collides with HDFS-1489. Jakob, please let me know it goes with HDFS-1465 ... Refactor fsimage loading code - Key: HDFS-1506 URL: https://issues.apache.org/jira/browse/HDFS-1506 Project: Hadoop HDFS Issue Type: Improvement Components: name-node Affects Versions: 0.23.0 Reporter: Hairong Kuang Assignee: Hairong Kuang I plan to do some code refactoring to make HDFS-1070 simpler. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
