[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13037376#comment-13037376
]
Hudson commented on HDFS-1575:
--
Integrated in Hadoop-Hdfs-trunk #673 (See
[https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk/673/])
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-22.0.patch,
hdfs-1575-trunk.0.patch, hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch,
hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13037208#comment-13037208
]
Hudson commented on HDFS-1575:
--
Integrated in Hadoop-Hdfs-trunk-Commit #677 (See
[https://builds.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/677/])
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-22.0.patch,
hdfs-1575-trunk.0.patch, hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch,
hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036014#comment-13036014
]
Aaron T. Myers commented on HDFS-1575:
--
+1, looks good to me. I especially like the reworking of the loop which
iterates over {{blks}}. Thanks for cleaning this up.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch, hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036026#comment-13036026
]
Hadoop QA commented on HDFS-1575:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479722/hdfs-1575-trunk.2.patch
against trunk revision 1124459.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/582//console
This message is automatically generated.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch, hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036037#comment-13036037
]
Hadoop QA commented on HDFS-1575:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479729/hdfs-1575-trunk.3.patch
against trunk revision 1124459.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.hdfs.TestHDFSTrash
org.apache.hadoop.hdfs.TestPipelines
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//testReport/
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/585//console
This message is automatically generated.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch, hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036045#comment-13036045
]
Todd Lipcon commented on HDFS-1575:
---
I tried the failing tests locally and they pass. Will commit to 22 and trunk
momentarily.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch, hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036049#comment-13036049
]
Todd Lipcon commented on HDFS-1575:
---
Committed to trunk. Looks like we need to alter the patch a little for 0.22
since the federation stuff isn't there. Mind doing that?
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch, hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13036507#comment-13036507
]
Hadoop QA commented on HDFS-1575:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479841/hdfs-1575-22.0.patch
against trunk revision 1125057.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
-1 patch. The patch command could not apply the patch.
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/593//console
This message is automatically generated.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-22.0.patch,
hdfs-1575-trunk.0.patch, hdfs-1575-trunk.1.patch, hdfs-1575-trunk.2.patch,
hdfs-1575-trunk.3.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035784#comment-13035784
]
Todd Lipcon commented on HDFS-1575:
---
Since these changes are just in the java, it seems we could have some true unit
tests for it?
Also, when concatenating val in the getUrlParam functions, shouldn't it be
encoded?
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035790#comment-13035790
]
Aaron T. Myers commented on HDFS-1575:
--
bq. Since these changes are just in the java, it seems we could have some true
unit tests for it?
Sure could. I'll work on that.
bq. Also, when concatenating val in the getUrlParam functions, shouldn't it
be encoded?
Maybe. I'm not sure that the URL encoding should be done at this level.
Regardless, it has the potential to break a lot of stuff via double-encoding,
so I'd rather do that as part of a separate JIRA, if it's alright with you.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035970#comment-13035970
]
Hadoop QA commented on HDFS-1575:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479703/hdfs-1575-trunk.1.patch
against trunk revision 1124459.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
-1 release audit. The applied patch generated 1 release audit warnings
(more than the trunk's current 0 warnings).
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.TestDFSStorageStateRecovery
org.apache.hadoop.hdfs.TestFileConcurrentReader
org.apache.hadoop.tools.TestJMXGet
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//testReport/
Release audit warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
Findbugs warnings:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/hudson/job/PreCommit-HDFS-Build/577//console
This message is automatically generated.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13035971#comment-13035971
]
Todd Lipcon commented on HDFS-1575:
---
Looks like license header is missing on TestDatanodeJsp
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Assignee: Aaron T. Myers
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575, hdfs-1575-trunk.0.patch,
hdfs-1575-trunk.1.patch
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13023077#comment-13023077
]
Todd Lipcon commented on HDFS-1575:
---
A few issues with the patch:
- style issue: need braces around the if () {...} block
- style issue: continuation of line path = req.getPathInfo()... should be
indented
- The filename that gets put onto the path needs to get path-encoded. Right now
there is an XSS vulnerability if you name a file something like
'...evilcodehere...'. Note that path-encoding is different than URLEncoding -
particularly in that / should not be encoded, and turns to %20 instead
of +.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021516#comment-13021516
]
Hadoop QA commented on HDFS-1575:
-
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12476499/HDFS-1575
against trunk revision 1094748.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.hdfs.server.datanode.TestBlockReport
org.apache.hadoop.hdfs.TestFileConcurrentReader
-1 contrib tests. The patch failed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//testReport/
Findbugs warnings:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/390//console
This message is automatically generated.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020481#comment-13020481
]
Dmytro Molkov commented on HDFS-1575:
-
I guess I should also do url unencode if I fetch the value from the filename
parameter, shouldn't I?
The original patch in 1109 was fixing the problem with certain characters that
were not handled correctly when passed around in the request parameter.
Unfortunately I did not take into account the fact that we have jsp files being
used for this at the same time.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13020484#comment-13020484
]
Dmytro Molkov commented on HDFS-1575:
-
Just looked at the original patch and there is no URL decoding, so with this
patch the behaviour is exactly like the one before 1109 if the path is passed
via the filename parameter, and also works when the path is passed as a part of
PathInfo to the servlet.
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
Attachments: HDFS-1575
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13019131#comment-13019131
]
Suresh Srinivas commented on HDFS-1575:
---
I had asked Dmytro to look at it. He agreed to in HDFS-1109. Dmytro do you have
any update?
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HDFS-1575) viewing block from web UI broken
[
https://issues.apache.org/jira/browse/HDFS-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12979835#action_12979835
]
Jakob Homan commented on HDFS-1575:
---
This bug was identified in HDFS-1109 (http://s.apache.org/D2i), but I don't see
that a JIRA was ever opened for it. Suresh? Dmytro?
viewing block from web UI broken
Key: HDFS-1575
URL: https://issues.apache.org/jira/browse/HDFS-1575
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 0.22.0
Reporter: Todd Lipcon
Priority: Blocker
Fix For: 0.22.0
DatanodeJspHelper seems to expect the file path to be in the path info of
the HttpRequest, rather than in a parameter. I see the following exception
when visiting the URL
{{http://localhost.localdomain:50075/browseBlock.jsp?blockId=5006108823351810567blockSize=20genstamp=1001filename=%2Fuser%2Ftodd%2FissuedatanodePort=50010namenodeInfoPort=50070}}
java.io.FileNotFoundException: File does not exist: /
at
org.apache.hadoop.hdfs.server.namenode.FSNamesystem.getBlockLocationsInternal(FSNamesystem.java:834)
...
at
org.apache.hadoop.hdfs.server.datanode.DatanodeJspHelper.generateFileDetails(DatanodeJspHelper.java:258)
at
org.apache.hadoop.hdfs.server.datanode.browseBlock_jsp._jspService(browseBlock_jsp.java:79)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
