[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770172#action_12770172 ] Hairong Kuang commented on HDFS-728: For this issue, I plan to take Nigel's suggestion for now. this is clearly a functional test, so it make sense to create a separate directory structure like test/src/functional. +1. This is the way to go! We also need a new target in build.xml. Shall we do it in a different jira? Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch, HDFS-728.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770174#action_12770174 ] Konstantin Boudnik commented on HDFS-728: - And, the target creation has to be done as a separate JIRA's patch Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch, HDFS-728.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12770212#action_12770212 ] Konstantin Boudnik commented on HDFS-728: - +1 patch looks good Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch, appendTest1.patch, HDFS-728.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769400#action_12769400 ] Konstantin Boudnik commented on HDFS-728: - I've ran the test by the means of Ant build and it hands after 15 minutes. Apparently it happens after JUnit timeout is reached. Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769410#action_12769410 ] Hairong Kuang commented on HDFS-728: This test is not intended as a junit test. Instead, it should run as an application from the command line. Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769414#action_12769414 ] Konstantin Boudnik commented on HDFS-728: - Right, I've understood this. My question is: How do we suppose to run it in Hudson then? It has to be executed by Hudson on a regular basis if it suppose to be a part of standard development cycle. Shell it be moved to a special load (or stressful) test suite? It might be an open discussion for this. However, there's no way to run a command line application as a part of CI build/test cycle. Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769443#action_12769443 ] Nigel Daley commented on HDFS-728: -- Hairong, please write this as a Junit test. You can name the test appropriately so that it doesn't get picked up by the test target (simply don't start the test class name with the word Test). We should then file a Jira to add a functional test target to Ant that can pick up this and other similar tests. Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch, HDFS-728.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[
https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769446#action_12769446
]
Konstantin Boudnik commented on HDFS-728:
-
Merging together last two comments and adding some thoughts on top:
- no split of the test case is required then. So, my patch could be modified
slightly and seems to be good to go.
- this is clearly a functional test, so it make sense to create a separate
directory structure like {{test/src/functional}}
- for this new target a different timeout settings would be required
Creat a comprehensive functional test for append
Key: HDFS-728
URL: https://issues.apache.org/jira/browse/HDFS-728
Project: Hadoop HDFS
Issue Type: New Feature
Affects Versions: 0.21.0
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Fix For: 0.21.0
Attachments: appendTest.patch, HDFS-728.patch
This test aims to do
1. create a file of len1;
2. reopen the file for append;
3. write len2 bytes to the file and hflush;
4. write len3 bytes to the file and close the file;
5. validate the content of the file.
Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and
len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1,
len2, and len3. To minimize the running time, bytes per checksum is set to be
4 bytes, each packet size is set to be bytes per checksum, and each block
contains 2 packets.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-728) Creat a comprehensive functional test for append
[ https://issues.apache.org/jira/browse/HDFS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12769448#action_12769448 ] Tsz Wo (Nicholas), SZE commented on HDFS-728: - ... You can name the test appropriately so that it doesn't get picked up by the test target (simply don't start the test class name with the word Test). ... We have already moved to junit 4 and so we are using the @Test annotation. The name of the test does not matter. Creat a comprehensive functional test for append Key: HDFS-728 URL: https://issues.apache.org/jira/browse/HDFS-728 Project: Hadoop HDFS Issue Type: New Feature Affects Versions: 0.21.0 Reporter: Hairong Kuang Assignee: Hairong Kuang Fix For: 0.21.0 Attachments: appendTest.patch, HDFS-728.patch This test aims to do 1. create a file of len1; 2. reopen the file for append; 3. write len2 bytes to the file and hflush; 4. write len3 bytes to the file and close the file; 5. validate the content of the file. Len1 ranges from [0, 2*BLOCK_SIZE+1], len2 ranges from [0, BLOCK_SIZE+1], and len3 ranges from [0, BLOCK_SIZE+1]. The test tries all combination of len1, len2, and len3. To minimize the running time, bytes per checksum is set to be 4 bytes, each packet size is set to be bytes per checksum, and each block contains 2 packets. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
