Re: "calibre" package fails to build.

2018-08-11 Thread Andreas Enge 
Hello,

On Mon, Aug 06, 2018 at 07:27:33PM -0700, Chris Marusich wrote:
> Matthew Brooks  writes:
> > Crashes on start with the "ImportError: No module named QtWebKitWidgets" 
> > error, sadly.
> If this is still an issue, could you please submit a bug report
> (including what commit/Guix version you used) to bug-g...@gnu.org?

the bug report already exists:
   https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24404

Andreas

Re: "calibre" package fails to build.

2018-08-06 Thread Chris Marusich 
Matthew Brooks  writes:

> On Wed, 1 Aug 2018 13:17:39 +0300
> Efraim Flashner  wrote:
>
> Crashes on start with the "ImportError: No module named QtWebKitWidgets" 
> error, sadly.

If this is still an issue, could you please submit a bug report
(including what commit/Guix version you used) to bug-g...@gnu.org?

Thank you,

-- 
Chris


signature.asc
Description: PGP signature

Re: "calibre" package fails to build.

2018-08-05 Thread Matthew Brooks 
On Wed, 1 Aug 2018 13:17:39 +0300
Efraim Flashner  wrote:

Crashes on start with the "ImportError: No module named QtWebKitWidgets" error, 
sadly.


pgpVVTx3y9XRx.pgp
Description: OpenPGP digital signature

Re: "calibre" package fails to build.

2018-08-01 Thread Efraim Flashner 
On Sun, Jul 22, 2018 at 11:49:14AM +0200, Andreas Enge wrote:
> Hello,
> 
> I ended up disabling tests (see comments in the patch).
> Now the package builds, but tries to install into the Qt directory; at the
> end of the cmake phase, it prints:
>   -- Installing in the same prefix as Qt, adopting their path scheme.
> The previous version of the package contains a phase to adapt this,
> but the .pri files to be modified do not exist any more.
> 
> I also tried to inherit from qtsvg like other qt* packages; but the
> gnu-build-system does not work any more for qtwebkit, the build finishes
> in a few seconds creating only the documentation and not compiling the code...
> 
> At this point, I am giving up; it would be nice if someone else could take
> a look, I am attaching the current patch.

Thanks for getting the patch this far! I switched the 'configure phase
from (invoke qmake) to fully cmake with some necessary configure-flags.
It seemed easier than trying to convince qmake to install to the correct
location.

I also left the tests disabled, 7+ hours compiling on my fast aarch64
board was quite long enough. I'm not opposed to re-enabling them but I
don't want to debug failures.

> 
> If there is no progress during the next few days, I would suggest to re-add
> pyqt@5.9 for calibre. What do you think?

After fixing a bug in optipng (bundling outdated copies of libraries is
definately a bug) I was able to compile calibre on aarch64. I run it
headless, so I wasn't able to test it but hopefully it's back to
working.

> Andreas
> 
> PS: There is a thread from 2016 in which the Calibre author states that he
> will stick with qtwebkit and in the worst case take over the maintenance
> of a fork:
>https://www.mobileread.com/forums/showthread.php?t=270258

If he's planning on going the same route as gnucash I assume its only a
matter of time until he realizes distros will drop calibre rather than
carry along his beloved cruft.


-- 
Efraim Flashner  אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Re: "calibre" package fails to build.

2018-07-22 Thread Andreas Enge 
Hello,

I ended up disabling tests (see comments in the patch).
Now the package builds, but tries to install into the Qt directory; at the
end of the cmake phase, it prints:
  -- Installing in the same prefix as Qt, adopting their path scheme.
The previous version of the package contains a phase to adapt this,
but the .pri files to be modified do not exist any more.

I also tried to inherit from qtsvg like other qt* packages; but the
gnu-build-system does not work any more for qtwebkit, the build finishes
in a few seconds creating only the documentation and not compiling the code...

At this point, I am giving up; it would be nice if someone else could take
a look, I am attaching the current patch.

If there is no progress during the next few days, I would suggest to re-add
pyqt@5.9 for calibre. What do you think?

Andreas

PS: There is a thread from 2016 in which the Calibre author states that he
will stick with qtwebkit and in the worst case take over the maintenance
of a fork:
   https://www.mobileread.com/forums/showthread.php?t=270258

>From 3fe25c8153e28823411d045251e7458c82e62421 Mon Sep 17 00:00:00 2001
From: Andreas Enge 
Date: Sun, 22 Jul 2018 11:38:58 +0200
Subject: [PATCH] gnu: qtwebkit: Update to 5.212.0-alpha2.

* gnu/packages/qt.scm (qtwebkit): Update to 5.212.0-alpha2.
* gnu/packages/patches/qtwebkit-pbutils-include.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register the patch.
---
 gnu/local.mk  |  1 +
 .../patches/qtwebkit-pbutils-include.patch| 15 
 gnu/packages/qt.scm   | 87 +++
 3 files changed, 30 insertions(+), 73 deletions(-)
 create mode 100644 gnu/packages/patches/qtwebkit-pbutils-include.patch

diff --git a/gnu/local.mk b/gnu/local.mk
index e55c2bf3b..066b9fb42 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1092,6 +1092,7 @@ dist_patch_DATA = 
\
   %D%/packages/patches/qtbase-use-TZDIR.patch  \
   %D%/packages/patches/qtoctave-qt-5.11-fix.patch  \
   %D%/packages/patches/qtscript-disable-tests.patch\
+  %D%/packages/patches/qtwebkit-pbutils-include.patch   \
   %D%/packages/patches/quagga-reproducible-build.patch  \
   %D%/packages/patches/quassel-qt-5.11.patch   \
   %D%/packages/patches/quickswitch-fix-dmenu-check.patch   \
diff --git a/gnu/packages/patches/qtwebkit-pbutils-include.patch 
b/gnu/packages/patches/qtwebkit-pbutils-include.patch
new file mode 100644
index 0..57961e7a5
--- /dev/null
+++ b/gnu/packages/patches/qtwebkit-pbutils-include.patch
@@ -0,0 +1,15 @@
+Patch taken from Nix:
+   
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/qt-5/5.11/qtwebkit.patch
+
+diff --git a/Source/WebKit2/PlatformQt.cmake b/Source/WebKit2/PlatformQt.cmake
+--- a/Source/WebKit2/PlatformQt.cmake
 b/Source/WebKit2/PlatformQt.cmake
+@@ -261,6 +261,7 @@
+ list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+ ${GLIB_INCLUDE_DIRS}
+ ${GSTREAMER_INCLUDE_DIRS}
++${GSTREAMER_PBUTILS_INCLUDE_DIRS}
+ ${Qt5Quick_INCLUDE_DIRS}
+ ${Qt5Quick_PRIVATE_INCLUDE_DIRS}
+ ${SQLITE_INCLUDE_DIR}
+
diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm
index a15d6453c..5386fc6d0 100644
--- a/gnu/packages/qt.scm
+++ b/gnu/packages/qt.scm
@@ -1991,18 +1991,16 @@ different kinds of sliders, and much more.")
 (define-public qtwebkit
   (package
 (name "qtwebkit")
-(version "5.9.1")
+(version "5.212.0-alpha2")
 (source
   (origin
 (method url-fetch)
-(uri (string-append "https://download.qt.io/official_releases/qt/";
-(version-major+minor version) "/" version
-"/submodules/" name "-opensource-src-"
-version ".tar.xz"))
+(uri 
"https://github.com/annulen/webkit/releases/download/qtwebkit-5.212.0-alpha2/qtwebkit-5.212.0-alpha2.tar.xz";)
 (sha256
  (base32
-  "1ksjn1vjbfhdm4y4rg08ag4krk87ahp7qcdcpwll42l0rnz61998"
-(build-system gnu-build-system)
+  "12lg7w00d8wsj672s1y5z5gm0xdcgs16nas0b5bgq4byavg03ygq"))
+(patches (search-patches "qtwebkit-pbutils-include.patch"
+(build-system cmake-build-system)
 (native-inputs
  `(("perl" ,perl)
("python" ,python-2.7)
@@ -2013,6 +2011,8 @@ different kinds of sliders, and much more.")
("pkg-config" ,pkg-config)))
 (inputs
  `(("icu" ,icu4c)
+   ("glib" ,glib)
+   ("gst-plugins-base" ,gst-plugins-base)
("libjpeg" ,libjpeg)
("libpng" ,libpng)
("libwebp" ,libwebp)
@@ -2021,85 +2021,26 @@ different kinds of sliders, and much more.")
("libxrender" ,libxrender)
("qtbase" ,qtbase)
("qtdeclarative" ,qtdeclarative)
+   ("qtlocation" ,qtlocation)
("qtmultimedia" ,qtmultimedia)
+   ("qtsensors" ,qtsensors)
+   ("qtwebchannel" ,qtwebchannel)

Re: "calibre" package fails to build.

2018-07-21 Thread Andreas Enge 
On Sat, Jul 21, 2018 at 10:34:48PM +0200, Andreas Enge wrote:
> Does this ring a bell?

Nix has a patch:
   
https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/qt-5/5.11/qtwebkit.patch

diff --git a/Source/WebKit2/PlatformQt.cmake b/Source/WebKit2/PlatformQt.cmake
--- a/Source/WebKit2/PlatformQt.cmake
+++ b/Source/WebKit2/PlatformQt.cmake
@@ -261,6 +261,7 @@
 list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
 ${GLIB_INCLUDE_DIRS}
 ${GSTREAMER_INCLUDE_DIRS}
+${GSTREAMER_PBUTILS_INCLUDE_DIRS}
 ${Qt5Quick_INCLUDE_DIRS}
 ${Qt5Quick_PRIVATE_INCLUDE_DIRS}
 ${SQLITE_INCLUDE_DIR}

This looks like something we could need! I will give it a try.

Andreas

Re: "calibre" package fails to build.

2018-07-21 Thread Andreas Enge 
On Sat, Jul 21, 2018 at 09:52:25PM +0300, Efraim Flashner wrote:
> I see, debian moved to the same source. I am worried though that that
> repo hasn't seen any action in 6 months.

And it does not compile at all with our current recipe:
The custom phases 'fix-qmlwebkit-plugins-rpath and 'patch-installpaths
manipulate files that do not exist anymore. I removed them.

Then it complains about missing cmake. I moved to cmake-build-system,
which results in a warning:
starting phase `configure'
Info: creating stash file 
/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/.qmake.stash
phase `configure' succeeded after 0.1 seconds
## WARNING: phase `configure' returned `0'.  Return values other than #t
## are deprecated.  Please migrate this package so that its phase
## procedures report errors by raising an exception, and otherwise
## always return #t.
starting phase `patch-generated-file-shebangs'

and then fails with a complaint about missing stuff.
I added qtlocation, qtsensors and qtwebchannel to the inputs.
Then it complains about glib, which I added.
Then it complains about gst-plugins-base, which I also added.
Then it starts building.

A good hour later, it fails with the following error message:

[ 94%] Building CXX object 
Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/gstreamer/WebPageProxyGStreamer.cpp.o
cd 
/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/release/Source/WebKit2
 && /gnu/store/zrhwhlqqk51qslbddk4cip2z2p3fpvxd-gcc-5.5.0/bin/g++  
-DBUILDING_QT__=1 -DBUILDING_WEBKIT -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebKit2 
-DENABLE_DATABASE_PROCESS=1 -DENABLE_PLUGIN_PROCESS=1 -DHAVE_CONFIG_H=1 
-DQT_ASCII_CAST_WARNINGS -DQT_CORE_LIB -DQT_DEPRECATED_WARNINGS 
-DQT_DISABLE_DEPRECATED_BEFORE=0x05 -DQT_GUI_LIB -DQT_NETWORK_LIB 
-DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_DYNAMIC_CAST -DQT_NO_EXCEPTIONS 
-DQT_POSITIONING_LIB -DQT_QML_LIB -DQT_QUICK_LIB -DQT_SENSORS_LIB 
-DQT_USE_QSTRINGBUILDER -DQT_WEBCHANNEL_LIB 
-DSTATICALLY_LINKED_WITH_JavaScriptCore -DSTATICALLY_LINKED_WITH_WTF 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/release/Source/WebKit2
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/release/Source/WebKit2/WebKit2_autogen/include
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/JavaScriptCore/llint
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/DatabaseProcess
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/DatabaseProcess/IndexedDB
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/NetworkProcess
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/NetworkProcess/CustomProtocols
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/NetworkProcess/Downloads
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/NetworkProcess/FileAPI
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/NetworkProcess/cache
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Platform
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Platform/IPC
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/PluginProcess
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/API
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/API/c
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/Authentication
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/CoreIPCSupport
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/Databases
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/Databases/IndexedDB
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/FileAPI
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/Plugins
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/Plugins/Netscape
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/Plugins/Netscape/x11
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/Shared/WebsiteData
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-5.212.0-alpha2/Source/WebKit2/UIProcess
 
-I/tmp/guix-build-qtwebkit-5.212.0-alpha2.drv-0/qtwebkit-

Re: "calibre" package fails to build.

2018-07-21 Thread Efraim Flashner 
On Sat, Jul 21, 2018 at 08:48:22PM +0200, Andreas Enge wrote:
> On Sat, Jul 21, 2018 at 09:38:30PM +0300, Efraim Flashner wrote:
> > I see a new version of Calibre was just pushed to master, does that
> > build as expected?
> 
> Yes and no; it builds, but then using it fails with
> ...
>   File 
> "/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/comments_editor.py",
>  line 17, in 
> from PyQt5.QtWebKitWidgets import QWebView, QWebPage
> ImportError: No module named QtWebKitWidgets
> 
> Gentoo moved to a new snapshot of qtwebkit:
>
> https://forums.gentoo.org/viewtopic-p-8226560.html?sid=cdd617a96f698cdc99a6156a22a4a54f
> They claim this solved their problems.
> 
> The current git server of qtwebkit is here:
>https://code.qt.io/cgit/qt/qtwebkit.git
> 
> I am downloading version 5.212.0-alpha2 from here:
>https://github.com/annulen/webkit/releases
> and will give it a try.
> 
> Andreas
> 

I see, debian moved to the same source. I am worried though that that
repo hasn't seen any action in 6 months.

-- 
Efraim Flashner  אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted


signature.asc
Description: PGP signature

Re: "calibre" package fails to build.

2018-07-21 Thread Andreas Enge 
On Sat, Jul 21, 2018 at 09:38:30PM +0300, Efraim Flashner wrote:
> I see a new version of Calibre was just pushed to master, does that
> build as expected?

Yes and no; it builds, but then using it fails with
...
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/comments_editor.py",
 line 17, in 
from PyQt5.QtWebKitWidgets import QWebView, QWebPage
ImportError: No module named QtWebKitWidgets

Gentoo moved to a new snapshot of qtwebkit:
   
https://forums.gentoo.org/viewtopic-p-8226560.html?sid=cdd617a96f698cdc99a6156a22a4a54f
They claim this solved their problems.

The current git server of qtwebkit is here:
   https://code.qt.io/cgit/qt/qtwebkit.git

I am downloading version 5.212.0-alpha2 from here:
   https://github.com/annulen/webkit/releases
and will give it a try.

Andreas

Re: "calibre" package fails to build.

2018-07-21 Thread Efraim Flashner 
On Sat, Jul 21, 2018 at 08:13:58PM +0200, Andreas Enge wrote:
> On Sat, Jul 21, 2018 at 07:32:03PM +0200, Andreas Enge wrote:
> > So this needs to be corrected with respect to the disappearance of
> > QtWebKitWidgets from Qt, I will have a look now.
> 
> This is due to the following commit:
> 
> commit c0e7a52996edf75a403ef6c454072271fd1c277a
> Author: Efraim Flashner 
> Date:   Mon Jun 4 10:48:55 2018 +0300
> 
> gnu: python-pyqt: Update to 5.10.1.
> 
> * gnu/packages/qt.scm (python-pyqt): Update to 5.10.1.
> [inputs]: Remove qtwebkit.
> [arguments]: Add custom phase to fix compilation with Qt 5.11.
> 
> 
> I tried adding qtwebkit (which is in version 5.9.1) to the python-pyqt
> inputs again, but then compilation of python-pyqt fails with the following
> error:
> make[1]: Entering directory 
> '/tmp/guix-build-python-pyqt-5.10.1.drv-0/PyQt5_gpl-5.10.1/QtWebKitWidgets'
> g++ -c -pipe -O2 -std=gnu++11 -fno-exceptions -Wall -W -D_REENTRANT -fPIC 
> -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG 
> -DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB 
> -DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem 
> /gnu/store/gx7gjwr05gzbh7f2kwbwhbxrh27hvgk8-python-3.6.5/include/python3.6m 
> -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5 
> -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKitWidgets
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5 
> -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtPrintSupport
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtWidgets
>  -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKit
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtGui 
> -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtNetwork
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtCore 
> -I. -isystem 
> /gnu/store/n97v4mfg9dmi4ki5ijnqyvlkhd8a44zp-libdrm-2.4.92/include/libdrm 
> -I/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/lib/qt5/mkspecs/linux-g++
>  -o sipQtWebKitWidgetsQGraphicsWebView.o 
> sipQtWebKitWidgetsQGraphicsWebView.cpp
> g++ -c -pipe -O2 -std=gnu++11 -fno-exceptions -Wall -W -D_REENTRANT -fPIC 
> -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG 
> -DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB 
> -DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem 
> /gnu/store/gx7gjwr05gzbh7f2kwbwhbxrh27hvgk8-python-3.6.5/include/python3.6m 
> -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5 
> -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKitWidgets
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5 
> -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtPrintSupport
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtWidgets
>  -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKit
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtGui 
> -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtNetwork
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtCore 
> -I. -isystem 
> /gnu/store/n97v4mfg9dmi4ki5ijnqyvlkhd8a44zp-libdrm-2.4.92/include/libdrm 
> -I/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/lib/qt5/mkspecs/linux-g++
>  -o sipQtWebKitWidgetsQList0101QWebFrame.o 
> sipQtWebKitWidgetsQList0101QWebFrame.cpp
> g++ -c -pipe -O2 -std=gnu++11 -fno-exceptions -Wall -W -D_REENTRANT -fPIC 
> -DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG 
> -DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB 
> -DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem 
> /gnu/store/gx7gjwr05gzbh7f2kwbwhbxrh27hvgk8-python-3.6.5/include/python3.6m 
> -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5 
> -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKitWidgets
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5 
> -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtPrintSupport
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtWidgets
>  -isystem 
> /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKit
>  -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtGui 
> -isystem 
> /gnu/store/4jpvg4rqfjpyj5rjpm6aid351

Re: bug#24404: "calibre" package fails to build.

2018-07-21 Thread Andreas Enge 
On Sat, Jul 21, 2018 at 08:13:58PM +0200, Andreas Enge wrote:
> Interestingly enough, there is a commit in Calibre which claims to work
> on Qt 5.11 compatibility:
>
> https://github.com/kovidgoyal/calibre/commit/68bbec179abc980ebcb3f13854d2e4fd46f4897c
> So the Calibre author apparently has managed to put it all together.

Well, he is simply using pyqt-5.8:
   https://github.com/kovidgoyal/build-calibre/blob/master/scripts/sources.json
(grep for "pyqt").

So what can we do? Add the previous version of pyqt with qtwebkit back?

Andreas

Re: "calibre" package fails to build.

2018-07-21 Thread Andreas Enge 
On Sat, Jul 21, 2018 at 07:32:03PM +0200, Andreas Enge wrote:
> So this needs to be corrected with respect to the disappearance of
> QtWebKitWidgets from Qt, I will have a look now.

This is due to the following commit:

commit c0e7a52996edf75a403ef6c454072271fd1c277a
Author: Efraim Flashner 
Date:   Mon Jun 4 10:48:55 2018 +0300

gnu: python-pyqt: Update to 5.10.1.

* gnu/packages/qt.scm (python-pyqt): Update to 5.10.1.
[inputs]: Remove qtwebkit.
[arguments]: Add custom phase to fix compilation with Qt 5.11.


I tried adding qtwebkit (which is in version 5.9.1) to the python-pyqt
inputs again, but then compilation of python-pyqt fails with the following
error:
make[1]: Entering directory 
'/tmp/guix-build-python-pyqt-5.10.1.drv-0/PyQt5_gpl-5.10.1/QtWebKitWidgets'
g++ -c -pipe -O2 -std=gnu++11 -fno-exceptions -Wall -W -D_REENTRANT -fPIC 
-DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG 
-DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB 
-DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem 
/gnu/store/gx7gjwr05gzbh7f2kwbwhbxrh27hvgk8-python-3.6.5/include/python3.6m 
-isystem /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5 
-isystem 
/gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKitWidgets
 -isystem /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtPrintSupport
 -isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtWidgets 
-isystem 
/gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKit 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtGui 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtNetwork 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtCore 
-I. -isystem 
/gnu/store/n97v4mfg9dmi4ki5ijnqyvlkhd8a44zp-libdrm-2.4.92/include/libdrm 
-I/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/lib/qt5/mkspecs/linux-g++
 -o sipQtWebKitWidgetsQGraphicsWebView.o sipQtWebKitWidgetsQGraphicsWebView.cpp
g++ -c -pipe -O2 -std=gnu++11 -fno-exceptions -Wall -W -D_REENTRANT -fPIC 
-DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG 
-DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB 
-DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem 
/gnu/store/gx7gjwr05gzbh7f2kwbwhbxrh27hvgk8-python-3.6.5/include/python3.6m 
-isystem /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5 
-isystem 
/gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKitWidgets
 -isystem /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtPrintSupport
 -isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtWidgets 
-isystem 
/gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKit 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtGui 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtNetwork 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtCore 
-I. -isystem 
/gnu/store/n97v4mfg9dmi4ki5ijnqyvlkhd8a44zp-libdrm-2.4.92/include/libdrm 
-I/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/lib/qt5/mkspecs/linux-g++
 -o sipQtWebKitWidgetsQList0101QWebFrame.o 
sipQtWebKitWidgetsQList0101QWebFrame.cpp
g++ -c -pipe -O2 -std=gnu++11 -fno-exceptions -Wall -W -D_REENTRANT -fPIC 
-DSIP_PROTECTED_IS_PUBLIC -Dprotected=public -DQT_NO_EXCEPTIONS -DQT_NO_DEBUG 
-DQT_PLUGIN -DQT_WEBKITWIDGETS_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB 
-DQT_WEBKIT_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I. -I. -isystem 
/gnu/store/gx7gjwr05gzbh7f2kwbwhbxrh27hvgk8-python-3.6.5/include/python3.6m 
-isystem /gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5 
-isystem 
/gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKitWidgets
 -isystem /gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtPrintSupport
 -isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtWidgets 
-isystem 
/gnu/store/dmb48z3jd4d2axngkgy7x279sk21js1n-qtwebkit-5.9.1/include/qt5/QtWebKit 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtGui 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtNetwork 
-isystem 
/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-qtbase-5.11.0/include/qt5/QtCore 
-I. -isystem 
/gnu/store/n97v4mfg9dmi4ki5ijnqyvlkhd8a44zp-libdrm-2.4.92/include/libdrm 
-I/gnu/store/4jpvg4rqfjpyj5rjpm6aid35145yfpzg-

Re: "calibre" package fails to build.

2018-07-21 Thread Andreas Enge 
Hello Matthew,

On Thu, Jun 28, 2018 at 05:01:55PM -0500, Matthew Brooks wrote:
> It's also several versions out of date, according to the website. Which lists 
> 3.26.1 as the latest version, while 3.17 is the latest in the guix repo:
> https://calibre-ebook.com/whats-new
> (This might be the cause of the error, since I remember reading that calibre 
> is tightly bound to specific versions of QT, but I don't have the link to the 
> forum post it was in.)

I just updated our package to the most recent one, 3.28.0, and it now
builds. However, I forgot to test it, and running it fails with
Traceback (most recent call last):
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/bin/.calibre-real", 
line 20, in 
sys.exit(calibre())
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui_launch.py",
 line 74, in calibre
main(args)
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/main.py",
 line 567, in main
gui_debug=gui_debug)
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/main.py",
 line 396, in run_gui
from calibre.gui2.ui import Main
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/ui.py",
 line 43, in 
from calibre.gui2.init import LibraryViewMixin, LayoutMixin
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/init.py",
 line 19, in 
from calibre.gui2.library.views import BooksView, DeviceBooksView
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/library/views.py",
 line 19, in 
from calibre.gui2.library.delegates import (RatingDelegate, PubDateDelegate,
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/library/delegates.py",
 line 24, in 
from calibre.gui2.dialogs.comments_dialog import CommentsDialog, 
PlainTextDialog
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/dialogs/comments_dialog.py",
 line 9, in 
from calibre.gui2.dialogs.comments_dialog_ui import Ui_CommentsDialog
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/dialogs/comments_dialog_ui.py",
 line 40, in 
from calibre.gui2.comments_editor import Editor
  File 
"/gnu/store/brj5xv8zqa1w7byz8b1fz0fd1hmy3kd4-calibre-3.28.0/lib/calibre/calibre/gui2/comments_editor.py",
 line 17, in 
from PyQt5.QtWebKitWidgets import QWebView, QWebPage
ImportError: No module named QtWebKitWidgets

So this needs to be corrected with respect to the disappearance of
QtWebKitWidgets from Qt, I will have a look now. (So far, I think there
is no point in reverting the commit to get back from a non-working to
a non-compiling calibre...)

Andreas

"calibre" package fails to build.

2018-06-28 Thread Matthew Brooks 
It's also several versions out of date, according to the website. Which lists 
3.26.1 as the latest version, while 3.17 is the latest in the guix repo:
https://calibre-ebook.com/whats-new
(This might be the cause of the error, since I remember reading that calibre is 
tightly bound to specific versions of QT, but I don't have the link to the 
forum post it was in.)

The actual error appears to be the following snippet of the output, but I've 
got the entire output piped to a file if anyone needs it.

>In file included from 
>/gnu/store/kjzfprjsjgyi2y7ybs7rinaac7gziabb-qtbase-5.11.0/include/qt5/QtGui/qtguiglobal.h:43:0,
> from 
> /gnu/store/kjzfprjsjgyi2y7ybs7rinaac7gziabb-qtbase-5.11.0/include/qt5/QtGui/5.11.0/QtGui/qpa/qplatformfontdatabase.h:52,
> from 
> /tmp/guix-build-calibre-3.17.0.drv-0/calibre-3.17.0/src/calibre/headless/fontconfig_database.h:9,
> from 
> /tmp/guix-build-calibre-3.17.0.drv-0/calibre-3.17.0/src/calibre/headless/fontconfig_database.cpp:40:
>/tmp/guix-build-calibre-3.17.0.drv-0/calibre-3.17.0/src/calibre/headless/fontconfig_database.cpp:296:1:
> error: static assertion failed: sizeof specialLanguages / sizeof 
>*specialLanguages == QChar::ScriptCount
> Q_STATIC_ASSERT(sizeof specialLanguages / sizeof *specialLanguages == 
> QChar::ScriptCount);
> ^
>make: *** [Makefile:337: fontconfig_database.o] Error 1


pgpMgp8GQvj8E.pgp
Description: OpenPGP digital signature