Re: Test fail

[Ludovic Courtès]

Hello,

Gábor Boskovits  skribis:

> Ludovic Courtès  ezt írta (időpont: 2018. márc. 30., P 18:39):
>
>> Hi Maria,
>>
>> Thanks for your report.  In practice you can safely ignore this test
>> failure.  We had a similar report earlier that this fails on Ubuntu:
>> .
>>
>> Something we should do, though, is to at least skip the test when we
>> know we’re using a faulty kernel.  Currently we already have:
>>
>>   ;; XXX: Skip this test when running Linux > 4.7.5 to work around
>>   ;; .
>>   (when (or (not perform-container-tests?)
>> (version>? (utsname:release (uname)) "4.7.5"))
>> (test-skip 1))
>>
>> Gábor, given what you wrote about Ubuntu’s 4.4 kernel, should we
>> explicitly flag “4.4.0-116-generic” in a similar way?  Would it be
>> enough?
>>
>>
>>
> Yes, it seems that would be enough.
> We also have this "4.4.0-21-generic" for not x86.

OK, done.

As time passes, this test can no longer run given the constraints
above.  We should probably rethink it…

> Alternatively we can point Ubuntu users to the LTSEnablementStack.
> This provides a 4.8 kernel since 16.04.2. (feb. 2017.)

Yeah, well, no big deal.

Thanks,
Ludo’.

Re: Test fail

[Gábor Boskovits]

Ludovic Courtès  ezt írta (időpont: 2018. márc. 30., P 18:39):

> Hi Maria,
>
> Thanks for your report.  In practice you can safely ignore this test
> failure.  We had a similar report earlier that this fails on Ubuntu:
> .
>
> Something we should do, though, is to at least skip the test when we
> know we’re using a faulty kernel.  Currently we already have:
>
>   ;; XXX: Skip this test when running Linux > 4.7.5 to work around
>   ;; .
>   (when (or (not perform-container-tests?)
> (version>? (utsname:release (uname)) "4.7.5"))
> (test-skip 1))
>
> Gábor, given what you wrote about Ubuntu’s 4.4 kernel, should we
> explicitly flag “4.4.0-116-generic” in a similar way?  Would it be
> enough?
>
>
>
Yes, it seems that would be enough.
We also have this "4.4.0-21-generic" for not x86.

Alternatively we can point Ubuntu users to the LTSEnablementStack.
This provides a 4.8 kernel since 16.04.2. (feb. 2017.)


> Thank you both!
>
> Ludo’.
>

Re: Test fail

[Ludovic Courtès]

Hi Maria,

Thanks for your report.  In practice you can safely ignore this test
failure.  We had a similar report earlier that this fails on Ubuntu:
.

Something we should do, though, is to at least skip the test when we
know we’re using a faulty kernel.  Currently we already have:

  ;; XXX: Skip this test when running Linux > 4.7.5 to work around
  ;; .
  (when (or (not perform-container-tests?)
(version>? (utsname:release (uname)) "4.7.5"))
(test-skip 1))

Gábor, given what you wrote about Ubuntu’s 4.4 kernel, should we
explicitly flag “4.4.0-116-generic” in a similar way?  Would it be
enough?

Thank you both!

Ludo’.

Re: Test fail

[Maria Sidorova]

On 29.03.2018 15:51, Gábor Boskovits wrote:
2018-03-29 14:46 GMT+02:00 Maria Sidorova >:




On 29.03.2018 09:17, Gábor Boskovits wrote:

2018-03-28 15:51 GMT+02:00 Gábor Boskovits  >>:

     2018-03-28 8:36 GMT+02:00 Maria Sidorova

     >>:



         On 28.03.2018 09:33, Gábor Boskovits wrote:

             2018-03-27 23:34 GMT+02:00 Maria Sidorova
             
>
              
     >
     in our bug tracker that might be affecting you, or the
shared mounts
     I noticed much later. I'm going to investigate this and
report back.


I've created a vm image with a current Ubuntu 16.04 yesterday,
installed
the guix 

Re: Test fail

[Maria Sidorova]

On 29.03.2018 09:17, Gábor Boskovits wrote:
2018-03-28 15:51 GMT+02:00 Gábor Boskovits >:


2018-03-28 8:36 GMT+02:00 Maria Sidorova >:



On 28.03.2018 09:33, Gábor Boskovits wrote:

2018-03-27 23:34 GMT+02:00 Maria Sidorova

>>:


     Hello,

     Running the test suite (`make check`) gives me one of
the tests failed.

     This is from test-suite.log

     test-name: pivot-root
     location: /home/masha/src/guix/tests/syscalls.scm:156
     source:
     + (test-equal
     +   "pivot-root"
     +   #t
     +   (match (pipe)
     +          ((in . out)
     +           (match (clone (logior CLONE_NEWUSER
CLONE_NEWNS SIGCHLD))
     +                  (0
     +                   (dynamic-wind
     +                     (const #t)
     +                     (lambda ()
     +                       (close in)
     +                       (call-with-temporary-directory
     +                         (lambda (root)
     +                           (let ((put-old
(string-append root
     "/real-root")))
     +                             (mount "none" root "tmpfs")
     +                             (mkdir put-old)
     +                             (call-with-output-file
     +                               (string-append root
"/test")
     +                               (lambda (port) (display
"testing\n"
     port)))
     +                             (pivot-root root put-old)
     +                             (write (file-exists?
"/test") out)
     +                             (close out)
     +                     (lambda () (primitive-exit 0
     +                  (pid (close out)
     +                       (let ((result (read in)))
     +                         (close in)
     +                         (and (zero? (match (waitpid pid)
     +                                            ((_ . status)
     +   
  (status:exit-val

     status
     +                              (eq? #t result
     expected-value: #t
     actual-value: #f
     result: FAIL


     The summary is:
     # TOTAL: 777
     # PASS:  772
     # SKIP:  4
     # XFAIL: 0
     # FAIL:  1
     # XPASS: 0
     # ERROR: 0

     I'm novice in Guix, can anyone give me a clue?


Actually there are two possibilities. I'm trying to narrow this down
now.
There is a bug:https://bugzilla.kernel.org/show_bug.cgi?id=183461

in our bug tracker that might be affecting you, or the shared mounts
I noticed much later. I'm going to investigate this and report back.


I've created a vm image with a current Ubuntu 16.04 yesterday, installed
the guix binary tarball, and did a make check in a guix environment guix.
This error was not shown in my case.

My uname -r is:
  4.10.0-28-generic

This test should be skipped, if kernel version > 4.7.5.
Can you please send the output of uname -r ?


4.4.0-116-generic

Re: Test fail

[Maria Sidorova]

On 28.03.2018 09:33, Gábor Boskovits wrote:
2018-03-27 23:34 GMT+02:00 Maria Sidorova >:


Hello,

Running the test suite (`make check`) gives me one of the tests failed.

This is from test-suite.log

test-name: pivot-root
location: /home/masha/src/guix/tests/syscalls.scm:156
source:
+ (test-equal
+   "pivot-root"
+   #t
+   (match (pipe)
+          ((in . out)
+           (match (clone (logior CLONE_NEWUSER CLONE_NEWNS SIGCHLD))
+                  (0
+                   (dynamic-wind
+                     (const #t)
+                     (lambda ()
+                       (close in)
+                       (call-with-temporary-directory
+                         (lambda (root)
+                           (let ((put-old (string-append root
"/real-root")))
+                             (mount "none" root "tmpfs")
+                             (mkdir put-old)
+                             (call-with-output-file
+                               (string-append root "/test")
+                               (lambda (port) (display "testing\n"
port)))
+                             (pivot-root root put-old)
+                             (write (file-exists? "/test") out)
+                             (close out)
+                     (lambda () (primitive-exit 0
+                  (pid (close out)
+                       (let ((result (read in)))
+                         (close in)
+                         (and (zero? (match (waitpid pid)
+                                            ((_ . status)
+                                             (status:exit-val
status
+                              (eq? #t result
expected-value: #t
actual-value: #f
result: FAIL


The summary is:
# TOTAL: 777
# PASS:  772
# SKIP:  4
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

I'm novice in Guix, can anyone give me a clue?


Can you please write the type of system you are building guix on?
We recently discovered that on systemd based systems pivot-root
might fail because of shared mountpoints.


Ubuntu 16.04 (64)

Re: Test fail

[Gábor Boskovits]

2018-03-27 23:34 GMT+02:00 Maria Sidorova :

> Hello,
>
> Running the test suite (`make check`) gives me one of the tests failed.
>
> This is from test-suite.log
>
> test-name: pivot-root
> location: /home/masha/src/guix/tests/syscalls.scm:156
> source:
> + (test-equal
> +   "pivot-root"
> +   #t
> +   (match (pipe)
> +  ((in . out)
> +   (match (clone (logior CLONE_NEWUSER CLONE_NEWNS SIGCHLD))
> +  (0
> +   (dynamic-wind
> + (const #t)
> + (lambda ()
> +   (close in)
> +   (call-with-temporary-directory
> + (lambda (root)
> +   (let ((put-old (string-append root
> "/real-root")))
> + (mount "none" root "tmpfs")
> + (mkdir put-old)
> + (call-with-output-file
> +   (string-append root "/test")
> +   (lambda (port) (display "testing\n" port)))
> + (pivot-root root put-old)
> + (write (file-exists? "/test") out)
> + (close out)
> + (lambda () (primitive-exit 0
> +  (pid (close out)
> +   (let ((result (read in)))
> + (close in)
> + (and (zero? (match (waitpid pid)
> +((_ . status)
> + (status:exit-val status
> +  (eq? #t result
> expected-value: #t
> actual-value: #f
> result: FAIL
>
>
> The summary is:
> # TOTAL: 777
> # PASS:  772
> # SKIP:  4
> # XFAIL: 0
> # FAIL:  1
> # XPASS: 0
> # ERROR: 0
>
> I'm novice in Guix, can anyone give me a clue?
>
>
Can you please write the type of system you are building guix on?
We recently discovered that on systemd based systems pivot-root
might fail because of shared mountpoints.


> Thanks,
> Maria.
>
>