Re: [hibernate-dev] [ORM] Reducing startup log verbosity
Yeah sure, they will be kept as is just moved to DEBUG. The only one that would change is the "Processing PersistenceUnitInfo" thing: we will remove the INFO one and keep the more detailed DEBUG one. BTW, I agree with everything Steve said, sorry for not replying earlier. On Mon, Jan 7, 2019 at 4:46 PM Chris Cranford wrote: > See below. > > On 1/3/19 10:29 AM, Steve Ebersole wrote: > > [o.h.d.Dialect] (main) HHH000400: Using dialect: > >> org.hibernate.dialect.PostgreSQL95Dialect > >> > >> -> wondering if it has any value to log the dialect? I mean if you don't > >> use the right one, you will definitely have some issues. > >> > > True, but it is probably hard(er) to interpret the true source of the > > issues later on. > > > > However, I think it is reasonable to make this DEBUG. If you have > problems > > the first reasonable thing to do is to crank logging to DEBUG if not > TRACE. > > I completely agree. > > I think its reasonable to make it DEBUG/TRACE but I don't think I want > to necessarily change it such that it is no longer included in log > output at all. Having it be included is a good first-line of defense on > trying to resolve potential problems not only for us, but even for users > who are doing their own debugging before reporting an issue; > particularly if the error in question implies some Dialect configuration > problem. > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] [ORM] Reducing startup log verbosity
See below. On 1/3/19 10:29 AM, Steve Ebersole wrote: > [o.h.d.Dialect] (main) HHH000400: Using dialect: >> org.hibernate.dialect.PostgreSQL95Dialect >> >> -> wondering if it has any value to log the dialect? I mean if you don't >> use the right one, you will definitely have some issues. >> > True, but it is probably hard(er) to interpret the true source of the > issues later on. > > However, I think it is reasonable to make this DEBUG. If you have problems > the first reasonable thing to do is to crank logging to DEBUG if not TRACE. I completely agree. I think its reasonable to make it DEBUG/TRACE but I don't think I want to necessarily change it such that it is no longer included in log output at all. Having it be included is a good first-line of defense on trying to resolve potential problems not only for us, but even for users who are doing their own debugging before reporting an issue; particularly if the error in question implies some Dialect configuration problem. ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] inSession / inTransaction
I have no objections to exposing them directly rather than being part of
the test infrastructure.
On 12/20/18 5:16 PM, Steve Ebersole wrote:
> On Thu, Dec 20, 2018 at 1:33 PM Gunnar Morling wrote:
>
>> Hey,
>>
>> When discussing this before, there were some doubts about its actual
>> usefulness in non-testing, real-world code. E.g. you'd typically
>> interact with multiple DAOs/repositories etc. and would have to
>> somehow pass the session to each of them.
>>
> I've written many non-trivial apps in my past that did not use
> "DAO/repositories" etc. Not sure why we'd choose to not implement
> something that is useful just because not everyone would use it. To me, if
> something is repeatedly useful in writing tests... it tends to be
> more-or-less generally useful.
>
>
> One other thought is that inTransaction() should allow to return a result
>> value.
>>
> An over-loaded form perhaps, yes I can see that - but non-returning is
> valid as well. So maybe:
>
> public interface SessionFactory ... {
> ...
> void inSession(Consumer action);
> void inTransaction(Consumer action);
> void inTransaction(Session session, Consumer action);
>
> T inSession(Function action);
> T inTransaction(Function action);
> T inTransaction(Session session, Function action);
> }
>
> and
>
> public interface Session ... {
> void inTransaction(Consumer action);
>
> T inTransaction(Function action);
> }
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
[hibernate-dev] Hibernate Validator 6.0.14.Final
Hi, We just released Hibernate Validator 6.0.14.Final to fix an important issue reported by one of our users. This update is highly recommended and contains just a fix for this issue (+ a fix for the Dutch translation and an upgrade to WildFly 15 and 14.0.1 for the WildFly patches we generate). More information in the announcement: http://in.relation.to/2019/01/07/hibernate-validator-6014-final-out/ . Have a nice day. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
