[hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
Hi, There were lots of differences in the compatibility report, so as a first step, I've excluded packages/classes that I considered SPI, internal, or "grey area". This reduced the the differences to a more manageable amount. You can see a summary of the incompatibilities along with suggested mitigation at [1]. The report is attached to [1], along with a zip with instructions for running the report. I believe there are some "false positives" in the report, and I have documented them in the section, "False Positives?". Feel free to comment on the article. Thanks, Gail [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilityBetween51And53 ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
I've moved the document to https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw . Please let me know if you need an invite to view the document. The attachments are still at https://developer.jboss.org/wiki/ HibernateORMBinaryCompatibilityBetween51And53. Regards, Gail On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner wrote: > Hi, > > There were lots of differences in the compatibility report, so as a first > step, I've excluded packages/classes that I considered SPI, internal, or > "grey area". This reduced the the differences to a more manageable amount. > > You can see a summary of the incompatibilities along with suggested > mitigation at [1]. > > The report is attached to [1], along with a zip with instructions for > running the report. > > I believe there are some "false positives" in the report, and I have > documented them in the section, "False Positives?". > > Feel free to comment on the article. > > Thanks, > Gail > > [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit > yBetween51And53 > > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
Thanks Gail, great job! I fixed a trivial one, just a thousand to go ;) On 16 March 2018 at 23:09, Gail Badner wrote: > I've moved the document to > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw > . > > Please let me know if you need an invite to view the document. > > The attachments are still at https://developer.jboss.org/wiki/ > HibernateORMBinaryCompatibilityBetween51And53. > > Regards, > Gail > > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner wrote: > >> Hi, >> >> There were lots of differences in the compatibility report, so as a first >> step, I've excluded packages/classes that I considered SPI, internal, or >> "grey area". This reduced the the differences to a more manageable amount. >> >> You can see a summary of the incompatibilities along with suggested >> mitigation at [1]. >> >> The report is attached to [1], along with a zip with instructions for >> running the report. >> >> I believe there are some "false positives" in the report, and I have >> documented them in the section, "False Positives?". >> >> Feel free to comment on the article. >> >> Thanks, >> Gail >> >> [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit >> yBetween51And53 >> >> > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
Yes there were "lots of differences" but a vast majority of them are false-positives, not just those listed in the already massive "false positives" section. I've been going through the non-"false positive" section and "resolving" specific items (via strike-through) with either (1) link to Jira fixing it or (2) comment as to the reason I believe it is a false-positive. I did not bother striking through the "false positives" section. At this point there are very few unresolved items in this list. Those items require more discussion On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero wrote: > Thanks Gail, great job! > I fixed a trivial one, just a thousand to go ;) > > On 16 March 2018 at 23:09, Gail Badner wrote: > > I've moved the document to > > > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw > > . > > > > Please let me know if you need an invite to view the document. > > > > The attachments are still at https://developer.jboss.org/wiki/ > > HibernateORMBinaryCompatibilityBetween51And53. > > > > Regards, > > Gail > > > > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner > wrote: > > > >> Hi, > >> > >> There were lots of differences in the compatibility report, so as a > first > >> step, I've excluded packages/classes that I considered SPI, internal, or > >> "grey area". This reduced the the differences to a more manageable > amount. > >> > >> You can see a summary of the incompatibilities along with suggested > >> mitigation at [1]. > >> > >> The report is attached to [1], along with a zip with instructions for > >> running the report. > >> > >> I believe there are some "false positives" in the report, and I have > >> documented them in the section, "False Positives?". > >> > >> Feel free to comment on the article. > >> > >> Thanks, > >> Gail > >> > >> [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit > >> yBetween51And53 > >> > >> > > ___ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
To make sure all the noise form "false positives" won't get us to miss something, someone knows an alternative tool which can do better? Thanks, Sanne On 22 March 2018 at 14:22, Steve Ebersole wrote: > Yes there were "lots of differences" but a vast majority of them are > false-positives, not just those listed in the already massive "false > positives" section. I've been going through the non-"false positive" > section and "resolving" specific items (via strike-through) with either (1) > link to Jira fixing it or (2) comment as to the reason I believe it is a > false-positive. > > I did not bother striking through the "false positives" section. > > At this point there are very few unresolved items in this list. Those items > require more discussion > > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero wrote: >> >> Thanks Gail, great job! >> I fixed a trivial one, just a thousand to go ;) >> >> On 16 March 2018 at 23:09, Gail Badner wrote: >> > I've moved the document to >> > >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw >> > . >> > >> > Please let me know if you need an invite to view the document. >> > >> > The attachments are still at https://developer.jboss.org/wiki/ >> > HibernateORMBinaryCompatibilityBetween51And53. >> > >> > Regards, >> > Gail >> > >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner >> > wrote: >> > >> >> Hi, >> >> >> >> There were lots of differences in the compatibility report, so as a >> >> first >> >> step, I've excluded packages/classes that I considered SPI, internal, >> >> or >> >> "grey area". This reduced the the differences to a more manageable >> >> amount. >> >> >> >> You can see a summary of the incompatibilities along with suggested >> >> mitigation at [1]. >> >> >> >> The report is attached to [1], along with a zip with instructions for >> >> running the report. >> >> >> >> I believe there are some "false positives" in the report, and I have >> >> documented them in the section, "False Positives?". >> >> >> >> Feel free to comment on the article. >> >> >> >> Thanks, >> >> Gail >> >> >> >> [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit >> >> yBetween51And53 >> >> >> >> >> > ___ >> > hibernate-dev mailing list >> > hibernate-dev@lists.jboss.org >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
Not sure. animal-sniffer is the other one I know, but not sure it would be better. On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero wrote: > To make sure all the noise form "false positives" won't get us to miss > something, someone knows an alternative tool which can do better? > > Thanks, > Sanne > > > On 22 March 2018 at 14:22, Steve Ebersole wrote: > > Yes there were "lots of differences" but a vast majority of them are > > false-positives, not just those listed in the already massive "false > > positives" section. I've been going through the non-"false positive" > > section and "resolving" specific items (via strike-through) with either > (1) > > link to Jira fixing it or (2) comment as to the reason I believe it is a > > false-positive. > > > > I did not bother striking through the "false positives" section. > > > > At this point there are very few unresolved items in this list. Those > items > > require more discussion > > > > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero > wrote: > >> > >> Thanks Gail, great job! > >> I fixed a trivial one, just a thousand to go ;) > >> > >> On 16 March 2018 at 23:09, Gail Badner wrote: > >> > I've moved the document to > >> > > >> > > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw > >> > . > >> > > >> > Please let me know if you need an invite to view the document. > >> > > >> > The attachments are still at https://developer.jboss.org/wiki/ > >> > HibernateORMBinaryCompatibilityBetween51And53. > >> > > >> > Regards, > >> > Gail > >> > > >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner > >> > wrote: > >> > > >> >> Hi, > >> >> > >> >> There were lots of differences in the compatibility report, so as a > >> >> first > >> >> step, I've excluded packages/classes that I considered SPI, internal, > >> >> or > >> >> "grey area". This reduced the the differences to a more manageable > >> >> amount. > >> >> > >> >> You can see a summary of the incompatibilities along with suggested > >> >> mitigation at [1]. > >> >> > >> >> The report is attached to [1], along with a zip with instructions for > >> >> running the report. > >> >> > >> >> I believe there are some "false positives" in the report, and I have > >> >> documented them in the section, "False Positives?". > >> >> > >> >> Feel free to comment on the article. > >> >> > >> >> Thanks, > >> >> Gail > >> >> > >> >> [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit > >> >> yBetween51And53 > >> >> > >> >> > >> > ___ > >> > hibernate-dev mailing list > >> > hibernate-dev@lists.jboss.org > >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev > >> ___ > >> hibernate-dev mailing list > >> hibernate-dev@lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
This tool is usually pretty good; in fact I think it likely that it's the best of its kind. The false positives are really a fairly recent development AFAIK; I don't recall hitting any when I ran it for our EJB changes a year or two ago. It might be a good idea to contribute a fix for the problem upstream; it might even be relatively easy to do. Or it could already be fixed. On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole wrote: > Not sure. animal-sniffer is the other one I know, but not sure it would be > better. > > On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero > wrote: >> >> To make sure all the noise form "false positives" won't get us to miss >> something, someone knows an alternative tool which can do better? >> >> Thanks, >> Sanne >> >> >> On 22 March 2018 at 14:22, Steve Ebersole wrote: >> > Yes there were "lots of differences" but a vast majority of them are >> > false-positives, not just those listed in the already massive "false >> > positives" section. I've been going through the non-"false positive" >> > section and "resolving" specific items (via strike-through) with either >> > (1) >> > link to Jira fixing it or (2) comment as to the reason I believe it is a >> > false-positive. >> > >> > I did not bother striking through the "false positives" section. >> > >> > At this point there are very few unresolved items in this list. Those >> > items >> > require more discussion >> > >> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero >> > wrote: >> >> >> >> Thanks Gail, great job! >> >> I fixed a trivial one, just a thousand to go ;) >> >> >> >> On 16 March 2018 at 23:09, Gail Badner wrote: >> >> > I've moved the document to >> >> > >> >> > >> >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw >> >> > . >> >> > >> >> > Please let me know if you need an invite to view the document. >> >> > >> >> > The attachments are still at https://developer.jboss.org/wiki/ >> >> > HibernateORMBinaryCompatibilityBetween51And53. >> >> > >> >> > Regards, >> >> > Gail >> >> > >> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner >> >> > wrote: >> >> > >> >> >> Hi, >> >> >> >> >> >> There were lots of differences in the compatibility report, so as a >> >> >> first >> >> >> step, I've excluded packages/classes that I considered SPI, >> >> >> internal, >> >> >> or >> >> >> "grey area". This reduced the the differences to a more manageable >> >> >> amount. >> >> >> >> >> >> You can see a summary of the incompatibilities along with suggested >> >> >> mitigation at [1]. >> >> >> >> >> >> The report is attached to [1], along with a zip with instructions >> >> >> for >> >> >> running the report. >> >> >> >> >> >> I believe there are some "false positives" in the report, and I have >> >> >> documented them in the section, "False Positives?". >> >> >> >> >> >> Feel free to comment on the article. >> >> >> >> >> >> Thanks, >> >> >> Gail >> >> >> >> >> >> [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit >> >> >> yBetween51And53 >> >> >> >> >> >> >> >> > ___ >> >> > hibernate-dev mailing list >> >> > hibernate-dev@lists.jboss.org >> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> ___ >> >> hibernate-dev mailing list >> >> hibernate-dev@lists.jboss.org >> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev -- - DML ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
On 22 March 2018 at 15:55, David Lloyd wrote: > This tool is usually pretty good; in fact I think it likely that it's > the best of its kind. The false positives are really a fairly recent > development AFAIK; I don't recall hitting any when I ran it for our > EJB changes a year or two ago. It might be a good idea to contribute > a fix for the problem upstream; it might even be relatively easy to > do. Or it could already be fixed. Good to know, thanks. I might explore that next week. Sanne > > On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole wrote: >> Not sure. animal-sniffer is the other one I know, but not sure it would be >> better. >> >> On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero >> wrote: >>> >>> To make sure all the noise form "false positives" won't get us to miss >>> something, someone knows an alternative tool which can do better? >>> >>> Thanks, >>> Sanne >>> >>> >>> On 22 March 2018 at 14:22, Steve Ebersole wrote: >>> > Yes there were "lots of differences" but a vast majority of them are >>> > false-positives, not just those listed in the already massive "false >>> > positives" section. I've been going through the non-"false positive" >>> > section and "resolving" specific items (via strike-through) with either >>> > (1) >>> > link to Jira fixing it or (2) comment as to the reason I believe it is a >>> > false-positive. >>> > >>> > I did not bother striking through the "false positives" section. >>> > >>> > At this point there are very few unresolved items in this list. Those >>> > items >>> > require more discussion >>> > >>> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero >>> > wrote: >>> >> >>> >> Thanks Gail, great job! >>> >> I fixed a trivial one, just a thousand to go ;) >>> >> >>> >> On 16 March 2018 at 23:09, Gail Badner wrote: >>> >> > I've moved the document to >>> >> > >>> >> > >>> >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw >>> >> > . >>> >> > >>> >> > Please let me know if you need an invite to view the document. >>> >> > >>> >> > The attachments are still at https://developer.jboss.org/wiki/ >>> >> > HibernateORMBinaryCompatibilityBetween51And53. >>> >> > >>> >> > Regards, >>> >> > Gail >>> >> > >>> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner >>> >> > wrote: >>> >> > >>> >> >> Hi, >>> >> >> >>> >> >> There were lots of differences in the compatibility report, so as a >>> >> >> first >>> >> >> step, I've excluded packages/classes that I considered SPI, >>> >> >> internal, >>> >> >> or >>> >> >> "grey area". This reduced the the differences to a more manageable >>> >> >> amount. >>> >> >> >>> >> >> You can see a summary of the incompatibilities along with suggested >>> >> >> mitigation at [1]. >>> >> >> >>> >> >> The report is attached to [1], along with a zip with instructions >>> >> >> for >>> >> >> running the report. >>> >> >> >>> >> >> I believe there are some "false positives" in the report, and I have >>> >> >> documented them in the section, "False Positives?". >>> >> >> >>> >> >> Feel free to comment on the article. >>> >> >> >>> >> >> Thanks, >>> >> >> Gail >>> >> >> >>> >> >> [1] https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit >>> >> >> yBetween51And53 >>> >> >> >>> >> >> >>> >> > ___ >>> >> > hibernate-dev mailing list >>> >> > hibernate-dev@lists.jboss.org >>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev >>> >> ___ >>> >> hibernate-dev mailing list >>> >> hibernate-dev@lists.jboss.org >>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > -- > - DML ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
I just pushed the first round of fixes for this upstream. On Thu, Mar 22, 2018 at 11:00 AM Sanne Grinovero wrote: > On 22 March 2018 at 15:55, David Lloyd wrote: > > This tool is usually pretty good; in fact I think it likely that it's > > the best of its kind. The false positives are really a fairly recent > > development AFAIK; I don't recall hitting any when I ran it for our > > EJB changes a year or two ago. It might be a good idea to contribute > > a fix for the problem upstream; it might even be relatively easy to > > do. Or it could already be fixed. > > Good to know, thanks. I might explore that next week. > > Sanne > > > > > On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole > wrote: > >> Not sure. animal-sniffer is the other one I know, but not sure it > would be > >> better. > >> > >> On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero > >> wrote: > >>> > >>> To make sure all the noise form "false positives" won't get us to miss > >>> something, someone knows an alternative tool which can do better? > >>> > >>> Thanks, > >>> Sanne > >>> > >>> > >>> On 22 March 2018 at 14:22, Steve Ebersole wrote: > >>> > Yes there were "lots of differences" but a vast majority of them are > >>> > false-positives, not just those listed in the already massive "false > >>> > positives" section. I've been going through the non-"false positive" > >>> > section and "resolving" specific items (via strike-through) with > either > >>> > (1) > >>> > link to Jira fixing it or (2) comment as to the reason I believe it > is a > >>> > false-positive. > >>> > > >>> > I did not bother striking through the "false positives" section. > >>> > > >>> > At this point there are very few unresolved items in this list. > Those > >>> > items > >>> > require more discussion > >>> > > >>> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero > > >>> > wrote: > >>> >> > >>> >> Thanks Gail, great job! > >>> >> I fixed a trivial one, just a thousand to go ;) > >>> >> > >>> >> On 16 March 2018 at 23:09, Gail Badner wrote: > >>> >> > I've moved the document to > >>> >> > > >>> >> > > >>> >> > > https://docs.google.com/document/d/1jH0znbYwgvGKHC-110zcjRaXLllBsvRKw-pdHrMzRzw > >>> >> > . > >>> >> > > >>> >> > Please let me know if you need an invite to view the document. > >>> >> > > >>> >> > The attachments are still at https://developer.jboss.org/wiki/ > >>> >> > HibernateORMBinaryCompatibilityBetween51And53. > >>> >> > > >>> >> > Regards, > >>> >> > Gail > >>> >> > > >>> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner > > >>> >> > wrote: > >>> >> > > >>> >> >> Hi, > >>> >> >> > >>> >> >> There were lots of differences in the compatibility report, so > as a > >>> >> >> first > >>> >> >> step, I've excluded packages/classes that I considered SPI, > >>> >> >> internal, > >>> >> >> or > >>> >> >> "grey area". This reduced the the differences to a more > manageable > >>> >> >> amount. > >>> >> >> > >>> >> >> You can see a summary of the incompatibilities along with > suggested > >>> >> >> mitigation at [1]. > >>> >> >> > >>> >> >> The report is attached to [1], along with a zip with instructions > >>> >> >> for > >>> >> >> running the report. > >>> >> >> > >>> >> >> I believe there are some "false positives" in the report, and I > have > >>> >> >> documented them in the section, "False Positives?". > >>> >> >> > >>> >> >> Feel free to comment on the article. > >>> >> >> > >>> >> >> Thanks, > >>> >> >> Gail > >>> >> >> > >>> >> >> [1] > https://developer.jboss.org/wiki/HibernateORMBinaryCompatibilit > >>> >> >> yBetween51And53 > >>> >> >> > >>> >> >> > >>> >> > ___ > >>> >> > hibernate-dev mailing list > >>> >> > hibernate-dev@lists.jboss.org > >>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev > >>> >> ___ > >>> >> hibernate-dev mailing list > >>> >> hibernate-dev@lists.jboss.org > >>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > > > > > -- > > - DML > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
On Thu, Mar 22, 2018 at 4:20 PM, Sanne Grinovero wrote: > To make sure all the noise form "false positives" won't get us to miss > something, someone knows an alternative tool which can do better? > We use this one for HV https://github.com/siom79/japicmp . Not sure it's better though. If not, I'd say the best way to rule out the false positives would be to open issues on the projects and get the fixes integrated there. Of course, it will require some additional effort from us. -- Guillaume ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
I've mostly used Japicmp recently http://siom79.github.io/japicmp/). Works pretty well, but it lacks a way to distinguish between API and SPI, so you'll likely also see "false positives". In fact I thought it's the one you'd be using, but it doesn't seem so from looking at the report attached to that wiki page. 2018-03-22 16:59 GMT+01:00 Sanne Grinovero : > On 22 March 2018 at 15:55, David Lloyd wrote: > > This tool is usually pretty good; in fact I think it likely that it's > > the best of its kind. The false positives are really a fairly recent > > development AFAIK; I don't recall hitting any when I ran it for our > > EJB changes a year or two ago. It might be a good idea to contribute > > a fix for the problem upstream; it might even be relatively easy to > > do. Or it could already be fixed. > > Good to know, thanks. I might explore that next week. > > Sanne > > > > > On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole > wrote: > >> Not sure. animal-sniffer is the other one I know, but not sure it > would be > >> better. > >> > >> On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero > >> wrote: > >>> > >>> To make sure all the noise form "false positives" won't get us to miss > >>> something, someone knows an alternative tool which can do better? > >>> > >>> Thanks, > >>> Sanne > >>> > >>> > >>> On 22 March 2018 at 14:22, Steve Ebersole wrote: > >>> > Yes there were "lots of differences" but a vast majority of them are > >>> > false-positives, not just those listed in the already massive "false > >>> > positives" section. I've been going through the non-"false positive" > >>> > section and "resolving" specific items (via strike-through) with > either > >>> > (1) > >>> > link to Jira fixing it or (2) comment as to the reason I believe it > is a > >>> > false-positive. > >>> > > >>> > I did not bother striking through the "false positives" section. > >>> > > >>> > At this point there are very few unresolved items in this list. > Those > >>> > items > >>> > require more discussion > >>> > > >>> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero > > >>> > wrote: > >>> >> > >>> >> Thanks Gail, great job! > >>> >> I fixed a trivial one, just a thousand to go ;) > >>> >> > >>> >> On 16 March 2018 at 23:09, Gail Badner wrote: > >>> >> > I've moved the document to > >>> >> > > >>> >> > > >>> >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC- > 110zcjRaXLllBsvRKw-pdHrMzRzw > >>> >> > . > >>> >> > > >>> >> > Please let me know if you need an invite to view the document. > >>> >> > > >>> >> > The attachments are still at https://developer.jboss.org/wiki/ > >>> >> > HibernateORMBinaryCompatibilityBetween51And53. > >>> >> > > >>> >> > Regards, > >>> >> > Gail > >>> >> > > >>> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner > > >>> >> > wrote: > >>> >> > > >>> >> >> Hi, > >>> >> >> > >>> >> >> There were lots of differences in the compatibility report, so > as a > >>> >> >> first > >>> >> >> step, I've excluded packages/classes that I considered SPI, > >>> >> >> internal, > >>> >> >> or > >>> >> >> "grey area". This reduced the the differences to a more > manageable > >>> >> >> amount. > >>> >> >> > >>> >> >> You can see a summary of the incompatibilities along with > suggested > >>> >> >> mitigation at [1]. > >>> >> >> > >>> >> >> The report is attached to [1], along with a zip with instructions > >>> >> >> for > >>> >> >> running the report. > >>> >> >> > >>> >> >> I believe there are some "false positives" in the report, and I > have > >>> >> >> documented them in the section, "False Positives?". > >>> >> >> > >>> >> >> Feel free to comment on the article. > >>> >> >> > >>> >> >> Thanks, > >>> >> >> Gail > >>> >> >> > >>> >> >> [1] https://developer.jboss.org/wiki/ > HibernateORMBinaryCompatibilit > >>> >> >> yBetween51And53 > >>> >> >> > >>> >> >> > >>> >> > ___ > >>> >> > hibernate-dev mailing list > >>> >> > hibernate-dev@lists.jboss.org > >>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev > >>> >> ___ > >>> >> hibernate-dev mailing list > >>> >> hibernate-dev@lists.jboss.org > >>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > > > > > -- > > - DML > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
I'm happy to see all the progress on this while I've been occupied with 5.1.13 and some other urgent issues. I hope to have time to get caught up on things later today or tomorrow. On Thu, Mar 22, 2018 at 10:55 AM, Gunnar Morling wrote: > I've mostly used Japicmp recently http://siom79.github.io/japicmp/). Works > pretty well, but it lacks a way to distinguish between API and SPI, so > you'll likely also see "false positives". In fact I thought it's the one > you'd be using, but it doesn't seem so from looking at the report attached > to that wiki page. > > 2018-03-22 16:59 GMT+01:00 Sanne Grinovero : > > > On 22 March 2018 at 15:55, David Lloyd wrote: > > > This tool is usually pretty good; in fact I think it likely that it's > > > the best of its kind. The false positives are really a fairly recent > > > development AFAIK; I don't recall hitting any when I ran it for our > > > EJB changes a year or two ago. It might be a good idea to contribute > > > a fix for the problem upstream; it might even be relatively easy to > > > do. Or it could already be fixed. > > > > Good to know, thanks. I might explore that next week. > > > > Sanne > > > > > > > > On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole > > wrote: > > >> Not sure. animal-sniffer is the other one I know, but not sure it > > would be > > >> better. > > >> > > >> On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero > > > >> wrote: > > >>> > > >>> To make sure all the noise form "false positives" won't get us to > miss > > >>> something, someone knows an alternative tool which can do better? > > >>> > > >>> Thanks, > > >>> Sanne > > >>> > > >>> > > >>> On 22 March 2018 at 14:22, Steve Ebersole > wrote: > > >>> > Yes there were "lots of differences" but a vast majority of them > are > > >>> > false-positives, not just those listed in the already massive > "false > > >>> > positives" section. I've been going through the non-"false > positive" > > >>> > section and "resolving" specific items (via strike-through) with > > either > > >>> > (1) > > >>> > link to Jira fixing it or (2) comment as to the reason I believe it > > is a > > >>> > false-positive. > > >>> > > > >>> > I did not bother striking through the "false positives" section. > > >>> > > > >>> > At this point there are very few unresolved items in this list. > > Those > > >>> > items > > >>> > require more discussion > > >>> > > > >>> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero < > sa...@hibernate.org > > > > > >>> > wrote: > > >>> >> > > >>> >> Thanks Gail, great job! > > >>> >> I fixed a trivial one, just a thousand to go ;) > > >>> >> > > >>> >> On 16 March 2018 at 23:09, Gail Badner > wrote: > > >>> >> > I've moved the document to > > >>> >> > > > >>> >> > > > >>> >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC- > > 110zcjRaXLllBsvRKw-pdHrMzRzw > > >>> >> > . > > >>> >> > > > >>> >> > Please let me know if you need an invite to view the document. > > >>> >> > > > >>> >> > The attachments are still at https://developer.jboss.org/wiki/ > > >>> >> > HibernateORMBinaryCompatibilityBetween51And53. > > >>> >> > > > >>> >> > Regards, > > >>> >> > Gail > > >>> >> > > > >>> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner < > gbad...@redhat.com > > > > > >>> >> > wrote: > > >>> >> > > > >>> >> >> Hi, > > >>> >> >> > > >>> >> >> There were lots of differences in the compatibility report, so > > as a > > >>> >> >> first > > >>> >> >> step, I've excluded packages/classes that I considered SPI, > > >>> >> >> internal, > > >>> >> >> or > > >>> >> >> "grey area". This reduced the the differences to a more > > manageable > > >>> >> >> amount. > > >>> >> >> > > >>> >> >> You can see a summary of the incompatibilities along with > > suggested > > >>> >> >> mitigation at [1]. > > >>> >> >> > > >>> >> >> The report is attached to [1], along with a zip with > instructions > > >>> >> >> for > > >>> >> >> running the report. > > >>> >> >> > > >>> >> >> I believe there are some "false positives" in the report, and I > > have > > >>> >> >> documented them in the section, "False Positives?". > > >>> >> >> > > >>> >> >> Feel free to comment on the article. > > >>> >> >> > > >>> >> >> Thanks, > > >>> >> >> Gail > > >>> >> >> > > >>> >> >> [1] https://developer.jboss.org/wiki/ > > HibernateORMBinaryCompatibilit > > >>> >> >> yBetween51And53 > > >>> >> >> > > >>> >> >> > > >>> >> > ___ > > >>> >> > hibernate-dev mailing list > > >>> >> > hibernate-dev@lists.jboss.org > > >>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > >>> >> ___ > > >>> >> hibernate-dev mailing list > > >>> >> hibernate-dev@lists.jboss.org > > >>> >> https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > > > > > > > > > > -- > > > - DML > > ___ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > >
Re: [hibernate-dev] API differences in Hibernate ORM 5.1 vs 5.3
Definitely. Thanks for doing this On Thu, Mar 22, 2018, 3:25 PM Gail Badner wrote: > I'm happy to see all the progress on this while I've been occupied with > 5.1.13 and some other urgent issues. > > I hope to have time to get caught up on things later today or tomorrow. > > On Thu, Mar 22, 2018 at 10:55 AM, Gunnar Morling > wrote: > > > I've mostly used Japicmp recently http://siom79.github.io/japicmp/). > Works > > pretty well, but it lacks a way to distinguish between API and SPI, so > > you'll likely also see "false positives". In fact I thought it's the one > > you'd be using, but it doesn't seem so from looking at the report > attached > > to that wiki page. > > > > 2018-03-22 16:59 GMT+01:00 Sanne Grinovero : > > > > > On 22 March 2018 at 15:55, David Lloyd wrote: > > > > This tool is usually pretty good; in fact I think it likely that it's > > > > the best of its kind. The false positives are really a fairly recent > > > > development AFAIK; I don't recall hitting any when I ran it for our > > > > EJB changes a year or two ago. It might be a good idea to contribute > > > > a fix for the problem upstream; it might even be relatively easy to > > > > do. Or it could already be fixed. > > > > > > Good to know, thanks. I might explore that next week. > > > > > > Sanne > > > > > > > > > > > On Thu, Mar 22, 2018 at 10:37 AM, Steve Ebersole < > st...@hibernate.org> > > > wrote: > > > >> Not sure. animal-sniffer is the other one I know, but not sure it > > > would be > > > >> better. > > > >> > > > >> On Thu, Mar 22, 2018 at 10:21 AM Sanne Grinovero < > sa...@hibernate.org > > > > > > >> wrote: > > > >>> > > > >>> To make sure all the noise form "false positives" won't get us to > > miss > > > >>> something, someone knows an alternative tool which can do better? > > > >>> > > > >>> Thanks, > > > >>> Sanne > > > >>> > > > >>> > > > >>> On 22 March 2018 at 14:22, Steve Ebersole > > wrote: > > > >>> > Yes there were "lots of differences" but a vast majority of them > > are > > > >>> > false-positives, not just those listed in the already massive > > "false > > > >>> > positives" section. I've been going through the non-"false > > positive" > > > >>> > section and "resolving" specific items (via strike-through) with > > > either > > > >>> > (1) > > > >>> > link to Jira fixing it or (2) comment as to the reason I believe > it > > > is a > > > >>> > false-positive. > > > >>> > > > > >>> > I did not bother striking through the "false positives" section. > > > >>> > > > > >>> > At this point there are very few unresolved items in this list. > > > Those > > > >>> > items > > > >>> > require more discussion > > > >>> > > > > >>> > On Fri, Mar 16, 2018 at 6:37 PM Sanne Grinovero < > > sa...@hibernate.org > > > > > > > >>> > wrote: > > > >>> >> > > > >>> >> Thanks Gail, great job! > > > >>> >> I fixed a trivial one, just a thousand to go ;) > > > >>> >> > > > >>> >> On 16 March 2018 at 23:09, Gail Badner > > wrote: > > > >>> >> > I've moved the document to > > > >>> >> > > > > >>> >> > > > > >>> >> > https://docs.google.com/document/d/1jH0znbYwgvGKHC- > > > 110zcjRaXLllBsvRKw-pdHrMzRzw > > > >>> >> > . > > > >>> >> > > > > >>> >> > Please let me know if you need an invite to view the document. > > > >>> >> > > > > >>> >> > The attachments are still at > https://developer.jboss.org/wiki/ > > > >>> >> > HibernateORMBinaryCompatibilityBetween51And53. > > > >>> >> > > > > >>> >> > Regards, > > > >>> >> > Gail > > > >>> >> > > > > >>> >> > On Fri, Mar 16, 2018 at 12:36 AM, Gail Badner < > > gbad...@redhat.com > > > > > > > >>> >> > wrote: > > > >>> >> > > > > >>> >> >> Hi, > > > >>> >> >> > > > >>> >> >> There were lots of differences in the compatibility report, > so > > > as a > > > >>> >> >> first > > > >>> >> >> step, I've excluded packages/classes that I considered SPI, > > > >>> >> >> internal, > > > >>> >> >> or > > > >>> >> >> "grey area". This reduced the the differences to a more > > > manageable > > > >>> >> >> amount. > > > >>> >> >> > > > >>> >> >> You can see a summary of the incompatibilities along with > > > suggested > > > >>> >> >> mitigation at [1]. > > > >>> >> >> > > > >>> >> >> The report is attached to [1], along with a zip with > > instructions > > > >>> >> >> for > > > >>> >> >> running the report. > > > >>> >> >> > > > >>> >> >> I believe there are some "false positives" in the report, > and I > > > have > > > >>> >> >> documented them in the section, "False Positives?". > > > >>> >> >> > > > >>> >> >> Feel free to comment on the article. > > > >>> >> >> > > > >>> >> >> Thanks, > > > >>> >> >> Gail > > > >>> >> >> > > > >>> >> >> [1] https://developer.jboss.org/wiki/ > > > HibernateORMBinaryCompatibilit > > > >>> >> >> yBetween51And53 > > > >>> >> >> > > > >>> >> >> > > > >>> >> > ___ > > > >>> >> > hibernate-dev mailing list > > > >>> >> > hibernate-dev@lists.jboss.org > > > >>> >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev >
