Re: [hibernate-dev] orm.xml scanning issue

2018-08-01 Thread Emmanuel Bernard
What does that even mean the "root of the classpath"?
Which classlaoder do we use to look up the resources? That's the one
showing us multiple entries.

On Tue 18-07-31 17:51, Guillaume Smet wrote:
>From what I understand, the issue is that we don't consider only the root
>file but also files deep in the hierarchy:
>https://github.com/spring-projects/spring-boot/issues/10363 .
>
>On Tue, Jul 31, 2018 at 5:46 PM Emmanuel Bernard 
>wrote:
>
>> You'll need to check but AFAIR the spec says that META-INF/orm.xml is
>> automatically added. So the fault is on the builder of
>> PersistenceUnitInfo to include it. But we could be friendly and detect
>> the addition of the same file twice.
>>
>> Emmanuel
>>
>> On Tue 18-07-31 17:23, Guillaume Smet wrote:
>> >Hi,
>> >
>> >This issue seems legit to me:
>> >https://hibernate.atlassian.net/browse/HHH-12873
>> >
>> >That being said, I'm not familiar at all with the boot process so I might
>> >be wrong.
>> >
>> >Could someone confirm and take a look at this issue? It looks annoying for
>> >people using Spring Boot.
>> >
>> >Thanks!
>> >
>> >--
>> >Guillaume
>> >___
>> >hibernate-dev mailing list
>> >hibernate-dev@lists.jboss.org
>> >https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] orm.xml scanning issue

2018-07-31 Thread Guillaume Smet
>From what I understand, the issue is that we don't consider only the root
file but also files deep in the hierarchy:
https://github.com/spring-projects/spring-boot/issues/10363 .

On Tue, Jul 31, 2018 at 5:46 PM Emmanuel Bernard 
wrote:

> You'll need to check but AFAIR the spec says that META-INF/orm.xml is
> automatically added. So the fault is on the builder of
> PersistenceUnitInfo to include it. But we could be friendly and detect
> the addition of the same file twice.
>
> Emmanuel
>
> On Tue 18-07-31 17:23, Guillaume Smet wrote:
> >Hi,
> >
> >This issue seems legit to me:
> >https://hibernate.atlassian.net/browse/HHH-12873
> >
> >That being said, I'm not familiar at all with the boot process so I might
> >be wrong.
> >
> >Could someone confirm and take a look at this issue? It looks annoying for
> >people using Spring Boot.
> >
> >Thanks!
> >
> >--
> >Guillaume
> >___
> >hibernate-dev mailing list
> >hibernate-dev@lists.jboss.org
> >https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] orm.xml scanning issue

2018-07-31 Thread Emmanuel Bernard
You'll need to check but AFAIR the spec says that META-INF/orm.xml is
automatically added. So the fault is on the builder of
PersistenceUnitInfo to include it. But we could be friendly and detect
the addition of the same file twice.

Emmanuel

On Tue 18-07-31 17:23, Guillaume Smet wrote:
>Hi,
>
>This issue seems legit to me:
>https://hibernate.atlassian.net/browse/HHH-12873
>
>That being said, I'm not familiar at all with the boot process so I might
>be wrong.
>
>Could someone confirm and take a look at this issue? It looks annoying for
>people using Spring Boot.
>
>Thanks!
>
>-- 
>Guillaume
>___
>hibernate-dev mailing list
>hibernate-dev@lists.jboss.org
>https://lists.jboss.org/mailman/listinfo/hibernate-dev
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


[hibernate-dev] orm.xml scanning issue

2018-07-31 Thread Guillaume Smet
Hi,

This issue seems legit to me:
https://hibernate.atlassian.net/browse/HHH-12873

That being said, I'm not familiar at all with the boot process so I might
be wrong.

Could someone confirm and take a look at this issue? It looks annoying for
people using Spring Boot.

Thanks!

-- 
Guillaume
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev