Re: [hibernate-dev] Custom EventType and listeners
Thanks for the feedback! I've created https://hibernate.atlassian.net/browse/HHH-13890 . On Thu, Mar 5, 2020 at 7:57 AM Steve Ebersole wrote: > I agree at the high level. > > On Thu, Mar 5, 2020 at 9:17 AM Sanne Grinovero > wrote: > >> Hi Gail, >> >> at high level it seems a reasonable idea to me. >> >> In more detail, let's make sure the `registeredEventListeners` >> initialization is not affected by data races, but we can defer >> discussing such details on a PR as that would probably be clearer. >> >> Thanks, >> Sanne >> >> On Thu, 5 Mar 2020 at 07:16, Gail Badner wrote: >> > >> > There has been some discussion that it may be useful for hibernate-rx >> to be >> > able to define RX-specific event types and listeners. >> > >> > I've created a POC [1] that adds this support. I still need to do some >> > testing, but I would like some feedback before I spend too much time on >> > this. >> > >> > Please let me know if this is a reasonable improvement. If it is, I will >> > create an HHH jira and create a pull request. >> > >> > Thanks, >> > Gail >> > >> > [1] >> > >> https://github.com/gbadner/hibernate-core/commit/2d368a2ce1da36468ab7f965467711bc59f439cf >> > ___ >> > hibernate-dev mailing list >> > hibernate-dev@lists.jboss.org >> > https://lists.jboss.org/mailman/listinfo/hibernate-dev >> > >> ___ >> hibernate-dev mailing list >> hibernate-dev@lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/hibernate-dev >> >> ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Custom EventType and listeners
I agree at the high level. On Thu, Mar 5, 2020 at 9:17 AM Sanne Grinovero wrote: > Hi Gail, > > at high level it seems a reasonable idea to me. > > In more detail, let's make sure the `registeredEventListeners` > initialization is not affected by data races, but we can defer > discussing such details on a PR as that would probably be clearer. > > Thanks, > Sanne > > On Thu, 5 Mar 2020 at 07:16, Gail Badner wrote: > > > > There has been some discussion that it may be useful for hibernate-rx to > be > > able to define RX-specific event types and listeners. > > > > I've created a POC [1] that adds this support. I still need to do some > > testing, but I would like some feedback before I spend too much time on > > this. > > > > Please let me know if this is a reasonable improvement. If it is, I will > > create an HHH jira and create a pull request. > > > > Thanks, > > Gail > > > > [1] > > > https://github.com/gbadner/hibernate-core/commit/2d368a2ce1da36468ab7f965467711bc59f439cf > > ___ > > hibernate-dev mailing list > > hibernate-dev@lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
Re: [hibernate-dev] Custom EventType and listeners
Hi Gail, at high level it seems a reasonable idea to me. In more detail, let's make sure the `registeredEventListeners` initialization is not affected by data races, but we can defer discussing such details on a PR as that would probably be clearer. Thanks, Sanne On Thu, 5 Mar 2020 at 07:16, Gail Badner wrote: > > There has been some discussion that it may be useful for hibernate-rx to be > able to define RX-specific event types and listeners. > > I've created a POC [1] that adds this support. I still need to do some > testing, but I would like some feedback before I spend too much time on > this. > > Please let me know if this is a reasonable improvement. If it is, I will > create an HHH jira and create a pull request. > > Thanks, > Gail > > [1] > https://github.com/gbadner/hibernate-core/commit/2d368a2ce1da36468ab7f965467711bc59f439cf > ___ > hibernate-dev mailing list > hibernate-dev@lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev > ___ hibernate-dev mailing list hibernate-dev@lists.jboss.org https://lists.jboss.org/mailman/listinfo/hibernate-dev
