Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread andrea boriero
Related with the TypeConfiguration and BootstrapContext work, I have just
made a PR targeting your last comments, but I need to know if the work done
it's fine and especially if it is enough to be considered done and then
integrated.

On 22 March 2018 at 14:15, Steve Ebersole  wrote:

> Still waiting for feedback on the PR or Jira.  I will integrate upstream
> today if I don't hear replies needing changes
>
> But regardless, this is not the only change CR2 is waiting on as I
> mentioned before
>
>
> On Thu, Mar 22, 2018, 8:54 AM Sanne Grinovero  wrote:
>
> > Could you help us understand. None of the SPI changes have been merged
> > in master yet?
> >
> > On 22 March 2018 at 13:39, Steve Ebersole  wrote:
> > > Then you'll have to wait.  Seems like snapshot is better than waiting
> > but of
> > > course your opinion seems just waiting is better...
> > >
> > > On Thu, Mar 22, 2018 at 8:34 AM Sanne Grinovero 
> > wrote:
> > >>
> > >>
> > >> No, snapshots are confusing when you need multiple people to
> collaborate
> > >> on a POC.
> > >>
> > >> It's not clear if a patch will work the same to others and it's
> > >> unpractical to match to a specific source commit.
> > >>
> > >> Why would we ever publish CRs if SNAPSHOTS are the same.
> > >>
> > >> On Thu, 22 Mar 2018, 13:17 Steve Ebersole, 
> wrote:
> > >>>
> > >>> Like a snapshot?
> > >>>
> > >>> On Thu, Mar 22, 2018, 7:22 AM Sanne Grinovero 
> > >>> wrote:
> > 
> >  On 22 March 2018 at 12:18, Steve Ebersole 
> > wrote:
> >  > There is already a branch that contains these changes that they
> can
> >  > work
> >  > with... no need to wait for a CR.  I still want to let Andrea
> finish
> >  > the
> >  > work on TypeConfiguration and BootstrapContext before we cut CR2.
> > 
> >  It would help to have a tagged release which can be consumed from
> > Maven.
> > 
> >  Could we not tag this as CR2 and whatever else is coming will be
> > another
> >  CRx ?
> > 
> >  I can do this release if that helps.
> > 
> >  Thanks,
> >  Sanne
> > 
> >  >
> >  > On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero <
> > sa...@hibernate.org>
> >  > wrote:
> >  >>
> >  >> Steve, all,
> >  >>
> >  >> would it be possible to tag a CR2 as soon as the Caching SPI
> > changes
> >  >> are complete?
> >  >>
> >  >> That would help the Infinispan team so they can get started
> >  >> immediately on their side of things.
> >  >>
> >  >> Thanks,
> >  >> Sanne
> >
> ___
> hibernate-dev mailing list
> hibernate-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread Steve Ebersole
Still waiting for feedback on the PR or Jira.  I will integrate upstream
today if I don't hear replies needing changes

But regardless, this is not the only change CR2 is waiting on as I
mentioned before


On Thu, Mar 22, 2018, 8:54 AM Sanne Grinovero  wrote:

> Could you help us understand. None of the SPI changes have been merged
> in master yet?
>
> On 22 March 2018 at 13:39, Steve Ebersole  wrote:
> > Then you'll have to wait.  Seems like snapshot is better than waiting
> but of
> > course your opinion seems just waiting is better...
> >
> > On Thu, Mar 22, 2018 at 8:34 AM Sanne Grinovero 
> wrote:
> >>
> >>
> >> No, snapshots are confusing when you need multiple people to collaborate
> >> on a POC.
> >>
> >> It's not clear if a patch will work the same to others and it's
> >> unpractical to match to a specific source commit.
> >>
> >> Why would we ever publish CRs if SNAPSHOTS are the same.
> >>
> >> On Thu, 22 Mar 2018, 13:17 Steve Ebersole,  wrote:
> >>>
> >>> Like a snapshot?
> >>>
> >>> On Thu, Mar 22, 2018, 7:22 AM Sanne Grinovero 
> >>> wrote:
> 
>  On 22 March 2018 at 12:18, Steve Ebersole 
> wrote:
>  > There is already a branch that contains these changes that they can
>  > work
>  > with... no need to wait for a CR.  I still want to let Andrea finish
>  > the
>  > work on TypeConfiguration and BootstrapContext before we cut CR2.
> 
>  It would help to have a tagged release which can be consumed from
> Maven.
> 
>  Could we not tag this as CR2 and whatever else is coming will be
> another
>  CRx ?
> 
>  I can do this release if that helps.
> 
>  Thanks,
>  Sanne
> 
>  >
>  > On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero <
> sa...@hibernate.org>
>  > wrote:
>  >>
>  >> Steve, all,
>  >>
>  >> would it be possible to tag a CR2 as soon as the Caching SPI
> changes
>  >> are complete?
>  >>
>  >> That would help the Infinispan team so they can get started
>  >> immediately on their side of things.
>  >>
>  >> Thanks,
>  >> Sanne
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread Sanne Grinovero
Could you help us understand. None of the SPI changes have been merged
in master yet?

On 22 March 2018 at 13:39, Steve Ebersole  wrote:
> Then you'll have to wait.  Seems like snapshot is better than waiting but of
> course your opinion seems just waiting is better...
>
> On Thu, Mar 22, 2018 at 8:34 AM Sanne Grinovero  wrote:
>>
>>
>> No, snapshots are confusing when you need multiple people to collaborate
>> on a POC.
>>
>> It's not clear if a patch will work the same to others and it's
>> unpractical to match to a specific source commit.
>>
>> Why would we ever publish CRs if SNAPSHOTS are the same.
>>
>> On Thu, 22 Mar 2018, 13:17 Steve Ebersole,  wrote:
>>>
>>> Like a snapshot?
>>>
>>> On Thu, Mar 22, 2018, 7:22 AM Sanne Grinovero 
>>> wrote:

 On 22 March 2018 at 12:18, Steve Ebersole  wrote:
 > There is already a branch that contains these changes that they can
 > work
 > with... no need to wait for a CR.  I still want to let Andrea finish
 > the
 > work on TypeConfiguration and BootstrapContext before we cut CR2.

 It would help to have a tagged release which can be consumed from Maven.

 Could we not tag this as CR2 and whatever else is coming will be another
 CRx ?

 I can do this release if that helps.

 Thanks,
 Sanne

 >
 > On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero 
 > wrote:
 >>
 >> Steve, all,
 >>
 >> would it be possible to tag a CR2 as soon as the Caching SPI changes
 >> are complete?
 >>
 >> That would help the Infinispan team so they can get started
 >> immediately on their side of things.
 >>
 >> Thanks,
 >> Sanne
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread Sanne Grinovero
No, snapshots are confusing when you need multiple people to collaborate on
a POC.

It's not clear if a patch will work the same to others and it's unpractical
to match to a specific source commit.

Why would we ever publish CRs if SNAPSHOTS are the same.

On Thu, 22 Mar 2018, 13:17 Steve Ebersole,  wrote:

> Like a snapshot?
>
> On Thu, Mar 22, 2018, 7:22 AM Sanne Grinovero  wrote:
>
>> On 22 March 2018 at 12:18, Steve Ebersole  wrote:
>> > There is already a branch that contains these changes that they can work
>> > with... no need to wait for a CR.  I still want to let Andrea finish the
>> > work on TypeConfiguration and BootstrapContext before we cut CR2.
>>
>> It would help to have a tagged release which can be consumed from Maven.
>>
>> Could we not tag this as CR2 and whatever else is coming will be another
>> CRx ?
>>
>> I can do this release if that helps.
>>
>> Thanks,
>> Sanne
>>
>> >
>> > On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero 
>> wrote:
>> >>
>> >> Steve, all,
>> >>
>> >> would it be possible to tag a CR2 as soon as the Caching SPI changes
>> >> are complete?
>> >>
>> >> That would help the Infinispan team so they can get started
>> >> immediately on their side of things.
>> >>
>> >> Thanks,
>> >> Sanne
>>
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread Steve Ebersole
Like a snapshot?

On Thu, Mar 22, 2018, 7:22 AM Sanne Grinovero  wrote:

> On 22 March 2018 at 12:18, Steve Ebersole  wrote:
> > There is already a branch that contains these changes that they can work
> > with... no need to wait for a CR.  I still want to let Andrea finish the
> > work on TypeConfiguration and BootstrapContext before we cut CR2.
>
> It would help to have a tagged release which can be consumed from Maven.
>
> Could we not tag this as CR2 and whatever else is coming will be another
> CRx ?
>
> I can do this release if that helps.
>
> Thanks,
> Sanne
>
> >
> > On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero 
> wrote:
> >>
> >> Steve, all,
> >>
> >> would it be possible to tag a CR2 as soon as the Caching SPI changes
> >> are complete?
> >>
> >> That would help the Infinispan team so they can get started
> >> immediately on their side of things.
> >>
> >> Thanks,
> >> Sanne
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread Sanne Grinovero
On 22 March 2018 at 12:18, Steve Ebersole  wrote:
> There is already a branch that contains these changes that they can work
> with... no need to wait for a CR.  I still want to let Andrea finish the
> work on TypeConfiguration and BootstrapContext before we cut CR2.

It would help to have a tagged release which can be consumed from Maven.

Could we not tag this as CR2 and whatever else is coming will be another CRx ?

I can do this release if that helps.

Thanks,
Sanne

>
> On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero  wrote:
>>
>> Steve, all,
>>
>> would it be possible to tag a CR2 as soon as the Caching SPI changes
>> are complete?
>>
>> That would help the Infinispan team so they can get started
>> immediately on their side of things.
>>
>> Thanks,
>> Sanne
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev


Re: [hibernate-dev] Hibernate ORM 5.3 CR2 ?

2018-03-22 Thread Steve Ebersole
There is already a branch that contains these changes that they can work
with... no need to wait for a CR.  I still want to let Andrea finish the
work on TypeConfiguration and BootstrapContext before we cut CR2.

On Thu, Mar 22, 2018 at 7:17 AM Sanne Grinovero  wrote:

> Steve, all,
>
> would it be possible to tag a CR2 as soon as the Caching SPI changes
> are complete?
>
> That would help the Infinispan team so they can get started
> immediately on their side of things.
>
> Thanks,
> Sanne
>
___
hibernate-dev mailing list
hibernate-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev