[jira] Commented: (HIVE-1084) Cleanup Class names
[ https://issues.apache.org/jira/browse/HIVE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804356#action_12804356 ] Prasad Chakka commented on HIVE-1084: - please use 'svn rename' to change file names instead of doing 'svn delete' and 'svn add'. the former will preserve the history where as later do not preserver the history of the file. Cleanup Class names --- Key: HIVE-1084 URL: https://issues.apache.org/jira/browse/HIVE-1084 Project: Hadoop Hive Issue Type: Task Affects Versions: 0.6.0 Reporter: Carl Steinbach Assignee: Carl Steinbach Attachments: cleanup-class-names.2.patch, cleanup-class-names.patch [Sun's Code Conventions for the Java Programming Language|http://java.sun.com/docs/codeconv/] document stipulates that Java class names must begin with a capital letter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1084) Cleanup Class names
[ https://issues.apache.org/jira/browse/HIVE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804363#action_12804363 ] Carl Steinbach commented on HIVE-1084: -- I am working on a Mac with a case-insensitive file system, and as a result I can't use 'svn rename' when the difference between old and new names is just capitalization. 'svn rename a b' reduces to 'svn copy a b; svn delete a'. This fails on case-insensitive file systems since svn thinks you are trying to copy the file to itself. I have tried doing 'svn rename selectDesc.java S1electDesc.java', followed by 'svn rename S1electDesc.java SelectDesc.java', but this seems to corrupt my svn index. I have two suggestions for how to proceed: # Apply the patch as-is and lose the revision history of the deleted files. I don't think this is a big deal since the deleted files are mostly bean, annotations, etc and don't contain much real code. # Pass this ticket and patch on to a committer with access to a case-sensitive file system for more work. Cleanup Class names --- Key: HIVE-1084 URL: https://issues.apache.org/jira/browse/HIVE-1084 Project: Hadoop Hive Issue Type: Task Affects Versions: 0.6.0 Reporter: Carl Steinbach Assignee: Carl Steinbach Attachments: cleanup-class-names.2.patch, cleanup-class-names.patch [Sun's Code Conventions for the Java Programming Language|http://java.sun.com/docs/codeconv/] document stipulates that Java class names must begin with a capital letter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1084) Cleanup Class names
[ https://issues.apache.org/jira/browse/HIVE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804374#action_12804374 ] Carl Steinbach commented on HIVE-1084: -- Please ignore my last comment. I created a case-sensitive HFS+ partition and am redoing the patch. Cleanup Class names --- Key: HIVE-1084 URL: https://issues.apache.org/jira/browse/HIVE-1084 Project: Hadoop Hive Issue Type: Task Affects Versions: 0.6.0 Reporter: Carl Steinbach Assignee: Carl Steinbach Attachments: cleanup-class-names.2.patch, cleanup-class-names.patch [Sun's Code Conventions for the Java Programming Language|http://java.sun.com/docs/codeconv/] document stipulates that Java class names must begin with a capital letter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1084) Cleanup Class names
[ https://issues.apache.org/jira/browse/HIVE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12804388#action_12804388 ] Zheng Shao commented on HIVE-1084: -- Looks good to me. The script and patch applied cleanly. Running tests now. Will commit after tests pass. Cleanup Class names --- Key: HIVE-1084 URL: https://issues.apache.org/jira/browse/HIVE-1084 Project: Hadoop Hive Issue Type: Task Affects Versions: 0.6.0 Reporter: Carl Steinbach Assignee: Carl Steinbach Attachments: cleanup-class-names.2.patch, cleanup-class-names.4.patch, cleanup-class-names.patch, svn-move-renamed-files.sh [Sun's Code Conventions for the Java Programming Language|http://java.sun.com/docs/codeconv/] document stipulates that Java class names must begin with a capital letter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1084) Cleanup Class names
[ https://issues.apache.org/jira/browse/HIVE-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12803654#action_12803654 ] Zheng Shao commented on HIVE-1084: -- There is a problem applying this patch: cannot find ql/src/java/org/apache/hadoop/hive/ql/plan/JoinCondDesc.java to patch. Can you take a look? Cleanup Class names --- Key: HIVE-1084 URL: https://issues.apache.org/jira/browse/HIVE-1084 Project: Hadoop Hive Issue Type: Task Affects Versions: 0.6.0 Reporter: Carl Steinbach Assignee: Carl Steinbach Attachments: cleanup-class-names.patch [Sun's Code Conventions for the Java Programming Language|http://java.sun.com/docs/codeconv/] document stipulates that Java class names must begin with a capital letter. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
