[jira] Commented: (HIVE-1203) HiveInputFormat.getInputFormatFromCache "swallows" cause exception when trowing IOExcpetion

2010-08-17 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899488#action_12899488
 ] 

He Yongqiang commented on HIVE-1203:


Vladimir, can you update the patch? After that, i will test and commit it.

> HiveInputFormat.getInputFormatFromCache "swallows"  cause exception when 
> trowing IOExcpetion
> 
>
> Key: HIVE-1203
> URL: https://issues.apache.org/jira/browse/HIVE-1203
> Project: Hadoop Hive
>  Issue Type: Bug
>Affects Versions: 0.4.0, 0.4.1, 0.5.0
>Reporter: Vladimir Klimontovich
>Assignee: Vladimir Klimontovich
> Attachments: 0.4.patch, 0.5.patch, trunk.patch
>
>
> To fix this it's simply needed to add second parameter to IOException 
> constructor. Patches for 0.4, 0.5 and trunk are available.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1203) HiveInputFormat.getInputFormatFromCache "swallows" cause exception when trowing IOExcpetion

2010-02-28 Thread Vladimir Klimontovich (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12839427#action_12839427
 ] 

Vladimir Klimontovich commented on HIVE-1203:
-

Well, I can't assign this issue. Seems like I don't have enough permissions

> HiveInputFormat.getInputFormatFromCache "swallows"  cause exception when 
> trowing IOExcpetion
> 
>
> Key: HIVE-1203
> URL: https://issues.apache.org/jira/browse/HIVE-1203
> Project: Hadoop Hive
>  Issue Type: Bug
>Affects Versions: 0.4.0, 0.4.1, 0.5.0
>Reporter: Vladimir Klimontovich
> Fix For: 0.4.2, 0.5.1, 0.6.0
>
> Attachments: 0.4.patch, 0.5.patch, trunk.patch
>
>
> To fix this it's simply needed to add second parameter to IOException 
> constructor. Patches for 0.4, 0.5 and trunk are available.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1203) HiveInputFormat.getInputFormatFromCache "swallows" cause exception when trowing IOExcpetion

2010-02-26 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838968#action_12838968
 ] 

He Yongqiang commented on HIVE-1203:


Thanks for the explanation.  Yes, there is no harm to do that.
I will test and commit it.

> HiveInputFormat.getInputFormatFromCache "swallows"  cause exception when 
> trowing IOExcpetion
> 
>
> Key: HIVE-1203
> URL: https://issues.apache.org/jira/browse/HIVE-1203
> Project: Hadoop Hive
>  Issue Type: Bug
>Affects Versions: 0.4.0, 0.4.1, 0.5.0
>Reporter: Vladimir Klimontovich
> Fix For: 0.4.2, 0.5.1, 0.6.0
>
> Attachments: 0.4.patch, 0.5.patch, trunk.patch
>
>
> To fix this it's simply needed to add second parameter to IOException 
> constructor. Patches for 0.4, 0.5 and trunk are available.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1203) HiveInputFormat.getInputFormatFromCache "swallows" cause exception when trowing IOExcpetion

2010-02-26 Thread Vladimir Klimontovich (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838960#action_12838960
 ] 

Vladimir Klimontovich commented on HIVE-1203:
-

I think so. Exception could be thrown not only from Class.forName, but also 
from Class.newInstance. Actually it was my case as due to incorrect settings 
constructor of my InputFormat was throwing an exception (and this exception was 
being swallowed).

Also, it's a general rule in most java projects (to add exception as a cause 
esception). More information in stacktrace never hurts :) 
(Although I'm not sure that Hive should follow this rule)

> HiveInputFormat.getInputFormatFromCache "swallows"  cause exception when 
> trowing IOExcpetion
> 
>
> Key: HIVE-1203
> URL: https://issues.apache.org/jira/browse/HIVE-1203
> Project: Hadoop Hive
>  Issue Type: Bug
>Affects Versions: 0.4.0, 0.4.1, 0.5.0
>Reporter: Vladimir Klimontovich
> Fix For: 0.4.2, 0.5.1, 0.6.0
>
> Attachments: 0.4.patch, 0.5.patch, trunk.patch
>
>
> To fix this it's simply needed to add second parameter to IOException 
> constructor. Patches for 0.4, 0.5 and trunk are available.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



[jira] Commented: (HIVE-1203) HiveInputFormat.getInputFormatFromCache "swallows" cause exception when trowing IOExcpetion

2010-02-26 Thread He Yongqiang (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-1203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838953#action_12838953
 ] 

He Yongqiang commented on HIVE-1203:


Vladimir, in this case, do we really need a stack trace? It is mostly caused by 
ClassNotFound etc when creating an input format instance with the class name.
Is there some error that can only be found from the stack trace?

> HiveInputFormat.getInputFormatFromCache "swallows"  cause exception when 
> trowing IOExcpetion
> 
>
> Key: HIVE-1203
> URL: https://issues.apache.org/jira/browse/HIVE-1203
> Project: Hadoop Hive
>  Issue Type: Bug
>Affects Versions: 0.4.0, 0.4.1, 0.5.0
>Reporter: Vladimir Klimontovich
> Fix For: 0.4.2, 0.5.1, 0.6.0
>
> Attachments: 0.4.patch, 0.5.patch, trunk.patch
>
>
> To fix this it's simply needed to add second parameter to IOException 
> constructor. Patches for 0.4, 0.5 and trunk are available.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.