[jira] Commented: (HIVE-1211) Tapping logs from child processes

[Namit Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902500#action_12902500
 ] 

Namit Jain commented on HIVE-1211:
--

@Carl,
The test multi_insert.q failed - can you take a look ?

> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt, HIVE-1211.4.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902159#action_12902159
 ] 

HBase Review Board commented on HIVE-1211:
--

Message from: "Carl Steinbach" 


bq.  On 2010-08-24 16:04:04, Ted Yu wrote:
bq.  > ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java, line 622
bq.  > 
bq.  >
bq.  > getChildErrStream() should be called.

Fixed in HIVE-1211.4.patch.txt


- Carl


---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/718/#review1028
---





> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt, HIVE-1211.4.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902155#action_12902155
 ] 

HBase Review Board commented on HIVE-1211:
--

Message from: "Carl Steinbach" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/718/
---

(Updated 2010-08-24 16:14:42.928915)


Review request for Hive Developers.


Summary
---

Patch provided by bc Wong. Rebased to trunk.


This addresses bug HIVE-1211.
http://issues.apache.org/jira/browse/HIVE-1211


Diffs (updated)
-

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java ca37dc5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java fefe42d 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java a36b06e 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 70d64ef 

Diff: http://review.cloudera.org/r/718/diff


Testing
---


Thanks,

Carl




> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt, HIVE-1211.4.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902145#action_12902145
 ] 

HBase Review Board commented on HIVE-1211:
--

Message from: "Ted Yu" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/718/#review1028
---



ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java


getChildErrStream() should be called.


- Ted





> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[Namit Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902138#action_12902138
 ] 

Namit Jain commented on HIVE-1211:
--

+1

will commit if the tests pass

> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[HBase Review Board (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902129#action_12902129
 ] 

HBase Review Board commented on HIVE-1211:
--

Message from: "Carl Steinbach" 

---
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/718/
---

Review request for Hive Developers.


Summary
---

Patch provided by bc Wong. Rebased to trunk.


This addresses bug HIVE-1211.
http://issues.apache.org/jira/browse/HIVE-1211


Diffs
-

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java ca37dc5 
  ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java fefe42d 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java a36b06e 
  ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 70d64ef 

Diff: http://review.cloudera.org/r/718/diff


Testing
---


Thanks,

Carl




> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[Carl Steinbach (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12902128#action_12902128
 ] 

Carl Steinbach commented on HIVE-1211:
--

Rebased the patch to trunk.

+1

> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch, 
> HIVE-1211.3.patch.txt
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[Namit Jain (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899644#action_12899644
 ] 

Namit Jain commented on HIVE-1211:
--

@Carl, can you take a look ?

> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Fix For: 0.7.0
>
> Attachments: HIVE-1211-2.patch, HIVE-1211.1.patch
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[bc Wong (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842346#action_12842346
 ] 

bc Wong commented on HIVE-1211:
---

I'd like to retrieve the logs related to a particular query.

SessionState.out and SessionState.err are meant for that exact purpose. 
Unfortunately, they don't capture the child processes' output, which currently 
goes directly to System.out and System.err. Therefore this patch introduces 
SessionState.childout and SessionState.childerr, which by default (null) do 
nothing. But it allows anyone to hook a stream there to get the child's output.

> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>Assignee: bc Wong
> Attachments: HIVE-1211.1.patch
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[Zheng Shao (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842239#action_12842239
 ] 

Zheng Shao commented on HIVE-1211:
--

Hi bc, can you talk a bit more about the use case in your mind?


> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
> Attachments: HIVE-1211.1.patch
>
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HIVE-1211) Tapping logs from child processes

[bc Wong (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-1211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840834#action_12840834
 ] 

bc Wong commented on HIVE-1211:
---

I'd like to change it to go through the {{SessionState}} first. 
{{SessionState}} will have two new {{PrintStream}}, called {{childOut}} and 
{{childErr}}, which are similar to the current {{out}} and {{err}}. They let 
users tap into the child's output. If they're null, then the child's out will 
continue on to stdout/stderr.

And this doesn't break any existing users who aren't interested in the child's 
output. They can tap into {{SessionState.out|err}} and ignore the new fields.

> Tapping logs from child processes
> -
>
> Key: HIVE-1211
> URL: https://issues.apache.org/jira/browse/HIVE-1211
> Project: Hadoop Hive
>  Issue Type: Improvement
>  Components: Logging
>Reporter: bc Wong
>
> Stdout/stderr from child processes (e.g. {{MapRedTask}}) are redirected to 
> the parent's stdout/stderr. There is little one can do to to sort out which 
> log is from which query.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.