[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[
https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869344#action_12869344
]
Edward Capriolo commented on HIVE-1351:
---
This is so notpicky, but
{noformat}
+--rcfilecat)
+ SERVICE=rcfilecat
+ shift
+ ;;
{noformat}
I do not think we should do this. We are just giving alternate invocations that
end up being more confusing.
Why should you be able to do this:
{noformat}
hive --rcfilecat
{noformat}
but not
{noformat}
hive --hwi
{noformat}
?
as for execHiveCmd. If you want to share this why not move it up into bin/hive?
We do not need to add a file to shared when subs specified in in bin/hive are
already shared.
> Tool to cat rcfiles
> ---
>
> Key: HIVE-1351
> URL: https://issues.apache.org/jira/browse/HIVE-1351
> Project: Hadoop Hive
> Issue Type: New Feature
>Reporter: Namit Jain
>Assignee: He Yongqiang
> Fix For: 0.6.0
>
> Attachments: hive.1351.1.patch, hive.1351.2.patch
>
>
> It will be useful for debugging
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869306#action_12869306 ] He Yongqiang commented on HIVE-1351: I moved almost all cli.sh code to util/execHiveCmd because these code can be shared with rcfilecat. i think these code should be independent (we may add new command in future.) > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Fix For: 0.6.0 > > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869287#action_12869287 ] Venky Iyer commented on HIVE-1351: -- I think we'll end up using rcfilecat in a lot of stuff, not just for debugging -- (to dump small tables for off-Hive processing). It should be treated as production code IMO. > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869284#action_12869284 ] Edward Capriolo commented on HIVE-1351: --- As ning mentioned why move the cli code. If anything more of the code should be moving up into the main script rather then into smaller scripts. I see people making changes to only the cli. We have to make sure that fixes for things like cygwin get propogated to all files, or shared code gets shared. Also rcfilecat is just a debug util, but it should have a unit test right? Just cat to files to make sure it works? > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869257#action_12869257 ] Ning Zhang commented on HIVE-1351: -- what's the reason to change cli.sh? > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869218#action_12869218 ] Namit Jain commented on HIVE-1351: -- will test and commit if tests pass > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869196#action_12869196 ] He Yongqiang commented on HIVE-1351: It's hive --service rcfilecat [--start=xxx] [--length=yyy] filename > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1351) Tool to cat rcfiles
[ https://issues.apache.org/jira/browse/HIVE-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869010#action_12869010 ] Namit Jain commented on HIVE-1351: -- The script doesnt seem to work - can you describe how to use this ? > Tool to cat rcfiles > --- > > Key: HIVE-1351 > URL: https://issues.apache.org/jira/browse/HIVE-1351 > Project: Hadoop Hive > Issue Type: New Feature >Reporter: Namit Jain >Assignee: He Yongqiang > Attachments: hive.1351.1.patch, hive.1351.2.patch > > > It will be useful for debugging -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
