[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912765#action_12912765 ] Todd Lipcon commented on HIVE-1526: --- Planning on upgrading to 0.4.0. The main incompatible changes to deal with: - Methods that return enums now actually return a java enum type instead of an int (eg fb303's get_status method as well as the operator and stage getType() methods) - readBinary and writeBinary now use ByteBuffer instead of byte[] Unfortunately the maven situation is still not yet sorted out. I built a libthrift.jar and a libfb303.jar from the 0.4.0 release tree and will upload them here. Had to fix a minor issue to get fb303 to build (see THRIFT-381) Aside from that, it seems pretty straightforward. I have a patch, running unit tests now. > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure >Reporter: Carl Steinbach >Assignee: Todd Lipcon > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912768#action_12912768 ] Todd Lipcon commented on HIVE-1526: --- Er, sorry, not THRIFT-381, but rather THRIFT-907. Too many browser tabs! > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure >Reporter: Carl Steinbach >Assignee: Todd Lipcon > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913843#action_12913843 ] Ning Zhang commented on HIVE-1526: -- The Hive ODBC code is dependent on Thrift as well. In particular the hive client and unixODBC libraries have to be linked with the new libthrift.so. Can you test if the ODBC code is compatible with the new thrift version? > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Attachments: hive-1526.txt, libfb303.jar, libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913933#action_12913933 ] Carl Steinbach commented on HIVE-1526: -- @Todd: Can you please regenerate this patch? Both 'patch -p0' and 'git apply -p0' fail. Thanks. > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure, Clients >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Fix For: 0.6.0, 0.7.0 > > Attachments: hive-1526.txt, libfb303.jar, libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914207#action_12914207 ] Todd Lipcon commented on HIVE-1526: --- Hi Carl. It appears to apply fine for me on today's trunk: t...@todd-laptop:~/git/hive$ git reset --hard HEAD HEAD is now at 08d5e5b HIVE-1661. Default values for parameters (Siying Dong via He Yongqiang) t...@todd-laptop:~/git/hive$ curl 'https://issues.apache.org/jira/secure/attachment/12455323/hive-1526.txt' | patch -p0 ... patch output t...@todd-laptop:~/git/hive$ Sure you're up to date on trunk? > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure, Clients >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Fix For: 0.6.0, 0.7.0 > > Attachments: hive-1526.txt, libfb303.jar, libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914255#action_12914255 ] Carl Steinbach commented on HIVE-1526: -- Sorry, that was a false alarm about the patch. Turns out the github Hive mirror lags the main repo by about a week. @Todd: This patch introduces unsatisfied dependencies on slf4j-api and slf4j-log4j12. Can you please update the patch to pull these dependencies down with Ivy? > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure, Clients >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Fix For: 0.6.0, 0.7.0 > > Attachments: hive-1526.txt, libfb303.jar, libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916741#action_12916741 ] Ning Zhang commented on HIVE-1526: -- Carl and Todd, is this a blocking issue for 0.6? If not, we can make it in 0.7 and get 0.6 release ASAP. > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure, Clients >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Fix For: 0.6.0, 0.7.0 > > Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, > libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916751#action_12916751 ] Carl Steinbach commented on HIVE-1526: -- @Ning: I removed the 0.6 tag. Can you please review this change? Thanks. > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure, Clients >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Fix For: 0.7.0 > > Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, > libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-1526) Hive should depend on a release version of Thrift
[ https://issues.apache.org/jira/browse/HIVE-1526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916798#action_12916798 ] Ning Zhang commented on HIVE-1526: -- I will take a look. > Hive should depend on a release version of Thrift > - > > Key: HIVE-1526 > URL: https://issues.apache.org/jira/browse/HIVE-1526 > Project: Hadoop Hive > Issue Type: Task > Components: Build Infrastructure, Clients >Reporter: Carl Steinbach >Assignee: Todd Lipcon > Fix For: 0.7.0 > > Attachments: HIVE-1526.2.patch.txt, hive-1526.txt, libfb303.jar, > libthrift.jar > > > Hive should depend on a release version of Thrift, and ideally it should use > Ivy to resolve this dependency. > The Thrift folks are working on adding Thrift artifacts to a maven repository > here: https://issues.apache.org/jira/browse/THRIFT-363 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
