[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752314#action_12752314 ] Edward Capriolo commented on HIVE-425: -- I took a look through apache today. I think wikit looks good. http://wicket.apache.org/exampleguestbook.html 1. apache framework 2. work in class files What do you think? > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745589#action_12745589 ] Edward Capriolo commented on HIVE-425: -- I was thinking we can even go with servlets generating XHTML and CSS. In this way we can remove the JSP, the unit test process could read the XML for result status, and the CSS will make it look decent in a browser. > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732120#action_12732120 ] Alex Loddengaard commented on HIVE-425: --- I've used both Struts and Spring, but I'm pretty certain both are much larger than 5MB. That said, I found each of them to be good in their own separate ways. I recall liking Spring better. It's been a long time since my JSP MVC fiddling :). Struts is an Apache project, though: [http://struts.apache.org/]. Sorry I can't provide more insight, Edward. > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732112#action_12732112 ] Edward Capriolo commented on HIVE-425: -- Alex, Here are the current problems I see. * JSP ** Hard To check Syntax at Compile Time ** References to other parts of hive (not many but) may become outdated with API changes * Hard to unit test Are unit test tests the SessionManager, not the actual jsp flow of passing form items. So the ideal framework would be: * small <5MB. we dont want to make Hive bigger just better * mostly .Java and servlet based (little/no JSP) * Possibly a way to unit test a transaction. Login->RunQuery->Verify Results * Apache compat license * XML/CSS (if it helps eliminate JSP) * Low complexity (I am not interested in learning what a org.springframework.transaction.interceptor.AbstractFallbackTransactionAttributeSource ) is for example :) I know little about JSP Frameworks. Do you you have one that fits the needs? > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732039#action_12732039 ] Alex Loddengaard commented on HIVE-425: --- Hi Edward, which MVC frameworks are you going to consider? I assume Struts and Spring don't fall into the "light" category, yeah? I'm mostly just curious. > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731990#action_12731990 ] Edward Capriolo commented on HIVE-425: -- I have tried several things to make this process work. Without siting any one specific error it seems that the 'org.apache.jasper.JspC' compilation seems to require specific ant-jetty combination. I want to look into a light mvc framework something that will get all the code into servlets/java classes. In this way it will be pre-compiled. > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (HIVE-425) HWI JSP pages should be compiled at build-time instead of run-time
[ https://issues.apache.org/jira/browse/HIVE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12700494#action_12700494 ] Edward Capriolo commented on HIVE-425: -- This is definitely a good idea. Doing a build and deploying just to have a compile time error is frustrating. This will speed up development cycles. Alex, I have read on how to do this. http://www.otweb.com/blog/index.php?id=441&t=JBoss_Jetty_JSP_Precompile. I do not have any changes/upgrades planned for hwi for a while, but I do have another jira open to add the ant tools to hive. Recompiling sounds like it would invalidate that jira. This way is preferred. > HWI JSP pages should be compiled at build-time instead of run-time > -- > > Key: HIVE-425 > URL: https://issues.apache.org/jira/browse/HIVE-425 > Project: Hadoop Hive > Issue Type: Improvement > Components: Web UI >Reporter: Alex Loddengaard > > HWI JSP pages are compiled via the ant jar at run-time. Doing so at run-time > requires ant as a dependency and also makes developing slightly more tricky, > as compiler errors are not discovered until HWI is deployed and running. HWI > should be instrumented in such a way where the JSP pages are compiled by ant > at build-time instead, just as the Hadoop status pages are. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
