Re: [hpx-users] list of OS names

2018-08-13 Thread Hartmut Kaiser
> > > On Mon, Aug 13, 2018 at 08:06:25AM -0500, Hartmut Kaiser wrote:
> > > > FWIW, I have merged #3402 just now.
> > >
> > > Thanks!
> > >
> > > I have got as far as linking libhpx now - somehow there is a -ldl in
> > > link.txt (and in the generated pkg-config .pc files). I have been
> > > hunting through the cmake files where it comes from, but haven't
> > > found it. Any ideas? (dlopen and friends are in many OS's system
> > > library as opposed to
> > > libdl.)
> >
> > libdl is handled here:
> > https://github.com/STEllAR-GROUP/hpx/blob/master/CMakeLists.txt#L1230-
> > L1232
>
> Thanks I searched for ldl and libdl... This gets me further:
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt index c780ea50ef..69e8261dce
> 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -1227,9 +1227,15 @@ if(NOT WIN32)
>  endif()
>endif()
>
> -  if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
> -hpx_libraries(dl)
> -  endif()
> +  # XXXPW if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
> +find_library(DL_LIBRARY NAMES dl)
> +if(DL_LIBRARY)
> +  message(STATUS "dl library found")
> +  hpx_libraries(dl)
> +else()
> +  message(STATUS "dl library not found")
> +endif()
> +  # XXXPW endif()
>
>if(NOT APPLE AND NOT ("${HPX_PLATFORM_UC}" STREQUAL "ANDROID"))
>  hpx_libraries(rt)
>
>
> but there are lots of ways of skinning that cat - have you a preferred way
> of doing AC_CHECK_LIB([dl],[dlopen]) ?
>
> (On linking I get:

How about doing something like this:
https://github.com/Fadis/libdcompile/blob/master/CMakeFiles/modules/FindLibD
L.cmake

>
> CMakeFiles/hpx.dir/runtime/threads/executors/this_thread_executors.cpp.o:
> In function
> `hpx::threads::coroutines::detail::context_base::~context_base()':
> this_thread_executors.cpp:(.text._ZN3hpx7threads10coroutines6detail12conte
> xt_baseD2Ev[_ZN3hpx7threads10coroutines6detail12context_baseD5Ev]+0x41):
> undefined reference to
> `hpx::threads::coroutines::detail::posix::use_guard_pages'
> )

This is unrelated. The variable is defined here:
https://github.com/STEllAR-GROUP/hpx/blob/master/src/util/runtime_configurat
ion.cpp#L71-L83.

Regards Hartmut
---
http://stellar.cct.lsu.edu
https://github.com/STEllAR-GROUP/hpx




___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread 'Patrick Welche'
On Mon, Aug 13, 2018 at 09:31:23AM -0500, Hartmut Kaiser wrote:
> 
> > On Mon, Aug 13, 2018 at 08:06:25AM -0500, Hartmut Kaiser wrote:
> > > FWIW, I have merged #3402 just now.
> >
> > Thanks!
> >
> > I have got as far as linking libhpx now - somehow there is a -ldl in
> > link.txt (and in the generated pkg-config .pc files). I have been hunting
> > through the cmake files where it comes from, but haven't found it. Any
> > ideas? (dlopen and friends are in many OS's system library as opposed to
> > libdl.)
> 
> libdl is handled here:
> https://github.com/STEllAR-GROUP/hpx/blob/master/CMakeLists.txt#L1230-L1232

Thanks I searched for ldl and libdl... This gets me further:

diff --git a/CMakeLists.txt b/CMakeLists.txt
index c780ea50ef..69e8261dce 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -1227,9 +1227,15 @@ if(NOT WIN32)
 endif()
   endif()
 
-  if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
-hpx_libraries(dl)
-  endif()
+  # XXXPW if(NOT ${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD")
+find_library(DL_LIBRARY NAMES dl)
+if(DL_LIBRARY)
+  message(STATUS "dl library found")
+  hpx_libraries(dl)
+else()
+  message(STATUS "dl library not found")
+endif()
+  # XXXPW endif()
 
   if(NOT APPLE AND NOT ("${HPX_PLATFORM_UC}" STREQUAL "ANDROID"))
 hpx_libraries(rt)


but there are lots of ways of skinning that cat - have you a preferred
way of doing AC_CHECK_LIB([dl],[dlopen]) ?

(On linking I get:

CMakeFiles/hpx.dir/runtime/threads/executors/this_thread_executors.cpp.o: In 
function `hpx::threads::coroutines::detail::context_base::~context_base()':
this_thread_executors.cpp:(.text._ZN3hpx7threads10coroutines6detail12context_baseD2Ev[_ZN3hpx7threads10coroutines6detail12context_baseD5Ev]+0x41):
 undefined reference to 
`hpx::threads::coroutines::detail::posix::use_guard_pages'
)

Cheers,

Patrick
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Thomas Heller
Patrick Welche  schrieb am Mo., 13. Aug. 2018 16:16:

> On Mon, Aug 13, 2018 at 08:06:25AM -0500, Hartmut Kaiser wrote:
> > FWIW, I have merged #3402 just now.
>
> Thanks!
>
> I have got as far as linking libhpx now - somehow there is a -ldl in
> link.txt (and in the generated pkg-config .pc files). I have been hunting
> through the cmake files where it comes from, but haven't found it. Any
> ideas? (dlopen and friends are in many OS's system library as opposed to
> libdl.)
>

If I'm not mistaken, this might even come out of the inner cmake core
itself.


> Cheers,
>
> Patrick
> ___
> hpx-users mailing list
> hpx-users@stellar.cct.lsu.edu
> https://mail.cct.lsu.edu/mailman/listinfo/hpx-users
>
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Hartmut Kaiser


> On Mon, Aug 13, 2018 at 08:06:25AM -0500, Hartmut Kaiser wrote:
> > FWIW, I have merged #3402 just now.
>
> Thanks!
>
> I have got as far as linking libhpx now - somehow there is a -ldl in
> link.txt (and in the generated pkg-config .pc files). I have been hunting
> through the cmake files where it comes from, but haven't found it. Any
> ideas? (dlopen and friends are in many OS's system library as opposed to
> libdl.)

libdl is handled here:
https://github.com/STEllAR-GROUP/hpx/blob/master/CMakeLists.txt#L1230-L1232

Regards Hartmut
---
http://stellar.cct.lsu.edu
https://github.com/STEllAR-GROUP/hpx



___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Patrick Welche
On Mon, Aug 13, 2018 at 08:06:25AM -0500, Hartmut Kaiser wrote:
> FWIW, I have merged #3402 just now.

Thanks!

I have got as far as linking libhpx now - somehow there is a -ldl in
link.txt (and in the generated pkg-config .pc files). I have been hunting
through the cmake files where it comes from, but haven't found it. Any
ideas? (dlopen and friends are in many OS's system library as opposed to
libdl.)

Cheers,

Patrick
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Hartmut Kaiser
FWIW, I have merged #3402 just now.

Regards Hartmut
---
http://stellar.cct.lsu.edu
https://github.com/STEllAR-GROUP/hpx


> -Original Message-
> From: hpx-users-boun...@stellar.cct.lsu.edu  boun...@stellar.cct.lsu.edu> On Behalf Of Lars Viklund
> Sent: Monday, August 13, 2018 7:35 AM
> To: hpx-users@stellar.cct.lsu.edu
> Subject: Re: [hpx-users] list of OS names
>
> On Mon, Aug 13, 2018 at 01:22:38PM +0100, Patrick Welche wrote:
> > On Mon, Aug 13, 2018 at 01:19:42PM +0100, Patrick Welche wrote:
> > > Chugging along trying to get hpx to compile, I thought I would try
> > > the
> > > 1.1.0 patches I had so far on master. I just got an extra compile
> error:
> > >
> > > /usr/src/local/hpx/src/hpx_init.cpp: In function â?~int
> hpx::detail::run_or_start(hpx::util::function_nonser tions::variables_map&)>&, const
> boost::program_options::options_description&, int, char**,
> std::vector >&&, hpx::startup_function_type,
> hpx::shutdown_function_type, hpx::runtime_mode, bool)â?T:
> > > /usr/src/local/hpx/src/hpx_init.cpp:603:24: error: â?~hpx_startâ?T has
> not been declared
> > >  if(hpx_start::include_libhpx_wrap)
>
> The functionality in question is part of one of our GSoC student's work on
> introducing HPX even earlier in the startup process via loader tricks,
> currently only on a few OSes like GNU/Linux and macOS.
>
> There is a missing guard in this source file and it should be resolved by
> the fix in PR#3402.
>
> https://github.com/STEllAR-GROUP/hpx/pull/3402
>
> Everything else about this feature should be inert on the OSes the feature
> doesn't apply to.
>
> --
> Lars Viklund | z...@acc.umu.se
> ___
> hpx-users mailing list
> hpx-users@stellar.cct.lsu.edu
> https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Lars Viklund
On Mon, Aug 13, 2018 at 01:22:38PM +0100, Patrick Welche wrote:
> On Mon, Aug 13, 2018 at 01:19:42PM +0100, Patrick Welche wrote:
> > Chugging along trying to get hpx to compile, I thought I would try the
> > 1.1.0 patches I had so far on master. I just got an extra compile error:
> > 
> > /usr/src/local/hpx/src/hpx_init.cpp: In function ‘int 
> > hpx::detail::run_or_start(hpx::util::function_nonser&,
> >  const boost::program_options::options_description&, int, char**, 
> > std::vector >&&, hpx::startup_function_type, 
> > hpx::shutdown_function_type, hpx::runtime_mode, bool)’:
> > /usr/src/local/hpx/src/hpx_init.cpp:603:24: error: ‘hpx_start’ has not 
> > been declared
> >  if(hpx_start::include_libhpx_wrap)

The functionality in question is part of one of our GSoC student's work
on introducing HPX even earlier in the startup process via loader
tricks, currently only on a few OSes like GNU/Linux and macOS.

There is a missing guard in this source file and it should be resolved
by the fix in PR#3402.

https://github.com/STEllAR-GROUP/hpx/pull/3402

Everything else about this feature should be inert on the OSes the
feature doesn't apply to.

-- 
Lars Viklund | z...@acc.umu.se
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Patrick Welche
On Mon, Aug 13, 2018 at 01:19:42PM +0100, Patrick Welche wrote:
> Chugging along trying to get hpx to compile, I thought I would try the
> 1.1.0 patches I had so far on master. I just got an extra compile error:
> 
> /usr/src/local/hpx/src/hpx_init.cpp: In function ‘int 
> hpx::detail::run_or_start(hpx::util::function_nonser&,
>  const boost::program_options::options_description&, int, char**, 
> std::vector >&&, hpx::startup_function_type, 
> hpx::shutdown_function_type, hpx::runtime_mode, bool)’:
> /usr/src/local/hpx/src/hpx_init.cpp:603:24: error: ‘hpx_start’ has not 
> been declared
>  if(hpx_start::include_libhpx_wrap)
> 
> 
> which seems to be from
> 
> commit bd77d6ed1720ba2d1c45c7129c5bf1d299a80498
> Author: Nikunj Gupta 
> Date:   Wed Jul 18 09:35:54 2018 +0530
> 
> Changes according to review
> 
> 
> Would a quick glance by you suggest the #ifs served as useful protection?
> (Now to find out what HPX_HAVE_DYNAMIC_HPX_MAIN does...)

Those #ifs still currently protect

namespace hpx_start
{
// Importing weak symbol from libhpx_wrap.a which may be shadowed by one 
present in
// hpx_main.hpp.
HPX_SYMBOL_EXPORT __attribute__((weak)) extern bool include_libhpx_wrap;
}


(but I don't understand the shadowing issue...)


Cheers,

Patrick
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] list of OS names

2018-08-13 Thread Patrick Welche
Chugging along trying to get hpx to compile, I thought I would try the
1.1.0 patches I had so far on master. I just got an extra compile error:

/usr/src/local/hpx/src/hpx_init.cpp: In function ‘int 
hpx::detail::run_or_start(hpx::util::function_nonser&,
 const boost::program_options::options_description&, int, char**, 
std::vector >&&, hpx::startup_function_type, 
hpx::shutdown_function_type, hpx::runtime_mode, bool)’:
/usr/src/local/hpx/src/hpx_init.cpp:603:24: error: ‘hpx_start’ has not been 
declared
 if(hpx_start::include_libhpx_wrap)


which seems to be from

commit bd77d6ed1720ba2d1c45c7129c5bf1d299a80498
Author: Nikunj Gupta 
Date:   Wed Jul 18 09:35:54 2018 +0530

Changes according to review


Would a quick glance by you suggest the #ifs served as useful protection?
(Now to find out what HPX_HAVE_DYNAMIC_HPX_MAIN does...)


Cheers,

Patrick
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users


Re: [hpx-users] CMake Targets for HPX

2018-08-13 Thread Thomas Heller
On Sun, Aug 12, 2018 at 7:13 PM Jayesh Badwaik 
wrote:

> Is it possible to use HPX with CMake with Targets? For example, can I
> do `target_link_libraries(mylib INTERFACE/PUBLIC/PRIVATE HPX::HPX)`?
>

Please see my reply to your ticket here:
https://github.com/STEllAR-GROUP/hpx/issues/3408


>
> Thank you
>
> --
> Cheers
> Jayesh Badwaik
> https://jayeshbadwaik.gitlab.io
> ___
> hpx-users mailing list
> hpx-users@stellar.cct.lsu.edu
> https://mail.cct.lsu.edu/mailman/listinfo/hpx-users
>
___
hpx-users mailing list
hpx-users@stellar.cct.lsu.edu
https://mail.cct.lsu.edu/mailman/listinfo/hpx-users