Hi,
I don't want to sound rude, but how exactly can we see your coding
skills from these source files? From what I see:
- You have successfully set up a build environment to build plugins
for GIMP.
- You can make a "hello world" plugin for GIMP, which is basically
taken literally from [0] with only a few textual changes.
- You can change 0 into height/4, 0 into width/5 and width into width
- width/5. Another example taken from [1].
- You cannot create the right diff. The diff you made transforms your
file back into the original, so it can't be used to take the original
file and transform it into yours.
- Where are the credits for the original author?
I'm sorry but you haven't convinced me yet. I know I'm not mentoring
(nor have I contributed a lot of code) but I don't think this shows
the level we need for a GSOC project. Maybe you have something else to
show?
[0] http://developer.gimp.org/writing-a-plug-in/1/hello.c
[1] http://developer.gimp.org/writing-a-plug-in/3/myblur3.c
--
Bart
On 20 apr, 01:03, Elle Yan wrote:
> Hi,
>
> Sorry for the late reply. I just got a chance to organize some source code
> files. I will have plenty of time in the summer (from May). Thank you very
> much for all suggestions of getting involved in open source development. It
> is really helpful. I am excited to contribute to Hugin and open source
> community. I learned quite a lot about open source before, but think taking
> some good actions from now is good.
>
> This Gsoc project will be a wonderful opportunity for me to start. I have
> uploaded some source code in Hugin Google Groups:
>
> http://groups.google.com/group/hugin-ptx/web/Sample%20source%20code.zip
>
> or, the Sample source code.zip file
> at:http://groups.google.com/group/hugin-ptx/files?upload=1
>
> I also uploaded another zip file, Hugin patch-screenshots.zip, in the same
> directory. That is my patch work to support the application of Hugin Gsoc
> project, Enfuse and Enblend Gimp Plugins. I have write a description for
> those files in the first email.
>
> I have shared source code before, and I agree that it is really great to
> give back. Thank you.
>
> Elle.
>
>
>
>
>
> On Thu, Apr 15, 2010 at 9:12 AM, Yuval Levy wrote:
> > I should be packing boxes and the computer should be already in one of
> > them.
> > so concise and to the point:
>
> > On April 15, 2010 01:24:13 am Elle Yan wrote:
> > > I should have asked how to send a patch.
>
> > or read the messages on this mailing list. I think it was Antoine that
> > asked.
> > Learning from other peoples questions and answers is an important skill in
> > Open Source.
>
> > > Since everyone in the mailing list can see the email
> > > addresses of the senders, why are they private information?
>
> > everybody can see my phone number in the phone book but it is still private
> > information and an unsolicited call on it without permission is not a good
> > thing.
>
> > > > ... maybe you can explain why I didn't notice you in this community
> > > > before?
>
> > > I just started to communicate in the community recently. Before, when I
> > > reviewed the code base, and found very useful sources, I made use of
> > them,
> > > e.g. spline.cpp.
>
> > OpenSource 101: FEEDBACK. Saying "Thank You" when making use of the code.
>
> > > > can you share some links to code you committed in the repository of the
> > > > mentioned projects?
>
> > > I am happy to share some. I did not often commit to the repository of
> > large
> > > software though.
>
> > I don't expect you to have commit right to the repository of large
> > software.
>
> > OpenSource 102: Contribution starts with communication.
>
> > Usually forwarding the changes to a maintainer (somebody with access to the
> > repository); or publishing a patch somewhere. Subsequently the maintainer
> > may
> > or may not accept the patch. If the patch is accepted, it leaves a trace in
> > a
> > commit and most maintainers will credit the contributor in the commit log.
> > For
> > an example, see [0].
>
> > > Usually, I code for the software out of my own interest or
> > > goal. For example, I code within the code base, to make and change some
> > > features as I needed. Or, I use their routines or libraries. It is not
> > the
> > > formal commit.
>
> > OpenSource 103: it is common for people to code out of their own interest.
> > It's called "scratch your itches".
>
> > The spirit of Open Source is that when you make changes you publish them
> > for
> > the next person in your same situation. Sometimes this spirit is enshrined,
> > to
> > different extent, in the more or less permissive licenses.
>
> > > For smaller software, I did have many commits. It is open source projects
> > > locally in two universities. They do not currently have commit info on
> > line
> > > publicly.
>
> > Do they have the source code published in other form, e.g. a tarball?
>
> > OpenSource 104: Giving back to the general public is key to be a good Open
> > Source citizen. In the days prior
