[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-20 Thread T. Modes

Bruno Postle schrieb:
 Yes probably cpclean should only work with the Align... button
 immediately after running a control point generator.  If there are
 already points in the project then you should have to go to the
 Images tab an click the button to run it.


Ok, changed it. When working with Align cpclean runs only after
running a cp generator. For consistency I implemented the same
behaviour for celeste in the assistant.

Thomas
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Pablo d'Angelo

Bruno Postle wrote:
 
 Cpclean is ready to go in as far as I'm concerned, the only question 
 is do we run it automatically with the Align... button?:

If in doubt: Make it configurable. I guess that it should be done for 
people that use the automatic method. However, if somebody adds some 
control points manually and presses Align again, it might remove the 
manually added points, which is probably not desired...

ciao
   Pablo

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Lukáš Jirkovský

Hi all,

2009/9/19 Bruno Postle br...@postle.net:

 On Thu 17-Sep-2009 at 21:24 -0400, Yuval Levy wrote:

to list the PROJECTS:

 Layout still needs some work:

- gsoc_2009_layout (James' project)

 Deghosting shouldn't cause problems as the code doesn't alter the
 existing workflow, I'd like to hear if Lukáš thinks it is ready to
 go in:

- gsoc_2009_deghosting (Lukáš' project)

I've committed probably the last change seconds ago. Now I'm going to
begin new thread with call for testing.


 Vigra would be nice, though as Pablo says ideally we would merge the
 hugin bits with upstream:

- vigra-1.6 (Lukáš' patch from before 0.8.0)

Yep, I think too. The only big change is support of OpenEXR. The other
changes are rather small, IIRC it's only some Point2D stuff or
something similar which I'm not sure if it's really necessary. I
should note that there's one thing I'd like to change about EXR
implementation. I think I'll start another thread so I don't pollute
this one.


 Cpclean is ready to go in as far as I'm concerned, the only question
 is do we run it automatically with the Align... button?:

- control-point cleaning (Thomas patch)

 auto-crop is looking good, but needs a couple of things (like an
 icon) and some more testing:

- auto-crop (Gary's patch)

 These need a lot of work:

- gsoc_2008_masking (Fahim's project)
- gsoc_2008_feature_atching (Onur's project)

 --
 Bruno

 


Lukáš

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Yuval Levy

Pablo d'Angelo wrote:
 Bruno Postle wrote:
 Cpclean is ready to go in as far as I'm concerned, the only question 
 is do we run it automatically with the Align... button?:
 
 If in doubt: Make it configurable.

same for adding autocrop.

default for both should be on as the features are more likely to be 
useful than harmful for the occasional user.

An unobtrusive warning (on the Control Points tab?) that cpclean is 
enabled (not a pop up, but rather an informative text on red background 
in the tab itself, saying something like Cpclean is active and could 
remove manually added CPs) would be nice for advanced users.

Yuv

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Yuval Levy

T. Modes wrote:
 I have feedback that the current version run on all platforms (Win/
 Linux/MacOS).

+1 here


 There's a point more to consider: there are changes in libpano
 (multiviewpoint panorama, parameter Tx, Ty, Tz and Ts). Hugin needs to
 extend to make use of these new parameters. This should done after
 integration of layout-branch, because many internal were changed in
 it.

this code is not even written yet. I'd call it future planning rather 
than integration queue. It probably does not make sense to start 
writing it before the layout codeline is integrated.

Yuv

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Yuval Levy

Bruno Postle wrote:
 On Thu 17-Sep-2009 at 21:24 -0400, Yuval Levy wrote:
 to list the PROJECTS:
 
 Layout still needs some work:
 
 - gsoc_2009_layout (James' project)

so this is the most critical / important change of magnitude. What work 
does it still need?

Yuv

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Bruno Postle

On Sat 19-Sep-2009 at 09:16 +0200, Pablo d'Angelo wrote:

If in doubt: Make it configurable. I guess that it should be done for
people that use the automatic method. However, if somebody adds some
control points manually and presses Align again, it might remove the
manually added points, which is probably not desired...

In principle it should only remove such a point if it was 
inconsistent with the rest of the points - i.e. if was 'bad'.

-- 
Bruno

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-19 Thread Bruno Postle

On Sat 19-Sep-2009 at 14:05 -0400, Yuval Levy wrote:
Bruno Postle wrote:
 In principle it should only remove such a point if it was
 inconsistent with the rest of the points - i.e. if was 'bad'.

sometimes the manually added point is what the user intends - and it is
the rest of the points which are 'bad'. Good or bad is very subjective...

Yes probably cpclean should only work with the Align... button 
immediately after running a control point generator.  If there are 
already points in the project then you should have to go to the 
Images tab an click the button to run it.

-- 
Bruno

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-18 Thread Rogier Wolff

On Thu, Sep 17, 2009 at 09:24:42PM -0400, Yuval Levy wrote:
 We could accelerate the sequence. Trunk and release 2009.2 are nearly in 
 sync - lens calibration is the only difference. Once we release 2009.2.0 
 trunk is very near to release status. We could branch out immediately 
 2009.4.0_beta1 and within 1-2 weeks declare it 2009.4.0_RC1 and probably 
 also final. We could have a release every few weeks. But it would be 
 exhausting for the developers and confusing for the general public.

Yuv, my vote from the sideline is to prefer release often. I hope
that we don't get a lot of build problems again, once we've learned
how to fix them. I hope we can keep them fixed. So releasing 2009.02 +
lens calibration should be easy and not put a large load on everybody.

Roger.

-- 
** r.e.wo...@bitwizard.nl ** http://www.BitWizard.nl/ ** +31-15-2600998 **
**Delftechpark 26 2628 XH  Delft, The Netherlands. KVK: 27239233**
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement. 
Does it sit on the couch all day? Is it unemployed? Please be specific! 
Define 'it' and what it isn't doing. - Adapted from lxrbot FAQ

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---



[hugin-ptx] Re: Integration Queue - how do we add features to trunk and to release

2009-09-18 Thread Pablo d'Angelo

Yuval Levy schrieb:

 Hi all, particularly develoeprs,
 
 - vigra-1.6 (Lukáš' patch from before 0.8.0)

I think this is best done by adding the hugin changes to the main vigra 
lib. Most changes are related to the vigra impex functinality, and it 
shouldn't be hard to get them integrated (Maybe except for one place 
were I have changed the behaviour when saving floating point images into 
an integer format.)
After that we can simply wait until vigra 1.7.0 is released with our 
patches in and then remove vigra from our tree.

 - control-point cleaning (Thomas patch)
 - auto-crop (Gary's patch)
 - gsoc_2008_masking (Fahim's project)
 - gsoc_2008_feature_atching (Onur's project)
 
 The longer we wait, the more trunk will diverge and the more difficult 
 integration will become. Moreover, there is a risk that newer changes 
 will be implemented against the current trunk and will not be compatible 
 once what is in the queue enters trunk.
 
 I'd like to go systematically and efficiently through the integration of 
 the above features.
 
 There are three steps:
 1. Maturity
 2. Trunk Integration
 3. Release
 
 and then there is a
 4. Shortcut
 
 
 1. MATURITY
 
 Only mature codelines/patches will be considered for integration in trunk
 
   can we verify the maturity of the PROJECTS?

Build and test them!
Actually, I did start a little work on the feature matching, however 
this is half finished and does not even compile, so I haven't commited 
that yet.

I think the two remaining gsoc2008 are the ones that need most work, and 
therefore aren't in a position to be included before some work has been 
done on them.

 2. TRUNK INTEGRATION
 
 IMO there is currently one feature that needs this sort of special 
 attention: it is gsoc2009_layout. It introduces a very important, 
 significant and welcome change in the underlying panorama model. It 
 affects almost every part of the code. The longer we wait, the more 
 difficult it will be to integrate.
 
 The question (to James, and his mentor Bruno) is: is it mature? if yes, 
 when do you have time to take care of the integration?
 
 Planning around James' project: what should we send to integration 
 before and what after?

I haven't yet looked at:
- control-point cleaning (Thomas patch)
- auto-crop (Gary's patch)

but I suspect that they are not too dependent on the layout work. So 
they could go in either before or after James.

I think gsoc2009_layout should be integrated as soon as possible after 
2009.4, if the marturity allows it.

 4. SHORTCUT
 Specifically: lens calibration does not affect Hugin's main 
 functionality at all. Should we send one extra chunk of code with it, 
 and if yes which one?

I couldn't find the control point cleaning patch in the patches tracker 
of hugin, can somebody point me to it? It might a good candidate for 
merging into trunk before 2009.4

ciao
   Pablo

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
hugin and other free panoramic software group.
A list of frequently asked questions is available at: 
http://wiki.panotools.org/Hugin_FAQ
To post to this group, send email to hugin-ptx@googlegroups.com
To unsubscribe from this group, send email to 
hugin-ptx-unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/hugin-ptx
-~--~~~~--~~--~--~---