[hugin-ptx] Re: cmake not working
Am Freitag 18 September 2009 schrieb D M German:
> I have a problem with the cmake configuration for libpano.
>
> --
> d...@phosphorus:~/hacking/libpano$ cmake CMakeLists.txt
> CMake Error at CMakeLists.txt:38 (include):
> include could not find load file:
>
> HuginMacros
>
>
> CMake Error at
> /usr/share/cmake-2.6/Modules/FindPackageHandleStandardArgs.cmake:57
> (MESSAGE): Could NOT find wxWidgets (missing: wxWidgets_FOUND)
> Call Stack (most recent call first):
> /usr/share/cmake-2.6/Modules/FindwxWidgets.cmake:765
> (FIND_PACKAGE_HANDLE_STANDARD_ARGS) CMakeLists.txt:54 (FIND_PACKAGE)
>
>
> -- Configuring incomplete, errors occurred!
> d...@phosphorus:~/hacking/libpano$
> --
>
>
> Libpano is defined as dependent of hugin and wxWidgets. In my laptop I
> don't have neither one, so it fails.
>
> Libpano should not depend on hugin and wxwidgets. As far as I know,
> there is nothing on libpano that depends on hugin.
>
> Is this really necessary?
>
> libpano should depend only on zlib, java, libpng, libjpg, and libtiff.
>
> --dmg
We could make it dependent on WIN32.
In fact, here it compiles.
===
--- CMakeLists.txt (revision 1057)
+++ CMakeLists.txt (working copy)
@@ -34,8 +34,10 @@
set(CMAKE_MODULE_PATH ${SOURCE_BASE_DIR}/hugin/CMakeModules )
ENDIF ( HUGIN_BASE_DIR )
-## load the Hugin cmake modules
-include(HuginMacros)
+if(WIN32)
+ ## load the Hugin cmake modules
+ include(HuginMacros)
+endif()
include(CheckIncludeFiles)
## global setup
Kornel
--
Kornel Benko
kornel.be...@berlin.de
signature.asc
Description: This is a digitally signed message part.
[hugin-ptx] Re: cmake not working
Bruno Postle wrote: > On Fri 18-Sep-2009 at 13:22 -0700, Daniel M. German wrote: >> Libpano is defined as dependent of hugin and wxWidgets. In my laptop I >> don't have neither one, so it fails. >> >> Libpano should not depend on hugin and wxwidgets. As far as I know, >> there is nothing on libpano that depends on hugin. > > The cmake build system in libpano13 is primarily to make things > easier for building on Windows - wxwidgets contains local copies of > libtiff, libpng and libjpeg so these are used in the Windows build. right - then on the other side what is a CMake build worth if it adds dependencies when none are needed? we had this discussion when setting up the CMake build for enblend, and I think the same solution can and should be adopted for Libpano. Then it will behave how Daniel expects it. The initial draft of CMake build for Libpano by Tom Sharpless used Hugin's CMakeModules. The initial draft of CMake build for Enblend did the same. It was vetoed from the repository until it was made independent. This meant in the short term a duplication of Hugin's CMakeModules folder. That folder should anyway disappear with time - better use CMake's default FindXXX modules when they are available and work; and contribute improvements upstream. Yuv --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx -~--~~~~--~~--~--~---
[hugin-ptx] Re: cmake not working
On Fri 18-Sep-2009 at 13:22 -0700, Daniel M. German wrote: > >Libpano is defined as dependent of hugin and wxWidgets. In my laptop I >don't have neither one, so it fails. > >Libpano should not depend on hugin and wxwidgets. As far as I know, >there is nothing on libpano that depends on hugin. The cmake build system in libpano13 is primarily to make things easier for building on Windows - wxwidgets contains local copies of libtiff, libpng and libjpeg so these are used in the Windows build. -- Bruno --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "hugin and other free panoramic software" group. A list of frequently asked questions is available at: http://wiki.panotools.org/Hugin_FAQ To post to this group, send email to hugin-ptx@googlegroups.com To unsubscribe from this group, send email to hugin-ptx-unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/hugin-ptx -~--~~~~--~~--~--~---
