Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-07 Thread Jeff Squyres (jsquyres) 
On Feb 7, 2017, at 11:48 AM, Samuel Thibault  wrote:
> 
>> -AC_MSG_WARN([*** and binding will not be support.])
>> +AC_MSG_WARN([*** and binding will likely not be supported.])
> 
> Well, it's not really "likely": unsupported systems really won't have
> binding support.  For getting the number of processors we have a couple
> of more or less generic ways, but for binding we don't have any.

Fair enough, but the test itself is just a switch/case statement -- it's not an 
actual test to see if the system supports binding or not.  Hence, hedging the 
warning message a little seemed reasonable.

-- 
Jeff Squyres
jsquy...@cisco.com

___
hwloc-devel mailing list
hwloc-devel@lists.open-mpi.org
https://rfd.newmexicoconsortium.org/mailman/listinfo/hwloc-devel

Re: [hwloc-devel] hwloc.m4: minor english fixes

2017-02-07 Thread Samuel Thibault 
git...@open-mpi.org, on Tue 07 Feb 2017 09:15:01 -0600, wrote:
> commit 96a1a1b4d9f4d34e6b26ed4a665a739fd449131a
> Author: Jeff Squyres 
> Date:   Tue Feb 7 10:13:27 2017 -0500
> 
> hwloc.m4: minor english fixes
> 
> Signed-off-by: Jeff Squyres 
> 
> @@ -262,7 +262,7 @@ EOF])
>  AC_MSG_WARN([*** hwloc does not support this system.])
>  AC_MSG_WARN([*** hwloc will *attempt* to build (but it may not 
> work).])
>  AC_MSG_WARN([*** hwloc run-time results may be reduced to showing 
> just one processor,])
> -AC_MSG_WARN([*** and binding will not be support.])
> +AC_MSG_WARN([*** and binding will likely not be supported.])

Well, it's not really "likely": unsupported systems really won't have
binding support.  For getting the number of processors we have a couple
of more or less generic ways, but for binding we don't have any.

Samuel
___
hwloc-devel mailing list
hwloc-devel@lists.open-mpi.org
https://rfd.newmexicoconsortium.org/mailman/listinfo/hwloc-devel