Re: [hwloc-devel] want 1.0rc4?
Brice Goglin, le Tue 04 May 2010 07:54:47 +0200, a écrit : > line 41 of src/misc.c in hwloc_snprintf(): > > str = malloc(size); > > > I am not sure what to do about this one... Is there any value we could return > without possibly breaking the caller ? 0 seems relatively safe to me. At worse the caller allocates 0 bytes, which might also return ENOMEM, but that's up to him to handle it. Samuel
Re: [hwloc-devel] want 1.0rc4?
On 04/05/2010 03:57, Christopher Samuel wrote:
>
> On 03/05/10 09:57, Jeff Squyres wrote:
>
> > 1.0rc4 is up.
>
> Running coccicheck on 1.0rc4 flags up this construct, I presume
> as an ambiguous construction:
>
> if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) {
>
> That's at line 1518 of src/topology.c in hwloc_discover(). The
> check file simply says:
>
> // !x&y combines boolean negation with bitwise and
>
>
> It's also flagged some unchecked malloc()'s in various bits:
>
Thanks a lot, I think I fixed most of these.
> line 41 of src/misc.c in hwloc_snprintf():
>
> str = malloc(size);
>
I am not sure what to do about this one... Is there any value we could
return without possibly breaking the caller ?
Brice
Re: [hwloc-devel] want 1.0rc4?
Awesome; thanks Chris!
On May 3, 2010, at 8:57 PM, Christopher Samuel wrote:
> On 03/05/10 09:57, Jeff Squyres wrote:
>
> > 1.0rc4 is up.
>
> Running coccicheck on 1.0rc4 flags up this construct, I presume
> as an ambiguous construction:
>
> if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) {
>
> That's at line 1518 of src/topology.c in hwloc_discover(). The
> check file simply says:
>
> // !x&y combines boolean negation with bitwise and
>
>
> It's also flagged some unchecked malloc()'s in various bits:
>
>
> line 41 of src/misc.c in hwloc_snprintf():
>
> str = malloc(size);
>
>
> line 321 of src/topology-linux.c in hwloc_linux_get_proc_tids():
>
>tids = malloc(max_tids*sizeof(pid_t));
>
>
> line 328 of src/topology-linux.c in hwloc_linux_get_proc_tids():
>
>tids = realloc(tids, max_tids*sizeof(pid_t));
>
>
> line 1561 of src/topology.c in hwloc_discover():
>
>objs = malloc(n_objs * sizeof(objs[0]));
>
>
> Hope these are helpful!
> Chris
> --
> Christopher Samuel - Senior Systems Administrator
> VLSCI - Victorian Life Sciences Computational Initiative
> Email: sam...@unimelb.edu.au Phone: +61 (0)3 903 55545
> http://www.vlsci.unimelb.edu.au/
>
> ___
> hwloc-devel mailing list
> hwloc-de...@open-mpi.org
> http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel
--
Jeff Squyres
jsquy...@cisco.com
For corporate legal information go to:
http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [hwloc-devel] want 1.0rc4?
On 03/05/10 09:57, Jeff Squyres wrote:
> 1.0rc4 is up.
Running coccicheck on 1.0rc4 flags up this construct, I presume
as an ambiguous construction:
if (!topology->flags & HWLOC_TOPOLOGY_FLAG_WHOLE_SYSTEM) {
That's at line 1518 of src/topology.c in hwloc_discover(). The
check file simply says:
// !x&y combines boolean negation with bitwise and
It's also flagged some unchecked malloc()'s in various bits:
line 41 of src/misc.c in hwloc_snprintf():
str = malloc(size);
line 321 of src/topology-linux.c in hwloc_linux_get_proc_tids():
tids = malloc(max_tids*sizeof(pid_t));
line 328 of src/topology-linux.c in hwloc_linux_get_proc_tids():
tids = realloc(tids, max_tids*sizeof(pid_t));
line 1561 of src/topology.c in hwloc_discover():
objs = malloc(n_objs * sizeof(objs[0]));
Hope these are helpful!
Chris
--
Christopher Samuel - Senior Systems Administrator
VLSCI - Victorian Life Sciences Computational Initiative
Email: sam...@unimelb.edu.au Phone: +61 (0)3 903 55545
http://www.vlsci.unimelb.edu.au/
Re: [hwloc-devel] want 1.0rc4?
Posted. On May 3, 2010, at 10:37 AM, Samuel Thibault wrote: > Jeff Squyres, le Mon 03 May 2010 09:57:09 -0400, a écrit : > > 1.0rc4 is up. Send me a windows binary when you get a chance. > > http://dept-info.labri.fr/~thibault/tmp/hwloc-win32-build-1.0rc4.zip > > Samuel > ___ > hwloc-devel mailing list > hwloc-de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel > -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [hwloc-devel] want 1.0rc4?
Jeff Squyres, le Mon 03 May 2010 09:57:09 -0400, a écrit : > 1.0rc4 is up. Send me a windows binary when you get a chance. http://dept-info.labri.fr/~thibault/tmp/hwloc-win32-build-1.0rc4.zip Samuel
Re: [hwloc-devel] want 1.0rc4?
1.0rc4 is up. Send me a windows binary when you get a chance. On May 3, 2010, at 9:30 AM, Samuel Thibault wrote: > Jeff Squyres, le Mon 03 May 2010 09:28:41 -0400, a écrit : > > I see a flurry of windows-related activity over the weekend. > > > > Do you guys want me to cut rc4? > > I'm done with what I wanted to fix in rc3. > > Samuel > ___ > hwloc-devel mailing list > hwloc-de...@open-mpi.org > http://www.open-mpi.org/mailman/listinfo.cgi/hwloc-devel > -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
Re: [hwloc-devel] want 1.0rc4?
Jeff Squyres, le Mon 03 May 2010 09:28:41 -0400, a écrit : > I see a flurry of windows-related activity over the weekend. > > Do you guys want me to cut rc4? I'm done with what I wanted to fix in rc3. Samuel
[hwloc-devel] want 1.0rc4?
I see a flurry of windows-related activity over the weekend. Do you guys want me to cut rc4? -- Jeff Squyres jsquy...@cisco.com For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/
