Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Kevin Locke]

On 01/12/2016 10:20 AM, Henrique de Moraes Holschuh wrote:
> On Tue, Jan 12, 2016, at 16:11, Kevin Locke wrote:
>> I looked through the DSDT and SSDT AML on the T430 (which also has both
>> a keyboard backlight and ThinkLight) and couldn't deduce which method
>> was being invoked for Fn+Space or an analog to MLCG/MLCS for the
>> ThinkLight.  However, that may be due to my inexperience interpreting
>> AML.  I'll keep looking/learning.
>
> It calls directly into the SMBIOS :-(

Bummer!  Thank you for taking the time to figure that out.

Kevin

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Henrique de Moraes Holschuh]

On Tue, Jan 12, 2016, at 14:59, Darren Hart wrote:
> Gah, these two threads landed next to each other in my Inbox and I didn't
> pick
> up the split. Apologies.
> 
> This is queued in testing (again).

Thanks!

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] More info onsuspend / resume bug

[jonnie o]

Sorry, link got mangled: https://bugzilla.kernel.org/show_bug.cgi?id=100171 

On Tuesday, 12 January 2016, 17:48, jonnie o  wrote:
 

 Hi, this is a showstopper bug, widely reported, but it seems to be getting no 
attention from ibm-acpi developers, despite a number of people willing to test 
solutions. See for example, info and thread here: 
https://bugzilla.kernel.org/show_bug.cgi?id=100171Is there anyone in particular 
we could contact about this?Best,Jonathan 

On Wednesday, 6 January 2016, 12:30, jonnie o  wrote:
 

 There are a couple of reports of this, and I've been experiencing the bug as 
well.E.g.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1520965?comments=all(with 
the most info on the bug)but also 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1424088http://www.spinics.net/lists/linux-acpi/msg57234.htmletc.

I am happy to help with any testing. Currently running kernel
4.4.0-999-generic #201512172100 SMP Fri Dec 18 02:02:38 UTC 2015 x86_64 x86_64 
x86_64 GNU/Linux
Best,Jonathan








   

   --
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Pavel Machek]

Hi!

On Mon 2016-01-11 21:03:01, Pali Rohár wrote:
> On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> > The two features are not the same (and are handled differently by the
> > firmware, for whatever reason), although they do serve the same
> > purpose. I don't think a thinkpad will ever have both features at
> > the same time, so I have no idea why they changed the firmware
> > interface.
> 
> Maybe we should decide if ::kbd_backlight LED suffix could be used also 
> for other LED devices and not only for those which are physically under 
> the keyboard.

Another problem is that N900 has _6_ backlight LEDs. Named
lp5523::kb1..6. ... Which does means desktop software will probably
not pick them up :-(. 

I guess we could have "/sys/class/kbd_light/brightness" that would
control all of them with one write.

Next question is.. apparently there are some keyboards that have
per-key RGB backlight... but maybe we can just call that "weird
enough" and ignore...

Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) 
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Henrique de Moraes Holschuh]

On Mon, Jan 11, 2016, at 18:03, Pali Rohár wrote:
> On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> > The two features are not the same (and are handled differently by the
> > firmware, for whatever reason), although they do serve the same
> > purpose. I don't think a thinkpad will ever have both features at
> > the same time, so I have no idea why they changed the firmware
> > interface.
> 
> Maybe we should decide if ::kbd_backlight LED suffix could be used also 
> for other LED devices and not only for those which are physically under 
> the keyboard.

Maybe, but that doesn't matter for thinkpad-acpi: the "thinklight" LED
name is kernel-userspace ABI so frozen by years and years of use that it
is not even funny.  It cannot be changed.

> At least I understand "keyboard backlight" as light which is under the 
> keyboard...

So do I...

> And more important, I was told that ThinkPad x230 comes in variant with 
> both ThinkLight (that LED upper the display) and keyboard backlight 
> (under they keyboard).

Ok, so there is yet another damn good reason to keep both separate.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

[ibm-acpi-devel] More info onsuspend / resume bug

[jonnie o]

Hi, this is a showstopper bug, widely reported, but it seems to be getting no 
attention from ibm-acpi developers, despite a number of people willing to test 
solutions. See for example, info and thread here: 
https://bugzilla.kernel.org/show_bug.cgi?id=100171Is there anyone in particular 
we could contact about this?Best,Jonathan 

On Wednesday, 6 January 2016, 12:30, jonnie o  wrote:
 

 There are a couple of reports of this, and I've been experiencing the bug as 
well.E.g.
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1520965?comments=all(with 
the most info on the bug)but also 
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1424088http://www.spinics.net/lists/linux-acpi/msg57234.htmletc.

I am happy to help with any testing. Currently running kernel
4.4.0-999-generic #201512172100 SMP Fri Dec 18 02:02:38 UTC 2015 x86_64 x86_64 
x86_64 GNU/Linux
Best,Jonathan








   --
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Darren Hart]

On Mon, Jan 11, 2016 at 05:28:00PM -0200, Henrique de Moraes Holschuh wrote:
 > 
> > Henrique, so are you taking back your Ack from 10 minutes prior?
> 
> Hmm? No, the ACK stands.
> 
> Pavel was talking about another feature altogether, apparently: older
> thinkpads did not have "keyboard backlight" (as in light from below the
> keys).  They had a "ThinkLight", which is an overhead light that shines
> down on the keyboard.
> 
> The two features are not the same (and are handled differently by the
> firmware, for whatever reason), although they do serve the same purpose.
>  I don't think a thinkpad will ever have both features at the same time,
> so I have no idea why they changed the firmware interface.
> 
> The patch adds support to the "keyboard backlight" feature, which was
> previously NOT supported.
> 
> > I've dropped this patch. Please let me know if I should pick it back up.
> 
> Please pick it back up.
> 

Gah, these two threads landed next to each other in my Inbox and I didn't pick
up the split. Apologies.

This is queued in testing (again).

-- 
Darren Hart
Intel Open Source Technology Center

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Yves-Alexis Perez]

On mar., 2016-01-12 at 14:07 -0200, Henrique de Moraes Holschuh wrote:
> We likely need to integrate better (future work) the new backlight
> control with the thinklight control and the firmware interface in the
> x230.

Ok so I've just checked my work X230, and I was just wrong: no ThinkLight on
it, although I really had the impression there /was/ a dual generation.

Regards,
-- 
Yves-Alexis



signature.asc
Description: This is a digitally signed message part
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel

Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Add support for keyboard backlight

[Henrique de Moraes Holschuh]

On Mon, Jan 11, 2016, at 19:12, Johannes Stezenbach wrote:
> On Mon, Jan 11, 2016 at 09:03:01PM +0100, Pali Rohár wrote:
> > On Monday 11 January 2016 20:28:00 Henrique de Moraes Holschuh wrote
> > > The two features are not the same (and are handled differently by the
> > > firmware, for whatever reason), although they do serve the same
> > > purpose. I don't think a thinkpad will ever have both features at
> > > the same time, so I have no idea why they changed the firmware
> > > interface.
> ...
> > And more important, I was told that ThinkPad x230 comes in variant with 
> > both ThinkLight (that LED upper the display) and keyboard backlight 
> > (under they keyboard).
> 
> I can confirm this, my x230 has both.  FWIW, BIOS hotkey
> Fn+Space cycles through off, dim backlight, full backlight
> and full thinklight. /sys/class/leds/tpacpi::thinklight/brightness
> can be read (showing either 0 or 255) but writes are ignored.
> Dito for /proc/acpi/ibm/light.

We likely need to integrate better (future work) the new backlight
control with the thinklight control and the firmware interface in the
x230.

Is the ACPI AML for fn+space readable enough, or is it trapping directly
into SMM?  Because if it interacts with the traditional higher-level
ACPI AML we already use to talk to the thinklight (and now to the
backlight), it should be relatively easy to fix the driver to better
support the x230.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month
Monitor end-to-end web transactions and take corrective actions now
Troubleshoot faster and improve end-user experience. Signup Now!
http://pubads.g.doubleclick.net/gampad/clk?id=267308311=/4140
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel