Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: adding new hotkey ID for Lenovo thinkpad
On 12/13/2016 02:23 AM, Darren Hart wrote: > On Tue, Nov 08, 2016 at 04:13:23PM +0800, Hui Wang wrote: >> Recently we met an issue on lots of Lenovo thinkpad laptops (those >> laptops are not released to market yet), the issue is that the >> thinkpad_acpi.ko can't be automatically loaded as before. >> >> Through debugging, we found the HKEY_HID is LEN0268 instead of >> LEN0068 on those machines, and the MHKV is 0x200 instead of >> 0x100. So adding the new ID into the driver. >> >> Signed-off-by: Hui Wang > With Henrique's ack, I've queued this to testing. > > However, in the commit message you mention two deltas: > > 1) HKEY_HID is LEN0268 > 2) MHKV is 0x200 > > This patch appears to address only #1. Is another patch needed for #2? The #2 was already addressed by the commit: commit 0118c2d3eac0545d4095877e5a015b5dc763b3c2 Author: Dennis Wassenberg Date: Wed Jun 8 10:54:25 2016 -0400 thinkpad_acpi: Add support for HKEY version 0x200 Lenovo Thinkpad devices T460, T460s, T460p, T560, X260 use HKEY version 0x200 without adaptive keyboard. HKEY version 0x200 has method MHKA with one parameter value. Passing parameter value 1 will get hotkey_all_mask (the same like HKEY version 0x100 without parameter). Passing parameter value 2 to MHKA method will retrieve hotkey_all_adaptive_mask. If 0 is returned in that case there is no adaptive keyboard available. It looks like the Lenovo machines have the change for HKEY_HID and MHKV as below: in the past: HKEY_HID=LEN0068 MHKV=0x100 about one year ago: HKEY_HID=LEN0068 MHKV=0x200 recently: HKEY_HID=LEN0268 MHKV=0x200 Cheers, Hui. > > (I'm digging myself out of a deep backlog, so if it's here already, I'll find > it, but it might expedite things to point it out to me). > > Thanks for the patch. > -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: Fix old style declaration GCC warning
On Fri, Nov 25, 2016 at 01:31:30PM -0200, Henrique de Moraes Holschuh wrote: > On Fri, 25 Nov 2016, Tobias Klauser wrote: > > Fix an [-Wold-style-declaration] GCC warning by moving the inline > > keyword before the return type. > > > > Signed-off-by: Tobias Klauser > > Acked-by: Henrique de Moraes Holschuh > Queued to testing, thank you. -- Darren Hart Intel Open Source Technology Center -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH] thinkpad_acpi: adding new hotkey ID for Lenovo thinkpad
On Tue, Nov 08, 2016 at 04:13:23PM +0800, Hui Wang wrote: > Recently we met an issue on lots of Lenovo thinkpad laptops (those > laptops are not released to market yet), the issue is that the > thinkpad_acpi.ko can't be automatically loaded as before. > > Through debugging, we found the HKEY_HID is LEN0268 instead of > LEN0068 on those machines, and the MHKV is 0x200 instead of > 0x100. So adding the new ID into the driver. > > Signed-off-by: Hui Wang With Henrique's ack, I've queued this to testing. However, in the commit message you mention two deltas: 1) HKEY_HID is LEN0268 2) MHKV is 0x200 This patch appears to address only #1. Is another patch needed for #2? (I'm digging myself out of a deep backlog, so if it's here already, I'll find it, but it might expedite things to point it out to me). Thanks for the patch. -- Darren Hart Intel Open Source Technology Center -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] [PATCH v5 2/2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode
On Fri, Nov 11, 2016 at 03:15:03PM -0500, Lyude wrote: > For whatever reason, the X1 Yoga doesn't support the normal method of > querying for tablet mode. Instead of providing the MHKG method under the > hotkey handle, we're instead given the CMMD method under the EC handle. > Values on this handle are either 0x1, laptop mode, or 0x6, tablet mode. > > Tested-by: Daniel Martin > Signed-off-by: Lyude Our apologies for the delay. Thank you for the updates. Queued to testing. -- Darren Hart Intel Open Source Technology Center -- Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
