Re: [ibm-acpi-devel] Duplicate key press events
On 7 August 2011 15:39, Henrique de Moraes Holschuh wrote: > If it is an EC bug or an ACPI firmware bug we cannot work around, we add an > event filter. Otherwise, we can try to fix it in a better way. Right, makes sense. I'm back from the conference now, and apologies for the delay. > Ok. Let's do it this way, then: please do a full acpi and dmidecode dump > of your current BIOS, gzip them (remove UUIDs/serial numbers) and send them > to us. Then, update the BIOS and EC, and do the same. That will help me do > a differential analysis if the update happens to fix the bug. I've uploaded them here, as it's over 100k in size: http://people.freedesktop.org/~hughsient/temp/acpi-hotkeys-hughsie.tar.bz2 > BTW, latest firmware for your box is version 1.46: 6MET86WW/6MHT45WW > There are important fixes if you can read between the lines of Lenovo > changelogs, but they are related to EC firmware bugs on the KBC emulation > and battery control. You really ought to update, but the chances of it > fixing the double-event-reporting issues are low. Those changelogs are very > incomplete. There appears to me no changes to my bug on the 1.46 update, and I still get duplicate events from the thinkpad input device and the acpi input device. Also, brightness_mode and brightness_enable are unchanged. Thanks for any help, Richard. -- uberSVN's rich system and user administration capabilities and model configuration take the hassle out of deploying and managing Subversion and the tools developers use with it. Learn more about uberSVN and get a free download at: http://p.sf.net/sfu/wandisco-dev2dev ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] Duplicate key press events
On Sun, 07 Aug 2011, Richard Hughes wrote: > [ 5079.277863] thinkpad_acpi: ThinkPad BIOS 6MET81WW (1.41 ), EC 6MHT43WW-1.18 > [ 5079.277867] thinkpad_acpi: Lenovo ThinkPad T510, model 4384BR2 ... > > Do you have acpi_fakekeys or any other such crap loaded? If you do, > > kill it and check if the problem goes away, please. > > Nope, it's Fedora 15 without all the Ubuntu fakekey stuff. The event > is coming from a thinkpad_acpi-generated input device for sure. Ok. Now we hunt down how the events are generated by the DSDT and SSDT and check whether it is an ACPI firmware bug, or something we are not doing right, or an EC bug. If it is an EC bug or an ACPI firmware bug we cannot work around, we add an event filter. Otherwise, we can try to fix it in a better way. > > BTW: dmidecode output, please. And if your firmware is not the latest > > (BIOS/UEFI/EC), please update it and check whether the problem goes away... > > I'm on 1.41, and the latest is 1.44 (I'm at a conference now, and > can't update the BIOS right now). I can update this when I get home if > you like in one weeks time. I'm also pretty sure most non-geeky people > don't ever update the BIOS, and it should probably work without a BIOS > update too. Ok. Let's do it this way, then: please do a full acpi and dmidecode dump of your current BIOS, gzip them (remove UUIDs/serial numbers) and send them to us. Then, update the BIOS and EC, and do the same. That will help me do a differential analysis if the update happens to fix the bug. After I get both dumps, I will try to find out what we're doing wrong, if anything, and come up with a solution. BTW, latest firmware for your box is version 1.46: 6MET86WW/6MHT45WW Changelog at: http://download.lenovo.com/ibmdl/pub/pc/pccbbs/mobiles/6muj25uc.txt There are important fixes if you can read between the lines of Lenovo changelogs, but they are related to EC firmware bugs on the KBC emulation and battery control. You really ought to update, but the chances of it fixing the double-event-reporting issues are low. Those changelogs are very incomplete. As for requesting BIOS updates from users: on thinkpads, you _REALLY_ have to update the firmware, because that's exactly what >95% of the users will do (Windows ThinkVantage makes it _really_ easy and automatic). Obviously we _will_ try to work around any dangerous BIOS bugs regardless of them being fixed in a BIOS update, but there are very good reasons for the thinkpad driver to have a facilty to whitelist/blacklist firmwares and warn the users that they need to update. And I just found out that now the battery pack firmware can also be upgraded. Joy. I *REALLY* need to get myself a 510/520-series box: http://support.lenovo.com/en_US/downloads/detail.page?DocID=DS003186 "What is Battery Firmware Update Utility? This battery firmware update utility fixes an issue where some batteries indicate an incorrect full charge capacity value. Because of this error, the amount of energy available for use is artificially low, decreasing the amount of time the system can be used on battery. The fix is entirely contained in the battery firmware update; there is no need to replace any hardware for this problem. The battery firmware update requires that a supporting Power Management driver and BIOS are installed. Lenovo has bundled the necessary dependencies and the battery firmware update into a common package. During the update, the system may reboot, or be shut down." Oh dear... Well, let me warn everybody about this one. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] Duplicate key press events
On 7 August 2011 13:30, Yves-Alexis Perez wrote: > Most non-geeky people use windows and have bios upgrade in thinkvantage, > I guess. Updating bios is *not* hard and Henrique said numerous time how > critical it was to have up to date ones. Point taken. I'll give the new BIOS a go when I get back from GUADEC. Richard. -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] Duplicate key press events
On dim., 2011-08-07 at 10:33 +0200, Richard Hughes wrote: > I'm on 1.41, and the latest is 1.44 (I'm at a conference now, and > can't update the BIOS right now). I can update this when I get home if > you like in one weeks time. I'm also pretty sure most non-geeky people > don't ever update the BIOS, and it should probably work without a BIOS > update too. Most non-geeky people use windows and have bios upgrade in thinkvantage, I guess. Updating bios is *not* hard and Henrique said numerous time how critical it was to have up to date ones. Regards, -- Yves-Alexis signature.asc Description: This is a digitally signed message part -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] Duplicate key press events
On 5 August 2011 12:38, Henrique de Moraes Holschuh wrote: > Force it to zero on driver load (modprobe thinkpad_acpi > brightness_enable=0). What does the driver says in dmesg/kernel log ? [ 5079.277852] thinkpad_acpi: ThinkPad ACPI Extras v0.24 [ 5079.277858] thinkpad_acpi: http://ibm-acpi.sf.net/ [ 5079.277863] thinkpad_acpi: ThinkPad BIOS 6MET81WW (1.41 ), EC 6MHT43WW-1.18 [ 5079.277867] thinkpad_acpi: Lenovo ThinkPad T510, model 4384BR2 [ 5079.279033] thinkpad_acpi: detected a 8-level brightness capable ThinkPad [ 5079.280951] thinkpad_acpi: radio switch found; radios are enabled [ 5079.295013] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is unblocked [ 5079.300894] Registered led device: tpacpi::thinklight [ 5079.301819] Registered led device: tpacpi::power [ 5079.302817] Registered led device: tpacpi::standby [ 5079.303796] Registered led device: tpacpi::thinkvantage [ 5079.335263] thinkpad_acpi: Console audio control enabled, mode: monitor (read only) [ 5079.341971] input: ThinkPad Extra Buttons as /devices/platform/thinkpad_acpi/input/input13 > Do you have acpi_fakekeys or any other such crap loaded? If you do, > kill it and check if the problem goes away, please. Nope, it's Fedora 15 without all the Ubuntu fakekey stuff. The event is coming from a thinkpad_acpi-generated input device for sure. > BTW: dmidecode output, please. And if your firmware is not the latest > (BIOS/UEFI/EC), please update it and check whether the problem goes away... I'm on 1.41, and the latest is 1.44 (I'm at a conference now, and can't update the BIOS right now). I can update this when I get home if you like in one weeks time. I'm also pretty sure most non-geeky people don't ever update the BIOS, and it should probably work without a BIOS update too. I've attached my dmidecode. Thanks for any help, Richard. # dmidecode 2.11 SMBIOS 2.6 present. 78 structures occupying 2861 bytes. Table at 0x000E0010. Handle 0x, DMI type 0, 24 bytes BIOS Information Vendor: LENOVO Version: 6MET81WW (1.41 ) Release Date: 10/26/2010 Address: 0xE Runtime Size: 128 kB ROM Size: 8192 kB Characteristics: PCI is supported PC Card (PCMCIA) is supported PNP is supported BIOS is upgradeable BIOS shadowing is allowed ESCD support is available Boot from CD is supported Selectable boot is supported EDD is supported 3.5"/720 kB floppy services are supported (int 13h) Print screen service is supported (int 5h) 8042 keyboard services are supported (int 9h) Serial services are supported (int 14h) Printer services are supported (int 17h) CGA/mono video services are supported (int 10h) ACPI is supported USB legacy is supported BIOS boot specification is supported Targeted content distribution is supported BIOS Revision: 1.65 Firmware Revision: 1.24 Handle 0x0001, DMI type 1, 27 bytes System Information Manufacturer: LENOVO Product Name: 4384BR2 Version: ThinkPad T510 Serial Number: R9APVPK UUID: ---- Wake-up Type: Power Switch SKU Number: Not Specified Family: ThinkPad T510 Handle 0x0002, DMI type 2, 15 bytes Base Board Information Manufacturer: LENOVO Product Name: 4384BR2 Version: Not Available Serial Number: 1ZJGE11D2DH Asset Tag: Not Specified Features: None Location In Chassis: Not Specified Chassis Handle: 0x Type: Unknown Contained Object Handles: 0 Handle 0x0003, DMI type 3, 21 bytes Chassis Information Manufacturer: LENOVO Type: Notebook Lock: Not Present Version: Not Available Serial Number: R9APVPK Asset Tag: No Asset Information Boot-up State: Unknown Power Supply State: Unknown Thermal State: Unknown Security Status: Unknown OEM Information: 0x Height: Unspecified Number Of Power Cords: Unspecified Contained Elements: 0 Handle 0x0004, DMI type 126, 21 bytes Inactive Handle 0x0005, DMI type 126, 21 bytes Inactive Handle 0x0006, DMI type 4, 42 bytes Processor Information Socket Designation: None Type: Central Processor Family: Other Manufacturer: GenuineIntel ID: 55 06 02 00 FF FB EB BF Version: Intel(R) Core(TM) i7 CPU M 620 @ 2.67GHz Voltage: 1.3 V External Clock: 133 MHz Max Speed: 2660 MHz Current Speed: 2660 MHz Status: Populated, Enabled Upgrade: None L1 Cache Handle: 0x000A L2 Cache Handle: 0x000B L3 Cache Handle: 0x0
Re: [ibm-acpi-devel] Duplicate key press events
On Fri, 05 Aug 2011, Richard Hughes wrote: > [hughsie@hughsie-t510 ~]$ cat > /sys/module/thinkpad_acpi/parameters/brightness_enable > 2 Force it to zero on driver load (modprobe thinkpad_acpi brightness_enable=0). What does the driver says in dmesg/kernel log ? Still, event reporting doesn't depend on the brightness subdriver being loaded, we do not filter events based on which driver got loaded. The ACPI firmware is usually very good about not issuing events that are innapropriate. Do you have acpi_fakekeys or any other such crap loaded? If you do, kill it and check if the problem goes away, please. If we _do_ track it down to the firmware, I can come up with something that will filter it. BTW: dmidecode output, please. And if your firmware is not the latest (BIOS/UEFI/EC), please update it and check whether the problem goes away... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] Duplicate key press events
On 5 August 2011 07:11, Yves-Alexis Perez wrote: > On jeu., 2011-08-04 at 22:30 +0100, Richard Hughes wrote: >> After talking to Matthew Garrett, he tells me the thinkpad-acpi driver >> event shouldn't be emitted if the computer has ACPI video support. >> > Check how thinkpad-acpi is loaded, check that brightness_enable is not > set or 0. [hughsie@hughsie-t510 ~]$ cat /sys/module/thinkpad_acpi/parameters/brightness_enable 2 [hughsie@hughsie-t510 ~]$ cat /sys/module/thinkpad_acpi/parameters/brightness_mode 4 So same as you. Richard. -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] Duplicate key press events
On jeu., 2011-08-04 at 22:30 +0100, Richard Hughes wrote: > After talking to Matthew Garrett, he tells me the thinkpad-acpi driver > event shouldn't be emitted if the computer has ACPI video support. > Check how thinkpad-acpi is loaded, check that brightness_enable is not set or 0. Though here on my x201s (where things are working correctly): /sys/module/thinkpad_acpi/parameters/brightness_enable:2 /sys/module/thinkpad_acpi/parameters/brightness_mode:4 Regards, -- Yves-Alexis signature.asc Description: This is a digitally signed message part -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
[ibm-acpi-devel] Duplicate key press events
When pressing the brightness up and brightness down buttons on my T510 I get two events per-keypress from X, with the exact same timestamp. After using evtest I get one event from "Video Bus" and another from "ThinkPad Extra Buttons": Event: time 1312492437.841546, type 4 (Misc), code 4 (ScanCode), value 10 Event: time 1312492437.841550, type 1 (Key), code 224 (Brightness down), value 1 After talking to Matthew Garrett, he tells me the thinkpad-acpi driver event shouldn't be emitted if the computer has ACPI video support. This is with 2.6.40-4.fc15.x86_64, although I can test with linux-2.6 if you want. Advice welcome. Thanks. Richard. -- BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA The must-attend event for mobile developers. Connect with experts. Get tools for creating Super Apps. See the latest technologies. Sessions, hands-on labs, demos & much more. Register early & save! http://p.sf.net/sfu/rim-blackberry-1 ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
