Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
On Wed, 19 May 2010, Jerone Young wrote: > Henrique, > This patch didn't make your merge request? Any reason why? Here is a > picture of the T410 keyboard: > http://images.anandtech.com/reviews/mobile/2010/lenovo-thinkpad-t410/lenovo-thinkpad-t410-keyboard-sm.jpg I am a bit short on time, so I just sent the stuff I had already reviewed before the window closed. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
Henrique,
This patch didn't make your merge request? Any reason why? Here is a
picture of the T410 keyboard:
http://images.anandtech.com/reviews/mobile/2010/lenovo-thinkpad-t410/lenovo-thinkpad-t410-keyboard-sm.jpg
Thanks,
Jerone
On Sun, 2010-04-25 at 23:51 -0500, Jerone Young wrote:
> Tested on a Thinkpad T410. Works. Also maps key to the same hotkey to
> the same key as the lenovo thinkpad usb keyboard maps it to in udev
> keymap file.
>
> Acked-by: Jerone Young
>
> On Tue, 2010-04-20 at 23:05 +0200, Jens Taprogge wrote:
> > On the T410s and most likely other current models Fn-F6 is labeled as
> > Camera/Headphone key. Report key presses as KEY_CAMERA.
> >
> > Please review and apply if appropriate.
> >
> > Signed-off-by: Jens Taprogge
> > ---
> > drivers/platform/x86/thinkpad_acpi.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/platform/x86/thinkpad_acpi.c
> > b/drivers/platform/x86/thinkpad_acpi.c
> > index 2cee76c..04c1e8c 100644
> > --- a/drivers/platform/x86/thinkpad_acpi.c
> > +++ b/drivers/platform/x86/thinkpad_acpi.c
> > @@ -3152,7 +3152,7 @@ static int __init hotkey_init(struct ibm_init_struct
> > *iibm)
> > static u16 lenovo_keycode_map[] __initdata = {
> > /* Scan Codes 0x00 to 0x0B: ACPI HKEY FN+F1..F12 */
> > KEY_FN_F1, KEY_COFFEE, KEY_BATTERY,KEY_SLEEP,
> > - KEY_WLAN, KEY_FN_F6, KEY_SWITCHVIDEOMODE, KEY_FN_F8,
> > + KEY_WLAN, KEY_CAMERA, KEY_SWITCHVIDEOMODE, KEY_FN_F8,
> > KEY_FN_F9, KEY_FN_F10, KEY_FN_F11, KEY_SUSPEND,
> >
> > /* Scan codes 0x0C to 0x1F: Other ACPI HKEY hot keys */
>
>
>
> --
> ___
> ibm-acpi-devel mailing list
> ibm-acpi-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
--
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
On ven., 2010-04-30 at 20:29 -0500, Jerone Young wrote: > Yes. > I actually sent the support to udev for the USB keyboard ;-) Thank your for that. Indeed I have /lib/udev/keymaps/lenovo-thinkpad-usb-keyboard-trackpoint. > > I have it and love it, why made sure has support in udev. Works great > in Ubuntu 10.04 (I'm biased of course). But any newer distro should pull > in the udev rules soon (if they havn't already). Debian has :) > > > Hal get events for: > > Fn+F2 (lock, sent as “XF86Screensaver” to wm) > > Fn+F3 (battery, not really useful on a desktop box :) > > Fn+F4 (sleep, can be catched by xfce4-power-manager) > > Fn+F5 (wlan, which I don't have either) > > Fn+F6 (camera) > > Fn+F7 (switch-videomode) > > Fn+F8 (f22) > > Fn+F12 (hibernate, sent to xfpm too) > > Fn+space (zoom) > > Fn+arrows (multimedia keys, play/pause/prev/next) > > Fn+home/end (brightness, though it does nothing on a desktop box) > > > Correct. But if you use these on ... say on a thinkpad they do work. That's good to know. > > What doesn't work: > > output mute led > > input (mic) mute led > > input (mic) mute key > > These have to be lighted via: > 1) Need a kernel module to expose the LEDS for it > 2) Need a daemon to monitor and light them up when the need to be on. > > This is the same under Windows. You have to install the special Lenovo > software for the the LEDs to cut on for the volume & mic mute. Though > you need the special software for the hotkeys as well. Yeah, I have to admit I'm not really sure it's worth it, but maybe at one point the heaviest desktop environment might include something like that (in an audio daemon or something). For the kernel part, I'm not sure it'd be worth having a kernel module just for a keyboard :) Cheers, -- Yves-Alexis signature.asc Description: This is a digitally signed message part -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
Yes. I actually sent the support to udev for the USB keyboard ;-) On Fri, 2010-04-30 at 08:27 +0200, Yves-Alexis Perez wrote: > On mer., 2010-04-21 at 19:00 -0300, Henrique de Moraes Holschuh wrote: > > I really should get people to send me keyboard photos of all models, so > > that I could have a per-model keymap, it would not waste any kernel > > runtime memory since they're discarded when the module installs > > itself... > > As a side note, would you be interested by the USB keyboard with > trackpoint (55Y9003)? It should be the same keyboard as the T400s. Works > fine, mostly. I have it and love it, why made sure has support in udev. Works great in Ubuntu 10.04 (I'm biased of course). But any newer distro should pull in the udev rules soon (if they havn't already). > Hal get events for: > Fn+F2 (lock, sent as “XF86Screensaver” to wm) > Fn+F3 (battery, not really useful on a desktop box :) > Fn+F4 (sleep, can be catched by xfce4-power-manager) > Fn+F5 (wlan, which I don't have either) > Fn+F6 (camera) > Fn+F7 (switch-videomode) > Fn+F8 (f22) > Fn+F12 (hibernate, sent to xfpm too) > Fn+space (zoom) > Fn+arrows (multimedia keys, play/pause/prev/next) > Fn+home/end (brightness, though it does nothing on a desktop box) > Correct. But if you use these on ... say on a thinkpad they do work. > > Key are sent to the wm for > Thinkvantage (XF86Launch1) > Caps-lock led > Yes. You can map this. > What else work: > Fn+Scrlk (numlock, but there's no led to indicate the status) > What doesn't work: > output mute led > input (mic) mute led > input (mic) mute key These have to be lighted via: 1) Need a kernel module to expose the LEDS for it 2) Need a daemon to monitor and light them up when the need to be on. This is the same under Windows. You have to install the special Lenovo software for the the LEDs to cut on for the volume & mic mute. Though you need the special software for the hotkeys as well. > > This is on 2.6.32-trunk-amd64 on Debian testing, under Xfce 4.6. Hal is > running, along with xfce4-power-manager (which catches events like > suspend/hibernat). > > If you're interested by more stuff, please ask. > -- > ___ > ibm-acpi-devel mailing list > ibm-acpi-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
On mer., 2010-04-21 at 19:00 -0300, Henrique de Moraes Holschuh wrote: > I really should get people to send me keyboard photos of all models, so > that I could have a per-model keymap, it would not waste any kernel > runtime memory since they're discarded when the module installs > itself... As a side note, would you be interested by the USB keyboard with trackpoint (55Y9003)? It should be the same keyboard as the T400s. Works fine, mostly. Hal get events for: Fn+F2 (lock, sent as “XF86Screensaver” to wm) Fn+F3 (battery, not really useful on a desktop box :) Fn+F4 (sleep, can be catched by xfce4-power-manager) Fn+F5 (wlan, which I don't have either) Fn+F6 (camera) Fn+F7 (switch-videomode) Fn+F8 (f22) Fn+F12 (hibernate, sent to xfpm too) Fn+space (zoom) Fn+arrows (multimedia keys, play/pause/prev/next) Fn+home/end (brightness, though it does nothing on a desktop box) Key are sent to the wm for Thinkvantage (XF86Launch1) Caps-lock led What else work: Fn+Scrlk (numlock, but there's no led to indicate the status) What doesn't work: output mute led input (mic) mute led input (mic) mute key This is on 2.6.32-trunk-amd64 on Debian testing, under Xfce 4.6. Hal is running, along with xfce4-power-manager (which catches events like suspend/hibernat). If you're interested by more stuff, please ask. -- Yves-Alexis signature.asc Description: This is a digitally signed message part -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
On Tue, 20 Apr 2010, Jens Taprogge wrote: > On the T410s and most likely other current models Fn-F6 is labeled as > Camera/Headphone key. Report key presses as KEY_CAMERA. Hmm, thanks for the information (could I have a photo of the T410s keyboard please?), but I will have to hold on this one. I really should get people to send me keyboard photos of all models, so that I could have a per-model keymap, it would not waste any kernel runtime memory since they're discarded when the module installs itself... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- ___ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Re: [ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
Tested on a Thinkpad T410. Works. Also maps key to the same hotkey to
the same key as the lenovo thinkpad usb keyboard maps it to in udev
keymap file.
Acked-by: Jerone Young
On Tue, 2010-04-20 at 23:05 +0200, Jens Taprogge wrote:
> On the T410s and most likely other current models Fn-F6 is labeled as
> Camera/Headphone key. Report key presses as KEY_CAMERA.
>
> Please review and apply if appropriate.
>
> Signed-off-by: Jens Taprogge
> ---
> drivers/platform/x86/thinkpad_acpi.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c
> b/drivers/platform/x86/thinkpad_acpi.c
> index 2cee76c..04c1e8c 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3152,7 +3152,7 @@ static int __init hotkey_init(struct ibm_init_struct
> *iibm)
> static u16 lenovo_keycode_map[] __initdata = {
> /* Scan Codes 0x00 to 0x0B: ACPI HKEY FN+F1..F12 */
> KEY_FN_F1, KEY_COFFEE, KEY_BATTERY,KEY_SLEEP,
> - KEY_WLAN, KEY_FN_F6, KEY_SWITCHVIDEOMODE, KEY_FN_F8,
> + KEY_WLAN, KEY_CAMERA, KEY_SWITCHVIDEOMODE, KEY_FN_F8,
> KEY_FN_F9, KEY_FN_F10, KEY_FN_F11, KEY_SUSPEND,
>
> /* Scan codes 0x0C to 0x1F: Other ACPI HKEY hot keys */
--
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
[ibm-acpi-devel] thinkpad_acpi: Add KEY_CAMERA (Fn-F6).
On the T410s and most likely other current models Fn-F6 is labeled as
Camera/Headphone key. Report key presses as KEY_CAMERA.
Please review and apply if appropriate.
Signed-off-by: Jens Taprogge
---
drivers/platform/x86/thinkpad_acpi.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/platform/x86/thinkpad_acpi.c
b/drivers/platform/x86/thinkpad_acpi.c
index 2cee76c..04c1e8c 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3152,7 +3152,7 @@ static int __init hotkey_init(struct ibm_init_struct
*iibm)
static u16 lenovo_keycode_map[] __initdata = {
/* Scan Codes 0x00 to 0x0B: ACPI HKEY FN+F1..F12 */
KEY_FN_F1, KEY_COFFEE, KEY_BATTERY,KEY_SLEEP,
- KEY_WLAN, KEY_FN_F6, KEY_SWITCHVIDEOMODE, KEY_FN_F8,
+ KEY_WLAN, KEY_CAMERA, KEY_SWITCHVIDEOMODE, KEY_FN_F8,
KEY_FN_F9, KEY_FN_F10, KEY_FN_F11, KEY_SUSPEND,
/* Scan codes 0x0C to 0x1F: Other ACPI HKEY hot keys */
--
1.7.0.4
--
___
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
