[infinispan-dev] old workaround in CacheImpl

2013-03-12 Thread Adrian Nistor 
Hi,

does anyone know what issue is the unused (but injected) 
CacheImpl.responseGenerator field supposed to cure? See here: 
https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
 


The accompanying comment does not seem to be valid anymore. There is no 
jira for it and the tests run fine without it. Can't we just remove it?

Cheers
___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] old workaround in CacheImpl

2013-03-12 Thread Adrian Nistor 
And this is how it looked in 5.1.x 
https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139

On 03/12/2013 01:40 PM, Adrian Nistor wrote:
> Hi,
>
> does anyone know what issue is the unused (but injected)
> CacheImpl.responseGenerator field supposed to cure? See here:
> https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
>
>
> The accompanying comment does not seem to be valid anymore. There is no
> jira for it and the tests run fine without it. Can't we just remove it?
>
> Cheers
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] old workaround in CacheImpl

2013-03-12 Thread Mircea Markus 
git annotate points to Mr. Surtani :-)

On 12 Mar 2013, at 11:43, Adrian Nistor wrote:

> And this is how it looked in 5.1.x 
> https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139
> 
> On 03/12/2013 01:40 PM, Adrian Nistor wrote:
>> Hi,
>> 
>> does anyone know what issue is the unused (but injected)
>> CacheImpl.responseGenerator field supposed to cure? See here:
>> https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
>> 
>> 
>> The accompanying comment does not seem to be valid anymore. There is no
>> jira for it and the tests run fine without it. Can't we just remove it?
>> 
>> Cheers
>> ___
>> infinispan-dev mailing list
>> infinispan-dev@lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

Cheers,
-- 
Mircea Markus
Infinispan lead (www.infinispan.org)





___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] old workaround in CacheImpl

2013-03-12 Thread Dan Berindei 
I think the field was needed because InboundInvocationHandlerImpl was using
ComponentRegistry.getComponent(ResponseGenerator.class), and there wasn't
anyone actually creating the ResponseGenerator component.

Since https://issues.jboss.org/browse/ISPN-1793, ComponentRegistry creates
the ResponseGenerator component explicitly, so the field in CacheImpl is no
longer needed.



On Tue, Mar 12, 2013 at 1:53 PM, Mircea Markus  wrote:

> git annotate points to Mr. Surtani :-)
>
> On 12 Mar 2013, at 11:43, Adrian Nistor wrote:
>
> > And this is how it looked in 5.1.x
> >
> https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139
> >
> > On 03/12/2013 01:40 PM, Adrian Nistor wrote:
> >> Hi,
> >>
> >> does anyone know what issue is the unused (but injected)
> >> CacheImpl.responseGenerator field supposed to cure? See here:
> >>
> https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
> >>
> >>
> >> The accompanying comment does not seem to be valid anymore. There is no
> >> jira for it and the tests run fine without it. Can't we just remove it?
> >>
> >> Cheers
> >> ___
> >> infinispan-dev mailing list
> >> infinispan-dev@lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> >
> > ___
> > infinispan-dev mailing list
> > infinispan-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> Cheers,
> --
> Mircea Markus
> Infinispan lead (www.infinispan.org)
>
>
>
>
>
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] old workaround in CacheImpl

2013-03-13 Thread Manik Surtani 
Correct answer, Dan.

And yes, it can now be removed.

On 12 Mar 2013, at 13:52, Dan Berindei  wrote:

> I think the field was needed because InboundInvocationHandlerImpl was using 
> ComponentRegistry.getComponent(ResponseGenerator.class), and there wasn't 
> anyone actually creating the ResponseGenerator component.
> 
> Since https://issues.jboss.org/browse/ISPN-1793, ComponentRegistry creates 
> the ResponseGenerator component explicitly, so the field in CacheImpl is no 
> longer needed.
> 
> 
> 
> On Tue, Mar 12, 2013 at 1:53 PM, Mircea Markus  wrote:
> git annotate points to Mr. Surtani :-)
> 
> On 12 Mar 2013, at 11:43, Adrian Nistor wrote:
> 
> > And this is how it looked in 5.1.x
> > https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139
> >
> > On 03/12/2013 01:40 PM, Adrian Nistor wrote:
> >> Hi,
> >>
> >> does anyone know what issue is the unused (but injected)
> >> CacheImpl.responseGenerator field supposed to cure? See here:
> >> https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
> >>
> >>
> >> The accompanying comment does not seem to be valid anymore. There is no
> >> jira for it and the tests run fine without it. Can't we just remove it?
> >>
> >> Cheers
> >> ___
> >> infinispan-dev mailing list
> >> infinispan-dev@lists.jboss.org
> >> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> >
> > ___
> > infinispan-dev mailing list
> > infinispan-dev@lists.jboss.org
> > https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> Cheers,
> --
> Mircea Markus
> Infinispan lead (www.infinispan.org)
> 
> 
> 
> 
> 
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev
> 
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/infinispan-dev

--
Manik Surtani
ma...@jboss.org
twitter.com/maniksurtani

Platform Architect, JBoss Data Grid
http://red.ht/data-grid

___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev

Re: [infinispan-dev] old workaround in CacheImpl

2013-03-13 Thread Adrian Nistor 

Will remove it then.

Thanks!

On 03/13/2013 02:46 PM, Manik Surtani wrote:

Correct answer, Dan.

And yes, it can now be removed.

On 12 Mar 2013, at 13:52, Dan Berindei > wrote:


I think the field was needed because InboundInvocationHandlerImpl was 
using ComponentRegistry.getComponent(ResponseGenerator.class), and 
there wasn't anyone actually creating the ResponseGenerator component.


Since https://issues.jboss.org/browse/ISPN-1793, ComponentRegistry 
creates the ResponseGenerator component explicitly, so the field in 
CacheImpl is no longer needed.




On Tue, Mar 12, 2013 at 1:53 PM, Mircea Markus > wrote:


git annotate points to Mr. Surtani :-)

On 12 Mar 2013, at 11:43, Adrian Nistor wrote:

> And this is how it looked in 5.1.x
>

https://github.com/anistor/infinispan/blob/5.1.x/core/src/main/java/org/infinispan/CacheImpl.java#L139
>
> On 03/12/2013 01:40 PM, Adrian Nistor wrote:
>> Hi,
>>
>> does anyone know what issue is the unused (but injected)
>> CacheImpl.responseGenerator field supposed to cure? See here:
>>

https://github.com/anistor/infinispan/blob/master/core/src/main/java/org/infinispan/CacheImpl.java#L139
>>
>>
>> The accompanying comment does not seem to be valid anymore.
There is no
>> jira for it and the tests run fine without it. Can't we just
remove it?
>>
>> Cheers
>> ___
>> infinispan-dev mailing list
>> infinispan-dev@lists.jboss.org

>> https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> ___
> infinispan-dev mailing list
> infinispan-dev@lists.jboss.org

> https://lists.jboss.org/mailman/listinfo/infinispan-dev

Cheers,
--
Mircea Markus
Infinispan lead (www.infinispan.org )





___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org

https://lists.jboss.org/mailman/listinfo/infinispan-dev


___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org 
https://lists.jboss.org/mailman/listinfo/infinispan-dev


--
Manik Surtani
ma...@jboss.org 
twitter.com/maniksurtani 

Platform Architect, JBoss Data Grid
http://red.ht/data-grid



___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev


___
infinispan-dev mailing list
infinispan-dev@lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev