Re: Question re: deleted tags
[EMAIL PROTECTED] writes: > > I understand WHY now. Since val-tags is just a cache, > where is the "real" tags repository. The individual RCS files in the repository. -Larry Jones I thought my life would seem more interesting with a musical score and a laugh track. -- Calvin ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
RE: Question re: deleted tags
Yep, I should've know that because I've seen the "real" tags in the ,v files. Thanks!!! -chris >-Original Message- >From: Rick Genter [mailto:[EMAIL PROTECTED] >Sent: Thursday, January 20, 2005 11:37 AM >To: Fouts Christopher (IFNA MP DC); info-cvs@gnu.org >Subject: RE: Question re: deleted tags > > >I believe that the "real" tags repository, as you call it, is >knowledge scattered in each ,v file in the repository. Each >file lists the tags with which it is tagged. That's why when >you specify a tag that is not in the val-tags file it can take >a long time to process the command; CVS has to look at every >,v file in the module(s) referenced in the command to see if >the tag exists. > > >-- >Rick Genter >Principal Engineer >Silverlink Communications ><mailto:[EMAIL PROTECTED]> >(781) 272-3080 x242 > >This e-mail, including attachments, may include confidential >and/or proprietary information, and may only be used by the >person or entity to which it is addressed. If the reader of >this e-mail is not the intended recipient or his or her >authorized agent, the reader is hereby notified that any >dissemination, distribution or copying of this e-mail is >prohibited. If you have received this e-mail in error, please >notify the sender by replying to this message and delete this >e-mail immediately. > > > >-Original Message- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] On >Behalf Of [EMAIL PROTECTED] >Sent: Thursday, January 20, 2005 11:04 AM >To: info-cvs@gnu.org >Subject: RE: Question re: deleted tags > >I understand WHY now. Since val-tags is just a cache, >where is the "real" tags repository. Again in my last >post, I said I did NOT see the deleted tag in val-tags >anymore, and don't see a tag that should still be there. > >-chris > >>-----Original Message- >>From: Larry Jones [mailto:[EMAIL PROTECTED] >>Sent: Wednesday, January 19, 2005 5:56 PM >>To: Derek Price >>Cc: Fouts Christopher (IFNA MP DC); info-cvs@gnu.org >>Subject: Re: Question re: deleted tags >> >> >>Derek Price writes: >>> >>> Since tag deletion is considered a relatively rare operation >>(as well >>> it >>> should be), no one has ever bother to write the code for the >>expensive, >>> complete tag search that would be necessary to determine if >>the tag is >>> really completely gone and should really be deleted from val-tags. >> >>It's not necessary -- since val-tags is just a cache, it would >>be safe to just delete it regardless. Of course, the first >>thing that needs to be done is to add some kind of locking for >>the val-tags file since there isn't any right now and the more >>we update it the better the chance of it getting corrupted by >>simultaneous updates. >> >>-Larry Jones >> >>I'm so disappointed. -- Calvin >> > > >___ >Info-cvs mailing list >Info-cvs@gnu.org >http://lists.gnu.org/mailman/listinfo/info-cvs > ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
RE: Question re: deleted tags
I believe that the "real" tags repository, as you call it, is knowledge scattered in each ,v file in the repository. Each file lists the tags with which it is tagged. That's why when you specify a tag that is not in the val-tags file it can take a long time to process the command; CVS has to look at every ,v file in the module(s) referenced in the command to see if the tag exists. -- Rick Genter Principal Engineer Silverlink Communications <mailto:[EMAIL PROTECTED]> (781) 272-3080 x242 This e-mail, including attachments, may include confidential and/or proprietary information, and may only be used by the person or entity to which it is addressed. If the reader of this e-mail is not the intended recipient or his or her authorized agent, the reader is hereby notified that any dissemination, distribution or copying of this e-mail is prohibited. If you have received this e-mail in error, please notify the sender by replying to this message and delete this e-mail immediately. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Thursday, January 20, 2005 11:04 AM To: info-cvs@gnu.org Subject: RE: Question re: deleted tags I understand WHY now. Since val-tags is just a cache, where is the "real" tags repository. Again in my last post, I said I did NOT see the deleted tag in val-tags anymore, and don't see a tag that should still be there. -chris >-Original Message- >From: Larry Jones [mailto:[EMAIL PROTECTED] >Sent: Wednesday, January 19, 2005 5:56 PM >To: Derek Price >Cc: Fouts Christopher (IFNA MP DC); info-cvs@gnu.org >Subject: Re: Question re: deleted tags > > >Derek Price writes: >> >> Since tag deletion is considered a relatively rare operation >(as well >> it >> should be), no one has ever bother to write the code for the >expensive, >> complete tag search that would be necessary to determine if >the tag is >> really completely gone and should really be deleted from val-tags. > >It's not necessary -- since val-tags is just a cache, it would >be safe to just delete it regardless. Of course, the first >thing that needs to be done is to add some kind of locking for >the val-tags file since there isn't any right now and the more >we update it the better the chance of it getting corrupted by >simultaneous updates. > >-Larry Jones > >I'm so disappointed. -- Calvin > ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
RE: Question re: deleted tags
I understand WHY now. Since val-tags is just a cache, where is the "real" tags repository. Again in my last post, I said I did NOT see the deleted tag in val-tags anymore, and don't see a tag that should still be there. -chris >-Original Message- >From: Larry Jones [mailto:[EMAIL PROTECTED] >Sent: Wednesday, January 19, 2005 5:56 PM >To: Derek Price >Cc: Fouts Christopher (IFNA MP DC); info-cvs@gnu.org >Subject: Re: Question re: deleted tags > > >Derek Price writes: >> >> Since tag deletion is considered a relatively rare operation >(as well >> it >> should be), no one has ever bother to write the code for the >expensive, >> complete tag search that would be necessary to determine if >the tag is >> really completely gone and should really be deleted from val-tags. > >It's not necessary -- since val-tags is just a cache, it would >be safe to just delete it regardless. Of course, the first >thing that needs to be done is to add some kind of locking for >the val-tags file since there isn't any right now and the more >we update it the better the chance of it getting corrupted by >simultaneous updates. > >-Larry Jones > >I'm so disappointed. -- Calvin > ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
Re: Question re: deleted tags
Larry Jones wrote: Derek Price writes: Well, "fixing" it this way would put us back in the position where checkouts and updates could sometimes report that tags don't exist when they do. I think this is worse than not checking out any data when the tag doesn't exist in the project or sub-project being checked out (which can happen anyhow when the tag is correctly in val-tags). I just fixed this on feature by having the tag command itself update the "cache". I think you've forgotten how val-tags works. If a tag appears in the val-tags file, it is assumed to be valid and no error is issued, even though the tag may not appear in any of the files being processed. If the tag does not appear in the val-tags file, then CVS examines all of the files to be processed. If the tag occurs in any of them, then it is valid and is added to the val-tags file; if not, then -- and only then -- do you get the "tag does not exist" error. I think that may have been the intention, but I don't think that's the way it really works. First, take a look at the dirs2-10 & rmadd-17 tests on stable (they've been eliminated on feature). They show that commit commands and sometimes update commands will sometimes both issue "no such tag" errors when they shouldn't. Hence the warning in the manual about trying "some combination of commands" until val-tags gets updated when encountering this message. So, obviously, some commands were not recursing when they didn't find the tag in val-tags. It's possible I took the wrong approach to fixing this bug. Not that what I did was bad, but perhaps I should have figured out why some commands were failing to search for the tag and fixed those? Derek ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
Re: Question re: deleted tags
Derek Price writes: > > Well, "fixing" it this way would put us back in the position where > checkouts and updates could sometimes report that tags don't exist when > they do. I think this is worse than not checking out any data when the > tag doesn't exist in the project or sub-project being checked out (which > can happen anyhow when the tag is correctly in val-tags). I just fixed > this on feature by having the tag command itself update the "cache". I think you've forgotten how val-tags works. If a tag appears in the val-tags file, it is assumed to be valid and no error is issued, even though the tag may not appear in any of the files being processed. If the tag does not appear in the val-tags file, then CVS examines all of the files to be processed. If the tag occurs in any of them, then it is valid and is added to the val-tags file; if not, then -- and only then -- do you get the "tag does not exist" error. -Larry Jones Mom would be a lot more fun if she was a little more gullible. -- Calvin ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
Re: Question re: deleted tags
Larry Jones wrote: Derek Price writes: Since tag deletion is considered a relatively rare operation (as well it should be), no one has ever bother to write the code for the expensive, complete tag search that would be necessary to determine if the tag is really completely gone and should really be deleted from val-tags. It's not necessary -- since val-tags is just a cache, it would be safe to just delete it regardless. Of course, the first thing that needs to be done is to add some kind of locking for the val-tags file since there isn't any right now and the more we update it the better the chance of it getting corrupted by simultaneous updates. Well, "fixing" it this way would put us back in the position where checkouts and updates could sometimes report that tags don't exist when they do. I think this is worse than not checking out any data when the tag doesn't exist in the project or sub-project being checked out (which can happen anyhow when the tag is correctly in val-tags). I just fixed this on feature by having the tag command itself update the "cache". Regards, Derek ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
Re: Question re: deleted tags
Derek Price writes: > > Since tag deletion is considered a relatively rare operation (as well it > should be), no one has ever bother to write the code for the expensive, > complete tag search that would be necessary to determine if the tag is > really completely gone and should really be deleted from val-tags. It's not necessary -- since val-tags is just a cache, it would be safe to just delete it regardless. Of course, the first thing that needs to be done is to add some kind of locking for the val-tags file since there isn't any right now and the more we update it the better the chance of it getting corrupted by simultaneous updates. -Larry Jones I'm so disappointed. -- Calvin ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
Re: Question re: deleted tags
[EMAIL PROTECTED] wrote: "Tags never get removed from val-tags." Why? If I delete a tag, I I want to, well, delete it! Only because it would be a lot of overhead to traverse the entire repository to make sure that _ALL_ files are really missing the tag. In other words, just because you executed `cvs tag -d whatevertag' in a workspace checked out from project1 does not guarantee that the tag does not exist in project2. Since tag deletion is considered a relatively rare operation (as well it should be), no one has ever bother to write the code for the expensive, complete tag search that would be necessary to determine if the tag is really completely gone and should really be deleted from val-tags. Regards, Derek ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
RE: Question re: deleted tags
>-Original Message- >From: [EMAIL PROTECTED] >[mailto:[EMAIL PROTECTED] >] On Behalf Of Fouts Christopher (IFNA MP DC) >Sent: Wednesday, January 19, 2005 8:46 AM >To: info-cvs@gnu.org >Subject: RE: Question re: deleted tags > > > > >>-Original Message- >>From: Jim.Hyslop [mailto:[EMAIL PROTECTED] >>Sent: Tuesday, January 18, 2005 4:25 PM >>To: Fouts Christopher (IFNA MP DC); info-cvs@gnu.org >>Subject: RE: Question re: deleted tags >> >> >>Christopher Fouts wrote: >>> What am I missing? >>CVSROOT/val-tags >> >>Tags never get removed from val-tags. The "no such tag" >>message will appear only if the tag does not appear in >>val-tags. If the tag appears in val-tags, then CVS has to >>search each file in each directory to determine which files >>may or may not have the tag. >> >>-- >>Jim Hyslop >>Senior Software Designer >>Leitch Technology International Inc. ( http://www.leitch.com ) >>Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) >> > >"Tags never get removed from val-tags." > >Why? If I delete a tag, I I want to, well, delete it! > >-chris > > >___ >Info-cvs mailing list >Info-cvs@gnu.org >http://lists.gnu.org/mailman/listinfo/info-cvs > Ok, I'm even more confused now. I looked at my CVSROOT/val-tags file and it does NOT have the deleted tag. Even more confusing, it does NOT have some valid tags that I use? So again, what am I missing? -chris ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
RE: Question re: deleted tags
>-Original Message- >From: Jim.Hyslop [mailto:[EMAIL PROTECTED] >Sent: Tuesday, January 18, 2005 4:25 PM >To: Fouts Christopher (IFNA MP DC); info-cvs@gnu.org >Subject: RE: Question re: deleted tags > > >Christopher Fouts wrote: >> What am I missing? >CVSROOT/val-tags > >Tags never get removed from val-tags. The "no such tag" >message will appear only if the tag does not appear in >val-tags. If the tag appears in val-tags, then CVS has to >search each file in each directory to determine which files >may or may not have the tag. > >-- >Jim Hyslop >Senior Software Designer >Leitch Technology International Inc. ( http://www.leitch.com ) >Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) > "Tags never get removed from val-tags." Why? If I delete a tag, I I want to, well, delete it! -chris ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
RE: Question re: deleted tags
Christopher Fouts wrote: > What am I missing? CVSROOT/val-tags Tags never get removed from val-tags. The "no such tag" message will appear only if the tag does not appear in val-tags. If the tag appears in val-tags, then CVS has to search each file in each directory to determine which files may or may not have the tag. -- Jim Hyslop Senior Software Designer Leitch Technology International Inc. ( http://www.leitch.com ) Columnist, C/C++ Users Journal ( http://www.cuj.com/experts ) ___ Info-cvs mailing list Info-cvs@gnu.org http://lists.gnu.org/mailman/listinfo/info-cvs
