Re: cyrus-imapd-2.1.13 sieve curiosity

2003-11-04 Thread Rob Siemborski
On Tue, 4 Nov 2003, Aidan Evans wrote:

   I've just come across instances of this problem.  Was there a correction
 for it in Cyrus 2.1 beyond 2.1.13?  There does not seem to be a mention of
 it in 2.1.15 changes.html, but maybe it's covered under Minor other bug
 fixes.  If there was a correction, is it easy to incorporate into 2.1.11?
 I don't want to update Cyrus completely in the middle of term, but a small
 code change and recompile may be acceptable.

No, there is no fix for this problem currently.

-Rob

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Rob Siemborski * Andrew Systems Group * Cyert Hall 207 * 412-268-7456
Research Systems Programmer * /usr/contributed Gatekeeper



Re: cyrus-imapd-2.1.13 sieve curiosity

2003-06-10 Thread Patrick Welche
On Mon, Jun 09, 2003 at 12:07:34PM -0500, Amos Gouaux wrote:
  On Mon, 9 Jun 2003 12:50:16 -0400 (EDT),
  Rob Siemborski [EMAIL PROTECTED] (rs) writes:
 
 rs I don't think so, I'm pretty sure its only caused by errors during
 rs sieve_script_parse, not during sieve_execute_script.
 
 I'm not sure yet, but I think I might have found the culprit.  The
 other day my boss was playing with uploading Sieve scripts using
 Mulberry.

Is there any documentation on how to do this? I get mixed up between
the server scripts and the local ones...

Cheers,

Patrick


cyrus-imapd-2.1.13 sieve curiosity

2003-06-09 Thread Amos Gouaux
I and a few others here have begun noticing that periodically Sieve
won't filter a message properly.  Sometimes I've even resent the
message again to find that on that occasion it did get filtered
just as expected.  I wonder, could that BerkeleyDB leak for which
Rob just posted those two patches have any bearing on this?  Sadly,
so far I haven't been able to detect a pattern to make this report
more meaningful, but I'll keep an eye out.

-- 
Amos



Re: cyrus-imapd-2.1.13 sieve curiosity

2003-06-09 Thread Rob Siemborski
On Mon, 9 Jun 2003, Amos Gouaux wrote:

 I and a few others here have begun noticing that periodically Sieve
 won't filter a message properly.  Sometimes I've even resent the
 message again to find that on that occasion it did get filtered
 just as expected.  I wonder, could that BerkeleyDB leak for which
 Rob just posted those two patches have any bearing on this?  Sadly,
 so far I haven't been able to detect a pattern to make this report
 more meaningful, but I'll keep an eye out.

The sieve parser state doesn't get reset properly after an error.  Thus
once a script fails to parse, all scripts will fail to parse (try to
submit a good script after a bad one in a timsieved session to see this in
action).

If badly-formed sieve scripts could have snuck in, then this will affect
lmtpd as well, leading to behavior like you describe here.

The bytecode, of course, solves this problem (But that won't ever be seen
in 2.1)

-Rob

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Rob Siemborski * Andrew Systems Group * Cyert Hall 207 * 412-268-7456
Research Systems Programmer * /usr/contributed Gatekeeper



Re: cyrus-imapd-2.1.13 sieve curiosity

2003-06-09 Thread Amos Gouaux
 On Mon, 9 Jun 2003 12:14:15 -0400 (EDT),
 Rob Siemborski [EMAIL PROTECTED] (rs) writes:

rs The sieve parser state doesn't get reset properly after an error.  Thus
rs once a script fails to parse, all scripts will fail to parse (try to
rs submit a good script after a bad one in a timsieved session to see this in
rs action).

Interesting.  Would an error like this also apply?

sieve runtime error for X id [EMAIL PROTECTED]: Fileinto: Mailbox does not exist

(The X is one of our users, but not myself.)

-- 
Amos



Re: cyrus-imapd-2.1.13 sieve curiosity

2003-06-09 Thread Rob Siemborski
On Mon, 9 Jun 2003, Amos Gouaux wrote:

 Interesting.  Would an error like this also apply?

 sieve runtime error for X id [EMAIL PROTECTED]: Fileinto: Mailbox does not 
 exist

 (The X is one of our users, but not myself.)

I don't think so, I'm pretty sure its only caused by errors during
sieve_script_parse, not during sieve_execute_script.

That said, it should be relatively easy to construct a test case based on
sieve/test.c which proves this.

-Rob

-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
Rob Siemborski * Andrew Systems Group * Cyert Hall 207 * 412-268-7456
Research Systems Programmer * /usr/contributed Gatekeeper



Re: cyrus-imapd-2.1.13 sieve curiosity

2003-06-09 Thread Amos Gouaux
 On Mon, 9 Jun 2003 12:50:16 -0400 (EDT),
 Rob Siemborski [EMAIL PROTECTED] (rs) writes:

rs I don't think so, I'm pretty sure its only caused by errors during
rs sieve_script_parse, not during sieve_execute_script.

I'm not sure yet, but I think I might have found the culprit.  The
other day my boss was playing with uploading Sieve scripts using
Mulberry.  It would seem that a string of binary characters was
included in this script after the comment '# Generated from text'.
I've commented out that line.  We'll see if things resume back to
abby-normal.

When I learn more just what he did, I'll contact Cyrusoft.

-- 
Amos