cyrus 2.3.3 change + solved: permission denied setting flags

2006-05-18 Thread Robert Mueller
Ok, we've tracked down the permissions problem. It has to do with what I 
believe is a change in behaviour between 2.3 CVS 6 months ago and 2.3.3.


Cyrus 2.3 from CVS about 6 months ago...

. select user.xyz
...
. OK [READ-WRITE] Completed
. examine user.xyz
...
. OK [READ-ONLY] Completed

Cyrus 2.3.3

. select user.xyz
...
. OK [READ-WRITE] Completed
. examine user.xyz
...
. OK [READ-WRITE] Completed

Ok that last one is saying that it's in [READ-WRITE] mode on an examine 
while previously it used to say [READ-ONLY]. Is that an expected behaviour 
change, or a bug?


Rob


Cyrus Home Page: http://asg.web.cmu.edu/cyrus
Cyrus Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html


Re: cyrus 2.3.3 change + solved: permission denied setting flags

2006-05-18 Thread Ken Murchison

Robert Mueller wrote:
Ok, we've tracked down the permissions problem. It has to do with what I 
believe is a change in behaviour between 2.3 CVS 6 months ago and 2.3.3.


Cyrus 2.3 from CVS about 6 months ago...

. select user.xyz
...
. OK [READ-WRITE] Completed
. examine user.xyz
...
. OK [READ-ONLY] Completed

Cyrus 2.3.3

. select user.xyz
...
. OK [READ-WRITE] Completed
. examine user.xyz
...
. OK [READ-WRITE] Completed

Ok that last one is saying that it's in [READ-WRITE] mode on an 
examine while previously it used to say [READ-ONLY]. Is that an 
expected behaviour change, or a bug?


Its a bug.  This make have creeped in with the updated ACL code. What is 
the ACL on user.xyz for the authorized user?



--
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University

Cyrus Home Page: http://asg.web.cmu.edu/cyrus
Cyrus Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html


Re: cyrus 2.3.3 change + solved: permission denied setting flags

2006-05-18 Thread Bron Gondwana
On Fri, May 19, 2006 at 02:40:11AM +1000, Robert Mueller wrote:
 [...] saying that it's in [READ-WRITE] mode on an examine 
 while previously it used to say [READ-ONLY]. Is that an expected behaviour 
 change, or a bug?

And if it's expected, then why was it saying Permission denied when our
code took it at its word and tried to set flags on a message!

Our solution is to be conservative in what we believe, and storing
'read-only' in our internal connection state data if we asked
for an examine rather than a select - regardless of the server's
response.  This feels like a good idea that will keep working just
fine when the bug is fixed, and protect us against any future
regressions!

Bron.

Cyrus Home Page: http://asg.web.cmu.edu/cyrus
Cyrus Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html


Re: cyrus 2.3.3 change + solved: permission denied setting flags

2006-05-18 Thread Ken Murchison

Robert Mueller wrote:
Ok, we've tracked down the permissions problem. It has to do with what I 
believe is a change in behaviour between 2.3 CVS 6 months ago and 2.3.3.


Cyrus 2.3 from CVS about 6 months ago...

. select user.xyz
...
. OK [READ-WRITE] Completed
. examine user.xyz
...
. OK [READ-ONLY] Completed

Cyrus 2.3.3

. select user.xyz
...
. OK [READ-WRITE] Completed
. examine user.xyz
...
. OK [READ-WRITE] Completed

Ok that last one is saying that it's in [READ-WRITE] mode on an 
examine while previously it used to say [READ-ONLY]. Is that an 
expected behaviour change, or a bug?


Fixed in CVS (lib/acl.h and imap/imapd.c)

--
Kenneth Murchison
Systems Programmer
Project Cyrus Developer/Maintainer
Carnegie Mellon University

Cyrus Home Page: http://asg.web.cmu.edu/cyrus
Cyrus Wiki/FAQ: http://cyruswiki.andrew.cmu.edu
List Archives/Info: http://asg.web.cmu.edu/cyrus/mailing-list.html