Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

[Shlomo Ben David]

About the last thing...
When people push drafts only they can view them, unless they add someone as
reviewers before publishing it as a regular patch.

That's why I think it is useless permission, but if you still want i can
add it.

Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 20, 2016 at 6:10 PM, Tal Nisan <tni...@redhat.com> wrote:

> None, just +2, especially not remove other reviewers as sometimes people
> remove the gerrit-hooks without asking.
> If you can block people from pushing drafts to the stable branches it will
> also be great
>
> On Tue, Dec 20, 2016 at 5:52 PM, Shlomo Ben David <sbend...@redhat.com>
> wrote:
>
>> Hi Tal/Eyal,
>>
>> I added CR (-/+)2 permission for the ovirt-engine-master-maintainers
>> group on the stable-branches.
>>
>>
>> Best Regards,
>>
>> Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
>> RHCSA | RHCE
>> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>>
>> OPEN SOURCE - 1 4 011 && 011 4 1
>>
>> On Tue, Dec 20, 2016 at 5:12 PM, Eyal Edri <ee...@redhat.com> wrote:
>>
>>> I wasn't aware we were allowing +2 permissions without merge rights on
>>> stable branch,
>>> If this should be supported then we need to update the permissions, so
>>> all master branch maintainers need +2 (w/o merge) to stable branches?
>>>
>>> On Tue, Dec 20, 2016 at 4:58 PM, Tal Nisan <tni...@redhat.com> wrote:
>>>
>>>> Master
>>>>
>>>> On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri <ee...@redhat.com> wrote:
>>>>
>>>>> stable branch maintainers or master branch maintainers?
>>>>>
>>>>> On Dec 20, 2016 4:40 PM, "Tal Nisan" <tni...@redhat.com> wrote:
>>>>>
>>>>>> Heard it from a couple of guys, yesterday it appeared to be working
>>>>>> fine, today it's not
>>>>>>
>>>>>>
>>>>>> ___
>>>>>> Infra mailing list
>>>>>> Infra@ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>>
>>>>>>
>>>>
>>>
>>>
>>> --
>>> Eyal Edri
>>> Associate Manager
>>> RHV DevOps
>>> EMEA ENG Virtualization R
>>> Red Hat Israel
>>>
>>> phone: +972-9-7692018 <+972%209-769-2018>
>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>
>>
>>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Maintainers can't give +2 on code review in ovirt-engine-4.1 stable branch

[Shlomo Ben David]

Hi Tal/Eyal,

I added CR (-/+)2 permission for the ovirt-engine-master-maintainers group
on the stable-branches.


Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 20, 2016 at 5:12 PM, Eyal Edri  wrote:

> I wasn't aware we were allowing +2 permissions without merge rights on
> stable branch,
> If this should be supported then we need to update the permissions, so all
> master branch maintainers need +2 (w/o merge) to stable branches?
>
> On Tue, Dec 20, 2016 at 4:58 PM, Tal Nisan  wrote:
>
>> Master
>>
>> On Tue, Dec 20, 2016 at 4:53 PM, Eyal Edri  wrote:
>>
>>> stable branch maintainers or master branch maintainers?
>>>
>>> On Dec 20, 2016 4:40 PM, "Tal Nisan"  wrote:
>>>
 Heard it from a couple of guys, yesterday it appeared to be working
 fine, today it's not


 ___
 Infra mailing list
 Infra@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/infra


>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018 <+972%209-769-2018>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Gerrit hooks change 4.1 bugs status to MODIFIED if merged on master

[Shlomo Ben David]

Hi Tal/Eyal,

As I see from [1], you are working on the 'master' branch.

The check hooks currently bypass the 'master' branch as you can see in the
gerrit log below.

   - Update Tracker::#1364152::OK, status: POST
   - Check Bug-Url::OK
   - Check Product::IGNORE, not relevant for branch: master
   - Check TM::IGNORE, not relevant for branch: master
   - Set POST::#1364152::OK, bug status: 'POST'
   - Check Backport::IGNORE, not relevant for branch: master

The update hooks (set_post, set_modified, update_tracker) do not bypass the
'master' branch.
I'm working on a patch that will bypass the 'master' branch only for the
set_modified hook.

[1] - https://gerrit.ovirt.org/#/c/68739/

Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 20, 2016 at 11:58 AM, Eyal Edri  wrote:

> Adding Shlomi.
>
> On Tue, Dec 20, 2016 at 11:56 AM, Tal Nisan  wrote:
>
>> This should be change to move to MODIFIED only after the bug is merged on
>> the 4.1 branch.
>> Here's an example:
>> https://gerrit.ovirt.org/#/c/68739/
>>
>> Thanks.
>>
>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018 <+972%209-769-2018>
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-942) [gerrit hooks] add CR (-1) grade beside the gerrit message

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-942:
--

 Summary: [gerrit hooks] add CR (-1) grade beside the gerrit message
 Key: OVIRT-942
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-942
 Project: oVirt - virtualization made easy
  Issue Type: Improvement
Reporter: Shlomo Ben David
Assignee: infra


Currently, we are grading with CR (-1) if there is not bug url
added to the commit message (only for stable branches).
The current message that Gerrit prints don't show the CR grade (-1)
beside the Gerrit message, It only shows the message.



--
This message was sent by Atlassian JIRA
(v1000.621.3#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-942) [gerrit hooks] add CR (-1) grade beside the gerrit message

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-942:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] add CR (-1) grade beside the gerrit message
> --
>
> Key: OVIRT-942
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-942
> Project: oVirt - virtualization made easy
>  Issue Type: Improvement
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> Currently, we are grading with CR (-1) if there is not bug url
> added to the commit message (only for stable branches).
> The current message that Gerrit prints don't show the CR grade (-1)
> beside the Gerrit message, It only shows the message.



--
This message was sent by Atlassian JIRA
(v1000.621.3#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-942) [gerrit hooks] add CR (-1) grade beside the gerrit message

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-942:
---
Epic Link: OVIRT-411

> [gerrit hooks] add CR (-1) grade beside the gerrit message
> --
>
> Key: OVIRT-942
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-942
> Project: oVirt - virtualization made easy
>  Issue Type: Improvement
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> Currently, we are grading with CR (-1) if there is not bug url
> added to the commit message (only for stable branches).
> The current message that Gerrit prints don't show the CR grade (-1)
> beside the Gerrit message, It only shows the message.



--
This message was sent by Atlassian JIRA
(v1000.621.3#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-941) [gerrit hooks] fix get_bug_info function

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-941:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] fix get_bug_info function
> 
>
> Key: OVIRT-941
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-941
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
>  The current function doesn't handle private/unavailable bugs.



--
This message was sent by Atlassian JIRA
(v1000.621.3#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-941) [gerrit hooks] fix get_bug_info function

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-941:
---
Epic Link: OVIRT-411

> [gerrit hooks] fix get_bug_info function
> 
>
> Key: OVIRT-941
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-941
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
>  The current function doesn't handle private/unavailable bugs.



--
This message was sent by Atlassian JIRA
(v1000.621.3#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-941) [gerrit hooks] fix get_bug_info function

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-941:
--

 Summary: [gerrit hooks] fix get_bug_info function
 Key: OVIRT-941
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-941
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra


 The current function doesn't handle private/unavailable bugs.




--
This message was sent by Atlassian JIRA
(v1000.621.3#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Bug moved to MODIFIED by hook while patches are not all in.

[Shlomo Ben David]

Hi,

The patch merged and applied.
Yaniv - can you verify?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Sun, Dec 11, 2016 at 3:40 PM, Eyal Edri  wrote:

> We merged a fix for it TODAY.
> Shlomi - can you verify its enabled on Gerrit so Yaniv can re-verify?
>
> On Sun, Dec 11, 2016 at 3:38 PM, Yaniv Dary  wrote:
>
>> Hi,
>> Can you have a look?
>> https://bugzilla.redhat.com/show_bug.cgi?id=827529#
>>
>> This bug moved to MODIFIED by hook while patches are not all in.
>>
>> Yaniv Dary
>> Technical Product Manager
>> Red Hat Israel Ltd.
>> 34 Jerusalem Road
>> Building A, 4th floor
>> Ra'anana, Israel 4350109
>>
>> Tel : +972 (9) 7692306
>> 8272306
>> Email: yd...@redhat.com
>> IRC : ydary
>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.phx.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.phx.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-830) Vdsm lost its "Forge Author" permission?

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-830:
--

Assignee: Shlomo Ben David  (was: infra)

> Vdsm lost its "Forge Author" permission?
> 
>
> Key: OVIRT-830
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-830
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: danken
>    Assignee: Shlomo Ben David
>
> Until recently, any registered user could take on somebody else's change,
> and post a new patchset to it.
> It's very useful when someone wants to fix a typo in someone else's
> code, or when we need to take on a work of a sick/vacating developer.
> Please amend this. I'm not 100% sure, but it could be fix by setting
> "Forge Author" on the vdsm project.
> https://gerrit-review.googlesource.com/Documentation/access-control.html#category_forge_author



--
This message was sent by Atlassian JIRA
(v1000.620.0#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-915) permission to run rpm-generating job

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-915:
--

Assignee: Shlomo Ben David  (was: infra)

> permission to run rpm-generating job
> 
>
> Key: OVIRT-915
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-915
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: danken
>        Assignee: Shlomo Ben David
>
> Hi,
> Would you grant myakove and mburman (CCed) the permission to log into
> jenkins.ovirt.org and trigger jobs such as
> http://jenkins.ovirt.org/job/ovirt-engine_4.0_build-artifacts-el7-x86_64-manual/8/
> Regards,
> Dan.



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-915) permission to run rpm-generating job

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=24006#comment-24006
 ] 

Shlomo Ben David commented on OVIRT-915:


Hi,

I added your username to the 'dev' role in Jenkins.

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Wed, Dec 7, 2016 at 3:17 PM, Meni Yakove (oVirt JIRA) <



> permission to run rpm-generating job
> 
>
> Key: OVIRT-915
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-915
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: danken
>Assignee: infra
>
> Hi,
> Would you grant myakove and mburman (CCed) the permission to log into
> jenkins.ovirt.org and trigger jobs such as
> http://jenkins.ovirt.org/job/ovirt-engine_4.0_build-artifacts-el7-x86_64-manual/8/
> Regards,
> Dan.



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-906) Permissions to new user

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-906:
--

Assignee: Shlomo Ben David  (was: infra)

> Permissions to new user
> ---
>
> Key: OVIRT-906
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-906
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Benny Zlotnik
>        Assignee: Shlomo Ben David
>
> Hi,
> Please grant my Jenkins user (bzlotnik) the dev permissions
> Thanks!



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-906) Permissions to new user

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23902#comment-23902
 ] 

Shlomo Ben David commented on OVIRT-906:


Hi Benny,

I added your user to the dev role in Jenkins.
Please sign out and  sign back into Jenkins to apply the new role.


Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 6, 2016 at 10:44 AM, Benny Zlotnik (oVirt JIRA) <



> Permissions to new user
> ---
>
> Key: OVIRT-906
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-906
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Benny Zlotnik
>Assignee: infra
>
> Hi,
> Please grant my Jenkins user (bzlotnik) the dev permissions
> Thanks!



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [JIRA] (OVIRT-906) Permissions to new user

[Shlomo Ben David]

Hi Benny,

I added your user to the dev role in Jenkins.
Please sign out and  sign back into Jenkins to apply the new role.


Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Dec 6, 2016 at 10:44 AM, Benny Zlotnik (oVirt JIRA) <
j...@ovirt-jira.atlassian.net> wrote:

> Benny Zlotnik created OVIRT-906:
> ---
>
>  Summary: Permissions to new user
>  Key: OVIRT-906
>  URL: https://ovirt-jira.atlassian.net/browse/OVIRT-906
>  Project: oVirt - virtualization made easy
>   Issue Type: By-EMAIL
> Reporter: Benny Zlotnik
> Assignee: infra
>
>
> Hi,
>
> Please grant my Jenkins user (bzlotnik) the dev permissions
>
> Thanks!
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v1000.610.2#100023)
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-904) False CI-1 due to unreachable copr-be.cloud.fedoraproject.org

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23841#comment-23841
 ] 

Shlomo Ben David commented on OVIRT-904:


[~eedri] currently I don't see any problem with the [1] repository
1. The old jobs from 2/12/2016 that were failed, do not exist 
2. The latest jobs successfully passed

[1] - 
http://copr-be.cloud.fedoraproject.org/results/patternfly/patternfly1/epel-7-x86_64/

> False CI-1 due to unreachable copr-be.cloud.fedoraproject.org
> -
>
> Key: OVIRT-904
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-904
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: danken
>Assignee: infra
>
> Many patches on
> https://gerrit.ovirt.org/#/q/topic:passthroughMigration fail CI due to
> failure: repodata/repomd.xml from patternfly: [Errno 256] No more
> mirrors to try.
> http://copr-be.cloud.fedoraproject.org/results/patternfly/patternfly1/epel-7-x86_64/repodata/repomd.xml:
> [Errno 14] curl#7 - "Failed connect to
> copr-be.cloud.fedoraproject.org:80; No route to host"
> http://copr-be.cloud.fedoraproject.org/results/patternfly/patternfly1/epel-7-x86_64



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23820#comment-23820
 ] 

Shlomo Ben David commented on OVIRT-900:


Only the 'vdsm-master-maintainers' group have full permissions on the master 
branch (and 'vdsm-maintainers' group as the owner of the project)
The user has permission as a registered user: push, verify, code-review on the 
'master' branch because he is not a member of that group.

> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>        Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=23809#comment-23809
 ] 

Shlomo Ben David commented on OVIRT-900:


Hi,

Nope, the 'Forge author Identity' is set specifically with the following
permissions:
'vdsm-master-maintainers' group for the 'master' branch
'vdsm-stable-maintainers' group for 'stable' branches


   - The user ybron...@redhat.com is a member of 'vdsm-stable-maintainers'
   and 'vdsm-arch-dependencies' groups
   - The user is not a member of 'vdsm-master-maintainers' group.


Should I add him to the 'vdsm-master-maintainers' group?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Thu, Dec 1, 2016 at 6:17 PM, eyal edri [Administrator] (oVirt JIRA) <



> Re: Rebase over other author's patch cannot be pushed to gerrit
> ---
>
> Key: OVIRT-900
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Barak Korren
>Assignee: Shlomo Ben David
>
> Forwarding to infra-support.
> On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > Not sure since when it was changed, but I noticed that I can't push patches
> > if I'm not the author
> >
> > Counting objects: 50, done.
> > Delta compression using up to 4 threads.
> > Compressing objects: 100% (50/50), done.
> > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > Total 50 (delta 34), reused 0 (delta 0)
> > remote: Resolving deltas: 100% (34/34)
> > remote: Processing changes: refs: 1, done
> > remote:
> > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > remote: ERROR:  author email address rnach...@redhat.com
> > remote: ERROR:  does not match your user account.
> > remote: ERROR:
> > remote: ERROR:  The following addresses are currently registered:
> > remote: ERROR:bronh...@gmail.com
> > remote: ERROR:ybron...@redhat.com
> > remote: ERROR:
> > remote: ERROR:  To register an email address, please visit:
> > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > remote:
> > remote:
> > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > error: failed to push some refs to
> > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> >
> > We must have permissions to do that, this is part of the rebasing part, and
> > I think its fine to fix patches on behalf of someone else.. but its not the
> > best practice for reviewing.
> > anyway, please undo this change, unless its something that related only to
> > my env.. let me know
> >
> > Thanks
> >
> > --
> > Yaniv Bronhaim.
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> -- 
> Barak Korren
> bkor...@redhat.com
> RHCE, RHCi, RHV-DevOps Team
> https://ifireball.wordpress.com/



--
This message was sent by Atlassian JIRA
(v1000.610.2#100023)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [JIRA] (OVIRT-900) Re: Rebase over other author's patch cannot be pushed to gerrit

[Shlomo Ben David]

Hi,

Nope, the 'Forge author Identity' is set specifically with the following
permissions:
'vdsm-master-maintainers' group for the 'master' branch
'vdsm-stable-maintainers' group for 'stable' branches


   - The user ybron...@redhat.com is a member of 'vdsm-stable-maintainers'
   and 'vdsm-arch-dependencies' groups
   - The user is not a member of 'vdsm-master-maintainers' group.


Should I add him to the 'vdsm-master-maintainers' group?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Thu, Dec 1, 2016 at 6:17 PM, eyal edri [Administrator] (oVirt JIRA) <
j...@ovirt-jira.atlassian.net> wrote:

>
> [ https://ovirt-jira.atlassian.net/browse/OVIRT-900?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=23633#comment-23633 ]
>
> eyal edri [Administrator] commented on OVIRT-900:
> -
>
> [~sbend...@redhat.com] maybe missing 'forge author identity' permission
> missing to all 'master branch maintaines'?
>
> > Re: Rebase over other author's patch cannot be pushed to gerrit
> > ---
> >
> > Key: OVIRT-900
> > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-900
> > Project: oVirt - virtualization made easy
> >  Issue Type: By-EMAIL
> >Reporter: Barak Korren
> >Assignee: Shlomo Ben David
> >
> > Forwarding to infra-support.
> > On 1 December 2016 at 18:03, Yaniv Bronheim <ybron...@redhat.com> wrote:
> > > Not sure since when it was changed, but I noticed that I can't push
> patches
> > > if I'm not the author
> > >
> > > Counting objects: 50, done.
> > > Delta compression using up to 4 threads.
> > > Compressing objects: 100% (50/50), done.
> > > Writing objects: 100% (50/50), 36.66 KiB | 0 bytes/s, done.
> > > Total 50 (delta 34), reused 0 (delta 0)
> > > remote: Resolving deltas: 100% (34/34)
> > > remote: Processing changes: refs: 1, done
> > > remote:
> > > remote: ERROR:  In commit db14ec7c1555a9eb37a0fb931bbb4ebdfc674bb4
> > > remote: ERROR:  author email address rnach...@redhat.com
> > > remote: ERROR:  does not match your user account.
> > > remote: ERROR:
> > > remote: ERROR:  The following addresses are currently registered:
> > > remote: ERROR:bronh...@gmail.com
> > > remote: ERROR:ybron...@redhat.com
> > > remote: ERROR:
> > > remote: ERROR:  To register an email address, please visit:
> > > remote: ERROR:  https://gerrit.ovirt.org/#/settings/contact
> > > remote:
> > > remote:
> > > To ssh://ybron...@gerrit.ovirt.org:29418/vdsm
> > >  ! [remote rejected] HEAD -> refs/for/master (invalid author)
> > > error: failed to push some refs to
> > > 'ssh://ybron...@gerrit.ovirt.org:29418/vdsm'
> > >
> > > We must have permissions to do that, this is part of the rebasing
> part, and
> > > I think its fine to fix patches on behalf of someone else.. but its
> not the
> > > best practice for reviewing.
> > > anyway, please undo this change, unless its something that related
> only to
> > > my env.. let me know
> > >
> > > Thanks
> > >
> > > --
> > > Yaniv Bronhaim.
> > >
> > > ___
> > > Infra mailing list
> > > Infra@ovirt.org
> > > http://lists.ovirt.org/mailman/listinfo/infra
> > >
> > --
> > Barak Korren
> > bkor...@redhat.com
> > RHCE, RHCi, RHV-DevOps Team
> > https://ifireball.wordpress.com/
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v1000.606.0#100023)
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-878) [gerrit hooks] add more checks to set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-878:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks]  add more checks to set_modified hook
> 
>
> Key: OVIRT-878
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-878
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> set_modified hook is setting bug status to MODIFIED although there are open 
> patches
> We need to add more checks to test if there are still open patches (in the 
> external tracker section)
> If there are ==> don't change the bug status to MODIFIED



--
This message was sent by Atlassian JIRA
(v1000.586.0#100022)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-878) [gerrit hooks] add more checks to set_modified hook

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-878:
--

 Summary: [gerrit hooks]  add more checks to set_modified hook
 Key: OVIRT-878
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-878
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra


set_modified hook is setting bug status to MODIFIED although there are open 
patches
We need to add more checks to test if there are still open patches (in the 
external tracker section)
If there are ==> don't change the bug status to MODIFIED



--
This message was sent by Atlassian JIRA
(v1000.586.0#100022)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-878) [gerrit hooks] add more checks to set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-878:
---
Epic Link: OVIRT-411

> [gerrit hooks]  add more checks to set_modified hook
> 
>
> Key: OVIRT-878
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-878
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> set_modified hook is setting bug status to MODIFIED although there are open 
> patches
> We need to add more checks to test if there are still open patches (in the 
> external tracker section)
> If there are ==> don't change the bug status to MODIFIED



--
This message was sent by Atlassian JIRA
(v1000.586.0#100022)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Add ovirt-engine-4.0.6 branch to the list of stable branches

[Shlomo Ben David]

The new check_backport hook released.
Currently waiting for CR.

- The new hook will replace the old check_merged_to_previous hook.
- The new hook bypass the static configuration file.

בתאריך 28 בנוב׳ 2016 02:48 PM,‏ "Eyal Edri"  כתב:

> We are in the last step of replacing this hook with a new hook which reads
> the branch names automatically from gerrit,
> w/o the need to maintain a static conf file.
>
> Adding Shlomi who can provide more info on ETA of deployment for it.
>
> On Mon, Nov 28, 2016 at 12:03 PM, Tal Nisan  wrote:
>
>> Otherwise gerrit-hooks ignores it: (taken from gerrit.ovirt.org/67324)
>>
>> gerrit-hooks
>> Nov 25 19:19
>> ↩
>>
>> Patch Set 1:
>>
>>- Update Tracker::#1398550::IGNORE, not relevant for Red Hat
>>classification
>>- Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
>>- Check Public Bug::#1398550::OK, public bug
>>- Check Product::#1398550::IGNORE, not relevant for classification:
>>Red Hat
>>- Check TM::#1398550::IGNORE, not relevant for classification: Red Hat
>>- Set POST::#1398550::IGNORE, not relevant for Red Hat classification
>>- Check merged to previous::IGNORE, Not in stable branch
>>(['ovirt-engine-3.6', 'ovirt-engine-4.0', 'ovirt-engine-3.6.9',
>>'ovirt-engine-4.0.2', 'ovirt-engine-4.0.4'])
>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Seems like every user can remove Gerrit-hooks vote on stable branch

[Shlomo Ben David]

Sure,  currently I released a new patch that removes all
ovirt-engine-master-maintainers permissions from the stable branches.

The abandon permission inherited from the All-Projects and granted to all
registered users.

בתאריך 28 בנוב׳ 2016 04:16 PM,‏ "Eyal Edri"  כתב:

> I'm not sure every user has this right, but we need to re-verify the list
> of stable branch maintainers to be correct.
> Shlomi - can you work with Tal to make sure the lists are updated for vdsm
> + engine ?
>
> On Mon, Nov 28, 2016 at 12:02 PM, Tal Nisan  wrote:
>
>> This is wrong, please revert it to how it was before when only stable
>> branch maintainers could remove it
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-877) [gerrit hooks] remove unused hooks

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-877:
--

 Summary: [gerrit hooks] remove unused hooks
 Key: OVIRT-877
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-877
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra


Remove all the unused hooks



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-877) [gerrit hooks] remove unused hooks

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-877:
---
Epic Link: OVIRT-403

> [gerrit hooks] remove unused hooks
> --
>
> Key: OVIRT-877
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-877
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> Remove all the unused hooks



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-877) [gerrit hooks] remove unused hooks

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-877:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] remove unused hooks
> --
>
> Key: OVIRT-877
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-877
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> Remove all the unused hooks



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-876) create check_backport hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-876:
---
Epic Link: OVIRT-403

> create check_backport hook
> --
>
> Key: OVIRT-876
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-876
> Project: oVirt - virtualization made easy
>  Issue Type: Improvement
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> The new hook should replace the old
> patchset-created.warn_if_not_merged_to_previous_branch
> - It should check that the current patch has been backported to all newer 
> branches
>   that are relevant for the patch.
> - It should bypass the use of the configuration file params (STABLE_BRANCH)
>   
>  



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-876) create check_backport hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-876:
---
Issue Type: Task  (was: Improvement)

> create check_backport hook
> --
>
> Key: OVIRT-876
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-876
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> The new hook should replace the old
> patchset-created.warn_if_not_merged_to_previous_branch
> - It should check that the current patch has been backported to all newer 
> branches
>   that are relevant for the patch.
> - It should bypass the use of the configuration file params (STABLE_BRANCH)
>   
>  



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-876) create check_backport hook

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-876:
--

 Summary: create check_backport hook
 Key: OVIRT-876
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-876
 Project: oVirt - virtualization made easy
  Issue Type: Improvement
Reporter: Shlomo Ben David
Assignee: infra


The new hook should replace the old
patchset-created.warn_if_not_merged_to_previous_branch
- It should check that the current patch has been backported to all newer 
branches
  that are relevant for the patch.
- It should bypass the use of the configuration file params (STABLE_BRANCH)

   



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-876) create check_backport hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-876:
--

Assignee: Shlomo Ben David  (was: infra)

> create check_backport hook
> --
>
> Key: OVIRT-876
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-876
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> The new hook should replace the old
> patchset-created.warn_if_not_merged_to_previous_branch
> - It should check that the current patch has been backported to all newer 
> branches
>   that are relevant for the patch.
> - It should bypass the use of the configuration file params (STABLE_BRANCH)
>   
>  



--
This message was sent by Atlassian JIRA
(v1000.571.2#100021)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: problem to see draft patches in gerrit.ovirt.org

[Shlomo Ben David]

Hi,

Drafts are personal for the draft creator unless he/she adds someone as a
reviewer.

BR,

Shlomi Ben-David

בתאריך 23 בנוב׳ 2016 08:08 AM,‏ "Eyal Edri"  כתב:

> Shlomi,  can you check?
>
> On Nov 23, 2016 12:07 AM, "Nir Soffer"  wrote:
>
>> This is the problematic draft:
>> https://gerrit.ovirt.org/#/c/67169/
>>
>> Happen also to me last week, trying to access a draft from Milan.
>>
>> On Wed, Nov 23, 2016 at 12:01 AM, Maor Lipchuk 
>> wrote:
>> > Hi all,
>> >
>> > There is a permission issue in gerrit.ovirt.org that blocks seeing
>> draft
>> > patches.
>> > Once I try to see a draft patch I'm getting the following message:
>> >  "The page you requested was not found, or you do not have permission to
>> > view this page."
>> > Will appreciate your help.
>> >
>> > Regards,
>> > Maor
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Gerrit->Bugzilla update failed

[Shlomo Ben David]

Hi Pavel and Shmuel,

You are right that the bug-url added, but it added with wrong convention:
https://bugzilla.redhat.com/show_bug.cgi?id=1335642

while it should be added as: https://bugzilla.redhat.com/1335642


Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Nov 15, 2016 at 2:34 PM, Pavel Zhukov  wrote:

> Hello,
> Thank you for reporting the issue.
> In both cases Bug-Url is recognized (check bug if public works fine) but
> bug itself was not updated. I'll open ticket to track this issue.
>
> --
> Pavel
>
> On Tue, Nov 15, 2016 at 1:24 PM, Shmuel Melamud 
> wrote:
>
>> Hi!
>>
>> Seems there is a problem with gerrit-hooks as related to Bugzilla updates.
>>
>> With this change https://gerrit.ovirt.org/#/c/66774/ gerrit-hooks says
>> that Bug-Url is absent, while it is present and correct.
>>
>> With this change: https://gerrit.ovirt.org/#/c/66723/ Bugzilla was not
>> updated, while Bug-Url is present and correct.
>>
>> Shmuel
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Pavel Zhukov
> Software Engineer
> RHEV Devops
> IRC: landgraf
>
>
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-843) Bug-Url is not recognized properly

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-843:
--

Assignee: Shlomo Ben David  (was: infra)

> Bug-Url is not recognized properly
> --
>
> Key: OVIRT-843
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-843
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>Reporter: Pavel Zhukov
>        Assignee: Shlomo Ben David
>Priority: High
>
> Example:
> Check Bug-Url::WARN, no bug url/s found  <== 
> Check Public Bug::#1373573::OK, public bug  <== But OK here
> Example changes:
> https://gerrit.ovirt.org/#/c/66723/
> https://gerrit.ovirt.org/#/c/66774/



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-843) Bug-Url is not recognized properly

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=22700#comment-22700
 ] 

Shlomo Ben David commented on OVIRT-843:


Hi Pavel,

It is not a bug, the user added the bug-url with wrong convention: 
https://bugzilla.redhat.com/*show_bug.cgi?id=*1335642
While it should be added as: https://bugzilla.redhat.com/1335642

> Bug-Url is not recognized properly
> --
>
> Key: OVIRT-843
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-843
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>Reporter: Pavel Zhukov
>Assignee: infra
>Priority: High
>
> Example:
> Check Bug-Url::WARN, no bug url/s found  <== 
> Check Public Bug::#1373573::OK, public bug  <== But OK here
> Example changes:
> https://gerrit.ovirt.org/#/c/66723/
> https://gerrit.ovirt.org/#/c/66774/



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-839) [gerrit hooks] retype classification message

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-839:
---
Epic Link: OVIRT-403

> [gerrit hooks] retype classification message
> 
>
> Key: OVIRT-839
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-839
> Project: oVirt - virtualization made easy
>  Issue Type: Improvement
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> The current message isn't consistent in all hooks.
> If the bug classification is not 'oVirt' return the following message:
> [hook name]::[bug id]::IGNORE: not relevant for '[other classification]' 
> classification.



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-839) [gerrit hooks] retype classification message

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-839:
--

 Summary: [gerrit hooks] retype classification message
 Key: OVIRT-839
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-839
 Project: oVirt - virtualization made easy
  Issue Type: Improvement
Reporter: Shlomo Ben David
Assignee: infra


The current message isn't consistent in all hooks.
If the bug classification is not 'oVirt' return the following message:
[hook name]::[bug id]::IGNORE: not relevant for '[other classification]' 
classification.



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-838) [gerrit hooks] disable verify on refs/meta/config branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-838:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] disable verify on refs/meta/config branch
> 
>
> Key: OVIRT-838
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-838
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> Hook: check_bug_url
> The current setting in the hook is to grade (verify -1) stable branches if 
> there are no bug-url found, but it catch also refs/meta/config or meta/config 
> branches (that should be ignored).



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-838) [gerrit hooks] disable verify on refs/meta/config branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-838:
---
Epic Link: OVIRT-403

> [gerrit hooks] disable verify on refs/meta/config branch
> 
>
> Key: OVIRT-838
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-838
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> Hook: check_bug_url
> The current setting in the hooks is to grade (verify -1) stable branches if 
> there are no bug-url found, but it catch also refs/meta/config or meta/config 
> branches (that should be ignored.



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-838) [gerrit hooks] disable verify on refs/meta/config branch

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-838:
--

 Summary: [gerrit hooks] disable verify on refs/meta/config branch
 Key: OVIRT-838
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-838
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra


Hook: check_bug_url
The current setting in the hooks is to grade (verify -1) stable branches if 
there are no bug-url found, but it catch also refs/meta/config or meta/config 
branches (that should be ignored.



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-838) [gerrit hooks] disable verify on refs/meta/config branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-838:
---
Description: 
Hook: check_bug_url
The current setting in the hook is to grade (verify -1) stable branches if 
there are no bug-url found, but it catch also refs/meta/config or meta/config 
branches (that should be ignored.

  was:
Hook: check_bug_url
The current setting in the hooks is to grade (verify -1) stable branches if 
there are no bug-url found, but it catch also refs/meta/config or meta/config 
branches (that should be ignored.


> [gerrit hooks] disable verify on refs/meta/config branch
> 
>
> Key: OVIRT-838
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-838
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> Hook: check_bug_url
> The current setting in the hook is to grade (verify -1) stable branches if 
> there are no bug-url found, but it catch also refs/meta/config or meta/config 
> branches (that should be ignored.



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-838) [gerrit hooks] disable verify on refs/meta/config branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-838:
---
Description: 
Hook: check_bug_url
The current setting in the hook is to grade (verify -1) stable branches if 
there are no bug-url found, but it catch also refs/meta/config or meta/config 
branches (that should be ignored).

  was:
Hook: check_bug_url
The current setting in the hook is to grade (verify -1) stable branches if 
there are no bug-url found, but it catch also refs/meta/config or meta/config 
branches (that should be ignored.


> [gerrit hooks] disable verify on refs/meta/config branch
> 
>
> Key: OVIRT-838
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-838
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> Hook: check_bug_url
> The current setting in the hook is to grade (verify -1) stable branches if 
> there are no bug-url found, but it catch also refs/meta/config or meta/config 
> branches (that should be ignored).



--
This message was sent by Atlassian JIRA
(v1000.526.2#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-814) [gerrit hooks] fix 'NoneType' in is_draft argument in set_modified hook

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-814:
--

 Summary: [gerrit hooks] fix 'NoneType' in is_draft argument in 
set_modified hook
 Key: OVIRT-814
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-814
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra


- When merging patches they are with MERGED status and the is_draft argument is 
set to 'None'.




--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-814) [gerrit hooks] fix 'NoneType' in is_draft argument in set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-814:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] fix 'NoneType' in is_draft argument in set_modified hook
> ---
>
> Key: OVIRT-814
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-814
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> - When merging patches they are with MERGED status and the is_draft argument 
> is set to 'None'.



--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-814) [gerrit hooks] fix 'NoneType' in is_draft argument in set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-814:
---
Epic Link: OVIRT-403

> [gerrit hooks] fix 'NoneType' in is_draft argument in set_modified hook
> ---
>
> Key: OVIRT-814
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-814
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> - When merging patches they are with MERGED status and the is_draft argument 
> is set to 'None'.



--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-813) [gerrit hooks] typo error in check_product hook

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=22330#comment-22330
 ] 

Shlomo Ben David commented on OVIRT-813:


patch #[66179|https://gerrit.ovirt.org/#/c/66179/] is ready.

current status: MERGED

> [gerrit hooks] typo error in check_product hook
> ---
>
> Key: OVIRT-813
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-813
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> There is a typo in passing the bugzilla server. 
> Currently it passed it as a list ['bz_server'] instead of a string 
> config['bz_server'].



--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-813) [gerrit hooks] typo error in check_product hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David closed OVIRT-813.
--
Resolution: Fixed

> [gerrit hooks] typo error in check_product hook
> ---
>
> Key: OVIRT-813
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-813
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> There is a typo in passing the bugzilla server. 
> Currently it passed it as a list ['bz_server'] instead of a string 
> config['bz_server'].



--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-813) [gerrit hooks] typo error in check_product hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-813:
---
Status: In Progress  (was: To Do)

> [gerrit hooks] typo error in check_product hook
> ---
>
> Key: OVIRT-813
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-813
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> There is a typo in passing the bugzilla server. 
> Currently it passed it as a list ['bz_server'] instead of a string 
> config['bz_server'].



--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-813) [gerrit hooks] typo error in check_product hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-813:
---
Epic Link: OVIRT-403

> [gerrit hooks] typo error in check_product hook
> ---
>
> Key: OVIRT-813
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-813
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> There is a typo in passing the bugzilla server. 
> Currently it passed it as a list ['bz_server'] instead of a string 
> config['bz_server'].



--
This message was sent by Atlassian JIRA
(v1000.499.4#100018)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-809) [gerrit hooks] recreate set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-809:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] recreate set_modified hook
> -
>
> Key: OVIRT-809
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-809
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>




--
This message was sent by Atlassian JIRA
(v1000.482.6#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-809) [gerrit hooks] recreate set_modified hook

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-809:
--

 Summary: [gerrit hooks] recreate set_modified hook
 Key: OVIRT-809
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-809
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra






--
This message was sent by Atlassian JIRA
(v1000.482.6#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-809) [gerrit hooks] recreate set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-809:
---
Epic Link: OVIRT-403

> [gerrit hooks] recreate set_modified hook
> -
>
> Key: OVIRT-809
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-809
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>




--
This message was sent by Atlassian JIRA
(v1000.482.6#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-804) [gerrit hooks] recreate set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-804:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] recreate set_modified hook
> -
>
> Key: OVIRT-804
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-804
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>




--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-804) [gerrit hooks] recreate set_modified hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-804:
---
Epic Link: OVIRT-403

> [gerrit hooks] recreate set_modified hook
> -
>
> Key: OVIRT-804
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-804
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>




--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-804) [gerrit hooks] recreate set_modified hook

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-804:
--

 Summary: [gerrit hooks] recreate set_modified hook
 Key: OVIRT-804
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-804
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra






--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-803) [gerrit hooks] enable updating external tracker info for master branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-803:
---
Epic Link: OVIRT-403

> [gerrit hooks] enable updating external tracker info for master branch
> --
>
> Key: OVIRT-803
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-803
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> - Currently we are not updating external tracker info for patches in 'master' 
> branch.
> - We should update both 'stable' and 'master' branch patches info in Bugzilla 
> (external tracker)



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-803) [gerrit hooks] enable updating external tracker info for master branch

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-803:
--

 Summary: [gerrit hooks] enable updating external tracker info for 
master branch
 Key: OVIRT-803
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-803
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra


- Currently we are not updating external tracker info for patches in 'master' 
branch.
- We should update both 'stable' and 'master' branch patches info in Bugzilla 
(external tracker)



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-803) [gerrit hooks] enable updating external tracker info for master branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-803:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] enable updating external tracker info for master branch
> --
>
> Key: OVIRT-803
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-803
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> - Currently we are not updating external tracker info for patches in 'master' 
> branch.
> - We should update both 'stable' and 'master' branch patches info in Bugzilla 
> (external tracker)



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Updating email configuration

[Shlomo Ben David]

Hi All,

Due to some restrictions on our email server we need to update our email
configuration to increase the security on it.
To apply the new configuration i will reboot the server today 31/10/2016 at
20:00 IST.

*Downtime EST: ~5 minutes*

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-801) [gerrit hooks] enable check_bug_url for master branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-801:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] enable check_bug_url for master branch
> -
>
> Key: OVIRT-801
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-801
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> - Currently we are not checking bug urls for master branch.
> - We need to enable check_bug_url for master branch and set it to be optional 
> for 'master'
>   branch but mandatory for 'stable' branches.



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-801) [gerrit hooks] enable check_bug_url for master branch

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-801:
--

 Summary: [gerrit hooks] enable check_bug_url for master branch
 Key: OVIRT-801
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-801
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra


- Currently we are not checking bug urls for master branch.
- We need to enable check_bug_url for master branch and set it to be optional 
for 'master'
  branch but mandatory for 'stable' branches.



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-801) [gerrit hooks] enable check_bug_url for master branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-801:
---
Epic Link: OVIRT-403

> [gerrit hooks] enable check_bug_url for master branch
> -
>
> Key: OVIRT-801
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-801
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> - Currently we are not checking bug urls for master branch.
> - We need to enable check_bug_url for master branch and set it to be optional 
> for 'master'
>   branch but mandatory for 'stable' branches.



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-797) [gerrit hooks] update tracker failed to update bugs

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-797:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] update tracker failed to update bugs
> ---
>
> Key: OVIRT-797
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-797
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>Priority: High
>
> bool(x) function isn't converts 'True' | 'False' strings into bool (True | 
> False) values,
> it only returns True if the passed value is True, False otherwise.
> I've replaced it with ast.literal_eval() function that converts and returns 
> the required bool values.



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-797) [gerrit hooks] update tracker failed to update bugs

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-797:
--

 Summary: [gerrit hooks] update tracker failed to update bugs
 Key: OVIRT-797
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-797
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra
Priority: High


bool(x) function isn't converts 'True' | 'False' strings into bool (True | 
False) values,
it only returns True if the passed value is True, False otherwise.
I've replaced it with ast.literal_eval() function that converts and returns the 
required bool values.



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-797) [gerrit hooks] update tracker failed to update bugs

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-797:
---
Epic Link: OVIRT-403

> [gerrit hooks] update tracker failed to update bugs
> ---
>
> Key: OVIRT-797
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-797
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>Priority: High
>
> bool(x) function isn't converts 'True' | 'False' strings into bool (True | 
> False) values,
> it only returns True if the passed value is True, False otherwise.
> I've replaced it with ast.literal_eval() function that converts and returns 
> the required bool values.



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-796) [gerrit hooks] recreate set_post hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-796:
--

Assignee: Shlomo Ben David  (was: infra)

> [gerrit hooks] recreate set_post hook
> -
>
> Key: OVIRT-796
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-796
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> The new hook will follow the bellow guidelines:
> * It updates only u/s bugs (oVirt classification)
> * It updates the bug status in bugzilla only from NEW to POST



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-796) [gerrit hooks] recreate set_post hook

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-796:
---
Epic Link: OVIRT-403

> [gerrit hooks] recreate set_post hook
> -
>
> Key: OVIRT-796
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-796
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>
> The new hook will follow the bellow guidelines:
> * It updates only u/s bugs (oVirt classification)
> * It updates the bug status in bugzilla only from NEW to POST



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-796) [gerrit hooks] recreate set_post hook

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-796:
--

 Summary: [gerrit hooks] recreate set_post hook
 Key: OVIRT-796
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-796
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra


The new hook will follow the bellow guidelines:
* It updates only u/s bugs (oVirt classification)
* It updates the bug status in bugzilla only from NEW to POST



--
This message was sent by Atlassian JIRA
(v1000.482.3#100017)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: ovirt-engine-4.0.5 is not treated as a monitored stable branch

[Shlomo Ben David]

Yep, you are right the hook is check_target_milestone and i explained it in
the previous email.

So after i've made some checks these are my conclusions:

   - All the new hooks are performing manipulation only on bugs with u/s
   classification (oVirt), the bug [1] is with a d/s classification.
   - The '*Check merged to previous' *hook is an old hook that is not
   configured to check classifications.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1368101

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Sun, Oct 30, 2016 at 3:50 PM, Eyal Edri <ee...@redhat.com> wrote:

> I think its this one: https://gerrit.ovirt.org/#/c/64538/
>
> And I think I know what the problem is,
> This bug [1] is 4.1 bug its target milestone is 4.0.6 because its a clone
> candidate bug.
> Shlomi - IIRC we addressed that issue in the hook, can you verify? (also,
> might be the bug is ignoring downstream bugs)
>
>
>
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1368101
>
> On Sun, Oct 30, 2016 at 3:35 PM, Eyal Edri <ee...@redhat.com> wrote:
>
>> Shlomi - do we have a gerrit hook that checks the bug version with the
>> branch name?
>> I remember we had something similar...
>>
>> On Sun, Oct 30, 2016 at 3:30 PM, Tal Nisan <tni...@redhat.com> wrote:
>>
>>> That was an example, the patch should have got -verified as a 4.1 bug
>>> url in a 4.0.5 branch
>>>
>>> On Sun, Oct 30, 2016 at 3:27 PM, Shlomo Ben David <sbend...@redhat.com>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> Tal: The '*Check merged to previous*' hook is checking if the current
>>>> patch was merged to previous stable branches and i think that it is not
>>>> related to the one that you're searching.
>>>>
>>>> Eyal: Currently there is no hook that checks if branch is enabled, but
>>>> there is hook that checks if the patch major version branch is [equal /
>>>> higher / lower] than the bug target milestone major version.
>>>> i'll explain by giving you few examples and their results:
>>>>
>>>> Example 1:
>>>> tm: '---'(empty target milestone)
>>>> branch major version: any
>>>> result: *WARN MSG*
>>>>
>>>> Example 2:
>>>> tm major version: 3.6
>>>> branch major version: 3.6
>>>> result: *OK MSG*
>>>>
>>>> Example 3:
>>>> tm major version: 3.6
>>>> branch major version: 4.0
>>>> result: checks for clone flags
>>>> (if tm major version in flags - *OK MSG* else *WARN MSG*)
>>>>
>>>> Example 4:
>>>> tm major version: 4.0
>>>> branch major version: 3.6
>>>> result: *WARN MSG*
>>>>
>>>>
>>>> Best Regards,
>>>>
>>>> Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
>>>> RHCSA | RHCE
>>>> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>>>>
>>>> OPEN SOURCE - 1 4 011 && 011 4 1
>>>>
>>>> On Sun, Oct 30, 2016 at 9:45 AM, Eyal Edri <ee...@redhat.com> wrote:
>>>>
>>>>> Shlomi,
>>>>> Can you check if we have the hook for verifying right branch is
>>>>> enabled?
>>>>>
>>>>>
>>>>>
>>>>> On Thu, Oct 27, 2016 at 11:00 AM, Tal Nisan <tni...@redhat.com> wrote:
>>>>>
>>>>>> This patch was pushed to 4.0.5 with a bug that at the time of the
>>>>>> push was 4.1, Gerrit hooks should have marked it as -verified, instead 
>>>>>> you
>>>>>> get:
>>>>>>
>>>>>>- Check merged to previous::IGNORE, Not in stable branch
>>>>>>(['ovirt-engine-3.6', 'ovirt-engine-4.0', 'ovirt-engine-3.6.9',
>>>>>>'ovirt-engine-4.0.2', 'ovirt-engine-4.0.4'])
>>>>>>
>>>>>>
>>>>>> On Thu, Oct 27, 2016 at 9:55 AM, Gil Shinar <gshi...@redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Can you please elaborate?
>>>>>>>
>>>>>>> Thanks
>>>>>>> Gil
>>>>>>>
>>>>>>> On Wed, Oct 26, 2016 at 11:50 AM, Tal Nisan <tni...@redhat.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> This patch for example:
>>>>>>>> https://gerrit.ovirt.org/#/c/65398/
>>>>>>>>
>>>>>>>>
>>>>>>>> ___
>>>>>>>> Infra mailing list
>>>>>>>> Infra@ovirt.org
>>>>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>> ___
>>>>>> Infra mailing list
>>>>>> Infra@ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Eyal Edri
>>>>> Associate Manager
>>>>> RHV DevOps
>>>>> EMEA ENG Virtualization R
>>>>> Red Hat Israel
>>>>>
>>>>> phone: +972-9-7692018
>>>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> Eyal Edri
>> Associate Manager
>> RHV DevOps
>> EMEA ENG Virtualization R
>> Red Hat Israel
>>
>> phone: +972-9-7692018
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>
>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: ovirt-engine-4.0.5 is not treated as a monitored stable branch

[Shlomo Ben David]

Hi,

Tal: The '*Check merged to previous*' hook is checking if the current patch
was merged to previous stable branches and i think that it is not related
to the one that you're searching.

Eyal: Currently there is no hook that checks if branch is enabled, but
there is hook that checks if the patch major version branch is [equal /
higher / lower] than the bug target milestone major version.
i'll explain by giving you few examples and their results:

Example 1:
tm: '---'(empty target milestone)
branch major version: any
result: *WARN MSG*

Example 2:
tm major version: 3.6
branch major version: 3.6
result: *OK MSG*

Example 3:
tm major version: 3.6
branch major version: 4.0
result: checks for clone flags
(if tm major version in flags - *OK MSG* else *WARN MSG*)

Example 4:
tm major version: 4.0
branch major version: 3.6
result: *WARN MSG*


Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Sun, Oct 30, 2016 at 9:45 AM, Eyal Edri  wrote:

> Shlomi,
> Can you check if we have the hook for verifying right branch is enabled?
>
>
>
> On Thu, Oct 27, 2016 at 11:00 AM, Tal Nisan  wrote:
>
>> This patch was pushed to 4.0.5 with a bug that at the time of the push
>> was 4.1, Gerrit hooks should have marked it as -verified, instead you get:
>>
>>- Check merged to previous::IGNORE, Not in stable branch
>>(['ovirt-engine-3.6', 'ovirt-engine-4.0', 'ovirt-engine-3.6.9',
>>'ovirt-engine-4.0.2', 'ovirt-engine-4.0.4'])
>>
>>
>> On Thu, Oct 27, 2016 at 9:55 AM, Gil Shinar  wrote:
>>
>>> Can you please elaborate?
>>>
>>> Thanks
>>> Gil
>>>
>>> On Wed, Oct 26, 2016 at 11:50 AM, Tal Nisan  wrote:
>>>
 This patch for example:
 https://gerrit.ovirt.org/#/c/65398/


 ___
 Infra mailing list
 Infra@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/infra


>>>
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: 'invalid author' while trying to rebase https://gerrit.ovirt.org/#/c/65831/

[Shlomo Ben David]

Hi Roy,

The permissions inherited from All-Projects (This is the default
configuration for all projects).
The project owners have all the necessary permissions (push, rebase, cr+2
etc)

Can you please check it now and let me know?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Sun, Oct 30, 2016 at 9:58 AM, Eyal Edri  wrote:

> A quick solution will be to add the 'forge author identity' to the project
> [1]
> But I'd like to make sure its not an issue with new permissions settings
> in gerrit, Shlomi - can you check?
>
> Also, IIRC all projects [2] should have an owner permissions that should
> allow the owner/maintainer to modify the permissions himself.
>
>
> [1] https://gerrit.ovirt.org/#/c/65852/1
> [2] except for vdsm & engine which are owned by multiple teams, so
> ownership permission lays with infra team.
>
> On Sun, Oct 30, 2016 at 9:51 AM, Roy Golan  wrote:
>
>> I can't rebase and merge this patch https://gerrit.ovirt.org/#/c/65831/
>>
>> According to [1] I might have wrong permission on that project
>> (ovirt-vdsmfake)
>>
>> Please help fixing the permission so this could be rebased and merge
>> ASAP  (I already have submit permissions)
>>
>> [1] https://bugs.chromium.org/p/gerrit/issues/detail?id=2670
>>
>> ___
>> Infra mailing list
>> Infra@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-788) [gerrit hooks] Disable patchset-created.bz.98.set_POST hook for drafts patches

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-788:
---
Epic Link: OVIRT-403

> [gerrit hooks] Disable patchset-created.bz.98.set_POST hook for drafts patches
> --
>
> Key: OVIRT-788
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-788
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>Priority: High
>
> When using patchset-created.bz.98.set_POST hook, it will update the bug 
> status in bugzilla from NEW to POST, it is not relevant for draft patches - 
> so it should be disabled. 



--
This message was sent by Atlassian JIRA
(v1000.456.2#100016)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-788) [gerrit hooks] Disable patchset-created.bz.98.set_POST hook for drafts patches

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-788:
--

 Summary: [gerrit hooks] Disable patchset-created.bz.98.set_POST 
hook for drafts patches
 Key: OVIRT-788
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-788
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra
Priority: High


When using patchset-created.bz.98.set_POST hook, it will update the bug status 
in bugzilla from NEW to POST, it is not relevant for draft patches - so it 
should be disabled. 



--
This message was sent by Atlassian JIRA
(v1000.456.2#100016)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Can not rebase or push updates to patches with different author

[Shlomo Ben David]

Hi Anton,

I still didn't update other projects to the default rules.
I'll update them when I return to the office.

BR,

Shlomi Ben-David

בתאריך 20 באוק׳ 2016 04:27 PM,‏ "Anton Marchukov" <amarc...@redhat.com> כתב:

> Hello Shlomi.
>
> I also had to add it to:
>
> ovirt-engine-sdk
> ovirt-engine-sdk-java
> ovirt-engine-sdk-js
> ovirt-engine-sdk-tests
>
> May it be that defaults are not sane enough for this particular rule?
>
>
> On Wed, Oct 19, 2016 at 11:50 PM, Shlomo Ben David <sbend...@redhat.com>
> wrote:
>
>> Hi,
>>
>> This permission was set for project owners only,
>> But in this specific case I think that it's the right solution, because
>> these projects have customized permissions.
>>
>> Thanks a lot Anton.
>>
>> BR,
>>
>> Shlomi Ben-David
>>
>> בתאריך 19 באוק׳ 2016 15:34,‏ "Tal Nisan" <tni...@redhat.com> כתב:
>>
>> Makes perfect sense for maintainers as we have to rebase or sometimes
>>> post minor updates (e.g. commit message) for patches that we are not the
>>> authors of.
>>> As for non maintainer users it is of small to no benefit at all so I
>>> think it's the best course of action.
>>>
>>> Thanks.
>>>
>>>
>>> On Wed, Oct 19, 2016 at 3:31 PM, Anton Marchukov <amarc...@redhat.com>
>>> wrote:
>>>
>>>> FYI. I have added Forge Author Identity to corresponding maintainers
>>>> groups for master and stables branches of ovirt-engine
>>>>
>>>> On Wed, Oct 19, 2016 at 1:37 PM, Anton Marchukov <amarc...@redhat.com>
>>>> wrote:
>>>>
>>>>> Hello Shlomi.
>>>>>
>>>>> May it be related to your permissions generalization work? This is
>>>>> something to consider/check.
>>>>>
>>>>> Anton.
>>>>>
>>>>>
>>>>>
>>>>> On Wed, Oct 19, 2016 at 1:26 PM, Tal Nisan <tni...@redhat.com> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Up till not long ago it was possible to rebase or push updates to
>>>>>> patches even if I was not the author of the patch, now I've noticed that
>>>>>> when trying to do so I encounter "invalid author" error.
>>>>>> For maintainers (especially in the stable branches) this is crucial
>>>>>> and makes the cycle much shorter as no intervention from the original
>>>>>> author is needed on trivial rebases, can you please restore the old 
>>>>>> state?
>>>>>>
>>>>>> Tal.
>>>>>>
>>>>>>
>>>>>> ___
>>>>>> Infra mailing list
>>>>>> Infra@ovirt.org
>>>>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Anton Marchukov
>>>>> Senior Software Engineer - RHEV CI - Red Hat
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Anton Marchukov
>>>> Senior Software Engineer - RHEV CI - Red Hat
>>>>
>>>>
>>>
>
>
> --
> Anton Marchukov
> Senior Software Engineer - RHEV CI - Red Hat
>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Can not rebase or push updates to patches with different author

[Shlomo Ben David]

Hi,

This permission was set for project owners only,
But in this specific case I think that it's the right solution, because
these projects have customized permissions.

Thanks a lot Anton.

BR,

Shlomi Ben-David

בתאריך 19 באוק׳ 2016 15:34,‏ "Tal Nisan"  כתב:

> Makes perfect sense for maintainers as we have to rebase or sometimes post
> minor updates (e.g. commit message) for patches that we are not the authors
> of.
> As for non maintainer users it is of small to no benefit at all so I think
> it's the best course of action.
>
> Thanks.
>
>
> On Wed, Oct 19, 2016 at 3:31 PM, Anton Marchukov 
> wrote:
>
>> FYI. I have added Forge Author Identity to corresponding maintainers
>> groups for master and stables branches of ovirt-engine
>>
>> On Wed, Oct 19, 2016 at 1:37 PM, Anton Marchukov 
>> wrote:
>>
>>> Hello Shlomi.
>>>
>>> May it be related to your permissions generalization work? This is
>>> something to consider/check.
>>>
>>> Anton.
>>>
>>>
>>>
>>> On Wed, Oct 19, 2016 at 1:26 PM, Tal Nisan  wrote:
>>>
 Hi,

 Up till not long ago it was possible to rebase or push updates to
 patches even if I was not the author of the patch, now I've noticed that
 when trying to do so I encounter "invalid author" error.
 For maintainers (especially in the stable branches) this is crucial and
 makes the cycle much shorter as no intervention from the original author is
 needed on trivial rebases, can you please restore the old state?

 Tal.


 ___
 Infra mailing list
 Infra@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/infra


>>>
>>>
>>> --
>>> Anton Marchukov
>>> Senior Software Engineer - RHEV CI - Red Hat
>>>
>>>
>>
>>
>> --
>> Anton Marchukov
>> Senior Software Engineer - RHEV CI - Red Hat
>>
>>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-766) Code Review - Error invalid author

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=21636#comment-21636
 ] 

Shlomo Ben David commented on OVIRT-766:


Hi,

The forge author + forge commiter permissions were set only for project
owners, that's because it allows users to push not signed-off-by patches.
Fixed in https://gerrit.ovirt.org/65427 patch.

Sandro - please let me know if it solved your issue.

BR,

Shlomi Ben-David

בתאריך 13 באוק׳ 2016 11:25,‏ "Evgheni Dereveanchin (oVirt JIRA)" <



> Code Review - Error invalid author
> --
>
> Key: OVIRT-766
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-766
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: sbonazzo
>Assignee: infra
>
> While editing a commit message or a file from gerrit I get:
> Code Review - Error invalid author
> when I save and publish the change.
> Can you please fix it?
> -- 
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at redhat.com
> <https://www.redhat.com/it/about/events/red-hat-open-source-day-2016>



--
This message was sent by Atlassian JIRA
(v1000.383.2#100014)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [JIRA] (OVIRT-766) Code Review - Error invalid author

[Shlomo Ben David]

Hi,

The forge author + forge commiter permissions were set only for project
owners, that's because it allows users to push not signed-off-by patches.
Fixed in https://gerrit.ovirt.org/65427 patch.

Sandro - please let me know if it solved your issue.

BR,

Shlomi Ben-David

בתאריך 13 באוק׳ 2016 11:25,‏ "Evgheni Dereveanchin (oVirt JIRA)" <
j...@ovirt-jira.atlassian.net> כתב:

>
> [ https://ovirt-jira.atlassian.net/browse/OVIRT-766?page=com.
> atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel=21633#comment-21633 ]
>
> Evgheni Dereveanchin commented on OVIRT-766:
> 
>
> looks like a duplicate of OVIRT-767
>
> > Code Review - Error invalid author
> > --
> >
> > Key: OVIRT-766
> > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-766
> > Project: oVirt - virtualization made easy
> >  Issue Type: By-EMAIL
> >Reporter: sbonazzo
> >Assignee: infra
> >
> > While editing a commit message or a file from gerrit I get:
> > Code Review - Error invalid author
> > when I save and publish the change.
> > Can you please fix it?
> > --
> > Sandro Bonazzola
> > Better technology. Faster innovation. Powered by community collaboration.
> > See how it works at redhat.com
> > 
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v1000.383.2#100014)
> ___
> Infra mailing list
> Infra@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-765) Gerrit automation posting to unrelated bugs on bugzilla.redhat.com?

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-765:
--

Assignee: Shlomo Ben David  (was: infra)

> Gerrit automation posting to unrelated bugs on bugzilla.redhat.com?
> ---
>
> Key: OVIRT-765
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-765
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: Nalin Dahyabhai
>        Assignee: Shlomo Ben David
>
> Gerrit automation seems to be touching bugs like
> https://bugzilla.redhat.com/show_bug.cgi?id=64468 and
> https://bugzilla.redhat.com/show_bug.cgi?id=63626, which don't seem to
> be related to ovirt.  Is it doing this instead of touching
> things that it should be, which are elsewhere?
> Nalin



--
This message was sent by Atlassian JIRA
(v1000.383.2#100014)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-756) gerrit allows changed without signed-off field

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-756:
--

Assignee: Shlomo Ben David  (was: infra)

> gerrit allows changed without signed-off field
> --
>
> Key: OVIRT-756
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-756
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>Reporter: Pavel Zhukov
>        Assignee: Shlomo Ben David
>Priority: High
>
> Example:
> https://gerrit.ovirt.org/#/c/65240/



--
This message was sent by Atlassian JIRA
(v1000.383.2#100014)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-747) Server Error after signing out and signing back in

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-747:
--

Assignee: Shlomo Ben David  (was: infra)

> Server Error after signing out and signing back in
> --
>
> Key: OVIRT-747
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-747
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>Priority: High
>
> After signing out and signing back in i've received 'Server Error'.
> It happened only when authenticating via oauth2 authentication



--
This message was sent by Atlassian JIRA
(v1000.383.1#100014)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-747) Server Error after signing out and signing back in

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-747:
---
Epic Link: OVIRT-403

> Server Error after signing out and signing back in
> --
>
> Key: OVIRT-747
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-747
> Project: oVirt - virtualization made easy
>  Issue Type: Bug
>        Reporter: Shlomo Ben David
>Assignee: infra
>Priority: High
>
> After signing out and signing back in i've received 'Server Error'.
> It happened only when authenticating via oauth2 authentication



--
This message was sent by Atlassian JIRA
(v1000.383.1#100014)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-747) Server Error after signing out and signing back in

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-747:
--

 Summary: Server Error after signing out and signing back in
 Key: OVIRT-747
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-747
 Project: oVirt - virtualization made easy
  Issue Type: Bug
Reporter: Shlomo Ben David
Assignee: infra
Priority: High


After signing out and signing back in i've received 'Server Error'.
It happened only when authenticating via oauth2 authentication



--
This message was sent by Atlassian JIRA
(v1000.383.1#100014)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Updating permissions on gerrit.ovirt.org

[Shlomo Ben David]

Hi All,

On the upcoming days i'm going to update permissions on gerrit.ovirt.org
server.
The changes shouldn't reflect on the current state but if you'll encounter
with any permission issues or other issues related to gerrit.ovirt.org
server please let me or infra@ovirt.org to know and we'll handle it ASAP.

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-721) Re: gerrit - Prevent pushing directly to origin/branches

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-721:
---
Status: In Progress  (was: To Do)

> Re: gerrit - Prevent pushing directly to origin/branches
> 
>
> Key: OVIRT-721
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-721
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: eyal edri [Administrator]
>        Assignee: Shlomo Ben David
>
> Opening a ticket on it.
> On Tue, Sep 6, 2016 at 11:13 AM, Roy Golan <rgo...@redhat.com> wrote:
> > Using ```git push origin HEAD:origin/ovirt-engine-3.6``` I'm able to
> > merge my work and bypass any review. This needs to be prevented to
> > unprivileged people i.e only stable branch maintainers.
> >
> > See example in https://gerrit.ovirt.org/#/c/62425/
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >
> -- 
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)



--
This message was sent by Atlassian JIRA
(v1000.319.1#100012)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Re: [ovirt-devel] I have this issue when trying to connect to gerrit

[Shlomo Ben David]

Hi Maokexu,

I'm very glad to hear that you want to work with oVirt Gerrit.
>From the attached log, you are reaching gerrit.ovirt.org server throught
port 22, but receving connection time out when connecting throught port
29418 (this is a gerrit default port).

There can be few reasons for that:
1. You are blocked by your local iptables\firewall <== already checked
2. You are blocked by your office or home firewall <== need to check

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Thu, Sep 8, 2016 at 9:36 AM, maok...@126.com <maok...@126.com> wrote:

> hi,Shomo Ben David:
>
> The output in the attachment.
> I want to working with oVirt Gerrit.
> I have Registered as a user ,the name is maokexu.
> I failed when ssh gerrit.ovirt.org.
> For such a long time back to the information , I am very sorry.
> Best Regards
> ----------
> maok...@126.com
>
>
> *From:* Shlomo Ben David <sbend...@redhat.com>
> *Date:* 2016-09-06 19:52
> *To:* maok...@126.com
> *CC:* Eyal Edri <ee...@redhat.com>; infra <infra@ovirt.org>
> *Subject:* Re: Re: [ovirt-devel] I have this issue when trying to connect
> to gerrit
> ok, can you please try to connect to gerrit.ovirt.org via port 22 and
> send me the output?
>
> $ ssh -vv gerrit.ovirt.org -p 22
> (from your previous email i saw that your default port to the server is
> via 29418)
>
> BTW, why are you trying to connect to gerrit? Is there anything that i can
> help you with?
>
> Best Regards,
>
> Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
> RHCSA | RHCE
> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>
> OPEN SOURCE - 1 4 011 && 011 4 1
>
> On Tue, Sep 6, 2016 at 11:44 AM, maok...@126.com <maok...@126.com> wrote:
>
>> hi,Shlomo Ben David and Eyal Edri:
>>
>> Is not the problem:
>> [maokx@maokx ~]$ date
>> Tue Sep  6 16:42:15 CST 2016
>> [maokx@maokx ~]$ getenforce
>> Permissive
>> [maokx@maokx ~]$ systemctl status iptables
>> ● iptables.service
>>Loaded: not-found (Reason: No such file or directory)
>>Active: inactive (dead)
>> [maokx@maokx ~]$ systemctl status firewalld
>> ● firewalld.service - firewalld - dynamic firewall daemon
>>Loaded: loaded (/usr/lib/systemd/system/firewalld.service
>> ; enabled; vendor preset: enabled)
>>Active: inactive (dead) since Tue 2016-09-06 14:31:58 CST
>> ; 2h 10min ago
>>   Process: 851 ExecStart=/usr/sbin/firewalld --nofork --nopi
>> d $FIREWALLD_ARGS (code=exited, status=0/SUCCESS)
>>  Main PID: 851 (code=exited, status=0/SUCCESS)
>>
>> Sep 06 08:57:24 maokx.com systemd[1]: Starting firewalld -
>> dynamic firewall daemon...
>> Sep 06 08:57:30 maokx.com systemd[1]: Started firewalld -
>> dynamic firewall daemon.
>> Sep 06 14:31:57 maokx.com systemd[1]: Stopping firewalld -
>> dynamic firewall daemon...
>> Sep 06 14:31:58 maokx.com systemd[1]: Stopped firewalld -
>> dynamic firewall daemon.
>> [maokx@maokx ~]$
>>
>> --
>> maok...@126.com
>>
>>
>> *From:* Shlomo Ben David <sbend...@redhat.com>
>> *Date:* 2016-09-06 16:16
>> *To:* Eyal Edri <ee...@redhat.com>
>> *CC:* maok...@126.com; infra <infra@ovirt.org>; devel <de...@ovirt.org>
>> *Subject:* Re: [ovirt-devel] I have this issue when trying to connect to
>> gerrit
>> Hi Maokexu,
>>
>> Its seems that there is some iptables/firewall issue on your machine.
>> Please make sure that port 29418 (tcp) is open.
>>
>> Best Regards,
>>
>> Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
>> RHCSA | RHCE
>> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>>
>> OPEN SOURCE - 1 4 011 && 011 4 1
>>
>> On Tue, Sep 6, 2016 at 10:52 AM, Eyal Edri <ee...@redhat.com> wrote:
>>
>>> Adding infra.
>>>
>>> On Tue, Sep 6, 2016 at 10:01 AM, maok...@126.com <maok...@126.com>
>>> wrote:
>>>
>>>> hi,all:
>>>> I have this issue when trying to connect to gerrit:
>>>> [maokx@maokx ~]$ ssh -vv gerrit.ovirt.org
>>>> OpenSSH_6.6.1, OpenSSL 1.0.1e-fips 11 Feb 2013
>>>> debug1: Reading configuration data /home/maokx/.ssh/config
>>>> debug1: /home/maokx/.ssh/config line 1: Applying options for
>>>> gerrit.ovirt.org
>>>> debug1: Reading configuration data /etc/ssh/ssh_config
>>>> debug1: /etc/ssh/ssh_confi

[JIRA] (OVIRT-724) Re: Lost merge rights on engine stable branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-724:
---
Resolution: Fixed
Status: Done  (was: To Do)

> Re: Lost merge rights on engine stable branch
> -
>
> Key: OVIRT-724
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-724
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: sbonazzo
>        Assignee: Shlomo Ben David
>
> Opening a ticket.
> Il 06/Set/2016 22:04, "Piotr Kliczewski" <pklic...@redhat.com> ha scritto:
> > I attempted to merge few patches but it looks like I do not see merge
> > button on "ready to be merged patches" for engine stable branch.
> >
> > Can someone check what happened?
> >
> > Thanks,
> > Piotr
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >



--
This message was sent by Atlassian JIRA
(v1000.305.0#100011)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-724) Re: Lost merge rights on engine stable branch

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=20427#comment-20427
 ] 

Shlomo Ben David commented on OVIRT-724:


Hi,

I've restored the previous permissions for the stable branches (3.[56] | 4.[01])
currently waiting for code-review: https://gerrit.ovirt.org/#/c/63462/1

BR,

Shlomi Ben-David


> Re: Lost merge rights on engine stable branch
> -
>
> Key: OVIRT-724
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-724
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: sbonazzo
>        Assignee: Shlomo Ben David
>
> Opening a ticket.
> Il 06/Set/2016 22:04, "Piotr Kliczewski" <pklic...@redhat.com> ha scritto:
> > I attempted to merge few patches but it looks like I do not see merge
> > button on "ready to be merged patches" for engine stable branch.
> >
> > Can someone check what happened?
> >
> > Thanks,
> > Piotr
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >



--
This message was sent by Atlassian JIRA
(v1000.305.0#100011)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-724) Re: Lost merge rights on engine stable branch

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-724:
--

Assignee: Shlomo Ben David  (was: infra)

> Re: Lost merge rights on engine stable branch
> -
>
> Key: OVIRT-724
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-724
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: sbonazzo
>        Assignee: Shlomo Ben David
>
> Opening a ticket.
> Il 06/Set/2016 22:04, "Piotr Kliczewski" <pklic...@redhat.com> ha scritto:
> > I attempted to merge few patches but it looks like I do not see merge
> > button on "ready to be merged patches" for engine stable branch.
> >
> > Can someone check what happened?
> >
> > Thanks,
> > Piotr
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >



--
This message was sent by Atlassian JIRA
(v1000.305.0#100011)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Re: [ovirt-devel] I have this issue when trying to connect to gerrit

[Shlomo Ben David]

ok, can you please try to connect to gerrit.ovirt.org via port 22 and send
me the output?

$ ssh -vv gerrit.ovirt.org -p 22
(from your previous email i saw that your default port to the server is via
29418)

BTW, why are you trying to connect to gerrit? Is there anything that i can
help you with?

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Sep 6, 2016 at 11:44 AM, maok...@126.com <maok...@126.com> wrote:

> hi,Shlomo Ben David and Eyal Edri:
>
> Is not the problem:
> [maokx@maokx ~]$ date
> Tue Sep  6 16:42:15 CST 2016
> [maokx@maokx ~]$ getenforce
> Permissive
> [maokx@maokx ~]$ systemctl status iptables
> ● iptables.service
>Loaded: not-found (Reason: No such file or directory)
>Active: inactive (dead)
> [maokx@maokx ~]$ systemctl status firewalld
> ● firewalld.service - firewalld - dynamic firewall daemon
>Loaded: loaded (/usr/lib/systemd/system/firewalld.
> service; enabled; vendor preset: enabled)
>Active: inactive (dead) since Tue 2016-09-06 14:31:58 CST; 2h 10min ago
>   Process: 851 ExecStart=/usr/sbin/firewalld --nofork --
> nopid $FIREWALLD_ARGS (code=exited, status=0/SUCCESS)
>  Main PID: 851 (code=exited, status=0/SUCCESS)
>
> Sep 06 08:57:24 maokx.com systemd[1]: Starting
> firewalld - dynamic firewall daemon...
> Sep 06 08:57:30 maokx.com systemd[1]: Started firewalld
> - dynamic firewall daemon.
> Sep 06 14:31:57 maokx.com systemd[1]: Stopping
> firewalld - dynamic firewall daemon...
> Sep 06 14:31:58 maokx.com systemd[1]: Stopped firewalld
> - dynamic firewall daemon.
> [maokx@maokx ~]$
>
> --
> maok...@126.com
>
>
> *From:* Shlomo Ben David <sbend...@redhat.com>
> *Date:* 2016-09-06 16:16
> *To:* Eyal Edri <ee...@redhat.com>
> *CC:* maok...@126.com; infra <infra@ovirt.org>; devel <de...@ovirt.org>
> *Subject:* Re: [ovirt-devel] I have this issue when trying to connect to
> gerrit
> Hi Maokexu,
>
> Its seems that there is some iptables/firewall issue on your machine.
> Please make sure that port 29418 (tcp) is open.
>
> Best Regards,
>
> Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
> RHCSA | RHCE
> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>
> OPEN SOURCE - 1 4 011 && 011 4 1
>
> On Tue, Sep 6, 2016 at 10:52 AM, Eyal Edri <ee...@redhat.com> wrote:
>
>> Adding infra.
>>
>> On Tue, Sep 6, 2016 at 10:01 AM, maok...@126.com <maok...@126.com> wrote:
>>
>>> hi,all:
>>> I have this issue when trying to connect to gerrit:
>>> [maokx@maokx ~]$ ssh -vv gerrit.ovirt.org
>>> OpenSSH_6.6.1, OpenSSL 1.0.1e-fips 11 Feb 2013
>>> debug1: Reading configuration data /home/maokx/.ssh/config
>>> debug1: /home/maokx/.ssh/config line 1: Applying options for
>>> gerrit.ovirt.org
>>> debug1: Reading configuration data /etc/ssh/ssh_config
>>> debug1: /etc/ssh/ssh_config line 56: Applying options for *
>>> debug2: ssh_connect: needpriv 0
>>> debug1: Connecting to gerrit.ovirt.org [107.22.212.69] port 29418.
>>> debug1: connect to address 107.22.212.69 port 29418: Connect
>>> ion timed out
>>> ssh: connect to host gerrit.ovirt.org port 29418: Connection timed out
>>>
>>> [root@maokx ~]# ping gerrit.ovirt.org
>>> PING gerrit.ovirt.org (107.22.212.69) 56(84) bytes of data.
>>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=1 t
>>> tl=25 time=272 ms
>>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=2 t
>>> tl=25 time=285 ms
>>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=3 t
>>> tl=25 time=275 ms
>>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=4 t
>>> tl=25 time=270 ms
>>> ^C
>>> --- gerrit.ovirt.org ping statistics ---
>>> 4 packets transmitted, 4 received, 0% packet loss, time 3006ms
>>> rtt min/avg/max/mdev = 270.741/275.835/285.228/5.694 ms
>>> [root@maokx ~]# telnet gerrit.ovirt.org 29418
>>> Trying 107.22.212.69...
>>> telnet: connect to address 107.22.212.69: Connection timed out
>>> [root@maokx ~]#
>>>
>>> --
>>> maok...@126.com
>>>
>>> ___
>>> Devel mailing list
>>> de...@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>>
>>
>>
>>
>> --
>> Eyal Edri
>> Associate Manager
>> RHV DevOps
>> EMEA ENG Virtualization R
>> Red Hat Israel
>>
>> phone: +972-9-7692018
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>
>
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: [ovirt-devel] I have this issue when trying to connect to gerrit

[Shlomo Ben David]

Hi Maokexu,

Its seems that there is some iptables/firewall issue on your machine.
Please make sure that port 29418 (tcp) is open.

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Tue, Sep 6, 2016 at 10:52 AM, Eyal Edri  wrote:

> Adding infra.
>
> On Tue, Sep 6, 2016 at 10:01 AM, maok...@126.com  wrote:
>
>> hi,all:
>> I have this issue when trying to connect to gerrit:
>> [maokx@maokx ~]$ ssh -vv gerrit.ovirt.org
>> OpenSSH_6.6.1, OpenSSL 1.0.1e-fips 11 Feb 2013
>> debug1: Reading configuration data /home/maokx/.ssh/config
>> debug1: /home/maokx/.ssh/config line 1: Applying options for
>> gerrit.ovirt.org
>> debug1: Reading configuration data /etc/ssh/ssh_config
>> debug1: /etc/ssh/ssh_config line 56: Applying options for *
>> debug2: ssh_connect: needpriv 0
>> debug1: Connecting to gerrit.ovirt.org [107.22.212.69] port 29418.
>> debug1: connect to address 107.22.212.69 port 29418: Connection timed out
>> ssh: connect to host gerrit.ovirt.org port 29418: Connection timed out
>>
>> [root@maokx ~]# ping gerrit.ovirt.org
>> PING gerrit.ovirt.org (107.22.212.69) 56(84) bytes of data.
>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=1 t
>> tl=25 time=272 ms
>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=2 t
>> tl=25 time=285 ms
>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=3 t
>> tl=25 time=275 ms
>> 64 bytes from gerrit.ovirt.org (107.22.212.69): icmp_seq=4 t
>> tl=25 time=270 ms
>> ^C
>> --- gerrit.ovirt.org ping statistics ---
>> 4 packets transmitted, 4 received, 0% packet loss, time 3006ms
>> rtt min/avg/max/mdev = 270.741/275.835/285.228/5.694 ms
>> [root@maokx ~]# telnet gerrit.ovirt.org 29418
>> Trying 107.22.212.69...
>> telnet: connect to address 107.22.212.69: Connection timed out
>> [root@maokx ~]#
>>
>> --
>> maok...@126.com
>>
>> ___
>> Devel mailing list
>> de...@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: Update gerrit plugins (oauth, avatars-gravatar)

[Shlomo Ben David]

Hi all,

The update completed successfully.
The server is up and running with the new plugins.

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Sun, Sep 4, 2016 at 7:41 PM, Shlomo Ben David <sbend...@redhat.com>
wrote:

> Hi,
>
> Today 04/09/2016 at 23:00 i'm planning to update gerrit-oauth plugin from v0.3
> ==> v2.11.3
>
> In addition i will add the new avatars-gravatar plugin (v2.11)
>
> Update Duration: ~10 min
> During the update the gerrit.ovirt.org server won't be available
>
> An update email will be sent when done.
>
> Best Regards,
>
> Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
> RHCSA | RHCE
> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>
> OPEN SOURCE - 1 4 011 && 011 4 1
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Update gerrit plugins (oauth, avatars-gravatar)

[Shlomo Ben David]

Hi,

Today 04/09/2016 at 23:00 i'm planning to update gerrit-oauth plugin from v0.3
==> v2.11.3

In addition i will add the new avatars-gravatar plugin (v2.11)

Update Duration: ~10 min
During the update the gerrit.ovirt.org server won't be available

An update email will be sent when done.

Best Regards,

Shlomi Ben-David | DevOps Engineer | Red Hat ISRAEL
RHCSA | RHCE
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-453) Gerrit: Issue 3885: Failed to index change

[Shlomo Ben David (oVirt JIRA)]

[ 
https://ovirt-jira.atlassian.net/browse/OVIRT-453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=20133#comment-20133
 ] 

Shlomo Ben David commented on OVIRT-453:


According to the fix that was made in gerrit v2.13 i will test it first on the 
test environment.

> Gerrit: Issue 3885:   Failed to index change
> --
>
> Key: OVIRT-453
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-453
> Project: oVirt - virtualization made easy
>  Issue Type: By-EMAIL
>Reporter: eyal edri [Administrator]
>        Assignee: Shlomo Ben David
>
> Its an open issue [1] in Gerrit, but still no fix available.
> We'll track it and see if there is a pending fix, cc'ing infra-support to
> open a ticket to track this.
> [1]
> https://code.google.com/p/gerrit/issues/detail?can=2=0=100==ID%20Type%20Stars%20Milestone%20Status%20Priority%20Owner%20Summary===3885
> On Sun, Mar 27, 2016 at 7:03 AM, Nadav Goldin <ngol...@redhat.com> wrote:
> > Hi,
> > gerrit started throwing weird errors this morning, such as:
> >
> >> internal server error: com.google.gerrit.server.git.UpdateException:
> >> java.io.IOException: java.util.concurrent.ExecutionException:
> >> org.apache.lucene.store.AlreadyClosedException: this IndexWriter is closed)
> >>
> >
> > restarting it now.
> >
> >
> > Nadav.
> >
> >
> > ___
> > Infra mailing list
> > Infra@ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/infra
> >
> >
> -- 
> Eyal Edri
> Associate Manager
> RHEV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)



--
This message was sent by Atlassian JIRA
(v1000.285.1#100011)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-706) add missing links and files to gerrit hooks directory

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David updated OVIRT-706:
---
Epic Link: OVIRT-411

> add missing links and files to gerrit hooks directory
> -
>
> Key: OVIRT-706
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-706
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>Assignee: infra
>




--
This message was sent by Atlassian JIRA
(v1000.253.3#100011)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-706) add missing links and files to gerrit hooks directory

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-706:
--

 Summary: add missing links and files to gerrit hooks directory
 Key: OVIRT-706
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-706
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra






--
This message was sent by Atlassian JIRA
(v1000.253.3#100011)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

FindBugs Plugin: WARNING: SKIPPED_CLASS_TOO_BIG

[Shlomo Ben David]

Hi,

Job [1] receives the following warning:
Plug-in Result:Unstable - 1 warning exceeds the threshold of 0 by 1
(Reference build: #343)

*Console output:*
*14:57:09 [FINDBUGS] Successfully parsed file
/home/jenkins/workspace/ovirt-engine_4.0_find-bugs_created/ovirt-engine/frontend/webadmin/modules/uicompat/target/findbugsXml.xml
with 1 unique warning and 0 duplicates.*
*14:57:09 [FINDBUGS] Successfully parsed file
/home/jenkins/workspace/ovirt-engine_4.0_find-bugs_created/ovirt-engine/frontend/webadmin/modules/userportal-gwtp/target/findbugsXml.xml
with 1 unique warning and 0 duplicates.*
*14:57:09 [FINDBUGS] Successfully parsed file
/home/jenkins/workspace/ovirt-engine_4.0_find-bugs_created/ovirt-engine/frontend/webadmin/modules/webadmin/target/findbugsXml.xml
with 1 unique warning and 0 duplicates.*
*14:57:09 [FINDBUGS] Computing warning deltas based on reference build #343*
*14:57:09 [FINDBUGS] Ignore new warnings since this is the first valid
build*
*14:57:09 [FINDBUGS] Plug-in Result: Unstable - 1
warning exceeds the threshold of 0 by 1*

*FindBugs Result:* [2]

*DEBUG:*
Since JOB#327 that was triggered by: gerrit patch [3] the warning appear.
The gerrit patch currently Merged.
In the patch there is a change in the UIConstants.java [4] file that can be
related.


[1] http://jenkins.ovirt.org/job/ovirt-engine_4.0_find-bugs_created/345/
[2] UIConstants.java:-1
,
SKIPPED_CLASS_TOO_BIG, Priority: Low
[3] https://gerrit.ovirt.org/61891
[4
] 
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java


Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
Red Hat Certified System Administrator | Red Hat Certified Engineer
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-640) upgrade/install plugins

[Shlomo Ben David (oVirt JIRA)]

 [ 
https://ovirt-jira.atlassian.net/browse/OVIRT-640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shlomo Ben David reassigned OVIRT-640:
--

Assignee: Shlomo Ben David  (was: infra)

> upgrade/install plugins
> ---
>
> Key: OVIRT-640
> URL: https://ovirt-jira.atlassian.net/browse/OVIRT-640
> Project: oVirt - virtualization made easy
>  Issue Type: Task
>        Reporter: Shlomo Ben David
>        Assignee: Shlomo Ben David
>
> 1. We need to upgrade 'gerrit-oauth-provider' plugin
> Current Version: 0.3
> New Version: v2.11.3
> 2. We need to install 'avatars-gravatar' plugin
> Version:  v2.11



--
This message was sent by Atlassian JIRA
(v1000.148.3#15)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

[JIRA] (OVIRT-640) upgrade/install plugins

[Shlomo Ben David (oVirt JIRA)]

Shlomo Ben David created OVIRT-640:
--

 Summary: upgrade/install plugins
 Key: OVIRT-640
 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-640
 Project: oVirt - virtualization made easy
  Issue Type: Task
Reporter: Shlomo Ben David
Assignee: infra


1. We need to upgrade 'gerrit-oauth-provider' plugin
Current Version: 0.3
New Version: v2.11.3

2. We need to install 'avatars-gravatar' plugin
Version:v2.11



--
This message was sent by Atlassian JIRA
(v1000.148.3#15)
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra

Re: gerrit.ovirt.org migration

[Shlomo Ben David]

Hi All,

The gerrit.ovirt.org migration process completed successfully.
The server is up and running.

Best Regards,

Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)

OPEN SOURCE - 1 4 011 && 011 4 1

On Sun, Jul 10, 2016 at 5:35 PM, Shlomo Ben David <sbend...@redhat.com>
wrote:

> Hi All,
>
> Today we are planning to migrate gerrit.ovirt.org server to a new bigger
> instance on Amazon to improve performance.
>
>- The migration will start at 18:00 IDT
>- Estimate migration end time 19:00 IDT.
>
>
>- During the migration the server will not be available (you won't be
>able to send patches or review code)
>
>
>- The server will be down for about an hour, but if we'll be able to
>restore it before we'll let you know.
>
>
>- An email will be sent at the end of the migration process.
>
>
> Best Regards,
>
> Shlomi Ben-David | Software Engineer | Red Hat ISRAEL
> Phone: +972-54-8008858
> IRC: shlomibendavid (on #rhev-integ, #rhev-dev, #rhev-ci)
>
> OPEN SOURCE - 1 4 011 && 011 4 1
>
___
Infra mailing list
Infra@ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra